Commit graph

1171 commits

Author SHA1 Message Date
Ashish Kumar
7a5dc77057 Refactor uploads (#2981)
* Feature/refractor uploads [WIP] (#2887)

* Fix duplicate param information (#2515)

* Bug fix issue #2476 (#2526)

* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery

* Versioning and changelog for v2.10.2 (#2531)

* Update changelog.md

* Versioning for v2.10.2

* Update changelog.md

* Bugfix/issue 2580 (#2584)

* Corrected string placedholders in certain string files

* Corrected string placedholders in certain string files[Bug fix #2580]

* Bug Fix #2585 (#2647)

* Bug Fix #2585
* Added null checks on view in SearchImageFragment when updating views from external sources
* Disposed the disposables in SearchActivity and SearchImageFragment when no longer in active lifecycle

* use FragmentUtils to verify fragment active state

* Bug Fix issue #2648 (#2678)

* Bug Fix issue #2648
* Handled external storage permission before file download

* * Removed redudant check for permission in MediaDetailPagerFragment (Dexter already does that)
* Removed duplicate code in PermissionUtil$checkPermissionsAndPerformAction, used the existing function with conditional extra parameters

* string name typo correction

* BugFix issue #2652 (#2706)

* Addded null check on bookmark before operating on it

* BugFix issue #2711 (#2712)

* Added null checks in OkHttpJsonApiClient$searchImages MwQueryResponse

* BugFix #2718 (#2719)

* Handled null auth cookies

* Fix #2791: NPE when nominating for deletion and leaving screen (#2792)

* Bug Fix issue #2789 (#2790)

* Handled Illegal State Exception for non existent appropriate view parents in ViewUtils$showShortSnackbar

* BugFix #2720 (#2831)

BugFix deprecated licenes #2720

* ui fixes, wip, upload

* *Issue #2886, BugFix #2832[wip]
* updated UploadActivity code
* modified ui
* Updated UploadPresenterTest

* * updated interfaces names to follow names suffixed with Contract
* added test cases

* card view elevation

* view pager disabled swipe

* bug fix, duplicate image

* used existing non-swipable view pager

* Avoid image view resize with keyboard, added adjustPan and stateVisible as softinputMode for UploadActivity

* retain UploadBaseFragment instances on orientation changes

* * Added test cases for UploadMediaPresenter
* Injected io and main thread schedulers

* categories presenter test cased wip

* Added CategoriesPresenter test

* * Added the logic to show open map (with to be uploaded image's coordinates while uploading image)

* codacy suggested changes * added java docs

* Added travis_wait fot android-wait-for-emulator

* ranamed interface onResponseCallback to Callback

* * Added api to delete picture in UploadModel
* cleanUp in UploadModel. once upload has been initiated
* Removed unused methods from UploadModel and the corresponding test class

* * Added tests for UploadPresenter
* Travis suggested changes
* Addded copy previous title and description

* * Made the upload add descriptions visible when keyboard visible
* add description request focus only when user manually requests it

* Added JavaDocs, review suggested changes

* Fix dagger injection

* use DialogUtil to show info in descriptions

* use activity context for DialogUtil

* Minor changes

* Bug fix, reduced the add description edit text clickable bound (#2973)

* Bugfix/uploads (#3000)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Fix memory leak (#3001)

* Bugfix/uploads (#3002)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Bugfix/uploads (#3011)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView

* bugfix/uploads (#3012)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView

* BugFix Illegal State Exception in ViewpPagerAdapter

* Remove irrelevant comment

* merge conflict with strings (#3016)
2019-06-14 01:09:41 +05:30
translatewiki.net
04b051b37a Localisation updates from https://translatewiki.net. 2019-06-13 20:02:26 +02:00
sherlockbeard
6619ccf8d5 removed the hard coded string (#3015)
* removed the hard coded string

* fix
2019-06-12 16:06:25 +03:00
translatewiki.net
69e23b73a8 Localisation updates from https://translatewiki.net. 2019-06-10 20:17:37 +02:00
Vivek Maskara
8971743479 Fixes #2888: Use Dexter for requesting location permissions (#2925)
* Use dexter to ask for location permissions

* Addressed code review comments
2019-06-08 08:45:30 +03:00
translatewiki.net
51e2febc53 Localisation updates from https://translatewiki.net. 2019-06-06 17:52:19 +02:00
Vitaly V. Pinchuk
cc0b059595 Image EXIF/XMP metadata removal routine (#2863)
* [WIP] Added preferences for EXIF tags

* [WIP] Added arrays, keys, strings to support EXIF preferences

* [WIP] Updated SettingsFragment to setup summary of added preferences(locationAccuracy)

* [WIP] Added methods getStringSet()in BasicKvStore, KeyValueStore to support Set<String> data type used in preferences (EXIF tags)

* [WIP] Added methods for removing EXIF tags and anonimyzing location coordinates in FileProcessor, GPSExtractor

* [WIP] Fixed errors in preferences EXIF tags, added XMP removal routine

* [WIP] Removed erroneous location accuracy handling

* [WIP] Fixed mistyped GPS Tags

* Reverted BasicKvStore. Removed Set<String> support in BasicKvStore as JsonKVStore already has it.

* FileProcessor: Replaced throwing runtime exception with warning if EXIF redaction fails.

* FileMetadataUtils: Javadoc added

* [WIP] FileMetadataUtilsTest added

* [WIP] FileMetadataUtilsTest: added javadoc

* [WIP] FileMetadataUtilsTest: added javadoc

* [WIP] FileProcessor: fixed disposing observables

* [WIP] FileMetadataUtils.getTagsFromPref: changed return type from observable to simple array

* [WIP] FileProcessorTest: added test for redactExifTags

* [WIP] FileProcessorTest: redactExifTags() doesn't work properly
2019-06-04 15:38:01 +03:00
translatewiki.net
5690dd9d0b Localisation updates from https://translatewiki.net. 2019-06-03 17:25:14 +02:00
translatewiki.net
12883e3d0b Localisation updates from https://translatewiki.net. 2019-05-27 16:34:33 +02:00
translatewiki.net
ab783a445f Localisation updates from https://translatewiki.net. 2019-05-23 14:10:29 +02:00
translatewiki.net
4896e5992e Localisation updates from https://translatewiki.net. 2019-05-20 13:41:58 +02:00
translatewiki.net
45fd7fe5fa Localisation updates from https://translatewiki.net. 2019-05-17 12:13:00 +02:00
translatewiki.net
54f6dd667f Localisation updates from https://translatewiki.net. 2019-05-13 14:29:38 +02:00
Madhur Gupta
5d827e44ae Moved hardcoded URLs to a constant file Fixed #2850 (#2851)
* Moved hardcoded URLs to build.grade Fixed #2850

* Moved Urls to a constant file

* Fixed Typo
2019-05-10 15:09:32 +03:00
translatewiki.net
a4ac27d5d3 Localisation updates from https://translatewiki.net. 2019-05-09 16:54:18 +02:00
kateOmally
41b53f4560 Replace with enum two strings that were in strings.xml but were used as (#2939)
constants. Remove strings from strings.xml Issue # 2931
2019-05-08 21:37:29 +03:00
translatewiki.net
c4b7164784 Localisation updates from https://translatewiki.net. 2019-05-06 16:37:10 +02:00
translatewiki.net
a4104bc368 Localisation updates from https://translatewiki.net. 2019-05-02 17:57:44 +02:00
Ashish Kumar
c8a58bfc2e
Revert "Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)" (#2934)
This reverts commit 3c9b7ba7a8.
2019-05-01 16:10:43 +05:30
neslihanturan
3c9b7ba7a8 Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)
* Api call

* added captions

* final commit

* some minor changes

* sigular

* test for captions

* mock fetchCaptionbyFileName

* corrected method name

* * used ? instead of !! (unsafe call on nullable)
* updated unit test for fetchCaptionByFilename()
2019-05-01 15:08:38 +05:30
translatewiki.net
047059c490 Localisation updates from https://translatewiki.net. 2019-04-29 17:26:12 +02:00
Madhur Gupta
13ea61c7a7 Fixed Navigation UI Problem in Split Screen mode # 2788 (#2807) 2019-04-26 10:53:38 +03:00
translatewiki.net
c127bcfea4 Localisation updates from https://translatewiki.net. 2019-04-25 20:12:55 +02:00
Vivek Maskara
5419733299 Center crop images (#2924) 2019-04-24 22:12:20 +03:00
Ashish Kumar
bb7ab62b34 Fix #2915 Refractor feature Review (#2916)
* BugFix #2915
* Refractor ReviewActivity and ReviewImageFragment and the related layout files, to properly use the scrollview
* Use ButterKnife for ViewBindings in ReviewImageFragment
* updated resource id names to follow underscore notation in xml
* Use menu item instead of ImageView over toolbar in ReviewActivity
* use tools:replace instead of android:text for dummy texts

* merge nested if's [Codacy review]

* updated string review_category_yes_button_text, use textAllCaps in yes and no button in ReviewFragment

* updated other strings to use non bold letters
2019-04-24 15:52:12 +03:00
Vivek Maskara
37e9eae314 Fetch and use thumbnail across the app (#2906) 2019-04-24 03:03:09 +10:00
Amir E. Aharoni
17d69cde02 Remove an unnecessary space after a line break (#2914) 2019-04-23 16:28:13 +05:30
translatewiki.net
987bf25921 Localisation updates from https://translatewiki.net. 2019-04-22 22:05:39 +02:00
translatewiki.net
99ae8f27bc Localisation updates from https://translatewiki.net. 2019-04-18 16:57:09 +02:00
Nahid Fatma
8ef99caa81 Use previous Title/Description option added (#2713)
* Use previous Title/Description option added

* Update UploadActivity.java

* add previous title/description option modified

* declaration of Descripton object moved within the loop

* spinner position gets adjusted according to the description's language

* prev Title/Desc option for multiple upload added

* Tooltip for previous title/description button added

* UI and other resolved issues
2019-04-18 23:32:10 +10:00
Madhur Gupta
84637c5fed Adjusted the gravity of SKIP THIS IMAGE Fixed #2848 (#2849) 2019-04-16 12:40:54 +03:00
Adam Jones
5d299b1511 Simplify welcome layouts (#2741)
* Simplify welcome layouts

* Add landscape layouts

* Reformat welcome layouts

* Rename string resources
2019-04-16 12:35:42 +03:00
translatewiki.net
fb0d025f33 Localisation updates from https://translatewiki.net. 2019-04-15 17:33:30 +02:00
Marcin Kwaśniak
4f76f1b642 Avoid jargon and slang, change for default, de and pl (#2874) (#2876)
* Avoid jargon and slang, change for default, de and pl (#2874)

* Revert "Avoid jargon and slang, change for default, de and pl (#2874)"

This reverts commit 174efe0309.

* check_category_success_title text changed to: Category check requested

* check_category_failure_title new text
2019-04-13 19:34:39 +10:00
translatewiki.net
a1ac7a0407 Localisation updates from https://translatewiki.net. 2019-04-11 17:43:18 +02:00
Madhur Gupta
a838962f49 Added Quick Launch Icon to the Home Screen Widget #1296 (#2862) 2019-04-11 18:32:11 +10:00
translatewiki.net
6bde4f97cf Localisation updates from https://translatewiki.net. 2019-04-08 16:40:59 +02:00
translatewiki.net
07c335e054 Localisation updates from https://translatewiki.net. 2019-04-04 19:57:33 +02:00
Ashish Kumar
08a555c095 Merge 2.10 with master & Fixed merge conflicts (#2844) 2019-04-04 03:09:54 +10:00
Madhur Gupta
02ad3b2dc8 Fixed Padding for FAB in nearby #2779 (#2780)
* Fixed Padding for FAB in nearby #2779

* Fixed Padding for Location FAB in nearby

* Fixed Extra Padding
2019-04-02 14:34:22 +03:00
Adam Jones
835b7979ff Remove unused/duplicate drawables (#2733) 2019-04-02 13:36:27 +03:00
Silky Priya
49ec2921c5 Fix pageindicator style issues(#2811) 2019-04-02 12:45:52 +03:00
Vivek Maskara
dcbf076965
Update master with backend overhaul branch (#2829)
* Beginnings of integration with Wikipedia client library. (#2642)

* Remove remaining unnecessary API version check.

* Roll up sleeves.

* Add and integrate the beginnings of app adapter.

* Remove vestigial event logging logic.

Event logging is no longer used in this app.

* Beginnings: remove StringUtils and associated redundancies.

* Remove redundant capitalize() method.

* Remove redundant urlEncode() method.

* Remove redundant (and incomplete) language lists.

* Remove redundant usages of SimpleDateFormat.

* Remove redundant json type adapter.

* Remove redundant MW error model classes.

* Rip out redundant MW model classes.

* Pass SessionManager into AppAdapter instead of injecting.

* Wire up more of the AppAdapter.

* Remove redundant Gson initialization and type adapters.

* Rip out PageTitle.

This was being used in some slightly incorrect/unexpected ways.

* Don't need static WikiSite.

* Bump data client library version

* Bump library version and fix build

* Fix tests

* Fix build

* Fix media of the day

* With fixes in recently modified APIs
2019-04-02 08:35:22 +05:30
translatewiki.net
76e5a30fb5 Localisation updates from https://translatewiki.net. 2019-04-01 20:24:14 +02:00
Silky Priya
874e761691 Add information icons to explan peer review activity (#2783) 2019-03-29 23:06:20 +00:00
Madhur Gupta
e3f3c915ea Fixed crash in LoginActivity on tablets (#2787) 2019-03-29 20:15:09 +00:00
Vivek Maskara
0bf63f50b3 Replace remaining AsyncTask with RxAndroid (#2681) 2019-03-28 21:10:47 +00:00
translatewiki.net
a62aaadf90 Localisation updates from https://translatewiki.net. 2019-03-28 19:31:43 +01:00
Madhur Gupta
7c77530c2e Refactor LoginActivity #2690 (#2775)
* Refactor LoginActivity #2690

* Fixed Error cannot find symbol
2019-03-28 15:19:49 +03:00
Adam Jones
4071d66d45 Remove duplicate information icon resources (#2734) 2019-03-28 13:28:17 +05:30