* Rephrase misleading statement shown when skipping login
The previous statement was misleading as it could also
mean that the user could never upload pictures if he
skips login. This not the case because after skipping
the login he could login again if he wants to upload
pictures.
Clarify it by using a statement which states that he
would have to login in future in case he wants to
upload pictures.
* Rephrase with a better statement
The old statement doesn't read so well.
Rephrase it with a better statement.
* Hide subtitle message when uploading a single image (#2163)
* updateSubtitleVisibility: Javadoc and replace if with ternary operator
* updateSubtitleVisibility: change findViewById to BindView
* Remove null checks for views
Null check is not required while binding views with butterknife.
* UploadController: Added support for using author names. Fixes#1707.
* Minor PR tidy-up
* Reword preference item
* Null check to pass startUpload test
* Fix memory leak due to wikidata edit listener (#2048)
* Fix bookmark crash fix (#2047)
* Fix bookmark crash fix
* Fix check for bookmark creator
* Bug fix#2042 (#2056)
* Bug fix#2042
* Added a snack with retry when api in AA fails
* Increased connection timeouts in okhttpclient builder
* added missing string resource
* Bugfix/duplicate categories (#2080)
* Increased timeout to 60 seconds
* Bug fix#1550
* filter duplicate categories
* Fix crash because of inactive fragment UI (#2046)
* Fix crash because of inactive fragment UI
* Add java docs
* Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057)
* Localisation updates from https://translatewiki.net.
* Remove unused mediawiki api dependency (#1991)
* Categories with pipe suffix (#1873)
* Bug fix issue #1826
Changes made :
-Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe
* review suggested changes
*Code formatting
*Extracted out the index of pipe in a variable
*Added issue link in comments
* Remove libraries section from README (#1988)
* Remove libraries section from README
* Add wiki link to "libraries used" to README
* Localisation updates from https://translatewiki.net.
* Localisation updates from https://translatewiki.net.
* Use alert dialog instead of popup window, for nearby information
* Revert irrelevant changes, sorry
* Add cancel and retry buttons on layout contribution
* Make sure your retry logic works
* Add cancel method too
* Add javadocs and remove debug logs
* Remove two unused methods
* Remove old and unused retry buttons as we do for their functions
* Check internet connection before button function, since function requires internet connection
* Remove unused variable
* Display possible solution for badtoken error
* Fix string
* Fixed#1930 Achievements activity is crashing on Android 8.1
* Fixed#1930 Achievements activity is crashing on Android 8.1
* Delete gradle-wrapper.properties
* Update build.gradle
* Create gradle-wrapper.properties
* fixed#1948 Search feature is light in dark theme
* Update FileUtils.java
* Update FileUtils.java
* Update FileUtils.java
* Fixed#1948 Search feature is light in dark theme
* changed files for the build
* Made the changes asked for
* Made the changes asked for
* Update gradle.properties
* Update gradle.properties
* Made changes in RecentSearchFragment
* Update WelcomeActivity.java
Now it starts welcome screen after not finishing the pager. Moved "Skip Tutorial" button here so it does not animate by swipe.
* Update activity_welcome.xml
Putting "Skip Tutorial" button here so that it does not animate by swipes.
* Update LoginActivity.java
Removing the set of "first run " flag from here. we set it after the buttons press or on WelcomeActivity's finish()
* Update welcome_do_upload.xml
removing "skip tut" button from here.
* Update welcome_dont_upload.xml
Removing "Skip Tutorial" button from here so that it does not animate by swipes.
* Update welcome_image_details.xml
Removing "Skip Tutorial" button from here so that it does not animate by swipes.
* Update welcome_wikipedia.xml
Removing "Skip Tutorial" button from here so that it does not animate by swipes.
* Update WelcomePagerAdapter.java
the "welcomyesButton" is removed from the child views in pager, so it is optional now.
* Add JavaDoc to WelcomeActivity.onBackPressed()
* Fix#2103: Remove welcomeYesButton from landscape layout
* Refactor WelcomePagerAdapter
* Add getGeolocation method to geolocation from file path
* Add geolocation check to receiveDirect method checks, means it will be checked durimg nearby direct uploads
* Create method body for geolocation and nearby place coordinate comparaison, this method will be filled on consequent commits
* Add a method to find location missmatch
* app/src/main/java/fr/free/nrw/commons/utils/ImageUtils.java
* Add if check to upload activity to detect pictures with wrong location, and save it to shared prefs
* Do not edit wikidata item if picture has wrong location info
* Add one more bitwise operand to possible warning reasons for wrong location case
* Add a bitwise variable for wrong locatio case
* Share nearby place location just like wikidataEntityId, so that we can compare
* Implement check image geolocation is different method by comparing nearby location and file EXIF geolocation
* Add Javadocs
* Remove logs
* Fix all taken on wrong phrases as taken at
* Fix typo on logs
* Simplify if logic
* Fix string issues
* Show campaigns
* Added a ui util class SwipableCardView which passes the onSwipe event to its children
* NearbyCardView & CampaignView extend SwipableCardView
* Fetch campaigns in ContributionsFragment
* Added an option to enable disable campaign in Settings/Preferences
* synced strings with master
* removed duplicate initialsation of CampaignPresenter
* Recognize user is moving on the map and show a button
* Use variable from strings xml instead of hardcoded string
* Change search this area button location in xml file
* Add location util file to convert mapbox LatLng to commons Latlng and viceversa
* Populate places around searched area
* Update narby map according to new points came from searched area
* Add searchThisAreaMode boolean to stop nearby map updated when we try to search nearby areas.
* Lock auto nearby operations during serch this area mode, with a more modular method and decrease code repetition
* Add an if clausse to prevent multiple refresh view calls, while map is moving
* Disable map gestures during search this area operation, re-eable them on operation is done
* Add progress bar during search this area operation
* Make sure you locked the map during search nearby map process
* Implement recenter map view button
* Fix logic problem and make sure you refreshed the view on coming back to previous position
* Use custom refresh method instead
* Use latest updated location from location manager isntead
* Update ListFragment accordingly too
* Do not update camera target according to bottom sheet status or do not follow users location with camera, if search this area mode is on
* Add javadocs, sorry forgotten previously
* Remove unused method
* Threat both or search this area and regular search in same way
* Make sure distances are correct
* Seperate cutom location updates and current location updates from each other to continue other operations
* Remove all logs, and make sure search this are button is not visible for no reason while around of current location is already loaded
* Notify load attractions from location method about search status, current location of custom location
* Make sure we calculate searched area and display search this area button when we are out of 3/4 of total searched area
* Localisation updates from https://translatewiki.net.
* Remove unused mediawiki api dependency (#1991)
* Categories with pipe suffix (#1873)
* Bug fix issue #1826
Changes made :
-Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe
* review suggested changes
*Code formatting
*Extracted out the index of pipe in a variable
*Added issue link in comments
* Remove libraries section from README (#1988)
* Remove libraries section from README
* Add wiki link to "libraries used" to README
* Localisation updates from https://translatewiki.net.
* Localisation updates from https://translatewiki.net.
* Display nearby notification only if it is loaded
* Cover don't ask again checkbox is selected posibility
* Clean commented out codes
* Add strings to string.xml
* Add unable to display text to strings xml
* Fix nearby card permission explanation string
* Add never ask again checkbox to dialogbox
* Add action to never display checkbox
* Implement a setting on settings page, to be able to enable this setting later
* Revert unnecessary changes
* Added new upload activity that receives shared files from the gallery. Cards show and hide, plus titles are correct. Displayed thumbnails for the shared images
* Better handling of the view paging plus error handling for required fields.
* Code cleanup to make things more readable.
* Extracted a model from the category search fragment that can possibly be shared with the new upload activity.
* Added category selection to the combined upload screen.
* Cleanup before the home-stretch on the GUI.
* Adding license selection.
* Fixed build warnings + cleanup
* Start to support the dark theme.
* Work in progress to add quality checking.
* Fixing merge.
* GPSExtractor: optimized away the EXifInterface object
* Implemented submit functionality, temporarily fixed jacoco crash by disabling DUMMY UploadView object.
* Implemented uploading of categories along with the picture. The category screen now displays GPS and recent categories when nothing is searched.
* Implemented caching of files. Did some work on picture quality detection.
* Implemented too dark picture detection.
* Added a side card for zoom and map buttons along with pretty animations for stuff.
* Added duplicate image on commons checking and fixed files not getting proper file extensions in several places.
* Added support for map button and switched in-app upload buttons to UploadActivity
* Pretty pretty animations!
* Implemented zoom functionality for th background image. Just pinching on the image works instead of requiring buttons.
* Added multi-language descriptions with categories by region.
* Reimplemented the duplicate title checker and implemented a check against putting the same language twice in the description.
* Javadocs for Description and UploadPresenter, plus some general cleanup.
* Small code changes.
* Implemented login checks for the Upload screen.
* Implement receiving data from Nearby.
* Feature/permissions library (#1855)
* Added permission for Dexter, the runtime permission handling library
* [Preparing fir issue #1773] Added a utility function which would take the user to app settings screen where he could manually give us the required permission
* Added an alert dialog with positive and negative callback [Preparing fir issue #1773]
* Improvements in the way External Storage Permission is handled in MultipleShareActivity[Bug fix#1697]
1. Used dexter to handle the external storage permission
2. Behaviour changes : When user tries to share(uppload) images to commons via MultipleShareActivity, following decision tree is followed
a. If the app has permission for external storage, normal upload operation is followed
b. If the app does not has the permission for external storage, dexter is used to ask for the same
c. If the user gives us the required permission, normal upload flow is proceeded
d. If the doesnot gives us the required permission a rationale dialog is shown with the appropriate message to let him know why we need the permission
e. If he presses okay, steps a-c are followed and if he presses cancel, we close the app.
f. If while asking for permission, the user chooses never ask again, then next time he tries to upload an image via MSA, the rational dialog follows the app setting screen where he could manually give us the required permission and the onActivityResult of same is handled
* Added a Constants class to handle request and result codes from one place and other related constants common to the all app elements
* replaced hardcoded strings ok and cancel in DialogUtil to string resources
* init permission rationale dialog in activities onCreate
* Code formatting, updated access modifiers wherever required, added javadocs for new methods created
* *shifted constants to app class
*Added JavaDocs in PermissionUtils
* removed class REQUEST_CODES from CommonsApplication and instead put the enclosing constants in the App class itself
* Made Codacy happy.
* Abstarcted permission acquisition into new class DexterPermissionObtainer
* Fixed Nearby upload detection
* Migrated bad picture detection from AsyncTask to RxJava.
* Removed ShareActivity and related dead code
* Removed dead or duplicate code from FileProcessor
* Added info button to title EditText
* Fixed the add description button not disappearing.
Added "Starting Upload" toast.
Added link to the license on final screen.
Made it so that the map button is hidden when image lacks gps coords.
* Support in app multiple uploads
* Minor changes to fix build
* Changes to fix pending issues with upload flow
* Fix display of similar image fragment
* When uploading several files at once the date is missing #1854 (#2)
* Bug fix issue #1854
* updated ContributionsDao to save create date, which it was not doing currently [it was instead saving current date]
* UploadItem accepts are dateCreated param
* Added a function in UploadModel, getFileCreatedDate which tries to fetched the file creaction date from all possible content providers.
* Fix pending issues in upload flow
* Make multiple uploads work for Google Photos
* Fix default state for upload activity
* Fix keyboard state for license screen
* Fix descriptions for uploads
* wip
* Fix language spinner
