Commit graph

4675 commits

Author SHA1 Message Date
neslihanturan
80708023aa Add all location permission related methods to view contract and implement in fragment. Call them from presenter by passing locationServiceManager parameter 2019-05-16 16:26:44 +03:00
neslihanturan
f8926aa2f1 Merge branch 'master' into refactorNearbyClassesMVP 2019-05-15 13:23:24 +03:00
Dmitry Brant
6fd969686c Remove additional unnecessary dependencies. (#2948) 2019-05-15 09:46:42 +03:00
neslihanturan
2aa554661e Relate parent presenter with parent fragment 2019-05-14 13:10:22 +03:00
neslihanturan
bfc0d8821c İmplement child fragment logic and their retain 2019-05-14 12:00:49 +03:00
neslihanturan
6b6a697277 Add main views on fragment 2019-05-14 11:37:57 +03:00
neslihanturan
11d1d00c17 Fix typo 2019-05-14 10:43:13 +03:00
neslihanturan
3da8e301a4 Implement missing methods 2019-05-14 10:19:08 +03:00
neslihanturan
a1e3b2ef6d Add presenter, contract and fragment for parent Fragment of both NearyListFragment and NearbyMapFragment 2019-05-14 10:18:48 +03:00
Dmitry Brant
967d3ea593 Remove unnecessary dependency on commons-codec. (#2945) 2019-05-14 08:28:13 +03:00
translatewiki.net
54f6dd667f Localisation updates from https://translatewiki.net. 2019-05-13 14:29:38 +02:00
neslihanturan
24aa7a25cc Add javadocs 2019-05-13 08:34:21 +03:00
neslihanturan
48a550f5fd Create presenters for map and list and implement user actions accordingly 2019-05-12 11:09:14 +03:00
neslihanturan
7dec4af113 Move constracts under contract package 2019-05-12 11:08:35 +03:00
neslihanturan
b9d9548126 Add explanation for keeping an emty View interface under NearbyListContract 2019-05-12 10:36:39 +03:00
neslihanturan
c7533eba0f Move general method to parent and add javadocs for parent 2019-05-12 10:35:13 +03:00
neslihanturan
24a85a16a3 Add javadocs and specific interfaces for list 2019-05-12 10:32:09 +03:00
neslihanturan
3b63d9ca2f Create map child contract and fill methods 2019-05-12 10:16:05 +03:00
neslihanturan
6483d21738 Create parent contract 2019-05-12 09:45:03 +03:00
Madhur Gupta
5d827e44ae Moved hardcoded URLs to a constant file Fixed #2850 (#2851)
* Moved hardcoded URLs to build.grade Fixed #2850

* Moved Urls to a constant file

* Fixed Typo
2019-05-10 15:09:32 +03:00
translatewiki.net
a4ac27d5d3 Localisation updates from https://translatewiki.net. 2019-05-09 16:54:18 +02:00
kateOmally
41b53f4560 Replace with enum two strings that were in strings.xml but were used as (#2939)
constants. Remove strings from strings.xml Issue # 2931
2019-05-08 21:37:29 +03:00
Madhur Gupta
2164fb00f3 Added Appetize badge (#2866)
* Added Appetize badge

* Update README.md
2019-05-08 11:21:33 +03:00
Madhur Gupta
867cc9921f Fixed Width of Navigation Drawer for Tablets (#2856) 2019-05-08 11:08:06 +03:00
translatewiki.net
c4b7164784 Localisation updates from https://translatewiki.net. 2019-05-06 16:37:10 +02:00
Ashish Kumar
73f272fded Merge 2.10 with master (#2938)
* Fix duplicate param information (#2515)

* Bug fix issue #2476 (#2526)

* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery

* Versioning and changelog for v2.10.2 (#2531)

* Update changelog.md

* Versioning for v2.10.2

* Update changelog.md

* Bugfix/issue 2580 (#2584)

* Corrected string placedholders in certain string files

* Corrected string placedholders in certain string files[Bug fix #2580]

* Bug Fix #2585 (#2647)

* Bug Fix #2585
* Added null checks on view in SearchImageFragment when updating views from external sources
* Disposed the disposables in SearchActivity and SearchImageFragment when no longer in active lifecycle

* use FragmentUtils to verify fragment active state

* Bug Fix issue #2648 (#2678)

* Bug Fix issue #2648
* Handled external storage permission before file download

* * Removed redudant check for permission in MediaDetailPagerFragment (Dexter already does that)
* Removed duplicate code in PermissionUtil$checkPermissionsAndPerformAction, used the existing function with conditional extra parameters

* string name typo correction

* BugFix issue #2652 (#2706)

* Addded null check on bookmark before operating on it

* BugFix issue #2711 (#2712)

* Added null checks in OkHttpJsonApiClient$searchImages MwQueryResponse

* BugFix #2718 (#2719)

* Handled null auth cookies

* Fix #2791: NPE when nominating for deletion and leaving screen (#2792)

* Bug Fix issue #2789 (#2790)

* Handled Illegal State Exception for non existent appropriate view parents in ViewUtils$showShortSnackbar

* BugFix #2720 (#2831)

BugFix deprecated licenes #2720

* * synced 2.10 with master * resolved merge conflicts

* merge 2.10 with master
2019-05-06 19:22:10 +05:30
translatewiki.net
a4104bc368 Localisation updates from https://translatewiki.net. 2019-05-02 17:57:44 +02:00
Ashish Kumar
c8a58bfc2e
Revert "Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)" (#2934)
This reverts commit 3c9b7ba7a8.
2019-05-01 16:10:43 +05:30
neslihanturan
3c9b7ba7a8 Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)
* Api call

* added captions

* final commit

* some minor changes

* sigular

* test for captions

* mock fetchCaptionbyFileName

* corrected method name

* * used ? instead of !! (unsafe call on nullable)
* updated unit test for fetchCaptionByFilename()
2019-05-01 15:08:38 +05:30
translatewiki.net
047059c490 Localisation updates from https://translatewiki.net. 2019-04-29 17:26:12 +02:00
Vivek Maskara
c004e47c0b Fix loading of images in contributions list (#2932) 2019-04-28 13:34:07 +05:30
Cesar Villalobos
ee3f4d4d30 Fix wrong language codes displaying to user (#2880) (#2930)
* Updated language codes displayed for Hebrew, Indonesian and Yiddish (#2880)

* Function 'fixLanguageCode' encapsulated with unit tests (#2880)

* Renaming class "StringUtils" as "LangCodeUtils" and small String formatting improvement in "SpinnerLanguagesAdapter"
2019-04-27 07:55:12 +03:00
neslihanturan
d22884f86a Move credential alert from skipLoginPressed to onCreate (#2928) 2019-04-26 15:23:32 +05:30
neslihanturan
c97764a01d Save media on orientation change so that same image will be reviewed (#2929) 2019-04-26 15:19:14 +05:30
Adam Jones
b17c9a75a7 Use WIKIMEDIA_API_HOST for CategoryApi (#2821) 2019-04-26 12:02:17 +03:00
Shubham Pinjwani
40e8182c9b removed Search This Area button if network connection is lost (#2774)
* removed Search This Area button if no connection is lost
2019-04-26 11:08:43 +03:00
Madhur Gupta
13ea61c7a7 Fixed Navigation UI Problem in Split Screen mode # 2788 (#2807) 2019-04-26 10:53:38 +03:00
translatewiki.net
c127bcfea4 Localisation updates from https://translatewiki.net. 2019-04-25 20:12:55 +02:00
Vivek Maskara
98d28c60a2 Bump data client library version (#2926)
* Bump data client library version

* Fix tests

* Add javadocs
2019-04-25 10:54:51 +05:30
Vivek Maskara
5419733299 Center crop images (#2924) 2019-04-24 22:12:20 +03:00
Ashish Kumar
bb7ab62b34 Fix #2915 Refractor feature Review (#2916)
* BugFix #2915
* Refractor ReviewActivity and ReviewImageFragment and the related layout files, to properly use the scrollview
* Use ButterKnife for ViewBindings in ReviewImageFragment
* updated resource id names to follow underscore notation in xml
* Use menu item instead of ImageView over toolbar in ReviewActivity
* use tools:replace instead of android:text for dummy texts

* merge nested if's [Codacy review]

* updated string review_category_yes_button_text, use textAllCaps in yes and no button in ReviewFragment

* updated other strings to use non bold letters
2019-04-24 15:52:12 +03:00
Vivek Maskara
37e9eae314 Fetch and use thumbnail across the app (#2906) 2019-04-24 03:03:09 +10:00
Amir E. Aharoni
17d69cde02 Remove an unnecessary space after a line break (#2914) 2019-04-23 16:28:13 +05:30
translatewiki.net
987bf25921 Localisation updates from https://translatewiki.net. 2019-04-22 22:05:39 +02:00
Vivek Maskara
af9d991a15 Fix fetching of bookmarks (#2905)
* Fix fetching of bookmarks

* With more robust tests
2019-04-21 17:06:31 +05:30
Vivek Maskara
a003e9706f Do not use erroneous thumb url util function (#2901)
* Do not use erroneous thumb url util function

* Remove unused code

* Fix image loading for peer review

* Clear disposable
2019-04-20 15:03:52 +05:30
Madhur Gupta
70b19754fb Completed TODO init views using bind view #2804 (#2808)
* Completed TODO init views using bind view #2804

* Added TODO
2019-04-20 14:14:49 +05:30
Vivek Maskara
accb880256 Fix image not loading issue in peer review (#2902)
* Fix image loading issue in peer review

* With more test cases
2019-04-20 10:42:09 +03:00
Kaartic Sivaraam
482cad6663 Use F-droid badge from Wikimedia Commons (#2896)
Fixes #2895.

The F-droid seems to be too slow recently due to unusual load
as a consequence of which the F-droid badge is not getting
loaded.

So, switch to using the F-droid badge from Wikimedia Commons for now.
2019-04-19 17:53:43 +01:00
translatewiki.net
99ae8f27bc Localisation updates from https://translatewiki.net. 2019-04-18 16:57:09 +02:00