valueOf() was being used in cases where it wasn't necessary because the method is called implicitly; this patch removes these usages to make the code clearer and easier to read.
In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability.
* Remove redundant empty if/else statement
This patch removes an empty if/else statement that has no effect on the execution flow of the program.
* Remove redundant empty if/else statement in MainActivity
This patch removes an empty if/else statement that has no effect on the execution flow of the program, which makes the code simpler.
* Fix duplicate param information (#2515)
* Bug fix issue #2476 (#2526)
* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery
* Versioning and changelog for v2.10.2 (#2531)
* Update changelog.md
* Versioning for v2.10.2
* Update changelog.md
* Bugfix/issue 2580 (#2584)
* Corrected string placedholders in certain string files
* Corrected string placedholders in certain string files[Bug fix#2580]
* Bug Fix#2585 (#2647)
* Bug Fix#2585
* Added null checks on view in SearchImageFragment when updating views from external sources
* Disposed the disposables in SearchActivity and SearchImageFragment when no longer in active lifecycle
* use FragmentUtils to verify fragment active state
* Bug Fix issue #2648 (#2678)
* Bug Fix issue #2648
* Handled external storage permission before file download
* * Removed redudant check for permission in MediaDetailPagerFragment (Dexter already does that)
* Removed duplicate code in PermissionUtil$checkPermissionsAndPerformAction, used the existing function with conditional extra parameters
* string name typo correction
* BugFix issue #2652 (#2706)
* Addded null check on bookmark before operating on it
* BugFix issue #2711 (#2712)
* Added null checks in OkHttpJsonApiClient$searchImages MwQueryResponse
* BugFix #2718 (#2719)
* Handled null auth cookies
* Fix#2791: NPE when nominating for deletion and leaving screen (#2792)
* Bug Fix issue #2789 (#2790)
* Handled Illegal State Exception for non existent appropriate view parents in ViewUtils$showShortSnackbar
* BugFix #2720 (#2831)
BugFix deprecated licenes #2720
* * synced 2.10 with master * resolved merge conflicts
* merge 2.10 with master
* Api call
* added captions
* final commit
* some minor changes
* sigular
* test for captions
* mock fetchCaptionbyFileName
* corrected method name
* * used ? instead of !! (unsafe call on nullable)
* updated unit test for fetchCaptionByFilename()
* Updated language codes displayed for Hebrew, Indonesian and Yiddish (#2880)
* Function 'fixLanguageCode' encapsulated with unit tests (#2880)
* Renaming class "StringUtils" as "LangCodeUtils" and small String formatting improvement in "SpinnerLanguagesAdapter"
* BugFix #2915
* Refractor ReviewActivity and ReviewImageFragment and the related layout files, to properly use the scrollview
* Use ButterKnife for ViewBindings in ReviewImageFragment
* updated resource id names to follow underscore notation in xml
* Use menu item instead of ImageView over toolbar in ReviewActivity
* use tools:replace instead of android:text for dummy texts
* merge nested if's [Codacy review]
* updated string review_category_yes_button_text, use textAllCaps in yes and no button in ReviewFragment
* updated other strings to use non bold letters
Fixes#2895.
The F-droid seems to be too slow recently due to unusual load
as a consequence of which the F-droid badge is not getting
loaded.
So, switch to using the F-droid badge from Wikimedia Commons for now.
* Use previous Title/Description option added
* Update UploadActivity.java
* add previous title/description option modified
* declaration of Descripton object moved within the loop
* spinner position gets adjusted according to the description's language
* prev Title/Desc option for multiple upload added
* Tooltip for previous title/description button added
* UI and other resolved issues
* Avoid jargon and slang, change for default, de and pl (#2874)
* Revert "Avoid jargon and slang, change for default, de and pl (#2874)"
This reverts commit 174efe0309.
* check_category_success_title text changed to: Category check requested
* check_category_failure_title new text
