* Use wrapper for accessing shared preferences across the app
* Use Json kv store for storing place object
* Fix tests
* Fix test failure
* Fix UI tests
* Use image picker to pick images for upload
* Consolidate storage permissions in Upload activity
* With proper request codes for image upload
* Use constants for upload limits
* Check for request code while handling requests
* Let fragment initiate the camera/gallery instead of activity
* Delete unused external storage utils
* Fix#2215 Added BetaCheckerUtil class and made necessary changes
* Fix#2215 Fixed formatting error in LogSender class
* Fix#2215 Renamed BetaCheckerUtil to ConfigUtils
* Fix#2215 Fixed formatting in CommonsApplicationModule
* Make version number copyable
* Resolve Travis build fail
* Revert "Make version number copyable"
This reverts commit c3f435423a.
* Revert "Resolve Travis build fail"
This reverts commit 20e70b21fb.
* Add gen folder to gitignore
* Removed default license settings, and implemented selecting last selected license as default licence(#2170)
* Replace settings license tests with recent upload limit test
* Add method to check if current location marker is in visible region or not
* Ignore postion track updates if current location marker is not in the visible region
* Fix unnecessary progess bar issue
* Rephrase misleading statement shown when skipping login
The previous statement was misleading as it could also
mean that the user could never upload pictures if he
skips login. This not the case because after skipping
the login he could login again if he wants to upload
pictures.
Clarify it by using a statement which states that he
would have to login in future in case he wants to
upload pictures.
* Rephrase with a better statement
The old statement doesn't read so well.
Rephrase it with a better statement.
* Hide subtitle message when uploading a single image (#2163)
* updateSubtitleVisibility: Javadoc and replace if with ternary operator
* updateSubtitleVisibility: change findViewById to BindView
* Remove null checks for views
Null check is not required while binding views with butterknife.
In the upload revamp, commit f607c1c1 (Multiple uploads with over haul (#1968), 19 Nov 2018),
kept back the label for the single upload intent but removed the label for the multiple upload
intent.
Correct it and bring back the label for the multiple upload intent thus giving a more useful
label for the intent, again.
* Dangling Javadoc comments
* Replace for loop with foreach
* Explicit type can be replaced with <>
* Anonymous type can be replaced with lambda
* Lambda can be replaced with method reference
* Remove redundant methods
* Use capital L for long literals
* Remove unnecessary StringBuilder
* UploadController: Added support for using author names. Fixes#1707.
* Minor PR tidy-up
* Reword preference item
* Null check to pass startUpload test
* SharedPreferences Dep Injection added, updateLicense() updated
method updateLicense() was previously looking to the UploadModel for the
current default license, this has now been changed so that it gets it from
a SharedPreferences object
* UploadModel.license aligned to SharedPreferences
variable UploadModel.license within the constuctor is now assigned to the string of the
"default_license" value within SharedPreferences
Admittedly this may not be completly necissary as UploadModel.license is modified via
UploadPresenter.updateLicense on creation.
* Updated deleteAll() method to remove all searches insetead of 10 (#2181)
* Updated deleteAll() method to delete all searches instead of 10 (#2181)
* some minor chages
* Add Traceur for getting meaningful RxJava stack traces (#1832)
* Hotfix for overwrite issue in 2.8.0 (#1838)
* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.
* Check if file title includes an extension already, by checking if is there any dot in it.
* Fix logic error
* Add uncovered tests
* Remove unecessary line breaks
* Make Javadocs more explicit
* Versioning and changelog for v2.8.2 (#1842)
* Versioning for v2.8.2
* Changelog for v2.8.2
* Delete unused MaterialShowcase class
* Add Javadocs and fix lint errors for DirectUpload.java
* Fix whitespace and add docs
* Replace fragment.getActivity() with the parentActivity var
* Rename unnecessarily-overloaded method getFromWikidataQuery(), add Javadocs
* Javadocs and whitespaces for NearbyPlaces.java
* Use local vars where possible instead of class fields. Non-constants should not be in all caps
* Missed one unnecessary class field
* Remove unnecessary whitespaces that don't improve readability
* Add class summary
* Optimize imports
* Fix access modifiers in Place.java
* Clearer Javadocs
* Add Javadocs to Place.java
* Remove residual conflict
* Fix lint issues in Sitelinks
* Javadocs for Sitelinks.java
* DirectUpload: Replace nested conditionals with guard clauses
