Commit graph

5919 commits

Author SHA1 Message Date
Ritika Pahwa
d967279abc
UploadActivity: fix multi-upload bugs (#5389) 2023-11-20 17:46:32 +09:00
translatewiki.net
a85decd2cd Localisation updates from https://translatewiki.net. 2023-11-16 13:02:57 +01:00
translatewiki.net
d87f7dec3c Localisation updates from https://translatewiki.net. 2023-11-13 13:03:19 +01:00
Nicolas Raoul
8be5526b7a
new disposable Mapbox token 2023-11-13 12:11:35 +09:00
Paul Hawke
5e35db159d
Remove butterknife from achievements fragment (#5382)
* Replace butterknife view bindings

* Migrated onClick listeners, and removed Butterknife
2023-11-12 14:39:59 +09:00
Paul Hawke
861d2b9bf6
Removed butterknife from login activity (#5380)
* Removed butterknife view bindings

* Migrated click listeners to view binding

* Migrate onEditorAction to use ViewBinding

* Finally, removed butterknife
2023-11-11 22:54:08 +09:00
Paul Hawke
9620f6eee0
Replaced Butterknife with Viewbinding, and dealt the a whole bunch of code quality warnings (#5379) 2023-11-10 23:03:12 +09:00
translatewiki.net
b113f3c986 Localisation updates from https://translatewiki.net. 2023-11-09 13:02:57 +01:00
Srishti Rohatgi
2ab100d99f
fixes wrong string translation in french (#5376) 2023-11-07 22:46:10 +09:00
Nicolas Raoul
c901140796
Replaced with disposable token "Commons-GitHub", please replace with former token when releasing 2023-11-07 11:23:06 +09:00
translatewiki.net
327541c7b1 Localisation updates from https://translatewiki.net. 2023-11-06 13:02:54 +01:00
translatewiki.net
fb166b52ec Localisation updates from https://translatewiki.net. 2023-11-02 13:02:53 +01:00
Kanahia
187872114c
Fixed Grey empty screen at Upload wizard (#5356)
* Fixed Grey empty screen at Upload wizard caption step after denying files permission

* Empty commit

* Fixed loop issue

* Created docs for earlier commits

* Fixed javadoc

* Fixed spaces
2023-11-02 10:19:47 +09:00
HNYDDDTONY-ANU
6f96e8959b
Fixes #5344 Some categories hidden at top of Upload Wizard suggestions, need to manually scroll up (#5370)
* Fix Issue #5344

* fix update Issue #5344

* Add Comment
2023-11-01 22:25:07 +09:00
translatewiki.net
b7913fa027 Localisation updates from https://translatewiki.net. 2023-10-30 13:02:43 +01:00
Ritika Pahwa
39a2fbe3d5
ensure that cancelled uploads are really getting cancelled (#5367) 2023-10-29 23:21:16 +09:00
translatewiki.net
6166fde7cd Localisation updates from https://translatewiki.net. 2023-10-26 13:03:03 +02:00
Kaartic Sivaraam
14b6c455bf Version v4.2.1 2023-10-25 23:29:06 +05:30
Priyank Shankar
2ddb6b2e5e
[WIP]Lossless Transformations(Rotate feature) (#5252)
* UI setup for the crop feature almost setup

* basic setup of rotate feature done

* Added basic changes for editing feature

* Getting data back from edit activity

* Getting data back from edit activity

* Updated contentUri

* Finally the rotated image is getting uploaded

* Minor Improvements for better testing

* Fixed thumbnail preview

* Fixed loss of exif data

* Copy exif data

* Save exif data

* Added java docs

* Minor fix

* Added Javadoc

* Refactoring

* Formatting fixes

* Minor Formatting Fix

* Fix unit test

* Add test coverage

* Formatting fixes

* Formatting Fixes

---------

Co-authored-by: Priyank Shankar <priyankshankar@changejar.in>
2023-10-24 13:04:21 +09:00
translatewiki.net
6b8954b4a9 Localisation updates from https://translatewiki.net. 2023-10-23 13:03:01 +02:00
Shin0017
6c14163c66
checks items length (#5360)
* checks items length

* Update UploadMediaPresenter.java

* Update UploadMediaPresenter.java

* Update UploadMediaPresenter.java
2023-10-23 11:09:45 +09:00
Zhiyuan Xu
57d7159ee0
Update the SoLoader SDK version (#5361) 2023-10-22 22:15:41 +09:00
Kaartic Sivaraam
c086ff264f
app: avoid R8 from obfuscating our model classes (#5359)
R8 shouldn't obfuscate the classes that we use for serialization /
de-serialization over Gson. This causes issues with app functioning.

Fixes #5358
2023-10-22 14:42:26 +09:00
Nicolas Raoul
1490710a51 Merge branch 'v4.2.0-release' 2023-10-20 13:51:30 +09:00
Nicolas Raoul
d4917b5455 Switch Mapbox account from Vivek to Nicolas 2023-10-20 12:05:02 +09:00
Srishti Rohatgi
c9dfc03a20
fixes unit tests (#5354)
* fixes unit tests

* fixes failing unit tests
2023-10-20 11:50:51 +09:00
translatewiki.net
af581612f6 Localisation updates from https://translatewiki.net. 2023-10-19 13:02:52 +02:00
Nicolas Raoul
04aec20fc9
Switch Mapbox account from Vivek to Nicolas 2023-10-19 17:27:20 +09:00
Tai Ha
988b83dc32
Fix #5212: removing bug causing progress dialog to load forever (#5350)
* Fixes bug causing the progress dialog to load forever (#5212)

* Fixes bug causing the progress dialog to load forever (#5212)

* remove unnecessary new line (#5212)
2023-10-19 16:20:28 +09:00
Alvin Tang
f7164d0b78
Fix #5246: map icon in Upload Wizard indicating if location is included in the EXIF data (#5343)
* Add XML map icons with a tick/question mark for the Upload Wizard
The existing map icon may not be intuitive enough to indicate
whether the location EXIF data will be included
The two new XML map icons are intended to indicate the status of
location sharing with the location data in the Upload Wizard

* Label the map icon in the Upload Wizard if location is included
If an image is capture with the in-app camera, the location in the
image metadata by default
If so, the map icon in the Upload Wizard should be labelled with
a green tick during initialisation of its UploadMediaDetailFragment instance

* Update the map icon in Upload Wizard if location is pin-pointed
If the user selects images from the device storage
to upload, the location EXIF data might originally not be included
The map icon is labelled with a red question mark
After pin-pointing the location manully, the map icon should be
labelled with a green tick instead

* Fix Upload Wizard map icon XML rendering failure
SVG path is invalid, resulting in failure to render the icons
Also imports are required for UploadMediaDetailFragment to
use Drawable objects and R objects

* Add hasLocation() to UploadableFile to indicate existence of EXIF
When an image is chosen from the album to the Upload Wizard,
its EXIF might contain location data. hasLocation() and fix of init()
in UploadMediaDetailFragment ensures that the map icon is shown
correctly

* Fix init() NullPointerException in UploadMediaDetailFragment

* Fix comment typo in UploadMediaDetailFragment
Fix the comment about red and green labels for the map icon

* Use SLF4J logging for try-catch clauses in UploadableFile class
Instead of using printStackTrace(), error directed to logcat

* Use Timber for logging in UploadableFile
Clean up the catch clause in hasLocation() and getDataTimeFromExif()
2023-10-18 22:42:01 +09:00
Srishti Rohatgi
64652b987d
fixes blank screen decrepancy when sharing items from external apps (#5345)
* fixes blank screen decrepancy when sharing items from external apps

* reverts comment removal
2023-10-18 12:16:33 +09:00
JiaYuan Huang
f13085147f
5338 bug fix (#5340)
* fix Bug index out bound

* fix Bug index out bound

* fix Bug index out bound

* fix Bug index out bound

* add some comments for that

* add some comments for that

* add some comments for that

* add some comments for that
2023-10-17 14:50:24 +09:00
Kaartic Sivaraam
26eaa4650d Merge branch 'siva/gradle-version-upgrade' into v4.2.0-release 2023-10-17 07:58:37 +05:30
Kaartic Sivaraam
870d138d11 Empty commit to enable merge 2023-10-17 07:55:04 +05:30
translatewiki.net
f06dedaebc Localisation updates from https://translatewiki.net. 2023-10-16 13:03:39 +02:00
Kaartic Sivaraam
e5e3a6b875 Upgrade robolectric to fix unit tests
This is as per the observation of Nicolas Raoul in the MR. He mentions
this brings down test failures to just 5.

Ref: https://github.com/commons-app/apps-android-commons/pull/5220#issuecomment-1722425627
2023-10-16 00:28:09 +05:30
Kaartic Sivaraam
eae3e312e4 Disable full mode R8 optimizations
Full mode R8 configurations are hindering the working of the app severly.
So, disable the same.

Also, ensure the POJO classes used to hold the API responses aren't optimized
so that we could use the response properly without any issues.
2023-10-16 00:14:21 +05:30
translatewiki.net
8553a96358 Localisation updates from https://translatewiki.net. 2023-10-12 13:03:03 +02:00
Srishti Rohatgi
a708c811d6
fixes image retention when no network is available (#5335) 2023-10-10 23:00:17 +09:00
Srishti Rohatgi
b18bc8ff4b
fixes popup message title and description on cancelling uploading image (#5334) 2023-10-10 22:21:15 +09:00
Srishti Rohatgi
0d90ac3c53
Tick icon in place of number of images selected in custom picker (#5331)
* tick in place of number of images selected in custom picker

* fixes tests, dark mode visibility, bold tick icon for better visibility
2023-10-09 23:08:00 +09:00
translatewiki.net
f69ecde713 Localisation updates from https://translatewiki.net. 2023-10-09 13:03:04 +02:00
Srishti Rohatgi
733c8709fc
Makes depicted place and category items unselectable for nearby place (#5325)
* Makes depicted place and category items unselectable for nearby place

* UploadCategoriesFragmentUnitTests.kt fixes and javadoc addition

* comment fix

* Fixes tests and hidden category appearing and dissapearing issue
2023-10-08 18:26:27 +09:00
Dean Stirrat
05fbfce865
check for exact category match on upload search (#5328) 2023-10-07 22:30:27 +09:00
Srishti Rohatgi
048b78a03a
Fixes location issue in upload wizard (#5329)
* Fixes location issue in upload wizard

* Fixes blue dot disappearance on first install
2023-10-07 22:07:08 +09:00
Srishti Rohatgi
8aee7a680d
Fixes copy to subsequent media functionality for nearby uploaded images (#5326) 2023-10-07 07:10:28 +09:00
translatewiki.net
fd6ba00fbd Localisation updates from https://translatewiki.net. 2023-10-05 13:03:16 +02:00
Kaartic Sivaraam
a629756f3a Retain siva's comment about disabling force = true 2023-10-04 06:56:52 +05:30
Kaartic Sivaraam
62661604ff Merge commit 'refs/pull/5220/head' of github.com:commons-app/apps-android-commons into new-tools 2023-10-04 06:54:48 +05:30
Aryan Arora
373c6201bd
Show progress dialog on mark/unmark photos not for upload (#5322) 2023-10-03 23:17:29 +09:00