Commit graph

3842 commits

Author SHA1 Message Date
Vivek Maskara
9845a6265d Integrate API for displaying featured images (#1456)
* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs
2018-05-07 11:09:23 +03:00
translatewiki.net
96eae8c0a6 Localisation updates from https://translatewiki.net. 2018-05-07 07:54:16 +02:00
Josephine Lim
228aa21290 Update contributing.md (#1477) 2018-05-06 23:35:55 +05:30
Ujjwal Agrawal
693c37f2ec Updated share feature (#1474) 2018-05-04 12:56:13 +03:00
translatewiki.net
bcb90db16c Localisation updates from https://translatewiki.net. 2018-05-03 09:21:58 +02:00
Ujjwal Agrawal
d3597b80a6 Added hideKeyboard in ViewUtil (#1488) 2018-05-03 02:47:56 +05:30
neslihanturan
35f05be8df
fix memory leaks (they happened due to hiding keyboard) and lint null pointer warnings in the same code (#1471) 2018-04-30 14:42:19 +03:00
Balakrishnan S
6d2c41b91e Help button (#1415)
* Help button added to tutorial

* debug typo removed

* Help changed to more info

* More option moved to bottom

* Alignment changes made
2018-04-30 14:31:27 +03:00
Abhishek Poonia
0223c5ab76 Error messages in LoginActivity persist after orientation change. (#1407) 2018-04-30 14:27:35 +03:00
neslihanturan
3c2cc26d3b
Fix conflicts from #1366 fixing lint issues (#1470)
* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added %d

* lint issue #171 - Changed version

* lint issue #171 - added singleLine="true"

* lint issue #171 - changed commit to apply

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* Codacy issues #778 - nested if loop

* Codacy issues #778 - nested if loop

* Revert "lint issue #171 - added %d" since we dont edit translated string files

This reverts commit e4917cddcf.
2018-04-30 14:05:47 +03:00
Mansi Agarwal
f80311d9f6 fixed crash while uploadiing certain images (#1388) 2018-04-30 13:49:03 +03:00
Ujjwal Agrawal
b017d1c99a Changed webview to Custom Tabs in Settings Page (#1328)
* Changed Webview to Custoom tabs in Settings Page

* Get COntext changed to getActivity
2018-04-30 12:24:37 +03:00
translatewiki.net
5ebaa7418e Localisation updates from https://translatewiki.net. 2018-04-30 08:19:57 +02:00
translatewiki.net
8a06aa5c14 Localisation updates from https://translatewiki.net. 2018-04-26 07:51:15 +02:00
Tanvi Dadu
9c91d7a799 Zoom (#1300)
*  Basic Zoom feature added along with button to control it

*  Pinch Zoom added

*  Merge Conflicts Resolved

*  Icons Changed

*  Compressed the high resolution images

* Fixed null pointer exception

* Fixed null pointer exception

*  Fixed exception

*  Fixed error

*  Fixed Resource availability issue
2018-04-26 03:18:58 +05:30
Vivek Maskara
fed9b1dc00
Merge pull request #1461 from misaochan/remove-author
Remove author Javadocs for FeaturedImagesListFragment.java
2018-04-25 02:28:33 +05:30
Vivek Maskara
07bdb42d84
Merge pull request #1460 from misaochan/fix-travis
Fix Travis
2018-04-25 02:28:16 +05:30
misaochan
fab3d32a8c Remove author Javadocs for FeaturedImagesListFragment.java
As mentioned at #1451 . Travis will fail prior to merge of #1460
2018-04-24 01:31:24 +10:00
misaochan
d252275b7c Fix error during merge conflict resolution 2018-04-23 21:56:48 +10:00
misaochan
4c78ebf58b Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-04-23 21:51:23 +10:00
misaochan
014da5fd00 Merge branch 'commons-app/master' 2018-04-23 20:20:49 +10:00
misaochan
d6a4188cb1 Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release'
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java
2018-04-23 20:14:21 +10:00
misaochan
649da00c7f Merge remote-tracking branch 'refs/remotes/commons-app/master' 2018-04-23 17:39:14 +10:00
translatewiki.net
970704334b Localisation updates from https://translatewiki.net. 2018-04-23 08:51:06 +02:00
Josephine Lim
533297dce7
Versioning and changelog for v2.7.1 (#1457)
* Versioning

* Update changelog.md
2018-04-20 15:28:42 +10:00
Vivek Maskara
ce7754af45
Merge pull request #1455 from commons-app/featuredImages
Featured images
2018-04-20 00:33:17 +05:30
Vivek Maskara
b108dff460
Merge branch 'master' into featuredImages 2018-04-19 23:44:33 +05:30
kamilya35231
108ca26967 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-19 23:50:23 +10:00
Vivek Maskara
8b118b309c Fix loading issue after upgrade from older version (#1454) 2018-04-19 12:52:58 +03:00
translatewiki.net
8b765109ca Localisation updates from https://translatewiki.net. 2018-04-19 09:18:13 +02:00
Kaartic Sivaraam
f814d33de7 Add CONTRIBUTING file (#879)
* docs: add an initial version of commit message/contributors guideline

The project has long evolved without a guideline for commit messages
and a contributors guideline. This has led to a lot mysteries in the
code base.

To avoid such mysteries in the code base in the future, add an intial
version of the commit message guideline in the form of a contributors
guideline.

The name 'CONTRIBUTING' is pretty common and also ensures that GitHub
(the place where this project currnetly evolves) brings the document to
notice to an user trying to create Pull Request. Further, the all caps
ensure it catches the eyes of the gazing user.

This initial version of guideline is based on the git project's guideline
for submitting patches (Documentation/SubmittingPatches).

* contributing: remove internal link

Markdown doesn't seem to be supporting internal links(fragments) to other
parts of the document.

So, replace it with normal text to refer to the section.

* contributing: fix typo and improve sentence

* contributing: add link to related wiki page

* contributing: fix typo

* contributing: quote section name correectly

Only part of the name of a section was quoted thus referring to
an inexistent section and making the sentence meaningless.

So, quote it completely.

* contributing: use plural to refer to wiki pages

A change might obsolete "multiple" Wiki pages, which have
technical documentation about the app.

So, use plural to refer to the wiki pages.

* contributing: move the main contributing file to the wiki

The document was based on Git project's guidelines for submitting
patches (Documentation/SubmittingPatches). As it was licensed under
GPLv2 while this porject is licensed under an Apache license a license
conflict arose.

To solve it move the main document which might be susceptible to
license issues to the wiki while keeping a jist of it in the
document itself.

* contributing: use lenient wording for steps that might be optional

It's not possible to write tests for all changes. For example, UI
changes. Also, it's not the case that the Wiki pages become stale all
the time.

So, use lineant wordings for optional steps

* contributing: correct grammar in a sentence

"documented in" reads better than "documented at" (at least for
me).

If this is wrong then we can revert it.

* contributing: add link to guidelines in the wiki page

* contributing: replace 'jist' with 'gist'

  "Jist is a pronunciation spelling of the word just when spoken
   with an American Southern accent.

   Gist is a noun that means a quick summary or the main point of
   something."

I intended to use the latter. So, ..
2018-04-18 14:42:31 +03:00
Josephine Lim
3b129a6ea4 Fix security exception (Nearby places not loading after permissions granted) (#1440)
* Update changelog.md

* Versioning for v2.7.0

* Add logging to onPermissionsRequestResult

* Request location updates onStatusChanged

* Copy onResume() actions into onPermissionsRequestResult

* Added getLastKnownLocation method and hooked it up to refreshView

* Remove unnecessary calls, add more logging

* Add check to prevent NPE

* Check that curLatLng exists before getting Mapbox instance

* Moar logging

* Make curLatLang clearer

* Not a good hack - put curLatLang into the bundle separately

* Add TODO

* Rename variables for clarity

* Check for Network Provider as well, tidy up getLKL()

* Add Javadocs

* Remove unnecessary method in onStatusChanged

* Add checkGPS comment

* Remove unnecessary logs

* Add TODO

* Call bundle.clear() before inserting CurLatLng
2018-04-18 14:30:13 +03:00
brok85
01a11a95ea Fix for issue #1436 list icon allows user only to show the list, but not to make it disappear (#1443)
* Fixed by using a boolean variable "opened" that changes according to the current state of the list. It is false by default when you open the nearby activity.

* Fixed by using bottomSheetBehavior.getState() to decide whether to expand or collapse the bottom list.
2018-04-17 16:12:04 +03:00
Anubhav Gupta
d3071718b4 Changes made (#1447) 2018-04-17 15:52:53 +03:00
misaochan
4285b5e77f Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-17 18:58:35 +10:00
Jatin0312
d5f3fd58ab Fixes Issue #1358 Circle page indicator display improved (#1379)
* Fixes Issue #1358 Circle page indicator

* Build test checking and reformated code
2018-04-16 16:00:38 +03:00
Balakrishnan S
f8fb9f1ce9 fixed typo in nearbyActivity (#1394) 2018-04-16 15:51:59 +03:00
Gabriela Radu
9a3b6fc964 Deletion button being disabled (#1403)
* used CDATA

* Improvements in Notification Activity (#1374)

* Improvements in Notification Activity

* Update NotificationActivity.java

* Share feature (#1338)

* added share app feature in About

* added share app feature in About

* a small fix

* Use custom tabs for nearby web views (#1347)

* Localisation updates from https://translatewiki.net.

* Fix for issue #1380 Improved Notification UI (#1387)

* Links added to TextView about_upload_to in aboutActivity (#1326)

*  Added the link in about_upload_to textfield

*  Merge conflicts resolved

*  Removed the extra textView

* Fix re-enabling delete button if the action is canceled.

* Keep delete button enabled until a reason is given.
2018-04-16 15:03:24 +03:00
kamilya35231
35a7d49590 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-16 14:37:04 +03:00
translatewiki.net
b012ce4142 Localisation updates from https://translatewiki.net. 2018-04-12 15:14:33 +02:00
translatewiki.net
7b150f78a8 Localisation updates from https://translatewiki.net. 2018-04-12 09:10:26 +02:00
neslihanturan
482b06ccf0 Hot fix connectivity leak (#1432)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone

* Fix memory leak causing usage of activity as context
2018-04-11 19:40:13 +10:00
translatewiki.net
2de9a1fe08 Localisation updates from https://translatewiki.net. 2018-04-09 08:15:46 +02:00
neslihanturan
802b2a8df4 Hot fix bundle issue (#1425)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone

* Fix adding bundle to an already created fragment
2018-04-08 19:17:20 +10:00
Paul Hawke
22772c851e Moved tests over to Kotlin. (#1428) 2018-04-08 17:59:20 +10:00
Josephine Lim
6b2dd8c1df
Fixed misspelling in credits.md 2018-04-06 19:26:23 +10:00
Josephine Lim
3b141c1425
Added new contributors to CREDITS.MD in alphabetical order
Please let me know if I missed anyone!
2018-04-06 19:02:50 +10:00
Yiran Cao
3949dbca5c Fixed issue #1395 (#1423)
* fixed issue #1395

* moved the compass icon to bottom-left corner
2018-04-05 20:27:10 +03:00
misaochan
912dfb05ec Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-04-06 00:15:45 +10:00
misaochan
a095a4e25b Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-06 00:15:40 +10:00