Commit graph

1315 commits

Author SHA1 Message Date
Zhao Gang
00b95ea9cf Remove unused string values(Fixed #2448) (#2484)
These string values are not used in layouts and java files. So just
remove them.
2019-02-22 20:02:55 +05:30
Ronak Lakhotia
01a7526477 Fix code quality issues (#2359)
* Minor changes

* Fix more errors

* Revert change

* Minor error fix

* Remove unused import

* Merge branch 'master' of github.com:commons-app/apps-android-commons into lint-errors

# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

* Minor changes

* Undo changes

* Undo performclick
2019-02-22 14:51:58 +05:30
Zhao Gang
9882d24651 Clean up placeholders in media detail fragment fields(Fixed #2471) (#2500)
Remove placeholders and let these descriptions only shown in Android
Studio layout preview. Use plain text in tools:text attributes so
relative string values can also be removed and ease the translation work.
2019-02-22 11:13:31 +05:30
Amir E. Aharoni
fa7585bf94 Add a space before parentheses (#2490) 2019-02-20 20:16:27 +05:30
Josephine Lim
b698d14172 Merge branch '2.10-release' 2019-02-18 19:13:24 +10:00
Vivek Maskara
083a7a80f0 Fix notification click (#2474) 2019-02-18 21:52:10 +13:00
translatewiki.net
6bedf54a43 Localisation updates from https://translatewiki.net. 2019-02-18 07:58:25 +01:00
Vivek Maskara
0ef60e050d
Revert "fixed. I have fixed the layout desingn of achivement activity (#2469)" (#2475)
This reverts commit c7e819d404.
2019-02-15 17:50:04 +05:30
Anike Nath
c7e819d404 fixed. I have fixed the layout desingn of achivement activity (#2469) 2019-02-15 17:39:31 +05:30
chris-fo
83770ea484 Changes achievement icon for: Images via "Nearby Places" (#2463) 2019-02-15 03:00:35 +00:00
translatewiki.net
b5a479ce93 Localisation updates from https://translatewiki.net. 2019-02-14 09:07:01 +01:00
Vanshika Arora
635047ded2 Fixed issue #2291 (#2292)
* Fixed issue #2291

* resolved codacy issue

* settings

* removed unwanted commemts
2019-02-13 21:08:24 +05:30
Vivek Maskara
73bb0c52c9 Show wikidata edits done through the app (#2431)
* Show wikidata edits done through the app

* Minor changes based on code review
2019-02-13 05:58:22 +13:00
Shubham Pinjwani
a9629c6f99 Added option in the action bar menu to view archived notifications (#2422)
* changed layout and implemented archived notificaitons feature

* set different texts for toolbar,menu option and no notification text in archived

* modified the startup intent for NotificationsActivity

* disabled swipe on archived

* commit

* fixed navigation drawer on notification activity

* handled on back pressed

* updated strings.xml

* removed TODO

* some minor changes

* set progress bar visibility

* some code quality changes

* commit

* some code quality changes

* removing unused import statements
2019-02-10 16:10:08 +05:30
translatewiki.net
cb3a570090 Localisation updates from https://translatewiki.net. 2019-02-07 15:54:04 +01:00
Vivek Maskara
f12837650a Use JSON SPARQL query for fetching nearby places (#2398)
* Use JSON response for nearby places

* Move okhttp calls to a different class

* wip

* Fetch picture of the day using JSON API

* Search images using JSON APIs

* tests

* Fix injection based on code review comments
2019-02-06 10:40:30 +05:30
Vanshika Arora
2cd375a11b Progressbar in category and media fragment now doesn't overlaps the views (#2382)
* graddle changes

* scrolling fixed for both media and category
2019-02-06 02:06:59 +05:30
translatewiki.net
8c12cc48e0 Localisation updates from https://translatewiki.net. 2019-02-04 08:57:03 +01:00
Vivek Maskara
52ab39381e Add module for file picker for camera and gallery uploads (#2375)
* Use easy image for image picker

* Do not use harcoded mime type

* Use uploadable file for image uploads

* Add picker files in filepicker module

* Remove redundant checks for file

* Make usage of file extensions consistent

* Add javadocs

* Fix tests

* Enable image upload using bookmark activity

* Fix multiple uploads

* Fix external image uploads

* Fix chooser intents

* Fix image quality checks

* Segregate internal and external upload intents

* Invoke all error messages from one place

* Minor changes

* Fix tests

* Add image processing service tests
2019-02-03 22:40:31 +02:00
Vanshika Arora
1b62ac4d2d Code to retrive unknown notification and UI (#2340)
* request change, changed notification icon

* Completed task 1 of the work

* commit changes

* commit changes

* updated notification class

* before notification id

* gradle reverted

* Minor changes to mark notifications as read

* commit changes

* delete on swipe

* notification count

* sipe to delete

* changes

* worked on changes requested

* commit changes

* Fix notification count

* reviewed changes

* round icon, swipe with icon

* Fix pending NPE issues with notifications

* final commit

* graddle changes

* removed changes for testing
2019-02-02 19:21:58 +05:30
Shubham Pinjwani
9451b00a15 Show bookmarked nearby locations differently (#2059) (#2349)
* Show bookmarked nearby locations differently (#2059)

* added custom bookmark marker

* passed value of bookmarkplacelist in tests

* update the nearby markers on clicking bookmark buttons
2019-02-02 19:13:42 +05:30
Vivek Maskara
16927057d0 Remove drawer layout from upload activity (#2380) 2019-02-01 23:31:28 +13:00
Vanshika Arora
f9adbbb48c Activity upload made full screen (#2370)
* graddle changes

* upload activity changes

* final commit
2019-01-31 15:41:11 +05:30
translatewiki.net
f6029be842 Localisation updates from https://translatewiki.net. 2019-01-30 23:38:57 +01:00
Vivek Maskara
1727a296c9 Remove notifications from nav drawer (#2319) 2019-01-30 11:51:29 +02:00
Vanshika Arora
f23cf3e7fa Caption can acquire the entire horizontal space (#2360)
* Fixed Issue #2357

* final commit

* final changes
2019-01-27 21:22:33 +05:30
Vanshika Arora
ada67e012c Fixed issue #1507 (#2348)
Fixed #1507: Add progress bar in Nearby list
2019-01-26 22:00:10 +05:30
Vanshika Arora
c04cb8cb9f Modified Image Layout (#2351)
* modified date format

* mediadetail fragment modified

* added the function in dateutils

* modified imports

* Fixed Issue #2350

* Undo other commit changes
2019-01-26 21:43:55 +05:30
Shubham Pinjwani
71920c8bbc made Version number selectable in About menu(#2342) (#2347) 2019-01-25 23:40:53 +05:30
Vanshika Arora
a12d62a095 fixed issue #2343 (#2344)
* fixed issue #2343

* build issues
2019-01-25 23:15:28 +05:30
ravi-kishan
fa406be9f0 Changed from harcoded text to string resource. Fix 2331 (#2338) 2019-01-25 21:52:48 +05:30
Vivek Maskara
e389a95592 Fix log file not being attached (#2316)
* Fix log file not being attached

* Add filter for email clients
2019-01-24 18:21:07 +10:00
translatewiki.net
07f9af19f5 Localisation updates from https://translatewiki.net. 2019-01-21 09:54:22 +01:00
translatewiki.net
071eab6302 Localisation updates from https://translatewiki.net. 2019-01-17 10:49:03 +01:00
Shubham Pinjwani
e93564fb79 Improved Result of the quiz activity for smaller screens(#2010) (#2304)
* Improved Result of the quiz activity for smaller screens(#2010)

* added scroll view
2019-01-15 21:27:54 +05:30
translatewiki.net
b2038ac017 Localisation updates from https://translatewiki.net. 2019-01-14 09:30:54 +01:00
vanshikaarora
1b7b909107 #2192 scroll issue resolved (#2290) 2019-01-13 16:00:33 +05:30
translatewiki.net
28bfb04f0c Localisation updates from https://translatewiki.net. 2019-01-10 08:45:01 +01:00
translatewiki.net
cd322d2f57 Localisation updates from https://translatewiki.net. 2019-01-07 10:04:32 +01:00
Supriya
2b45194379 Fix #2250: Make version number copyable in About screen (#2273)
* Make version number copyable

* Resolve Travis build fail

* Revert "Make version number copyable"

This reverts commit c3f435423a.

* Revert "Resolve Travis build fail"

This reverts commit 20e70b21fb.

* Add gen folder to gitignore
2019-01-06 01:28:45 +05:30
sp2710
dabcd43a5b Removed default license settings, and implemented selecting last selected license as default licence(#2170) (#2218)
* Removed default license settings, and implemented selecting last selected license as default licence(#2170)
* Replace settings license tests with recent upload limit test
2019-01-04 15:26:39 +00:00
Vivek Maskara
e773a82206 Handle null URI while uploading picture (#2262)
* Handle null URI while uploading picture

* Modify cache method to never return null path

* Fix tests
2019-01-04 18:21:55 +10:00
vanshikaarora
e69c03cf83 fixed issue #2154 for achievements activity (#2087)
* fixed issue #2065 for achievements activity

* updates for issue #2154

* removed unwanted comments and undo gradle changes

* added strings to strings.xml

* changes made after reviews

* review changes

* build issues resolved

* Undo changes in gradle properties
2019-01-03 21:25:13 +05:30
translatewiki.net
10e57bd8d0 Localisation updates from https://translatewiki.net. 2019-01-03 16:38:22 +01:00
Kaartic Sivaraam
ed51d8b871 Rephrase misleading statement shown when skipping login (#2249)
* Rephrase misleading statement shown when skipping login

The previous statement was misleading as it could also
mean that the user could never upload pictures if he
skips login. This not the case because after skipping
the login he could login again if he wants to upload
pictures.

Clarify it by using a statement which states that he
would have to login in future in case he wants to
upload pictures.

* Rephrase with a better statement

The old statement doesn't read so well.
Rephrase it with a  better statement.
2019-01-04 00:07:45 +10:00
Vivek Maskara
be98a56ba0 Improve text for receiving shared images (#2266) 2019-01-04 00:05:00 +10:00
Vivek Maskara
a48a09a785 Use dexter for requesting storage permissions (#2258)
* Use dexter for requesting storage permissions

* minor changes

* Fix minor issue
2019-01-02 18:11:19 +02:00
Adam Jones
5317063689 Fix night mode issues with search and categories (#2213) 2019-01-01 16:25:46 +05:30
Zhao Gang
af291a5fcc Fix #2163: Hide subtitle message when uploading a single image (#2169)
* Hide subtitle message when uploading a single image (#2163)

* updateSubtitleVisibility: Javadoc and replace if with ternary operator

* updateSubtitleVisibility: change findViewById to BindView

* Remove null checks for views

Null check is not required while binding views with butterknife.
2019-01-01 16:08:12 +05:30
Adam Jones
5c8a0cdd93 Add WhiteSearchBarTheme to styles.xml (#2211) 2019-01-01 15:55:34 +05:30