* Enhancement issue #1862
Added on click to the "middle text" of a Notification item.
* Added comment #1862
Added comment to better explain method usage.
The reported issue is that in the Nearby activity, the app does not communicate that there is no internet connection. On investigation, it appears that a toast message does briefly display "No internet connection". It looks like other activities have implemented this same message within the snackbar instead. In order to have a consistent style of communication to the user, I removed the toast message and replace it with the snackbar message, as implemented in NotificationActivity.java.
Fix#1914 using getX() instead of getRawX() method and subtracted right padding to get the value. Now info dialog opens only on touch of the icon (#1915)
* Add bookmark star images
* Add bookmark item in navigation menu
* Add Activity for bookmarks
* Implement bookmarks viewpager
* Bookmark object and bookmarkDao
* Implement Bookmark Picture Fragment and Controller
* Implement image detail bookmark menu action UI
* contentProvider + config + dao rework
* Fix Dao and Content Provider crashes
* Link bookmark controllers and dao
* Implement bookmark location fragment, controller
* Add bookmark icon to location items
* Add empty bookmark list behavior and refactoring
* bookmarkLocation dao and contentProvider
* Fix bookmarks location crashes
* Rename and refactor classes
* Implement location list refresh
* Fix picture list update
When user come back from detail picture fragment, it solve the refresh bug.
* full test coverage
* Refactor bookmarks classes
* Fix bookmarks pictures loading
* Fix bookmark locations list display
* Java Documetation
* Fix Code review quality
* Fix DB version update
* Remove forgotten todo
* Update bookmark activity base class
Change from AuthenticatedActivity to BaseNavigationActivity
* Updated contribution screen to show message for no uploads by default, message gets wiped after any picture is inserted into the list
* Changed string as suggested
* Added margin
* Fix log reporting for release builds
* Fix logs for release builds
* wip
* Clean up the branch to exclude unrelated changes
* With java docs
* Uncomment quiz checker
* Check for external storage permissions before sending logs
* With more java docs
* Fix crash while zipping log files
* Do not log token and cookies
* Add instruction to restart app
* Bugfix/upload via share (#1920)
* Bug Fix#1878
* Added a java library to fetch the MIME type from input stream
* Fetch MIME type using this and use the contribution tag only when this fails:
* formatting changes, removed unused commented out line
* Versioning and changelog for v2.8.5 (#1923)
* Versioning for v2.8.5
* Update changelog.md
* Fix crash(es) due to uninitialized notification channel.
The notification channel needs to be created for API versions greater than
OR EQUAL to 26 (O). Also, the channel does not need to be reinitialized
if it already exists.
* Initialize notification channel when Service is created.
* Sweeping update of gradle and library versions.
This updates all of the dependencies of the project to their latest
versions. Everyone should please upgrade to the latest version of Android
Studio, update your build tools, and keep your version of Gradle and the
Kotlin plugin up to date.
* Update build tools in travis.
* Remove cruft and fix tests.
* Remove even more stuff.
* Reinstate instrumented tests.
* Update emulator image in travis.
* Localisation updates from https://translatewiki.net.
* Work towards eliminating string literals from code. (#1861)
String literals are being used in many places in the code, instead of
proper string resources which are automatically localized. This PR
replaces many of the string literals with pre-packaged resources, or will
add the appropriate string if necessary.
* Add button on image details to copy wikicode to clipboard (#1849)
* Add button on image details to copy wikicode to clipboard
* Make copy wikicode button width the same as the nominate deletion button width by filling in background
* Build fix
* Enable ProGuard for Debug and Release builds.
This enables ProGuard minification, which significantly shrinks the APK
(for both debug and release configurations) and vastly decreases the
method count.
* Add ProGuard rules for test builds.
Vector drawables do *not* belong in dpi-specific subfolders. They should
always be placed in the general "res/drawable" folder. This can actually
cause crashes on certain devices.
* Add Traceur for getting meaningful RxJava stack traces (#1832)
* Hotfix for overwrite issue in 2.8.0 (#1838)
* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.
* Check if file title includes an extension already, by checking if is there any dot in it.
* Fix logic error
* Add uncovered tests
* Remove unecessary line breaks
* Make Javadocs more explicit
* Versioning and changelog for v2.8.2 (#1842)
* Versioning for v2.8.2
* Changelog for v2.8.2
* Add logs in wiki data edit and session refresh flow (#1874)
* Fix logout (#1875)
* [WIP] Refactor feedback and quiz to reduce possibility of NPE (#1881)
* Refactor feedback and quiz to reduce possibility of NPE
* Handle throwables in quiz checker
* Minor refactoring
* Set Traceur to only work in DEBUG mode (#1884)
* Bug fix for uploaded images count in achievements activity (#1885)
* Versioning and changelog for v2.8.3 (#1886)
* Update changelog.md
* Versioning for v2.8.3
* improve the algorithm for checking if the image is dark.
ImageUtils.java: algorithm used previously gave the 'TOO DARK' message for images that were perfectly valid.
The modified algorithm solves this problem.
* Clean up the code
* Added views for button skipLogin in layout-land and layout-xLarge, bug fix issue#1864
* xml improvisations
* Fixed string nominated_see_more [CDATA was used inappropriately]
* Added permission for Dexter, the runtime permission handling library
* [Preparing fir issue #1773] Added a utility function which would take the user to app settings screen where he could manually give us the required permission
* Added an alert dialog with positive and negative callback [Preparing fir issue #1773]
* Improvements in the way External Storage Permission is handled in MultipleShareActivity[Bug fix#1697]
1. Used dexter to handle the external storage permission
2. Behaviour changes : When user tries to share(uppload) images to commons via MultipleShareActivity, following decision tree is followed
a. If the app has permission for external storage, normal upload operation is followed
b. If the app does not has the permission for external storage, dexter is used to ask for the same
c. If the user gives us the required permission, normal upload flow is proceeded
d. If the doesnot gives us the required permission a rationale dialog is shown with the appropriate message to let him know why we need the permission
e. If he presses okay, steps a-c are followed and if he presses cancel, we close the app.
f. If while asking for permission, the user chooses never ask again, then next time he tries to upload an image via MSA, the rational dialog follows the app setting screen where he could manually give us the required permission and the onActivityResult of same is handled
* Added a Constants class to handle request and result codes from one place and other related constants common to the all app elements
* replaced hardcoded strings ok and cancel in DialogUtil to string resources
* init permission rationale dialog in activities onCreate
* Code formatting, updated access modifiers wherever required, added javadocs for new methods created
* *shifted constants to app class
*Added JavaDocs in PermissionUtils
* removed class REQUEST_CODES from CommonsApplication and instead put the enclosing constants in the App class itself
