Commit graph

1297 commits

Author SHA1 Message Date
Vanshika Arora
ec8bbb2782 removed swipe to delete (#2589) 2019-08-05 14:25:33 +03:00
translatewiki.net
579d44ce80 Localisation updates from https://translatewiki.net. 2019-08-05 11:59:55 +02:00
translatewiki.net
009fe6f012 Localisation updates from https://translatewiki.net. 2019-08-01 18:17:20 +02:00
translatewiki.net
9bccbfe443 Localisation updates from https://translatewiki.net. 2019-07-29 14:20:50 +02:00
translatewiki.net
2c7d210430 Localisation updates from https://translatewiki.net. 2019-07-25 10:07:43 +02:00
translatewiki.net
0574b753ba Localisation updates from https://translatewiki.net. 2019-07-22 13:52:54 +02:00
Josephine Lim
1a60fec5da Merge remote-tracking branch 'origin/2.11-release' 2019-07-22 00:12:21 +10:00
translatewiki.net
1560b77652 Localisation updates from https://translatewiki.net. 2019-07-18 16:19:33 +02:00
Vitaly V. Pinchuk
32715d9cce Set defaults to ON for all EXIF tags (#3068) 2019-07-16 19:46:23 +10:00
translatewiki.net
94f3b6ea39 Localisation updates from https://translatewiki.net. 2019-07-15 19:58:46 +02:00
translatewiki.net
bb570a5afc Localisation updates from https://translatewiki.net. 2019-07-11 17:18:56 +02:00
translatewiki.net
f605c5c13a Localisation updates from https://translatewiki.net. 2019-07-08 20:02:32 +02:00
Ashish Kumar
60b1eb1957 Feature/refactor contributions (#3046)
* * Refactored ContributionsListFragment to use RecyclerView
* Added ContributionsPresenter
* Extracted out the cursor to presenter
* Probable fix for #3028

* Improved the logic for cache in ContributionViewHolder

* Some more refactoring

* While displaying images in ContributionsList, check if status is not completed && local uri exists, use that uri to show image

* typo correction in LocalDataSource

* Fixed formatting in ContributionsPresenter

* retain adapter position when orientation changes

* retain child position with its id

* Made ContributionViewHolder not implement ViewHolder

* Code formatting, review suggested changes

* initialise the rv layout managers only when needed

* added test cases for ContributionPresenter

* removed not needed semi colon

* added more java docs and code formatting
2019-07-07 10:24:28 +03:00
PavelAplevich
108e28c89a Removed all hardcoded string in DeleteHelper (#3052)
* Removed hardcoded strings in DeleteHelper

* Revert "Removed hardcoded strings in DeleteHelper"

This reverts commit 4bc55fc3af.

* Removed all hardcoded strings in DeleteHelper.

* fixed test problems

* Correction strings in DeleteHelper

* decision problem with color of info icon #2940

* Correction DeleteHelper and string.xml

* minor fix

* fixed problems in DeleteHelper.java and strings.xml

* and another little fix

* Revert "and another little fix"

This reverts commit fe4ea5255f.

* Revert "decision problem with color of info icon #2940"

This reverts commit 5895cc8785.
2019-07-06 23:25:53 +03:00
translatewiki.net
b71dac33ae Localisation updates from https://translatewiki.net. 2019-07-05 07:01:56 +02:00
PavelAplevich
6fb3331178 Removed hardcoded strings in DeleteHelper (#3047)
* Removed hardcoded strings in DeleteHelper

* Revert "Removed hardcoded strings in DeleteHelper"

This reverts commit 4bc55fc3af.
2019-07-02 14:20:34 +03:00
translatewiki.net
cc92773d46 Localisation updates from https://translatewiki.net. 2019-07-01 09:22:23 +02:00
translatewiki.net
0c3b00244f Localisation updates from https://translatewiki.net. 2019-06-27 18:16:27 +02:00
Vivek Maskara
d7628959a7
Fix bugs in peer review flow (#3039) (#3042)
* Fix bugs in peer review flow

* Fix tests

* Bug fixes

* Fix remaining issues with peer review
2019-06-26 21:31:06 +05:30
Vivek Maskara
31b5179371
Merge branch 'master' into 2.11-release 2019-06-26 21:14:21 +05:30
Vivek Maskara
5dc45a53d3 Fix bugs in peer review flow (#3039)
* Fix bugs in peer review flow

* Fix tests

* Bug fixes

* Fix remaining issues with peer review
2019-06-26 17:40:49 +03:00
sherlockbeard
4ec92c2e7b fixes the string issue (#3041)
* fix strings

* Update activity_achievements.xml
2019-06-26 17:06:41 +03:00
translatewiki.net
17eb6f43ed Localisation updates from https://translatewiki.net. 2019-06-24 16:43:08 +02:00
neslihanturan
dd50e83319 Fixes previous PR - FIX #2918 Add option for default language for file descriptions (#3020)
* FIX #2918 Add option for default language for file descriptions

* navigation menu error fixed and improvement of code quality

* error language description default fixed

* adapter language selected fixed

* local language selected per default in description language

* Use a better string and variable name as required in review 1

* Add comments

* Add previously missing setValue methods so that list item will be chosen along with the summary

* Add missing Javadocs

* Fix capitalization

* Lint and formatting issues

* Rename methods so it's clearer they are to do with languages

* Use default kv store instead of shared preferences variable

* Make sure saved language code from settings activity is handled on init
2019-06-24 21:40:12 +10:00
translatewiki.net
2837748540 Localisation updates from https://translatewiki.net. 2019-06-20 21:28:47 +02:00
translatewiki.net
667372512b Localisation updates from https://translatewiki.net. 2019-06-17 19:14:52 +02:00
Ashish Kumar
7a5dc77057 Refactor uploads (#2981)
* Feature/refractor uploads [WIP] (#2887)

* Fix duplicate param information (#2515)

* Bug fix issue #2476 (#2526)

* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery

* Versioning and changelog for v2.10.2 (#2531)

* Update changelog.md

* Versioning for v2.10.2

* Update changelog.md

* Bugfix/issue 2580 (#2584)

* Corrected string placedholders in certain string files

* Corrected string placedholders in certain string files[Bug fix #2580]

* Bug Fix #2585 (#2647)

* Bug Fix #2585
* Added null checks on view in SearchImageFragment when updating views from external sources
* Disposed the disposables in SearchActivity and SearchImageFragment when no longer in active lifecycle

* use FragmentUtils to verify fragment active state

* Bug Fix issue #2648 (#2678)

* Bug Fix issue #2648
* Handled external storage permission before file download

* * Removed redudant check for permission in MediaDetailPagerFragment (Dexter already does that)
* Removed duplicate code in PermissionUtil$checkPermissionsAndPerformAction, used the existing function with conditional extra parameters

* string name typo correction

* BugFix issue #2652 (#2706)

* Addded null check on bookmark before operating on it

* BugFix issue #2711 (#2712)

* Added null checks in OkHttpJsonApiClient$searchImages MwQueryResponse

* BugFix #2718 (#2719)

* Handled null auth cookies

* Fix #2791: NPE when nominating for deletion and leaving screen (#2792)

* Bug Fix issue #2789 (#2790)

* Handled Illegal State Exception for non existent appropriate view parents in ViewUtils$showShortSnackbar

* BugFix #2720 (#2831)

BugFix deprecated licenes #2720

* ui fixes, wip, upload

* *Issue #2886, BugFix #2832[wip]
* updated UploadActivity code
* modified ui
* Updated UploadPresenterTest

* * updated interfaces names to follow names suffixed with Contract
* added test cases

* card view elevation

* view pager disabled swipe

* bug fix, duplicate image

* used existing non-swipable view pager

* Avoid image view resize with keyboard, added adjustPan and stateVisible as softinputMode for UploadActivity

* retain UploadBaseFragment instances on orientation changes

* * Added test cases for UploadMediaPresenter
* Injected io and main thread schedulers

* categories presenter test cased wip

* Added CategoriesPresenter test

* * Added the logic to show open map (with to be uploaded image's coordinates while uploading image)

* codacy suggested changes * added java docs

* Added travis_wait fot android-wait-for-emulator

* ranamed interface onResponseCallback to Callback

* * Added api to delete picture in UploadModel
* cleanUp in UploadModel. once upload has been initiated
* Removed unused methods from UploadModel and the corresponding test class

* * Added tests for UploadPresenter
* Travis suggested changes
* Addded copy previous title and description

* * Made the upload add descriptions visible when keyboard visible
* add description request focus only when user manually requests it

* Added JavaDocs, review suggested changes

* Fix dagger injection

* use DialogUtil to show info in descriptions

* use activity context for DialogUtil

* Minor changes

* Bug fix, reduced the add description edit text clickable bound (#2973)

* Bugfix/uploads (#3000)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Fix memory leak (#3001)

* Bugfix/uploads (#3002)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Bugfix/uploads (#3011)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView

* bugfix/uploads (#3012)

* merged with master

* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active

* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel

* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java

* Added class level JavaDoc UploadRemoteDataSource

* Added class level JavaDoc for UploadRepository

* Added JavaDocs for ThumbnailsAdapter

* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter

* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search

* Attached image scale listener to upload media image

* Bug fix, reduced the add description edit text clickable bound

* Added tooltip in Title in UploadMediaFragment

* BugFix recent categories

* Updated test methods

* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView

* BugFix Illegal State Exception in ViewpPagerAdapter

* Remove irrelevant comment

* merge conflict with strings (#3016)
2019-06-14 01:09:41 +05:30
translatewiki.net
04b051b37a Localisation updates from https://translatewiki.net. 2019-06-13 20:02:26 +02:00
sherlockbeard
6619ccf8d5 removed the hard coded string (#3015)
* removed the hard coded string

* fix
2019-06-12 16:06:25 +03:00
translatewiki.net
69e23b73a8 Localisation updates from https://translatewiki.net. 2019-06-10 20:17:37 +02:00
Vivek Maskara
8971743479 Fixes #2888: Use Dexter for requesting location permissions (#2925)
* Use dexter to ask for location permissions

* Addressed code review comments
2019-06-08 08:45:30 +03:00
translatewiki.net
51e2febc53 Localisation updates from https://translatewiki.net. 2019-06-06 17:52:19 +02:00
Vitaly V. Pinchuk
cc0b059595 Image EXIF/XMP metadata removal routine (#2863)
* [WIP] Added preferences for EXIF tags

* [WIP] Added arrays, keys, strings to support EXIF preferences

* [WIP] Updated SettingsFragment to setup summary of added preferences(locationAccuracy)

* [WIP] Added methods getStringSet()in BasicKvStore, KeyValueStore to support Set<String> data type used in preferences (EXIF tags)

* [WIP] Added methods for removing EXIF tags and anonimyzing location coordinates in FileProcessor, GPSExtractor

* [WIP] Fixed errors in preferences EXIF tags, added XMP removal routine

* [WIP] Removed erroneous location accuracy handling

* [WIP] Fixed mistyped GPS Tags

* Reverted BasicKvStore. Removed Set<String> support in BasicKvStore as JsonKVStore already has it.

* FileProcessor: Replaced throwing runtime exception with warning if EXIF redaction fails.

* FileMetadataUtils: Javadoc added

* [WIP] FileMetadataUtilsTest added

* [WIP] FileMetadataUtilsTest: added javadoc

* [WIP] FileMetadataUtilsTest: added javadoc

* [WIP] FileProcessor: fixed disposing observables

* [WIP] FileMetadataUtils.getTagsFromPref: changed return type from observable to simple array

* [WIP] FileProcessorTest: added test for redactExifTags

* [WIP] FileProcessorTest: redactExifTags() doesn't work properly
2019-06-04 15:38:01 +03:00
translatewiki.net
5690dd9d0b Localisation updates from https://translatewiki.net. 2019-06-03 17:25:14 +02:00
translatewiki.net
12883e3d0b Localisation updates from https://translatewiki.net. 2019-05-27 16:34:33 +02:00
translatewiki.net
ab783a445f Localisation updates from https://translatewiki.net. 2019-05-23 14:10:29 +02:00
translatewiki.net
4896e5992e Localisation updates from https://translatewiki.net. 2019-05-20 13:41:58 +02:00
translatewiki.net
45fd7fe5fa Localisation updates from https://translatewiki.net. 2019-05-17 12:13:00 +02:00
translatewiki.net
54f6dd667f Localisation updates from https://translatewiki.net. 2019-05-13 14:29:38 +02:00
Madhur Gupta
5d827e44ae Moved hardcoded URLs to a constant file Fixed #2850 (#2851)
* Moved hardcoded URLs to build.grade Fixed #2850

* Moved Urls to a constant file

* Fixed Typo
2019-05-10 15:09:32 +03:00
translatewiki.net
a4ac27d5d3 Localisation updates from https://translatewiki.net. 2019-05-09 16:54:18 +02:00
kateOmally
41b53f4560 Replace with enum two strings that were in strings.xml but were used as (#2939)
constants. Remove strings from strings.xml Issue # 2931
2019-05-08 21:37:29 +03:00
translatewiki.net
c4b7164784 Localisation updates from https://translatewiki.net. 2019-05-06 16:37:10 +02:00
translatewiki.net
a4104bc368 Localisation updates from https://translatewiki.net. 2019-05-02 17:57:44 +02:00
Ashish Kumar
c8a58bfc2e
Revert "Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)" (#2934)
This reverts commit 3c9b7ba7a8.
2019-05-01 16:10:43 +05:30
neslihanturan
3c9b7ba7a8 Fixes #2337 - Show captions of image in media details (conflicts fixed) (#2933)
* Api call

* added captions

* final commit

* some minor changes

* sigular

* test for captions

* mock fetchCaptionbyFileName

* corrected method name

* * used ? instead of !! (unsafe call on nullable)
* updated unit test for fetchCaptionByFilename()
2019-05-01 15:08:38 +05:30
translatewiki.net
047059c490 Localisation updates from https://translatewiki.net. 2019-04-29 17:26:12 +02:00
Madhur Gupta
13ea61c7a7 Fixed Navigation UI Problem in Split Screen mode # 2788 (#2807) 2019-04-26 10:53:38 +03:00
translatewiki.net
c127bcfea4 Localisation updates from https://translatewiki.net. 2019-04-25 20:12:55 +02:00
Vivek Maskara
5419733299 Center crop images (#2924) 2019-04-24 22:12:20 +03:00