Commit graph

4195 commits

Author SHA1 Message Date
Josephine Lim
c59efe83d9
Versioning and changelog for v2.8.6 (#1960)
* Versioning for 2.8.6

* Update changelog.md
2018-10-29 21:14:14 +11:00
Vivek Maskara
24b758e9f6 Fix log reporting for release builds (#1916) (#1952)
* Fix log reporting for release builds

* Fix logs for release builds

* wip

* Clean up the branch to exclude unrelated changes

* With java docs

* Uncomment quiz checker

* Check for external storage permissions before sending logs

* With more java docs

* Fix crash while zipping log files

* Do not log token and cookies

* Add instruction to restart app
2018-10-26 18:41:41 +11:00
Josephine Lim
9b708dbc32
Versioning and changelog for v2.8.5 (#1923)
* Versioning for v2.8.5

* Update changelog.md
2018-10-11 20:58:09 +11:00
Ashish Kumar
525d5da3d2 Bugfix/upload via share (#1920)
* Bug Fix #1878
* Added a java library to fetch the MIME type from input stream
* Fetch MIME type using this and use the contribution tag only when this fails:

* formatting changes, removed unused commented out line
2018-10-11 16:54:43 +11:00
Josephine Lim
6a254741ef
Versioning and changelog for v2.8.4 (#1909)
* Versioning for v2.8.4

* Update changelog.md
2018-09-28 19:44:23 +10:00
Josephine Lim
0b0cfd49c6
Revert to using target SDK hotfix for 2.8.4 (#1908)
* Revert "Cherry-pick dbrant's PR from master"

This reverts commit 718c70936d.

* Change target SDK to 26 temporarily

* Should actually target SDK 25

See https://developer.android.com/training/notify-user/channels
2018-09-28 19:37:02 +10:00
Dmitry Brant
718c70936d Cherry-pick dbrant's PR from master
Cherry-pick #1906 onto release branch
2018-09-28 01:52:10 +10:00
misaochan
feb26224b4 Revert merge of master into 2.8-release 2018-09-27 01:59:47 +10:00
Vivek Maskara
15f9895336
Merge branch 'master' into 2.8-release 2018-09-07 05:24:53 +05:30
Mansi Agarwal
13c377aa17 Improve the algorithm for detecting unwanted images. (#1798)
* improve the algorithm for checking if the image is dark.

ImageUtils.java: algorithm used previously gave the 'TOO DARK' message for images that were perfectly valid.
The modified algorithm solves this problem.

* Clean up the code
2018-09-07 05:18:38 +05:30
Ashish Kumar
92a8b5e37c Added views for button skipLogin in layout-land and layout-xLarge, bu… (#1865)
* Added views for button skipLogin in layout-land and layout-xLarge, bug fix issue#1864

* xml improvisations

* Fixed string nominated_see_more [CDATA was used inappropriately]
2018-09-07 05:17:23 +05:30
translatewiki.net
8f45de478c Localisation updates from https://translatewiki.net. 2018-09-06 21:22:19 +02:00
Ashish Kumar
70099a9014 Feature/permissions library (#1855)
* Added permission for Dexter, the runtime permission handling library

* [Preparing fir issue #1773] Added a utility function which would take the user to app settings screen where he could manually give us the required permission

* Added an alert dialog with positive and negative callback [Preparing fir issue #1773]

* Improvements in the way External Storage Permission is handled in MultipleShareActivity[Bug fix #1697]
1. Used dexter to handle the external storage permission
2. Behaviour changes : When user tries to share(uppload) images to commons via MultipleShareActivity, following decision tree is followed
	a. If the app has permission for external storage, normal upload operation is followed
	b. If the app does not has the permission for external storage, dexter is used to ask for the same
	c. If the user gives us the required permission, normal upload flow is proceeded
	d. If the doesnot gives us the required permission a rationale dialog is shown with the appropriate message to let him know why we need the permission
	e. If he presses okay, steps a-c are followed and if he presses cancel, we close the app.
	f. If while asking for permission, the user chooses never ask again, then next time he tries to upload an image via MSA, the rational dialog follows the app setting screen where he could manually give us the required permission and the onActivityResult of same is handled

* Added a Constants class to handle request and result codes from one place and other related constants common to the all app elements

* replaced hardcoded strings ok and cancel in DialogUtil to string resources

* init permission rationale dialog in activities onCreate

* Code formatting, updated access modifiers wherever required, added javadocs for new methods created

* *shifted constants to app class
*Added JavaDocs in PermissionUtils

* removed class REQUEST_CODES from CommonsApplication and instead put the enclosing constants in the App class itself
2018-09-07 02:57:07 +10:00
Josephine Lim
dd6144bbdb
Update credits.md 2018-09-07 02:49:58 +10:00
Josephine Lim
d3dfdc8c9c
Versioning and changelog for v2.8.3 (#1886)
* Update changelog.md

* Versioning for v2.8.3
2018-09-07 02:34:57 +10:00
Vivek Maskara
cc74f3add7 Bug fix for uploaded images count in achievements activity (#1885) 2018-09-07 01:57:40 +10:00
Josephine Lim
325e0168e3
Set Traceur to only work in DEBUG mode (#1884) 2018-09-07 00:37:47 +10:00
Vivek Maskara
6eb01b8076 [WIP] Refactor feedback and quiz to reduce possibility of NPE (#1881)
* Refactor feedback and quiz to reduce possibility of NPE

* Handle throwables in quiz checker

* Minor refactoring
2018-09-07 00:07:51 +10:00
Vivek Maskara
54caad265a Fix logout (#1875) 2018-09-05 18:25:09 +10:00
Josephine Lim
78f83230ee
Update credits.md 2018-09-04 19:37:39 +10:00
Vivek Maskara
b5849420fc Add logs in wiki data edit and session refresh flow (#1874) 2018-09-03 17:01:04 +10:00
translatewiki.net
2efd39bd14 Localisation updates from https://translatewiki.net. 2018-09-03 08:08:46 +02:00
Mansi Agarwal
3f52211b91 Add angle bracket (#1868)
app/src/main/res/values/strings.xml: Add the missing angle bracket.
2018-09-01 17:19:38 +10:00
Mansi Agarwal
430bf90310 Added CDATA tag (#1836)
* Fix issue#1772

Add the CDATA tag to welcome_help_button_text string. Set the text of the corresponding textview using Html.fromHtml() function.

* Fix issue#1772

Add the CDATA tag to nominated_see_more string. Set the text of the corresponding textview using Html.fromHtml() function.
2018-08-31 11:44:36 +03:00
Dmitry Brant
2884bd934a Remove dependency on Glide, Picasso, SVG, and multidex. (#1859)
* Eliminate the use of Picasso.

This gets rid of the single use of the Picasso library (which was causing
the whole library to be imported and shipped) and replaces it with Glide.
TODO: replace this and the other instance(s) of Glide usage with Fresco,
or vice versa.

* Remove dependency on Glide.

This removes the dependency on Glide, as well as the SVG rendering
library, whose only purpose was to display a single SVG image in the
Notification activity. Unfortunately Android doesn't support SVG natively,
but Echo notifications have icons that are SVG formatted. Rather than
import a bunch of heavy libraries to support this single case of SVG
rendering, we can simply create a few local drawables that correspond to
the different types of notifications, and use them instead.

* Remove multidex!

Multidex is a killer of performance and should be avoided at all costs.

* Remove further unused bits.

* Remove final vestige of multidex.
2018-08-30 14:40:17 +03:00
albendz
a059a3c2ef Add button on image details to copy wikicode to clipboard (#1849)
* Add button on image details to copy wikicode to clipboard

* Make copy wikicode button width the same as the nominate deletion button width by filling in background
2018-08-27 19:13:50 +10:00
Dmitry Brant
e945d45558 Work towards eliminating string literals from code. (#1861)
String literals are being used in many places in the code, instead of
proper string resources which are automatically localized. This PR
replaces many of the string literals with pre-packaged resources, or will
add the appropriate string if necessary.
2018-08-27 19:10:50 +10:00
translatewiki.net
b84e22c292 Localisation updates from https://translatewiki.net. 2018-08-27 07:39:43 +02:00
Ashish Kumar
355c4f5b0a Feature/nearby io fix (#1847)
* Bug fix issue #1839, changes
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor
* added null checks for the same varaible [Lets be safe side]
* replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier

* Bug fix issue #1846
1. Added null check in places in loadAttractionsFromLocation() in NearbyController
2. Catched exception in getFromWikidataQuery() which getFromWikidataQuery( )[Could be because of anything, primarily io].

* code formatting, adjusted whitespaces

* return places which is initialised to empty list instead of null for places

* replace catching Exception with the excact exception, ie. InterruptedIOException in NearbyPlaces
2018-08-24 22:36:23 +05:30
translatewiki.net
4baabab960 Localisation updates from https://translatewiki.net. 2018-08-23 08:13:52 +02:00
Ashish Kumar
e4584217d2 Bug fix issue #1839, changes (#1845)
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor
* added null checks for the same varaible [Lets be safe side]
* replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier
2018-08-22 10:13:36 +05:30
Vivek Maskara
4ea7229876 Null checks for activity to prevent unwanted crashes (#1730)
* Null checks for activity to prevent unwanted crashes

* With logs before return statements
2018-08-20 14:56:03 +03:00
Vivek Maskara
e13e2c2f40 Fix issue where beta prod flavour could not be installed at the same time (#1841) 2018-08-20 13:59:14 +03:00
Josephine Lim
b743d021f0
Versioning and changelog for v2.8.2 (#1842)
* Versioning for v2.8.2

* Changelog for v2.8.2
2018-08-20 20:07:29 +10:00
neslihanturan
4c476e7a06 Hotfix for overwrite issue in 2.8.0 (#1838)
* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.

* Check if file title includes an extension already, by checking if is there any dot in it.

* Fix logic error

* Add uncovered tests

* Remove unecessary line breaks

* Make Javadocs more explicit
2018-08-20 18:32:45 +10:00
translatewiki.net
73d5eb54f8 Localisation updates from https://translatewiki.net. 2018-08-20 08:06:30 +02:00
Yusuke Matsubara
6842420aeb Use NotificationChannel and prevent crash in API 26 (#1835) 2018-08-19 13:19:00 +03:00
Vivek Maskara
11c3772dd0 Add Traceur for getting meaningful RxJava stack traces (#1832) 2018-08-18 02:31:10 +10:00
translatewiki.net
7a43c59c80 Localisation updates from https://translatewiki.net. 2018-08-17 14:55:10 +02:00
Ashish Kumar
3cee4bbe3b Feature/bug fix#1793 (#1802)
* bug fix, locales not showing up in the spinner in ShareActivity [issue #1793]

* removed extra padding from the languages edit text in the spinner

* reduced weight percentage of spinner to 30% and increased that of the descriptions in row_item_descriptions to 70%
2018-08-17 03:51:55 +10:00
misaochan
61888f7456 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-14 17:59:48 +10:00
Josephine Lim
b17957dbb1
Versioning and changelog for v2.8.1 (#1827)
* Versioning for v2.8.1

* Update changelog.md

* Fix changelog.md typo
2018-08-14 17:58:32 +10:00
Vivek Maskara
7dee0a45b1 Fix category edits (#1823) 2018-08-14 02:47:23 +10:00
translatewiki.net
2fdcddd977 Localisation updates from https://translatewiki.net. 2018-08-13 08:08:25 +02:00
Amir Aharoni
a694ff1887 Fixes in grammar and punctuation in English translatable messages 2018-08-11 21:13:41 +09:00
Siddharth Vaish
81053a13b5 Username in nav drawer centrally aligned #1806 (#1817) 2018-08-10 00:45:57 +05:30
Siddharth Vaish
654ef80ff7 Renamed Set wallpaper to Set as wallpaper #1813 (#1818) 2018-08-10 00:45:31 +05:30
translatewiki.net
56675c91a4 Localisation updates from https://translatewiki.net. 2018-08-09 09:20:21 +02:00
Nicolas Raoul
78cab49544 Merge branch 'master' of github.com:commons-app/apps-android-commons 2018-08-08 16:48:57 +09:00
misaochan
98ed7beb33 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-08 17:38:01 +10:00