Commit graph

2359 commits

Author SHA1 Message Date
Aditya-Srivastav
f8a8f92070
Fixes #4329 "Back button in edit categories triggers back of media details." (#4346)
* Back button on fragment

* Handled back events

* minor changes

* removed extra lines
2021-04-19 17:19:27 +03:00
Ayan Sarkar
3369d96c49
READ_EXTERNAL_STORAGE permission is not necessary while picking file from gallery (#4356) 2021-04-19 13:31:01 +03:00
Ashish
8c7954a158
Fixes #4360 (#4363)
* Trigger API call to addDepictionsAndCaptions after succesfull upload from stash
2021-04-18 16:19:26 +09:00
Vinayak Aggarwal
bebc4afae2
Changes made (#4354) 2021-04-15 23:45:10 +09:00
Pratham Pahariya
58408cf2b0
Fixes #4297 - UI Issue: After changing the system theme from settings (#4332)
* fix UI issue after theme change

* removed unnecessary changes

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-08 20:51:07 +03:00
Prince kushwaha
153e57264d
fix:In setting Default description language option is needed to get disable when user is not login (#4342) 2021-04-08 19:37:58 +03:00
Ashish
ecbff7e3b8
Fixes #3790- Use WorkManagers to upload contributions (#4298)
* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated gradle

* Revert "Updated gradle"

This reverts commit c8979fe6dc.

* rolledback to compileSDKVersion 28, fixed tests

* Don't call the show notifications on the main thread

* Bug Fix- Duplicate contributions, handle upload stash errors
2021-04-08 15:59:07 +03:00
Ayan Sarkar
fd2a7a9c56
Fix SearchView is not visible properly in lower API devices (#4333) 2021-04-08 15:57:50 +03:00
Prince kushwaha
0d23e65e0f
fix:Setting Language list is not an language list which is supported by Commons for caption and description (#4325) 2021-04-07 23:33:47 +09:00
Prince kushwaha
12547fd34a
fix:App should respect device font-size (#4306)
* * Add adjuctFontScale function  to fix issue
* Add Javadoc

* reformed the codechange

* rearrange the codechange

* make metric and wm variable final
2021-04-06 17:47:38 +09:00
Pratham Pahariya
c269693625
Fixes #4296 - "Is this a picture of ...": Not too clear about which image it is asking me about (#4317)
* fix issue 4296

* minor improvements

* minor improvement

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-05 17:03:11 +09:00
Ayan Sarkar
40b2619ccf
Added Help link in Alert Dialogue (#4315)
* READ MORE button added

* Added link to tips

* Fixed minor issues
2021-04-03 17:55:19 +09:00
Pratham Pahariya
a479dd5bb1
#4048 - "copy to subsequent media" button (#4308)
* added copy to subsequent media button

* minor change

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-02 09:12:11 +03:00
Aditya-Srivastav
ff96f5047e
Fixes #4287 "Tapping multiple items in explore should not be allowed" (#4310)
* only one media detail at a time

* requested changes

* disabled multitap on screen

* requested changes
2021-04-01 23:24:48 +09:00
Gabriel Lee
7a04a2bf9c
Simplify peer review button text (#3376) (#4303)
* Simplify peer review button text (#3376)

The lengthy button text was not showing correctly, discussions concluded
that the button texts could be simplified to just "yes" or "no". To ensure
code read-ability, the buttons were renamed. Also made slight code style
adjustments to ReviewImageFragment.java and fragment_review_image.md.

Bug: #3376

* Remove string translate file changes from patch
2021-03-24 12:38:53 +03:00
Saumia Singhal
0857eae082
set icon frame visibility to View.GONE for all preferences (#3863) 2021-03-24 12:16:08 +03:00
Pratham Pahariya
944225c3a3
Fixes #4260 - Item with P582 (end time) shown as existing (#4292)
* fix issue with item with endtime shown as existing

* Removed destroyed and endtime, Added comments and also fixed the broken tests

* minor fix

* Added comments

* fix no such column location_exists error

* minor improvement

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-18 00:05:08 +09:00
Aditya-Srivastav
5c02b2fc0a
changed column name (#4288) 2021-03-04 16:55:21 +03:00
Aditya-Srivastav
7a5774e479
Fixes #4281 "Wrong language pre-selected in Nearby upload" (#4285)
* location added

* tests

* changes requested

* comments

* Test fixed, minor improvement
2021-03-04 15:51:28 +03:00
Fawziyah Alebiosu
91a5aa1abe
Delete categoryImagesActivity (#3878)
* deleted categoryImagesActivity test & activity

* deleted categoryImagesActivity reference in ActivityBuilderModule

* deleted categoryImages from manifest

* deleted categoryImages import from ActivityBuilderModule

* deleted categoryImagesActivity
2021-03-03 21:17:29 +03:00
Prince kushwaha
a4bdd23718
fix:Explore Search: No title bar for item, non-existent menu for item, wrongly-worded menu for category (#4274) 2021-03-03 15:39:42 +03:00
Aditya-Srivastav
9cf59f7801
fixes #4266 'Image Dimensions should be reduced if too large" (#4279)
* height restriction

* requested changes

* removed landscape drawee view

* javadoc
2021-03-01 23:37:44 +09:00
Pratham Pahariya
93cd89a34b
Fixes #4255 - Media details activity shows depictions in random languages, rather than in the user's locale (#4275)
* fixes issue with depiction names in random languages

* minor change

* using if conditions to check

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-01 20:50:09 +10:00
Aditya-Srivastav
0a857974f0
fixes #3440 "Campaign notification is not removed from Home even when disabling it in the setting" (#4231) 2021-02-27 19:27:06 +03:00
Pratham Pahariya
630c2a5dcd
#3732 - Nearby Tab Accessible Without Location Permission (#4259)
* Added ability to access nearby tab without location permissions

* added ability to remember user choice if the permission is denied.

* fixed the issue with permission dialog box in contribution tab.

* changed name for stored variables

* minor change

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-26 21:49:11 +09:00
Mrudul Tora
ba000eb26e
Fixes #4129 Resolved App crash on logging out from Contributors Tab (#4257)
* Resolved App crash on logging out from Contributors Tab

* Moved if condition in fetchContributions method
2021-02-26 17:21:16 +09:00
Pratham Pahariya
e82fdd0f4f
Fixes #2803 - Cancel nearby upload -> Next upload gets the same title/description 2021-02-23 16:42:41 +03:00
Mrudul Tora
6be9317eac
Hided Peer Review in Limited Connection Mode (#4247) 2021-02-23 16:06:00 +03:00
Mrudul Tora
0ec62170fc
Removed category editing accessibility when user not logged in (#4251) 2021-02-23 18:53:03 +09:00
Mrudul Tora
a83006fc7b
Fixed crashing on setting avatar when not logged in (#4258) 2021-02-23 18:43:32 +09:00
Aditya-Srivastav
f7d1fab566
Fixes #2252 "Tapping on map doesn't close tab in 'nearby'". (#4265)
* closing the list on tap ouside

* minor improvement

* minor changes

* javadoc

* official javadoc

* javadoc error
2021-02-23 17:17:11 +09:00
Pratham Pahariya
d81caf6a42
Fixes #4218 - In-App notifications appear on media detail fragment (#4246)
* Fixed issue with In-App Notification appearing on media detail view.

* Added a comment

* fixed style issues

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-22 19:00:28 +09:00
Aditya-Srivastav
7d8ea51c4f
Added bookmark section in not-logged-in version (#4256)
* added bookmark in not-logged-in version

* javadoc

* javadoc update

* spacing

* added unit test
2021-02-22 00:23:41 +09:00
Prince kushwaha
4f130e4dd0
fix:click on skip button in Peer Review after orientation change then app is crashed (#4176)
* #fixes-4143
In ReviewActivity overrides two function-> onResume() and onPause()

* Fixed the Bug-#4143

* reformed the codechange

* reformed the codechange

* Add javadoc

* Add javadoc
2021-02-21 10:58:07 +09:00
Mrudul Tora
9075b65ddf
Fixes #4244 - App crash in WikidataItemDetailsActivity resolved (#4248) 2021-02-20 21:35:28 +09:00
Aditya-Srivastav
68689980ee
fixed #4230 'Opening notifications in "Read" section still marks them read and removes them from the list'. (#4249)
* notifications fixed

* refractored

* javadoc
2021-02-20 10:00:22 +09:00
Pratham Pahariya
b8cdc5a537
Fixes #4229 - App Crashes while trying to nominate an item for deletion, When User is not logged in (#4237)
* Fixes the crash while nominating an item for deletion.

* removed unnecessary code

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-19 10:48:39 +09:00
Aditya-Srivastav
850d9411a5
Fixes #4211 "Location not available" while fetching location updates 2021-02-17 22:02:14 +10:00
Aditya-Srivastav
7cb5ff9167
Fixed #4232 App crashes on trying to upload a media from gallery. (#4235)
* ExifFixed

* requested changes

* requested changes

* indentation
2021-02-17 18:38:11 +09:00
Prince kushwaha
6293f90950
fix app crash in CategoryDetailsActivity (#4233)
Thanks Prince kushwaha!
2021-02-17 16:37:29 +09:00
Prince kushwaha
2695bbaf4b
fix- #2770 -Incomplete Nearby List shown in Landscape mode (#4188)
* fix-Incomplete Nearby List shown in Landscape mode (#2270)

* fix-Incomplete Nearby List shown in Landscape mode (#2770)

* added the setLayoutParams() method

* reformed the codechange
2021-02-15 21:01:48 +03:00
Pratham Pahariya
37c39ad55f
Fixed the issue with blank screen after changing the theme. (#4220)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-15 23:52:35 +09:00
Taco
38f80687b1
Remove duplicate ViewPagerAdapter (#4222) 2021-02-15 21:50:30 +09:00
Taco
ee50bc8188
Update AndroidX Browser and ExifInterface to latest version (#4223) 2021-02-15 21:35:20 +09:00
Aditya-Srivastav
1a31265770
Fixes #4215 "Swiping on the last item in explore featured tab takes you to uploaded via mobile" (#4227)
* scrolling disabled on media details

* javadoc added

* javadoc modified
2021-02-15 14:41:55 +09:00
Prince kushwaha
944bede42d
fixes - #3559 - Failed to send thanks" notification, but thank actually sent successfully
I create another Model Class->"MwThankPostResponse.java" to store the Result of Post Request POST(MW_API_PREFIX+"action=thank")
2021-02-08 16:50:30 +03:00
Prince kushwaha
8384ad03dc
fixes - #1984 -Upload count does not get updated right away post successful upload
->implements the Callback method to update total number of media uploaded
2021-02-08 15:06:16 +03:00
Adam Jones
89737b2640
#747: Convert action package (ThanksClient and PageEditClient) to Kotlin (#4075) 2021-01-23 14:36:01 +05:30
Pratham Pahariya
36406bad85
Fixed the issue with back button in contribution tab. (#4177)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-01-22 01:30:25 +10:00
Aditya-Srivastav
b58d135b4c
Fixes #4178 Bookmarks not Updated in Picture section after remove 2021-01-20 20:35:33 +03:00