Fixes #4297 - UI Issue: After changing the system theme from settings (#4332)

* fix UI issue after theme change

* removed unnecessary changes

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
This commit is contained in:
Pratham Pahariya 2021-04-08 23:21:07 +05:30 committed by GitHub
parent 153e57264d
commit 58408cf2b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 19 additions and 3 deletions

View file

@ -12,6 +12,7 @@ import androidx.fragment.app.FragmentManager;
import com.google.android.material.tabs.TabLayout;
import fr.free.nrw.commons.contributions.MainActivity;
import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
import fr.free.nrw.commons.explore.ParentViewPager;
import fr.free.nrw.commons.kvstore.JsonKvStore;
@ -78,6 +79,10 @@ public class BookmarkFragment extends CommonsDaggerSupportFragment {
applicationKvStore.getBoolean("login_skipped"));
viewPager.setAdapter(adapter);
tabLayout.setupWithViewPager(viewPager);
((MainActivity)getActivity()).showTabs();
((BaseActivity) getActivity()).getSupportActionBar().setDisplayHomeAsUpEnabled(false);
setupTabLayout();
return view;
}

View file

@ -148,6 +148,9 @@ public class ContributionsFragment
if(shouldShowMediaDetailsFragment){
showMediaDetailPagerFragment();
}else{
if (mediaDetailPagerFragment != null) {
removeFragment(mediaDetailPagerFragment);
}
showContributionsListFragment();
}

View file

@ -15,6 +15,7 @@ import butterknife.ButterKnife;
import com.google.android.material.tabs.TabLayout;
import fr.free.nrw.commons.R;
import fr.free.nrw.commons.ViewPagerAdapter;
import fr.free.nrw.commons.contributions.MainActivity;
import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
import fr.free.nrw.commons.theme.BaseActivity;
import fr.free.nrw.commons.utils.ActivityUtils;
@ -87,6 +88,9 @@ public class ExploreFragment extends CommonsDaggerSupportFragment {
fragmentList.add(mobileRootFragment);
titleList.add(getString(R.string.explore_tab_title_mobile).toUpperCase());
((MainActivity)getActivity()).showTabs();
((BaseActivity) getActivity()).getSupportActionBar().setDisplayHomeAsUpEnabled(false);
viewPagerAdapter.setTabData(fragmentList, titleList);
viewPagerAdapter.notifyDataSetChanged();
}

View file

@ -34,6 +34,7 @@
android:id="@+id/viewPagerBookmarks"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_below="@id/toolbar_layout" />
android:layout_below="@id/toolbar_layout"
android:background="?attr/mainBackground" />
</RelativeLayout>

View file

@ -34,5 +34,6 @@
android:id="@+id/viewPager"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_below="@id/toolbar_layout" />
android:layout_below="@id/toolbar_layout"
android:background="?attr/mainBackground"/>
</RelativeLayout>

View file

@ -3,7 +3,8 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:orientation="vertical"
android:paddingTop="@dimen/tiny_gap">
android:paddingTop="@dimen/tiny_gap"
android:background="?attr/mainBackground">
<TextView
android:id="@+id/contentNotFound"

View file

@ -6,4 +6,5 @@
android:layout_height="?attr/actionBarSize"
android:fitsSystemWindows="true"
app:titleTextColor="?attr/toolbar_text_color"
android:background="?attr/mainBackground"
/>