Commit graph

3794 commits

Author SHA1 Message Date
Kaartic Sivaraam
f814d33de7 Add CONTRIBUTING file (#879)
* docs: add an initial version of commit message/contributors guideline

The project has long evolved without a guideline for commit messages
and a contributors guideline. This has led to a lot mysteries in the
code base.

To avoid such mysteries in the code base in the future, add an intial
version of the commit message guideline in the form of a contributors
guideline.

The name 'CONTRIBUTING' is pretty common and also ensures that GitHub
(the place where this project currnetly evolves) brings the document to
notice to an user trying to create Pull Request. Further, the all caps
ensure it catches the eyes of the gazing user.

This initial version of guideline is based on the git project's guideline
for submitting patches (Documentation/SubmittingPatches).

* contributing: remove internal link

Markdown doesn't seem to be supporting internal links(fragments) to other
parts of the document.

So, replace it with normal text to refer to the section.

* contributing: fix typo and improve sentence

* contributing: add link to related wiki page

* contributing: fix typo

* contributing: quote section name correectly

Only part of the name of a section was quoted thus referring to
an inexistent section and making the sentence meaningless.

So, quote it completely.

* contributing: use plural to refer to wiki pages

A change might obsolete "multiple" Wiki pages, which have
technical documentation about the app.

So, use plural to refer to the wiki pages.

* contributing: move the main contributing file to the wiki

The document was based on Git project's guidelines for submitting
patches (Documentation/SubmittingPatches). As it was licensed under
GPLv2 while this porject is licensed under an Apache license a license
conflict arose.

To solve it move the main document which might be susceptible to
license issues to the wiki while keeping a jist of it in the
document itself.

* contributing: use lenient wording for steps that might be optional

It's not possible to write tests for all changes. For example, UI
changes. Also, it's not the case that the Wiki pages become stale all
the time.

So, use lineant wordings for optional steps

* contributing: correct grammar in a sentence

"documented in" reads better than "documented at" (at least for
me).

If this is wrong then we can revert it.

* contributing: add link to guidelines in the wiki page

* contributing: replace 'jist' with 'gist'

  "Jist is a pronunciation spelling of the word just when spoken
   with an American Southern accent.

   Gist is a noun that means a quick summary or the main point of
   something."

I intended to use the latter. So, ..
2018-04-18 14:42:31 +03:00
brok85
01a11a95ea Fix for issue #1436 list icon allows user only to show the list, but not to make it disappear (#1443)
* Fixed by using a boolean variable "opened" that changes according to the current state of the list. It is false by default when you open the nearby activity.

* Fixed by using bottomSheetBehavior.getState() to decide whether to expand or collapse the bottom list.
2018-04-17 16:12:04 +03:00
Anubhav Gupta
d3071718b4 Changes made (#1447) 2018-04-17 15:52:53 +03:00
misaochan
4285b5e77f Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-17 18:58:35 +10:00
Jatin0312
d5f3fd58ab Fixes Issue #1358 Circle page indicator display improved (#1379)
* Fixes Issue #1358 Circle page indicator

* Build test checking and reformated code
2018-04-16 16:00:38 +03:00
Balakrishnan S
f8fb9f1ce9 fixed typo in nearbyActivity (#1394) 2018-04-16 15:51:59 +03:00
Gabriela Radu
9a3b6fc964 Deletion button being disabled (#1403)
* used CDATA

* Improvements in Notification Activity (#1374)

* Improvements in Notification Activity

* Update NotificationActivity.java

* Share feature (#1338)

* added share app feature in About

* added share app feature in About

* a small fix

* Use custom tabs for nearby web views (#1347)

* Localisation updates from https://translatewiki.net.

* Fix for issue #1380 Improved Notification UI (#1387)

* Links added to TextView about_upload_to in aboutActivity (#1326)

*  Added the link in about_upload_to textfield

*  Merge conflicts resolved

*  Removed the extra textView

* Fix re-enabling delete button if the action is canceled.

* Keep delete button enabled until a reason is given.
2018-04-16 15:03:24 +03:00
kamilya35231
35a7d49590 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-16 14:37:04 +03:00
translatewiki.net
b012ce4142 Localisation updates from https://translatewiki.net. 2018-04-12 15:14:33 +02:00
translatewiki.net
7b150f78a8 Localisation updates from https://translatewiki.net. 2018-04-12 09:10:26 +02:00
neslihanturan
482b06ccf0 Hot fix connectivity leak (#1432)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone

* Fix memory leak causing usage of activity as context
2018-04-11 19:40:13 +10:00
translatewiki.net
2de9a1fe08 Localisation updates from https://translatewiki.net. 2018-04-09 08:15:46 +02:00
neslihanturan
802b2a8df4 Hot fix bundle issue (#1425)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone

* Fix adding bundle to an already created fragment
2018-04-08 19:17:20 +10:00
Paul Hawke
22772c851e Moved tests over to Kotlin. (#1428) 2018-04-08 17:59:20 +10:00
Josephine Lim
6b2dd8c1df
Fixed misspelling in credits.md 2018-04-06 19:26:23 +10:00
Josephine Lim
3b141c1425
Added new contributors to CREDITS.MD in alphabetical order
Please let me know if I missed anyone!
2018-04-06 19:02:50 +10:00
Yiran Cao
3949dbca5c Fixed issue #1395 (#1423)
* fixed issue #1395

* moved the compass icon to bottom-left corner
2018-04-05 20:27:10 +03:00
misaochan
912dfb05ec Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-04-06 00:15:45 +10:00
misaochan
a095a4e25b Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-06 00:15:40 +10:00
Josephine Lim
adff92042e Fix blank categories in direct Nearby uploads (#1426) 2018-04-05 16:53:08 +03:00
Josephine Lim
f4166899ca Fix issue with onRequestPermissionsResult not being called in Nearby map and list (#1424)
* Update changelog.md

* Versioning for v2.7.0

* Call fragment method, not activity's

* Initialize directUpload and controller in onCreate

* Add logs

* Change requestcodes in DirectUpload and NearbyMapFragment

* Chain to super in default case (where request codes don't match activity's)

* Controller must be initialized before directUpload

* Fix whitespace, add comments

* Alter request codes for Nearby List as well

* Make permission rationales more specific

* Add comments
2018-04-05 16:31:18 +03:00
translatewiki.net
74dc2fd0fd Localisation updates from https://translatewiki.net. 2018-04-05 09:15:25 +02:00
misaochan
23b2f3ce1d Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-04-04 22:32:17 +10:00
Jatin0312
2150d7f244 Fixed bug #1399 Overlapping problem (#1405)
* Fixed bug #1399

* Changed visibility from visible to gone

* Changed behaviour according to review

* Changed bottom sheet visibility from visible to gone
2018-04-04 11:36:34 +03:00
Tanvi Dadu
0205274dd5 Fix Acra (#1414)
*  update Acra

*  Update to latest version
2018-04-03 02:15:28 +10:00
Tanvi Dadu
6eebfbb4f6 Links added to TextView about_upload_to in aboutActivity (#1326)
*  Added the link in about_upload_to textfield

*  Merge conflicts resolved

*  Removed the extra textView
2018-04-02 22:42:06 +10:00
Josephine Lim
a5060053fa Change email address for logs to private mailing list (#1404)
* Change email address for logs to private mailing list

* Include version placeholder

* Add comments
2018-04-02 13:17:59 +03:00
Jatin0312
e23f7522f9 Fix for issue #1380 Improved Notification UI (#1387) 2018-03-31 17:11:30 +10:00
misaochan
ba9287fa8b Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-03-31 04:06:10 +10:00
Josephine Lim
c6f728a6ed
Versioning and changelog for v2.7.0 (#1392)
* Update changelog.md

* Versioning for v2.7.0
2018-03-31 03:57:15 +10:00
neslihanturan
09763f942f
Merge pull request #1390 from commons-app/fixNearbyLeaks
Fix nearby leaks, at least some ot them
2018-03-30 12:36:41 +03:00
neslihanturan
9b2f192478
Merge pull request #1391 from commons-app/fixNearbyBugCausedThemeChange
Fix NPE in nearby fragment
2018-03-30 12:35:58 +03:00
neslihanturan
499d64bb26 Fix NPE 2018-03-30 11:55:15 +03:00
neslihanturan
7b5c5ce497 Fix nearby leaks D 2018-03-29 23:15:21 +03:00
neslihanturan
ea57855dcc Fix memory leak C, I hope 2018-03-29 19:48:01 +03:00
neslihanturan
59a7428048 Fix neraby leak B, leak caused map marker's have reference to activity stays remain on destroy fragment 2018-03-29 16:11:30 +03:00
translatewiki.net
165850bf62 Localisation updates from https://translatewiki.net. 2018-03-29 09:04:37 +02:00
Vivek Maskara
e122bf3a54 Use custom tabs for nearby web views (#1347) 2018-03-29 16:56:34 +10:00
Mansi Agarwal
120130bfc7 Share feature (#1338)
* added share app feature in About

* added share app feature in About

* a small fix
2018-03-29 00:52:53 +05:30
Ujjwal Agrawal
c6679edbda Improvements in Notification Activity (#1374)
* Improvements in Notification Activity

* Update NotificationActivity.java
2018-03-29 00:49:35 +05:30
Josephine Lim
6fc294ab3f
Merge pull request #1381 from commons-app/fixNearbyCurLoctionMarker
Fix nearby current location marker
2018-03-29 00:29:31 +10:00
misaochan
a927a80265 Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-03-28 22:25:57 +10:00
misaochan
20b2b4d969 Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-03-28 22:24:23 +10:00
misaochan
b44743b3d2 Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release' 2018-03-28 22:24:18 +10:00
neslihanturan
286581dd8f
Merge pull request #1385 from misaochan/fix-index-error
Fix IndexOutOfBounds exception in Nearby
2018-03-28 14:55:06 +03:00
misaochan
0ec77b31f8 Add check for size of places array 2018-03-28 20:45:08 +10:00
misaochan
bf51c9789f Merge remote-tracking branch 'refs/remotes/commons-app/2.7.x-release' into 2.7.x-release-fork 2018-03-28 20:15:47 +10:00
Josephine Lim
ad0ba3edff
Merge pull request #1377 from Mansi449/UsingHTML
Solved underline issue in About page
2018-03-28 19:58:35 +10:00
misaochan
4c1bf1b3c5 Merge remote-tracking branch 'refs/remotes/origin/master' into 2.7.x-release 2018-03-28 19:48:13 +10:00
neslihanturan
469190cacb
Merge pull request #1383 from ujjwalagrawal17/travis_fix
Removed nearby Test temporarily
2018-03-28 08:54:38 +03:00