Commit graph

4830 commits

Author SHA1 Message Date
Josephine Lim
f7adbf7b4d
Update changelog.md 2020-01-22 22:49:10 +10:00
Josephine Lim
ba8efb5aaa Versioning for v2.12.2 2020-01-22 22:47:51 +10:00
Ashish Kumar
bae3fa8bbf Fixes #3335 (#3337)
Handled sqlitexception for adding existig column in app versions which already have COLUMN location_pic
2020-01-22 03:22:35 +10:00
Josephine Lim
53d3c37180
Update changelog.md 2020-01-20 00:03:05 +10:00
Josephine Lim
9c6e33901f Versioning for v2.12.1 2020-01-20 00:01:07 +10:00
Ashish Kumar
349e51f4a9 Fixes #3307 (#3308)
* Fixed positional argument format for string in "image_uploaded_by"
2019-12-24 18:55:26 +10:00
Ashish Kumar
824d6ac05e Bugfix/null revision in review (#3309)
* Fixes #3305
 * Handle null firstRevision

* initialise explanation
2019-12-24 14:02:56 +05:30
neslihanturan
959b3afd4c Fixes #3231 "Nearby" always first puts me in Punta Arenas (#3271)
* Update tables from 10 to 11

* Remove unneeded changes
2019-12-10 23:47:10 +10:00
Josephine Lim
bf4b73103f Merge branch 'master' into 2.12-release 2019-12-03 17:51:34 +10:00
Ashish Kumar
fa7deb3d34 Closes #3262, npe in touching edit text drawable area while uploading images (#3263) 2019-12-03 17:44:56 +10:00
Ashish Kumar
1359f706d9 Closes #3264, disable options menu for null media from provider (#3265) 2019-12-03 17:44:48 +10:00
Ashish Kumar
452f799cb3 Fixes #3260, handle null latlng when adding current location marker (#3261) 2019-12-03 17:44:31 +10:00
Ashish Kumar
7b9e792efc Unit-Tests for Campaigns (#3258) 2019-12-03 00:41:10 +10:00
translatewiki.net
4150e5fa40 Localisation updates from https://translatewiki.net. 2019-12-02 09:24:05 +01:00
Josephine Lim
551cddc043
Versioning and changelog for v2.12 (#3255)
* Versioning

* Update changelog.md
2019-12-02 02:59:24 +10:00
Josephine Lim
a7402f29fc
Update changelog.md 2019-12-02 02:51:01 +10:00
Josephine Lim
f51957f64c Versioning 2019-12-02 02:46:10 +10:00
Vivek Maskara
9244c0015b Fix write to parcelable for Place object (#3248) 2019-12-01 17:03:08 +10:00
Ashish Kumar
01ed96b957 Added unit-tests to cover all possible tags from preferences (#3253) 2019-11-30 22:11:36 +05:30
Ashish Kumar
dd578f7b4c Added unit test to verify onCategoryItemClicked (#3252) 2019-11-30 22:11:23 +05:30
Ashish Kumar
36e0f766c9 Added more unit tests to UploadMediaPresenterTest (#3251) 2019-11-30 22:11:06 +05:30
Ashish Kumar
88bb1d87ca Added more unit tests to UploadPresenter (#3250)
* Added more unit tests to UploadPresenter

* added method comments
2019-11-30 19:13:07 +05:30
Vivek Maskara
320674762b With proguard config for parcelable class (#3245) 2019-11-30 16:09:17 +10:00
neslihanturan
1c470241e3 Fix multiple current location marker issue (#3243) 2019-11-29 21:45:25 +05:30
neslihanturan
21503fc786 Disable current location button during markers load (#3238) 2019-11-30 00:18:53 +10:00
neslihanturan
3e5360ae4d Prevent NPE (#3241) 2019-11-30 00:18:05 +10:00
Vivek Maskara
cbd5ee1850 With artist information fixed (#3232) 2019-11-30 00:17:33 +10:00
Vivek Maskara
0f5422f19d With wikidata client tests (#3240) 2019-11-29 16:55:36 +05:30
translatewiki.net
8472c630bf Localisation updates from https://translatewiki.net. 2019-11-28 16:33:28 +01:00
neslihanturan
002df43632 Fix destroyed string (#3230) 2019-11-29 00:29:52 +10:00
Ashish Kumar
e828797f03 fixed beta wikidata url (#3229) 2019-11-28 17:13:01 +03:00
neslihanturan
b3c11842f3 Fixes #1450 Add filter to nearby (#3178)
* Add layout items for nearby filter list and filter item

(cherry picked from commit b96f8a68ce)

* Edit nearby query

(cherry picked from commit 1f3c8c8deb)

* Add filter items to nearby parent fragment xml

(cherry picked from commit d0beadd0e0)

* Add icon for green marker

(cherry picked from commit f65ca0387a)

* Add layout util file to organize layout utilities

(cherry picked from commit 5c57939245)

* Add pic parameter to nearby result item

(cherry picked from commit 86007e4bb6)

* Add pic parameter to place type

(cherry picked from commit 25c358b67f)

* Add green marker styling

(cherry picked from commit 929c92d887)

* Inıt search layouts on Nearby parent

(cherry picked from commit 2ac38a1919)

* Style green markers at nearby controller

(cherry picked from commit 3e08f39f8e)

* Edit bookmark daos to include pic to tables

(cherry picked from commit 48d69edf3b)

* TODO foc bookmark dao item but works now

(cherry picked from commit f748399720)

* Style nearby filter area

(cherry picked from commit 6267e488b0)

* fix style of filter tab

(cherry picked from commit 5f843bf366)

* Add nearby list adapter

(cherry picked from commit 56334afe03)

* Current status, list size is working, visibility working, filter mechanism is ready

(cherry picked from commit 7d75c9c589)

* Filtering works

(cherry picked from commit 8a13cf7728)

* Filter function works

(cherry picked from commit 78368a2c0c)

* Fix style issues

(cherry picked from commit 2204f70255)

* Add divider to recyclerview

(cherry picked from commit c8100b55d7)

* Hide bottom sheets accordingly

(cherry picked from commit c5deba8b0b)

* Code cleanup

(cherry picked from commit cf8f64f3cb)

* Add actions to chips

* Fetch destroyed information from servers

* Add destroyed places icon

* Make chip filter functions work

* Revert irrelevant changes

* Revert accidentally replaced strings

* Remove unneeded lines

* Remove only places expalanation from trings

* Do not filter if nearby places are not loaded

* Add triple checkbox for add none and neutral

* Make tri checkbox work

* Fix travis issue

* Add coments

* fix search this area button locaton

* Set initial place type state and recover it between each populate places
2019-11-28 18:22:32 +10:00
Josephine Lim
5c6ab3b253 Fix date template (#3226)
* Add Traceur for getting meaningful RxJava stack traces (#1832)

* Hotfix for overwrite issue in 2.8.0  (#1838)

* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.

* Check if file title includes an extension already, by checking if is there any dot in it.

* Fix logic error

* Add uncovered tests

* Remove unecessary line breaks

* Make Javadocs more explicit

* Versioning and changelog for v2.8.2 (#1842)

* Versioning for v2.8.2

* Changelog for v2.8.2

* Fix data template for other source
2019-11-27 14:30:12 +05:30
Ashish Kumar
dd76110c87 Fixes #3223 (#3224) 2019-11-26 15:14:22 +10:00
translatewiki.net
b27360b72c Localisation updates from https://translatewiki.net. 2019-11-25 15:29:32 +01:00
Ashish Kumar
3f0c3bb92b Closes #3217 (#3220) 2019-11-25 13:09:18 +03:00
Deepa Malani
9b15a327c5 Fix #3203 App Crash when rotating the Peer Review Screen (#3215)
* Fixing 3203 App crash when rotating the screen

* Add java comments for issue #3203

* Add if-else curly braces for issue #3203
2019-11-24 21:05:25 +05:30
Vivek Maskara
891d9ec41c With wikidata changes (#3199) 2019-11-23 15:26:18 +05:30
Dmitry Brant
02f5cdac59 Fix ability to make POST requests to Wikidata. (#3213) 2019-11-22 20:08:25 +10:00
Ignacio Garcia
48d70c704d Fixing#3210 When the place is not null but the descriptions list is empty there was a crash on getting the first element of the Descriptions list. (#3212)
* Deleted values-tt-cryl since it was causing an error and could not build the app.

* Fix for issue #3210: When the place is not null but the descriptions list is empty there was a crash on getting the first element of the Descriptions list. I just check if the list is empty, and in that case I add a new Description to the list.

* Revert "Deleted values-tt-cryl since it was causing an error and could not build the app."

This reverts commit b0f4392a
I reverted deleting the folder.
2019-11-22 00:42:56 +05:30
Vivek Maskara
b7f97aba53
Fix master build (#3216) 2019-11-22 00:31:58 +05:30
Alicia
0c98f5958a Do not create another dialog with the same custom view - reuse the old one (#3097)
* Clear parent from customView if parent is not null

* Do not create a new dialog when a dialog with a custom view already exists on resume

* remove debug code from dialog custom view parent investigation

* Add rest file

* Didn't mean to add that test file
2019-11-21 16:55:21 +03:00
translatewiki.net
d62afa141f Localisation updates from https://translatewiki.net. 2019-11-21 14:54:31 +01:00
Yash Khare
ff1056f662 Added more distance between failed upload buttons and retry and scrollbar (#3193) 2019-11-20 11:37:11 +05:30
translatewiki.net
f786598f36 Localisation updates from https://translatewiki.net. 2019-11-18 18:09:55 +01:00
translatewiki.net
7285cd53a1 Localisation updates from https://translatewiki.net. 2019-11-14 17:10:16 +01:00
translatewiki.net
1d40402d1e Localisation updates from https://translatewiki.net. 2019-11-11 16:50:11 +01:00
translatewiki.net
4fa8ba2f10 Localisation updates from https://translatewiki.net. 2019-11-07 16:06:25 +01:00
Vivek Maskara
8ccad2277d Merge backend-overhaul to master (#3198)
* Migrated logEvents to retrofit (#3087)

* Switched wikimedia-android-data-client for new features

* Added UserCLient and UserInterface

* Migrated ContributionsSyncAdapter to UserClient
Fixed sync related bugs

* Removed unused code

* Removed unused code

* Updated wikimedia-android-data-client to new version

* Update library for data client (#3131)

* Backend overhaul fetch media by filename (#3081)

* Added class MwParseResponse and MwParseResult for receiving parse output

* Migrated fetchMediaByFilename to retrofit

* Removed unused code

* Added tests

* Migrated isUserBlockedFromCommons to retrofit (#3085)

* Switched wikimedia-android-data-client for new features

* Added UserCLient and UserInterface

* Migrated isUserBlockedFromCommons to retrofit

* Added tests and removed dead code

* Implemented ban checking functionality in UploadActivity

* Removed unused class AuthenticatedActivity

* Fixed tests

* Fixed NullPointerException when a user accessed image details without logging in.

* * Login the login token way, handle LoginResult minutely, add account based on LoginResult (#3151)

* Added progress updater in UploadService to show upload progress in no… (#3156)

* added progress updater in UploadService to show upload progress in notification

* formatting changes

* [Dependency: Quadtree] Remove unused code from cache controller (#3163)

* Basic logging with redacted sensitive headers (#3159)

* As per #3026, removed the obsolete classes in package mwapi (#3150)

* fixed compile time error (#3165)

* [Dependency fluent]: Remove unused dependency fluent (#3164)

* Donot init quiz checker in onResume (#3167)

* clear image cache on logout (#3168)

* Fixed default locale and upload locales in descrptions (#3166)

* Fix 2FA login (#3170)

* Fix build (#3172)

* Localisation updates from https://translatewiki.net.

* Closes #3094 (#3095)

* BugFix in SpinnerDescriptionsAdapter and SpinnerLanguagesAdapter (use the langguage code provided by the spinner, donot set the language to the one returned by the locale)

* Update changelog.md

* Versioning for v2.11.0

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Center map on location clicked in nearby list and notification card(#2060) (#2366)

* center map on location clicked in nearby (#2060)

* improved animation

* Center map on location clicked in nearby list

* removed unnecessary methods

* center map on location clicked in nearby notification card

* some minor changes

* travis build error

* resolved errors

* Tidy up PR

* removed swipe to delete (#2589)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* edited CREDITS file (#3145)

* Unused dependencies are removed (#3141)

Part of #3128

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Working with #3129 issue (#3146)

* Replace Hard-Coded strings with those from strings.xml.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* delete res/values-en-gb (#3153)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* First commit (#3093)

Fixes info icon color is Review

* Solution #3126 (#3155)

Fixed wrong upload dates after image upload

* Bugfix/fix upload presenter tests (#3158)

* Revert "Merge branch 'backend-overhaul' into master"

This reverts commit 0090f24257, reversing
changes made to 9bccbfe443.

* * Fixed upload presenter tests
* Deleted app/src/main/res/values-en-gb/error.xml

* Localisation updates from https://translatewiki.net.

* Remove dependency on Exif parsing library. (#2947)

* Remove dependency on Exif parsing library.

* Fix test.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Refactor nearby classes mvp (#2969)

* Create parent contract

* Create map child contract and fill methods

* Add javadocs and specific interfaces for list

* Move general method to parent and add javadocs for parent

* Add explanation for keeping an emty View interface under NearbyListContract

* Move constracts under contract package

* Create presenters for map and list and implement user actions accordingly

* Add javadocs

* Add presenter, contract and fragment for parent Fragment of both NearyListFragment and NearbyMapFragment

* Implement missing methods

* Fix typo

* Add main views on fragment

* İmplement child fragment logic and their retain

* Relate parent presenter with parent fragment

* Add all location permission related methods to view contract and implement in fragment. Call them from presenter by passing locationServiceManager parameter

* Define refreshView method as updateMapAndList which is a better naming. Define it at presenter part.

* Define a presenter variable in fragment and call updateMapAndList method from there, if permissions are okay

* Add lock neabry method to unlisten nearby operations during updates

* Add network connection established check on view side, check it from presenter

* try to simplify previous method during refactor

* Add missing methods for NearbyMap

* Connect child fragment and prent fragment with presenter

* Change nearby design, first create views then register listeners

* AddnetworkBroadcatsReceiver on view side, call it from presenter

* Add comments

* Change the old NearbyFragment by our new NearbyParentFragment for first tests

* Prevent crash caused child fragment is actually null by checking if it is attached or not.

* Makes sure that initialize nearby operations method is called just after all views and fragments are ready and attached

* Make sure updateMAoAndList method is called when everything ready

* Rename a method with prepoer name

* Call update map and add required markers

* Find out zoom level problem

* Implement add nearby markers and add current marker methods

* remove unneeded codes copied from previous implementation

* Revert "remove unneeded codes copied from previous implementation"

This reverts commit 42539651de.

* add some commits and clear code

* Remove location listener implementation from view, handle them in presenter instead. And add timber debug notes and required method calls

* Style ,issues

* Refactor a variable name to camel case and bind search this area view

* Search this area button action is added

* Mostly implement search this area methods, not tested yet even once

* Make sure everything is called in required order and seach this area method basically works

* Rename methods accordingly and add Javadocs

* Add current location marker and remove circle around it

* Remove unused methods

* Add current location marker with object animator and remove previous marker is exists

* include clear map into add markers method and reorder methods

* Make search this area button appear at correct time

* Try to load un search this area is called

* Clear logs

* Add changes for permission made by Vivek to newly added fragments along with our nearby classes

* Add a view to nearby map ragment and insert map view as an item inside it

* Add logs to uınderstand why on meap ready callback is never called

* Add list item clicked and bottom sheet for list of nearby items is expanded

* Make nearby map ready callback came

* Add required methods to be called after map view is ready

* State: Map ready call is not called but permissions and methods are in correct order

* Remove unused logs

* Try to use SupportMapFragment instead, still no success...

* use SupportMapFragment instead

* Remove unused Near

* Upgrade mapbox sdk versions

* Remove Style import from fragment/NearbyMapFragment

* Remove Style import from **fragments/NearbyParentFragment

* Remove nearby/NearbyMapFragment

* Remove unused/old NearbyFragment and NearbyMapFragment

* Remove import of already removed class

* Make sure you removed everything related with mapbox implementation

* Update mapbox map

* Remove unused classes, do not forget centerMapToPlace doesn't work on this branch

* Remove Style class it required updated version of mapbox map

* Add base codes for new activity

* Prove that our mapbox sdk let us implement the map directly inside the activity

* Add base codes for testing mapbox activity in a single fragment inside activity

* Add codes from mapbox demo repository to test support fragment, map works in a single layer fragment

* Add base codes for test layered fragment activity

* Add Support fragment inside a fragment and proves that layered fragmentw with map works

* Test view pager and tab layout with support map fragment to see it works, it works!

* Move Contributions Fragment related codes to test activity

* Move nearby card methods

* Inject location manager and implement NerabyParentFragmentContract.View on test fragment

* Coppy the content of SupportMapFragment from mapbox repository, use this code to modify later. This method war suggested by mapbox team instead of extending the class

* Implement NearbyMapContract.View on our new SupportMapFragment

* Start to mplement logic of checking permissions

* Fix small dagger issue to inject location manager properly

* Request permission for nearby places if fragment is loaded and tab is selected

* Initialize map operations if map ready and tab is selected

* Markers loads at correct time

* Style the map according to new version of mapbox map

* Add some map elements like FABs and give their actions

* Implement map marker click actions

* Implement nearby Fabs logic with a small issue

* fix FABs are not closing problem

* Unkown problem occurs at map load when I try to use MainActivity again.

* Revert "Unkown problem occurs at map load when I try to use MainActivity again."

This reverts commit 3dc084415b.

* Search this area buttons are added but button function does not work and button visibility is problematic

* Fix issue with MainActivity with the help of Ashish

* Fix search this area button visibility issue

* Fix the issues with updating search nearby markers and camera position together

* Fix progress bar visibility issue

* Prevent loding map each time tab selected

* Take toolbar back

* Implement back button with presenter

* Add click actoion to bottom sheet details

* Add nearby list into bottom sheeet

* Make reuse existing fragments if there is any

* Code cleanup

* Cleanup

* Code cleanup

* Add lifecyle codes to prevent leaks

* Cleanup

* Code cleanup

* cleanup

* Make list item clicked and map focus to same place

* Add bookmark from list fragment

* Make nearby card click action work

* Revert "Fix conflicts"

This reverts commit f3451745d3, reversing
changes made to c5d4d5533d.

* Code cleanup

* Cleanup

* Make recenter button work when list sheet is expanded

* Cleanup

* Code cleanups

* NPE issue is not detected for now, can be solved on seperate PR

* Update map after Wikidata edit

* Cherry picked previously reverted merge, hoping this will fix enourmus amounts of diff files

* Previous merge bringed an file which should be deleted. Delete it.

* Revert irrelevant changes on build.gradle

* Revert irrelevant changes

* Jetbrains annotation is not included to build gradle, this issue caused build issues on my branch so I removed it to be able to build

* Rename ListView

* Use a singleton to access the presenter, instead of passing it to a variable inside fragment

* Fix code style issues

* Move hardcoded colors to colors.xml file

* Make larger methods smaller

* Make current location marker follow

* Do not track users position if user is searching around

* Revert irrelevant shanges at build gradle

* Remove unneeded variable

* Remove mvp directory, add sub directories directly under nearby directory instead

* Remove unneeded public definiton

* Remove unneeded namespace

* Add public defiiton, it is needed to reach the constructor.

* On Logout, fetch the CSRF token and then make the post logout call (#3182)

* Api call for logout

* call clear cached onCompleteSessionLogout

* Correction is passed file name to checkPageExistsUsingTitle, function expects file name prefixed with File: (#3194)

* Merge master (#3196)

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Mapped values-en-gb to values-en-rGB (#3161)

Fixes "Error: Invalid resource directory name" bug.

* Localisation updates from https://translatewiki.net.

* Removes the "Other" deletion option mentioned in #3174 (#3183)

* Localisation updates from https://translatewiki.net.

* Renamed resource file to prevent build from failing (#3189)

* Localisation updates from https://translatewiki.net.

* Removed some jargon/slang from strings.xml (#3162)

* Localisation updates from https://translatewiki.net.

* solve issue Avoid 'form movements' in the login screen #1107 (#2936)

* Disabled review buttons while an image is being loaded (#3185)

* Disabled review buttons while an image is being loaded

* Added javadocs for the new methods

* Fix build
2019-11-06 18:05:12 +05:30
Yash Khare
2ed32162b7 Disabled review buttons while an image is being loaded (#3185)
* Disabled review buttons while an image is being loaded

* Added javadocs for the new methods
2019-11-06 14:28:45 +03:00