Commit graph

180 commits

Author SHA1 Message Date
Vishan Seru
4fc3040d52 Synced branch with master 2018-02-18 00:32:25 +05:30
Manuel Lorenzo
304bf51f5f Fixing some lint issues for #171 2018-02-07 11:32:24 +01:00
maskara
7c54e95321 More cleanup based on comments 2018-01-14 02:09:32 +05:30
maskara
eb3e448452 Refactoring based on comments 2018-01-13 23:59:45 +05:30
maskara
e1afa6081e Refactor usage of dagger application with fixed dagger application 2018-01-13 16:16:47 +05:30
neslihanturan
1224302ccb
Merge pull request #1047 from psh/more-database-cleanup
More database related cleanup
2018-01-12 17:41:58 +03:00
Paul Hawke
4bd72462e5 More cleanup now that clean Dao classes are available from Dagger. 2018-01-05 19:53:51 -06:00
maskara
b639b649d7 Avoid crash when service is disconnected 2018-01-06 02:36:51 +05:30
Paul Hawke
9927879680 Injected the ContributionDao where needed. 2018-01-05 08:34:48 -06:00
Paul Hawke
7c80991049 Extracted and tested the database interactions from Contribution. 2017-12-21 13:56:36 -06:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
Vivek Maskara
f0d11a6074
Merge pull request #949 from ramarajesh2112/issue-944
Issue-944: Fix for same activity getting instantiated multiple times
2017-11-23 02:50:04 +05:30
Josephine Lim
591575faaf
Merge pull request #952 from JohnKal/master
Fixed issue #894
2017-11-21 15:45:45 +10:00
Ram Gudivada
3c9b325e58 Changed activity creation logic
- for home activity it will reuse existing activity from back stack and
  also clears all current activities
- for nearby, about and settings, it will use the existing activity from
  back stack
2017-11-20 21:37:10 -08:00
maskara
8dd8e09f2a Fixes NPE in Util function 2017-11-16 17:32:45 +05:30
maskara
d4bafd94e0 Fixes leaks in contribution and nearby activity 2017-11-13 23:15:53 +05:30
JohnKal
8dc9103ec0 Fixed issue #894 2017-11-12 13:02:16 +02:00
maskara
6a7b7cbbe8 Introduce dagger 2017-11-12 01:04:10 +05:30
Yusuke Matsubara
b0e8175003 Merge pull request #917 from RSBat/master
Fix Codacy issues
2017-10-27 22:26:44 +09:00
Paul Hawke
f134d23ecb Merge branch 'master' into dependency-injection 2017-10-21 17:20:56 -05:00
Sergey Kozelko
43af519a16 Fix Codacy issues 2017-10-18 21:57:57 +03:00
Vishan Seru
b9b54fdff6 Made changes to ensure that when attempting to upload multiple images, the GPS data is extracted and attached correctly. 2017-10-15 10:22:01 +05:30
Vishan Seru
d98a0263fd Added progressbar in ContributionsListFragment to be shown while its loading contributions 2017-10-11 22:16:39 +05:30
poojithakr
fc9cd0a3b7 Fixing codacy issues. Reduced reported count from 550 to 518. 2017-10-04 00:28:11 -07:00
Paul Hawke
c2b21eb575 Merge branch 'master' into dependency-injection 2017-09-29 22:39:25 -05:00
Paul Hawke
9aa021695b @Injected shared preferences where needed 2017-09-27 21:30:41 -05:00
Paul Hawke
7dd3dced35 Fixed merge conflicts 2017-09-26 22:33:59 -05:00
Paul Hawke
e33febf506 Merge branch 'master' into dependency-injection 2017-09-23 14:24:34 -05:00
Paul Hawke
c3d6d0eb44 Merge branch 'master' into lint-cleanup 2017-09-23 13:27:07 -05:00
Neslihan
4d9e63227c Fix codacy issue 2017-09-12 23:14:58 +03:00
Neslihan
c52c0b4a7f Fix coding style 2017-09-12 22:47:57 +03:00
Neslihan
1c50e8539b Request write permission for older android versions, too. 2017-09-12 22:47:31 +03:00
Paul Hawke
9c0cbe7ad5 Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account. 2017-09-09 14:08:40 -05:00
Paul Hawke
15107e622b Codacy suggestions for improvement. 2017-09-03 22:20:52 -05:00
Paul Hawke
8cbf56fa7b Java 5 / Java 8 language suggestions plus general cleanup. 2017-09-03 17:27:20 -05:00
Paul Hawke
13e84a82b8 Removed unused imports. 2017-09-03 17:05:37 -05:00
Paul Hawke
d0a85dbd82 Moved single-use code out of Utils over to where it's actually used. 2017-08-26 08:57:16 -05:00
Paul Hawke
cfe17cafa6 Moved other singletons over to being managed by Dagger 2017-08-26 08:57:15 -05:00
Paul Hawke
647cc166ef @Inject the MediaWikiApi where needed to reduce coupling between classes. 2017-08-26 08:56:15 -05:00
Paul Hawke
ed1ae98d8e Finished removing coupling between classes around the getInstance() method. 2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9 First baby steps into the world of dependency injection using Dagger. 2017-08-26 08:56:14 -05:00
Paul Hawke
97bbd51e13 Removed the popup and nav-drawer item relating to developer plans. 2017-08-24 22:19:43 -05:00
Mikel
2b30924242 Merge branch 'master' into rx_upload_count
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/concurrency/ThreadPoolExecutorService.java
#	app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
2017-07-28 14:47:37 +01:00
Mikel
6412e15f20 Move new Http query together with other ApacheHttpRequests 2017-07-28 14:38:54 +01:00
Josephine Lim
71a7742a83 Merge pull request #817 from akaita/overriden_annotations
Add missing annotations
2017-07-28 19:54:46 +10:00
Josephine Lim
a5a624f939 Merge pull request #808 from neslihanturan/oneTimePopUp
One time pop up
2017-07-27 16:49:22 +10:00
Neslihan
8b460b6f3a Fix ugly codes 2017-07-26 22:20:46 +03:00
Mikel
3b17d96bae Fix indentation 2017-07-26 17:36:05 +01:00
Mikel
09d94f3e06 Replace Guava-implemented getUploadCount with RxJava2 version 2017-07-26 16:56:44 +01:00
Mikel
79a22c1aca Add missing annotations 2017-07-26 16:24:24 +01:00