mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

More cleanup based on comments

Browse source
This commit is contained in:
maskara 2018-01-14 02:09:32 +05:30
parent eb3e448452
commit 7c54e95321
7 changed files with 4 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

5
app/src/main/java/fr/free/nrw/commons/auth/WikiAccountAuthenticatorService.java
View file

@ -15,11 +15,6 @@ public class WikiAccountAuthenticatorService extends CommonsDaggerService {
@Inject MediaWikiApi mwApi;
private WikiAccountAuthenticator wikiAccountAuthenticator = null;
@Override
public void onCreate() {
super.onCreate();
}
@Override
public IBinder onBind(Intent intent) {
if (!intent.getAction().equals(ACTION_AUTHENTICATOR_INTENT)) {

10
app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
View file

@ -83,11 +83,6 @@ public class CategorizationFragment extends CommonsDaggerSupportFragment {
}
});
@Override
public void onAttach(Context context) {
super.onAttach(context);
}
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
Bundle savedInstanceState) {
@ -140,11 +135,6 @@ public class CategorizationFragment extends CommonsDaggerSupportFragment {
}
}
@Override
public void onDestroy() {
super.onDestroy();
}
@Override
public void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);

6
app/src/main/java/fr/free/nrw/commons/category/CategoryContentProvider.java
View file

@ -43,12 +43,6 @@ public class CategoryContentProvider extends CommonsDaggerContentProvider {
@Inject DBOpenHelper dbOpenHelper;
@Override
public boolean onCreate() {
super.onCreate();
return true;
}
@SuppressWarnings("ConstantConditions")
@Override
public Cursor query(@NonNull Uri uri, String[] projection, String selection,

6
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsContentProvider.java
View file

@ -40,12 +40,6 @@ public class ContributionsContentProvider extends CommonsDaggerContentProvider {
@Inject DBOpenHelper dbOpenHelper;
@Override
public boolean onCreate() {
super.onCreate();
return true;
}
@SuppressWarnings("ConstantConditions")
@Override
public Cursor query(@NonNull Uri uri, String[] projection, String selection,

9
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
View file

@ -35,12 +35,13 @@ import fr.free.nrw.commons.MediaDataExtractor;
import fr.free.nrw.commons.MediaWikiImageView;
import fr.free.nrw.commons.PageTitle;
import fr.free.nrw.commons.R;
import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
import fr.free.nrw.commons.location.LatLng;
import fr.free.nrw.commons.mwapi.MediaWikiApi;
import fr.free.nrw.commons.ui.widget.CompatTextView;
import timber.log.Timber;
public class MediaDetailFragment extends Fragment {
public class MediaDetailFragment extends CommonsDaggerSupportFragment {
private boolean editable;
private MediaDetailPagerFragment.MediaDetailProvider detailProvider;
@ -60,12 +61,6 @@ public class MediaDetailFragment extends Fragment {
return mf;
}
@Override
public void onAttach(Context context) {
AndroidSupportInjection.inject(this);
super.onAttach(context);
}
@Inject
Provider<MediaDataExtractor> mediaDataExtractorProvider;

9
app/src/main/java/fr/free/nrw/commons/media/MediaDetailPagerFragment.java
View file

@ -36,6 +36,7 @@ import fr.free.nrw.commons.R;
import fr.free.nrw.commons.auth.SessionManager;
import fr.free.nrw.commons.contributions.Contribution;
import fr.free.nrw.commons.contributions.ContributionsActivity;
import fr.free.nrw.commons.di.CommonsDaggerSupportFragment;
import fr.free.nrw.commons.mwapi.MediaWikiApi;
import static android.Manifest.permission.READ_EXTERNAL_STORAGE;
@ -43,7 +44,7 @@ import static android.content.Context.DOWNLOAD_SERVICE;
import static android.content.Intent.ACTION_VIEW;
import static android.content.pm.PackageManager.PERMISSION_GRANTED;
public class MediaDetailPagerFragment extends Fragment implements ViewPager.OnPageChangeListener {
public class MediaDetailPagerFragment extends CommonsDaggerSupportFragment implements ViewPager.OnPageChangeListener {
@Inject MediaWikiApi mwApi;
@Inject SessionManager sessionManager;
@ -87,12 +88,6 @@ public class MediaDetailPagerFragment extends Fragment implements ViewPager.OnPa
return view;
}
@Override
public void onAttach(Context context) {
AndroidSupportInjection.inject(this);
super.onAttach(context);
}
@Override
public void onSaveInstanceState(Bundle outState) {
super.onSaveInstanceState(outState);

6
app/src/main/java/fr/free/nrw/commons/modifications/ModificationsContentProvider.java
View file

@ -39,12 +39,6 @@ public class ModificationsContentProvider extends CommonsDaggerContentProvider {
@Inject DBOpenHelper dbOpenHelper;
@Override
public boolean onCreate() {
super.onCreate();
return true;
}
@Override
public Cursor query(@NonNull Uri uri, String[] projection, String selection, String[] selectionArgs, String sortOrder) {
SQLiteQueryBuilder queryBuilder = new SQLiteQueryBuilder();