Commit graph

2795 commits

Author SHA1 Message Date
Ayan Sarkar
a16dca9f56
[Fixes Bug]: After moving between tabs on Bookmark fragment, Bookmarks never loads (#4951)
* Fixed the issue added tests

* Added requested changes
2022-05-05 10:08:56 +03:00
Benard Mathu
6ad70932c5
Refactor: notification models (#4866)
* Refactor: move notification modesl to data.models.notification

* Refactor: move notification models to notifications/models
2022-04-28 18:23:44 +03:00
Benard Mathu
8cdcd0f7c2
Refactor: RecentSearch model (#4857)
* Refactor: move recent search to data.models

* Refactor: move search models to explore/models
2022-04-28 17:57:17 +03:00
Benard Mathu
d37cdef3c4
Refactor: Campaign model (#4852)
* Refactor: move Campaign.kt to data.models

* Refactor: move campaign models to campaign/models
2022-04-28 17:35:07 +03:00
HCH
b2a901b9b3
Fixes #4942 Change category extraction algorithm (#4943)
* updated addCategory()method

* update addCategory()method

* add unit test for none category

* add comments to addCategory()method

* update comments

* update comments for addCategory()method
2022-04-28 23:21:45 +09:00
bf82fcc8d3
change description extraction algorithm (#4938)
The original algorithm uses comma to separate descriptions which causes bugs when there are comma inside description.
The algorithm is changed to repeatedly matching string patterns of `{{languageCode|desciption}}`
2022-04-28 17:34:02 +10:00
Benard Mathu
7fa3ff0eee
Refactor: Bookmark model (#4851)
* Bookmark: moved model to data.models package

* Refactor: move bookmark models to bookmark/models
2022-04-26 12:34:14 +03:00
Arin Modi
1ae013d2b3
Fixed #4906 : Peer review: "thank the contributor" should show snackb… (#4914)
* Fixed #4906 : Peer review: "thank the contributor" should show snackbar instead of notification

* changes the snackbar to toast

* added the tests

* minor changes

* minor changes - 2
2022-04-25 22:48:43 +03:00
Pratham Pahariya
d7ad3b934d
#4730 - Nothing happens on clicking media in the Contribution tab of User's Profile (#4736)
* enable clicking on contributions in user's profile

* Added null condition

* Added Comments

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2022-04-18 16:17:40 +03:00
Ayan Sarkar
17ac591233
Fixed the issue added tests (#4933) 2022-04-14 21:29:14 +09:00
neslihanturan
ee1bf4b5b6
Explore nearby pictures (#4910)
* Add map fragment for explore and search

* Create structure of explore map by defining view and user action interfaces to presenter

* Add methods to map start, bottom sheet and permission

* Make the simple map visible

* Imitate methods from nearby map for permission needed and non needed map initialisation operations, however, needs to be tested and reactor

* a level of abstraction

* update media params to include coordinates

* Implement pageable presenter to explore

* Create Root fragment for map and media

* Iplement two presenter one for map operations, the other for pageable operations

* Construct general structure for both explore with search query and just by location

* fix injection issue

* Make default explore work with zoom level

* increase offscreen page limit with newly added fragment

* Make two distinct api calls for search with and without query

* Before trying to use same presenter for both search with and without query

* Add notes for Madhur

* Add Madhur's fixes for binding

* Call serch with and without query from the same spot

* partially solve zoom issue

* Make tab view unswipble while map is being used on search activity

* make viewpager unswipable while map is being used

* Code cleanup and reverting unnecessry edits

* Add search this area methods

* Implement search this area button functionality

* Fix search this area button, current location FAB and bottom attribution UI elements

* Add marker click action

* Solve bookmarkdao injection issue

* Make display bottom sheet details on marker click

* remove label and set bottom sheet behavior

* Remove irrelevan buttons like wikidata and article buttons

* Cancel bookmark feature for commons images for know, needs to be thought

* Add search this area button

* Add location off dialog

* Implement back button for explore map fragment while not on search activity

* Make thumbnails visible, they need some styling though

* Make gridle views even more beautiful

* Remove classes added to support query

* Remove query related code from Reach Activity

* Solve two progressbar issue

* Remove query related ekstra codes

* Remove not needed anymore callback

* Make medai details work

* Remove all old removed code dependencies

* Solve initial load takes too long issue

* Solve current position track

* Add placeholder for possible load issues

* Add red stroke to bitmap

* Add borders to rectangles

* Change media details text to details

* Fix file name extension anf File: prefix

* Fix some code style issues

* Fix some style issues

* Fix style issues

* Fix build issue

* Fix test about etMediaListFromSearch

* Fix test issue with Seacrh Activity

* Fix conflict mark
2022-04-14 18:28:17 +10:00
Ayan Sarkar
7655562272
Fixes 4922 : Crash when trying to edit description (in Media details) (#4929)
* DescriptionEditActivity handled

* Minor change

* Minor changes
2022-04-11 21:14:26 +09:00
Ayan Sarkar
11292ab514
Fixes 4620 : Editing categories of an existing picture: Reuse categories selection UI from the Upload Wizard (#4928)
* Entry to new UI

* Getting existing categories

* Hidden categories managed

* Category edit updated

* Category Edition implemented

* Java docs added

* Java docs added

* Java docs added

* Previous UI discarded

* Test added

* More test added

* More test added

* More test added

* More test added

* More java docs added

* Minor changes
2022-04-11 19:30:21 +09:00
Ayan Sarkar
4194409cd2
Fixes 4544 : Language selection: history (#4880)
* Xml changes

* Content provider created

* Database setup done

* Database setup revised

* Database setup revised

* SettingsFragment finished

* SettingsFragment finished

* UploadMediaDetailFragment updated

* UploadMediaDetailFragment updated

* Java docs

* Test fixed

* Test added

* Test added

* Test updated

* More tests added
2022-03-23 16:33:54 +09:00
Devarsh Mavani
85bdcd5a7a
App downloads too many of my contributions, without reason (#4916)
* Init commit

* Fixed tests
2022-03-23 11:15:48 +09:00
Ayan Sarkar
bd9531b969
Fixed 4616 : Option for editing depictions (#4725)
* Dialog can't be dismissed

* Dialog can't be dismissed

* Option for editing depiction

* Java docs added

* Minor issues fixed

* Lining done

* "Depictions not updating instantly" issue resolved

* Existing Depicts on the top

* Existing Depicts on the top

* Back press handled

* Previous depictions unchecked

* Whole Screen issue fixed

* Nearby banner removed

* Test fixed

* Upload Wizard issue fixed

* Upload Wizard issue fixed

* Previous depicts issue fixed

* Previous depicts issue fixed

* All issues fixed

* Fixed late loading of updated depicts

* Depiction is removable

* Test fixed

* Back button press handled after losing focus for edittext

* RequiresApi removed

* RequiresApi removed

* Test fixed

* Requested changes

* Test added

* Test added

* UploadModelUnitTest added

* DepictEditHelperUnitTest added

* DepictEditHelperUnitTest added

* Test added

* More test added

* Indentation Reversed

* Indentation reversed

* Update MediaDetailFragment.java

* Indentation reversed

* Update MediaDetailFragment.java

* Indentation reversed

* Indentation reversed

* Indentation reversed

* Indentation reversed

* More test added

* More test added

* Minor fixes

* Minor fixes

* Minor fixes
2022-03-22 14:33:43 +09:00
Arin Modi
e58322ed63
Fixed #4908 : Thumbnail image is grey during upload (#4909)
* Fixed #4908 : Thumbnail image is grey during upload

* Test Added and minor changes
2022-03-21 22:25:20 +09:00
Devarsh Mavani
37070321d8
Init Commit (#4907) 2022-03-20 18:43:33 +09:00
Devarsh Mavani
fa0370438b
In app feedback (#4845)
* rebase

* Progress

* Completed UI and POST Request

* removed invalid string resource

* Removed unused code & Added string resources

* Resolved Code style issues

* Javadoc for getters & setters

* Codestyle fixes

* Minor Fixes

* wip

* Tests

* Comments

* Fixed Tests

* Minor changes

* minor change

* Comments

* Minor Fixes

* fixed tests

* Removed Butterknife

* Fixed tests

* Removed Unecessary strings

* Minor chnages

* Minor fix

* Minor changes

* Minor changes

* Implemented Suggestions

* Removed Redundant Toast
2022-03-20 12:10:25 +09:00
RISHAV GUPTA
6ea3198d65
Fixes : #4273 Add link to user guide in About (#4882)
* user guide added in about

* test added

* unit test added
2022-03-20 07:50:25 +05:30
Devarsh Mavani
103e2d546e
Review category issues (#4897)
* Ask for category only if exists in Peer Review

* Minor Fixes

* Fixed wrong categories issue

* Added comments

* Added comments

* Minor Changes

* Added test

* Tests

* Tests

* Tests
2022-03-17 19:12:30 +09:00
Arin Modi
7bc78f67ff
Remember last opened screen on app startup (Nearby or Contributions) (#4881)
* added required changes

* Fixed #4808 : Added the feature of opening last opened screen between Contribution & NearBy

* removed the unnecessary commits

* removed the unnecessary commits

* removed the unnecessary commits

* removed the unnecessary commits

* added test

* comments added
2022-03-16 18:09:54 +05:30
RISHAV GUPTA
ed572aab6f
Fixes #4589 :- The empty screen while no images found in custom picture selector [bug] (#4884)
* bug fix

* bug fix 2
2022-03-11 23:12:39 +09:00
RISHAV GUPTA
c02d569468
Fixes #4589 :- The empty screen while no images found in custom picture selector (#4863)
* no image found

* old removed

* new way

* minor changes

* reqeusted changes done
2022-03-07 18:34:03 +09:00
RISHAV GUPTA
824a82ad2a
Fixes : #4855 Copyright warning for beta flavor (#4873)
* xml work done

* testing

* copyright popup added local

* minor changes

* minor changes 2

* picture removed
2022-03-07 18:16:14 +09:00
Arin Modi
c626f97fb9
Fixed - #4844 : In peer review, deletion proposal is sent even if no reason is chosen (#4862)
* Fixed - #4844 : [Bug]: In peer review, deletion proposal is sent even if no reason is chosen

* Minor Changes

* Minor Fixes

* added required changes

* added required changes - 1

* Added Test For OK Button

* Minor Fixes
2022-03-07 17:52:04 +09:00
Arin Modi
9431e3770c
Fixed #4836 & #4840 Added the functionality of cancel upload and also solved the small bug of pausing upload (#4843)
* Fixed #4836 & #4840

* Added Pausing PopUp

* Closing Pausing PopUp exactly when pause button disappears

* Managed to display the Pausing Upload

* Added the Pausing Dialog Using Progress Bar

* Added the Pausing Dialog Using Progress Bar

* Added Required Changes

* Added Required Changes-wording change

* Added Required Changes-wording change
2022-02-26 08:41:14 +09:00
Jacob Fano
1405300fd5
Fixed #4784 : Inform users about unsupported features in beta flavor (#4834)
* Display toast and disable API in LeaderboardFragment beta flavor

* Display toast and disable API in AchievementsFragment beta flavor

* Removed unused Gravity import

* Added Toast appearance tests for AchievementsFragment

* Added Toast appearance tests for LeaderboardFragment

* Improve Context detection in Achievements+Leaderboard fragments to ensure Context found for Toast

* Add testOnCreateView for AchievementsFragment
2022-02-24 14:40:51 +09:00
Devarsh Mavani
d81587b85a
Deletion Language is in english (#4841)
* Deletion Language is in english

* Added Tests

* Added Tests

* Added Tests
2022-02-22 11:45:35 +09:00
Ayan Sarkar
4a69bc55cd
Unit Tests for LocationPickerActivity (#4830)
* LocationPickerActivityUnitTests.kt class created

* Unit tests for LocationPickerActivity

* Unit tests for LocationPickerActivity

* Added verify

* verify added

* Minor changes

* Covered more lines

* Covered more lines

* addCredits test added
2022-02-20 11:37:32 +05:30
Arin Modi
ea6258ccf5
Fixed #4750 : "Exists" is enabled by default for map view (#4838) 2022-02-19 18:02:50 +09:00
Arin Modi
68a0400b9f
Fixed #4793 : Remove the need to tap "Next" again (#4833)
* Fixed #4793 : Remove the need to tap "Next" again

* Fixed #4793 : Remove the need to tap "Next" again

* Fixed #4793 : Remove the need to tap "Next" again, Added Changes
2022-02-19 16:44:44 +09:00
Devarsh Mavani
c6fda6dadb
Show progress when uploading image (#4831) 2022-02-18 12:44:16 +09:00
Madhur Gupta
01904bccdf
Add CustomOkHttpNetworkFetcher Unit Tests (#4826) 2022-02-17 17:06:36 +10:00
Arin Modi
863477aa02
Fixed 4794 : Added a functionality of remembering zoom level on map (#4817)
* Fixed 4794 : Added a functionality of remembering zoom level on map

* Added Required Changes

* Added Required Changes

* Added Required Changes

* Added Required Changes

* Added Required Tests for the RememberZoomLevel
2022-02-17 15:52:48 +09:00
Devarsh Mavani
755b216507
Show user current location (#4825) 2022-02-16 23:13:23 +09:00
Ayan Sarkar
27e3f20ba2
Fixes 4539 : When Wikidata has no description showing instance_of's label as a description (#4799)
* Showing instance_of's name as a description

* Indentation fixed

* DepictsClient Test added
2022-02-16 14:19:27 +09:00
Devarsh Mavani
c2bc5b4f23
Show Last Known Location in LocationPickerActivity (#4816)
* Show Last Known Location in LocationPickerActivity

* Removed extra empty line

* Added tests

* Added tests

* Added tests

* Added tests

* Added tests

* Added tests

* Added tests
2022-02-16 00:44:46 +05:30
Ayan Sarkar
15fa93e8d0
Description and thumbnail is showing for the categories that are associated with Wikidata (#4803)
* Depiction.commons categories showing with description and thumbnail

* Test added

* Test added
2022-02-14 19:45:59 +09:00
Arin Modi
ecc6b1bf28
Fixed the issue #4806: Now, "Location Not Found" pop appears only one… (#4807)
* Fixed the issue #4806: Now, "Location Not Found" pop appears only one time

* Fixed the issue #4806: solved the small bug related to popups warning

* Fixed the issue #4806: solved the small bug of : Location Not Found Pop Up

* Fixed the issue #4806: solved the small bug of : Location Not Found Pop Up

* Fixed the issue #4806: solved the small bug of : Location Not Found Pop Up
2022-02-13 22:49:49 +09:00
Madhur Gupta
90b8d8c62e
Add CoordinateEditHelper Unit Tests (#4796) 2022-02-09 01:31:01 +10:00
RISHAV GUPTA
9c27f8510d
small changes (#4789) 2022-02-07 23:03:26 +09:00
Ayan Sarkar
0e4755301e
Nearby tab accessible without GPS (#4771)
* Nearby accessible without GPS

* Java doc added

* Added NearbyParentFragment test

* Test added

* merged two method and tests updates
2022-02-05 21:16:08 +05:30
Ayan Sarkar
e135fea20d
Fixes 1848 : Option for adding location for those pictures which have no location (#4755)
* Location wizard

* Location wizard

* Minor fix

* message changed

* Test fail fixed

* Test fail fixed

* Test fail fixed

* last location triggered

* last location added

* Some test added

* Java docs added

* More java docs added
2022-02-05 09:56:59 +09:00
Madhur Gupta
ff8f067841
Add Unit Tests for CategoryEditSearchRecyclerViewAdapter (#4775)
* Add Unit Tests for CategoryEditSearchRecyclerViewAdapter

* Use mock context instead of robolectric context
2022-02-02 16:24:32 +10:00
Madhur Gupta
9e38c33650
Add some more tests for SearchActivity (#4780) 2022-02-01 19:26:13 +10:00
Madhur Gupta
d77ae8e582
Add some more tests for NearbyController (#4778) 2022-02-01 19:25:49 +10:00
Ratnesh
873b4c500b
Show alert dialog card for sharing personal detail submission via email when clicking on the feedback menu. (#4772)
* Fixes #4732 Show alert dialog card for sharing personal detail submission via email when clicking on feedback menu.

* Show alert dialog card for sharing personal detail submission via email when clicking on feedback menu when user is logged in.

Add javadoc for the new methods
Update alert dialog message.
2022-01-31 23:16:02 +09:00
Ayan Sarkar
f162326e53
Fixed bug (#4763) 2022-01-25 21:38:37 +09:00
Ayan Sarkar
7e12d28557
Fixes 4497 : this a photo of place X: Do not ask if the item (depiction) is already selected for addition and the photo already has a caption (#4754)
* Dialog can't be dismissed

* Dialog can't be dismissed

* Nearby Place dialog can remember user preference

* Minor change

* Minor change

* Renamed the map
2022-01-20 23:34:44 +09:00