Commit graph

2795 commits

Author SHA1 Message Date
José Arias Canto
013809f46a
Fixes #5187: Fix App crashes when you click on Author Name (#5199)
* Add conditional on function onAuthorViewClicked for when there's not logged-in user

* Change media.getAuthor() for media.getUser()

* Change hardcoded URL for one given by the BuildConfig object
2023-04-13 19:59:50 +09:00
Ritika Pahwa
cf35307d9a
add constants file for map styles used across various fragments (#5200) 2023-04-05 16:05:05 +09:00
Priyank Shankar
07616485ae
Enable support toolbar for ProfileActivity and added a couple of unit… (#5188)
* Enable support toolbar for ProfileActivity and added a couple of unit tests

* Nit fixes

* Nit Fixes

* Minor styling changes in ContributionsFragment
2023-04-03 16:02:16 +09:00
Priyank Shankar
fc672dbd9b
Fixed #5181 Misleading warning title for duplicate file name (#5185)
* Added a string resource and changed the title of alertbox showDuplicatePicturePopup

* Removed duplicate_image_found from strings.xml as it is unused
2023-04-03 15:27:29 +09:00
Arman Navodia
92ecd61b6f
fixing: Duplicate filename notification completely replaces image-found-on-internet warning #5180 (#5192) 2023-04-03 15:08:24 +09:00
Ritika Pahwa
a5a65fc1ee
5191: Fix UI elements not conforming to dark mode (#5193)
* feedback dialog: fix black font in dark mode

* LocationPickerActivity: fix light map in dark mode

* Fix #5182 Switch From Mapbox to MapLibre (#5184)

* Fix #5182 Switch From Mapbox to MapLibre

* Fix #5182 Switch From Mapbox to MapLibre - Resolved requestFeature() issue

* Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on two screens

* Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on additional screens

* Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on notification screen

* Fix #5182 Switch From Mapbox to MapLibre - Test errors

* fix issue #5015 - custom image selector not identifying photo location (#5190)

Co-authored-by: Siva <doodsiva@gmail.com>

* feedback dialog: fix black font in dark mode

* LocationPickerActivity: fix light map in dark mode

* LocationPicker: use predefined style based on device theme

* LocationPickerActivityTest: add additional target exception in catch block

* LocationPickerConstants: remove extra newline introduced

---------

Co-authored-by: Kartikay Kaushik <93285364+kartikaykaushik14@users.noreply.github.com>
Co-authored-by: Siva Subramaniam <112970189+siva-subramaniam-v@users.noreply.github.com>
Co-authored-by: Siva <doodsiva@gmail.com>
2023-04-03 14:27:52 +09:00
Siva Subramaniam
0f1e526326
fix issue #5015 - custom image selector not identifying photo location (#5190)
Co-authored-by: Siva <doodsiva@gmail.com>
2023-03-31 12:21:07 +09:00
Kartikay Kaushik
8f8dcc0d52
Fix #5182 Switch From Mapbox to MapLibre (#5184)
* Fix #5182 Switch From Mapbox to MapLibre

* Fix #5182 Switch From Mapbox to MapLibre - Resolved requestFeature() issue

* Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on two screens

* Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on additional screens

* Fix #5182 Switch From Mapbox to MapLibre - Resolved dark mode issue on notification screen

* Fix #5182 Switch From Mapbox to MapLibre - Test errors
2023-03-31 09:31:58 +09:00
Manuel Cota
d1af26c8a8
Fix: user reset for Thanks screen (#5183)
Removed previous if statement. If the app is rotated, the Thanks message will disappear, but the username gets a reset for each new image reviewed.
2023-03-24 15:58:59 +09:00
Kartikay Kaushik
9b0b936c62
Fix:5175 Upgraded Minimum SDK Version, Compile and Target SDK Version (#5177)
* Kotlin Version Upgraded to 1.6.10

* Kotlin Version Upgraded to 1.6.20

* Kotlin Version Upgraded to 1.7.20

* Fix:5175 Upgraded Minimum SDK Version, Compile and Target SDK Version
2023-03-16 18:02:35 +09:00
Chan Jun Da
66e15a17ef
Change UploadModel::createAndAddUploadItem to not duplicate new uploadItems of same UploadableFile (#5179) 2023-03-16 10:19:24 +09:00
Ritika Pahwa
be1946cd7b
5161: Fix repeating images in peer review (#5170)
* fix API call to fetch the latest changes

* add database table to keep a track of reviewed and skipped images

* fix repeating reviewed or skipped images

* add removed newline again

* add necessary comments

* change from timber.e to timber.i in case there is no exception

* reintroduce the parameter rctag in the API URL

* modify API URL to retrieve latest uploads

* remove unused imports and code

* modify ReviewHelperTest and add new unit tests

* modify tests in ReviewHelperTest.kt

* add comments about the value of gcmlimit
2023-03-15 07:15:24 +09:00
Avanish Yadav
3f5b7f4c58
Fix:4797:Add one more choice to the list (#5173) 2023-03-10 14:21:17 +09:00
Eduardo Isai Martínez Méndez
ce1a0b88c3
Fix#5084: Tapping on GitHub icon opens app when installed (#5171) 2023-03-10 11:45:32 +09:00
Arman Navodia
b048e099c0
fixed: When the coordinates have been copied from another picture, explain it in description #4700 (#5166)
Very useful contribution, thanks Arman!
2023-03-10 11:37:18 +09:00
Arin Modi
496933654b
Skip used images (#5160)
* Only Review Images That Has No Usage

* Coding Standard Related Changes

* Coding Standard Changes - 1

* small change
2023-03-07 14:46:36 +09:00
Arman Navodia
b917fe3229
Leaderboard: Taping on my avatar should open tip popup explaining how to change it #4774 (#5159)
* fixed Leaderboard: Taping on my avatar should open tip popup explaining how to change it #4774

* fixed Leaderboard: Taping on my avatar should open tip popup explaining how to change it #4774

* Leaderboard: Taping on my avatar should open tip popup explaining how to change it #4774

* fixed Leaderboard: Taping on my avatar should open tip popup explaining how to change it #4775
2023-03-07 14:30:11 +09:00
Kartikay Kaushik
e1c04f2013
Disabled telemetry - Bug #5154 (#5155) 2023-02-28 22:17:14 +09:00
Arman Navodia
94d462cafb
Fixed: After canceling a sharing, application goes back to the search menu #2296 (#5156)
* fixed:After canceling a sharing, application goes back to the search menu #2296

* fixed:After canceling a sharing, application goes back to the search menu #2296

* fixed:After canceling a sharing, application goes back to the search menu #2296

* fixed SeachActivityUnityTest failure when calling testOnBackPressed and cleaned up unnecessary code
2023-02-27 15:42:20 +09:00
Ritika Pahwa
7d895c4379
5074: Fix cropped numbers in Leaderboard (#5143)
* fix cropped numbers in the Achievements fragment

* add null check in inflateAchievements method to fix NullPointerException in AchievementsFragmentUnitTests
2023-02-26 14:24:55 +09:00
Chan Jun Da
23ee2b60d8
Fix #5151: Use DialogUtil for MediaDetailFragment (#5153)
* Update DialogUtil to return the dialog object

* Update first instance of Builder to DialogAlert

* Update DialogUtil to allow null instead of empty string

* Update MediaDetailFragment to use DialogUtil

* Remove unnecessary semicolons
2023-02-25 15:34:57 +09:00
Chan Jun Da
20100c4960
Fix #5151: Use DialogUtil methods instead of AlertDialog.Builder (#5152)
* Update AboutActivity to use DialogUtil

* Update ProfileActivity to use DialogUtil

* Update AchievementsFragment to use DialogUtil

* Remove wrong message set in ProfileActivity

* Update DialogUtil to accept null instead of empty string
2023-02-24 18:00:58 +09:00
Arman Navodia
7da7062e3a
fixed 4731: Nearby banner appearing in Media Details (#5150)
* fixed 4731: Nearby banner appearing in Media Details

* fixed 4731: Nearby banner appearing in Media Details
2023-02-21 15:33:59 +09:00
Chan Jun Da
f56ee50c60
Fix #5148: Use DialogUtil method in Uploadactivity (#5149)
* Replace showInfoAlert with available DialogUtil method

* Remove test case that is no longer relevant
2023-02-20 15:27:57 +09:00
Chan Jun Da
1a8a068552
Fix #493: Fix erroneous no location reminder (#5145)
* Add showAlertDialog option for UploadPresenter to use

* Move location reminder logic from UploadActivity to UploadPresenter

* Add test cases for dialog alert with handleSubmit

* Change threshold variable name to be more descriptive

* Fix broken reference to renamed constant in tests
2023-02-18 23:18:52 +09:00
Chan Jun Da
f85efeba97
Fix #4347: Remove leading and trailing spaces in title (#5141)
* Update method to remove leading whitespace

* Update test cases testing remove whitespace method

* Remove unused whitespace check method

* Add comment about use of strip and trim in dealing with whitespace
2023-02-10 16:31:45 +09:00
Arin Modi
191186a474
Fix #5104: popup shown when tapping an already uploaded image in Medi… (#5127)
* Fix #5104: popup shown when tapping an already uploaded image in Media Details

* Small Changes

* JavaDoc Changes

* Javadoc Changes

* Coding Standards Changes
2023-01-30 22:41:41 +09:00
russianbear222
6dec69147f
[Enhancement] Add option to centre on GPS location for issue #5008 (#5098)
* Add option to centre on GPS location for issue #5008

* Rename and add new comments for issue #5008

* Add new comments for issue #5008

* Update comments for issue #5008
2022-12-17 23:05:45 +09:00
Ankush Bose
7b18c3eeb7
5115: Fix AdvanceQueryFragmentUnitTests (#5119)
* 5115: Fix AdvanceQueryFragmentUnitTests

* 5115: Adding further coverage
- removed redundant button.post() methods.
- increased code coverage
2022-12-17 22:43:34 +09:00
Jeremy Kenny
3dbc744075
review: exclude images not uploaded from the app (#5118)
* the Review feature (in the app's menu) was originally thought as a way to improve our app's overall upload quality, it is not really adapted to the wide variety of pictures uploaded via other upload tools.

* update the Review API call to request only images with the `android app edit` tag.
2022-12-14 19:29:29 +09:00
Ankush Bose
f7d3414cc3
4664: Moved RecentLanguagesAdapter to ViewBinding (#5112) 2022-11-21 23:00:40 +09:00
Ankush Bose
b90c123333
4664: Moved LanguagesAdapter to ViewBinding (#5111) 2022-11-21 23:00:29 +09:00
Jiaweeeeeen
3488644938
Fix issue #4962, remove trailing whitespace in caption field when set to uploadMediaDetails (#5085)
* add methods to check and remove trailing whitespace

* fix filter to check and remove trailing whitespace

* fix filter to check and remove trailing space first

* add test and fix filter() and removeTrailingWhitespace()

* caption trailing whitespace: change solution to remove trailing whitespaces when set to uploadMediaDetails

* update code documentation

* add more tests include instance tab, carriage return and Japanese whitespace

* Caption field: Stop blocking Japanese Space, convert to English Space when set to uploadMediaDetails

* Change method name from convertJapSpaceToEngSpace to convertIdeographicSpaceToLatinSpace

* Change pattern name from JapSpacePattern to ideographicSpacePattern
2022-10-30 18:58:15 +09:00
Daniel Kolibár
aa97629cbf
Rewrote reverseGeoCode() method to use Coordinates2Country library (#5093)
* rewrote reverseGeoCode() method to use Coordinates2Country library; wrote simple TC for receiveImage() method to check if country coordinates are set

* removed unused slf4j import in UploadMediaPresenter class

* updated mock in for setCorrectCountryCodeForReceivedImage() TC to match against exact location arguments

* added javadoc for getCountryNamesAndCodes() method in UploadMediaPresenter; implemented "lazy loading" for countryNamesAndCodes field

* removed unused field added by me from UploadMediaPresenterTest
2022-10-29 19:37:11 +09:00
Ankush Bose
cc24caa83c
4664: Moved AdvanceQueryFragment to ViewBinding (#5091) 2022-10-29 18:33:50 +09:00
Ankush Bose
3fd63b009a
4664: Moved PageableMediaFragment to ViewBinding (#5090) 2022-10-29 18:33:43 +09:00
Ankush Bose
4c24b65d2d
4664: Moved FolderFragment to ViewBinding (#5089) 2022-10-29 18:33:33 +09:00
Ankush Bose
26d2669a74
4664: Moved ImageFragment to ViewBinding (#5067) 2022-10-29 17:50:25 +09:00
Ankush Bose
64d4ffc5f1
4664: Moved CustomSelectorActivity to ViewBinding (#5065) 2022-10-29 17:50:19 +09:00
Ankush Bose
10b025c237
4664: Moved WelcomeActivity to ViewBinding (#5063)
* 4664: Moved WelcomeActivity to ViewBinding

* 4664: Removed non-null test on member variables
2022-10-29 17:50:10 +09:00
Andrii Nyvchyk
5949ffd1e8
Fix #5058 (#5059) 2022-09-25 10:35:14 +09:00
TurquoiseHexagonSun
eade6ca3a9
Merged the two conditions into a single condition. (#5055) 2022-09-21 14:43:12 +09:00
Yusuke Matsubara
789960a966
Fix Wiki Love Monuments year (#5049)
* Remove year from messages containing "Wiki Loves Monuments 2021"

* Retrieve Wiki Love Monuments year dynamically

* Add test and doc
2022-09-18 15:50:44 +09:00
Ayan Sarkar
33679eb6b4
[GSoC 2022] Improve custom picker (all features) (#5035)
* Project Initiated by creating helper classes for database operations

* Database created

* Rest of the work and documentation

* Requested changes done

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* [GSoC] Insert and Remove Images from not for upload (#4999)

* Inserted and marked images as not for upload

* Documentation added

* Test delete

* Implemented remove from not for upload

* Test fixed

* Requested changes done

* Added tests for new lines in existing classes

* [GSoC] Added Bubble Scroll (#5023)

* Library added

* Bubble scroll implemented

* Left and right swipe

* Requested changes

* [GSoC] Hide/Unhide actioned pictures and change numbering (#5012)

* Changed numbering of marked images

* Hide Unhide implemented

* Test fixed

* Improved speed for database operation

* Improved speed for database operation

* Changed progress dialog

* Improved hiding speed

* Test fixed

* Fixed bug

* Fixed bug and improved performance

* Fixed bug and improved performance

* Test fixed

* Bug fixed

* Bug fixed

* Bug fixed

* Bug fixed

* Bug fixed

* Code clean up

* Test hiding images

* Test hiding images

* Test hiding images

* Code clean up and test fixed

* Fixed layout

* Fixed bug

* Bug fixed

* Renamed method

* Documentation added explaining logic

* Documentation added explaining logic

* [GSoC] Full Screen Mode (#5032)

* Gesture detection implemented

* Left and right swipe

* Selection implemented

* onDown implemented

* onDown implemented

* FS mode implemented

* OnSwipe doc

* Scope cancel

* Added label in Manifest

* Merged two features

* Requested changes

* Image uploaded bug fixed

* Increased DB version

* Made requested changes

* Made requested changes

* Made requested changes

* Made requested changes

* Solved image flashing bug

* Solved image flashing bug

* Requested changes

* Requested changes

* Changed name of a function

* Fixed transaction failure on large number of images

* Tested with isIdentity

* Tested with isIdentity

* Increased the threshold

* Added info dialog

* Minor changes

* ImageAdapter Test

* CustomSelectorActivity Test

* Requested changes

* Test for ZoomableActivity

* Test for ZoomableActivity

* Test for ImageLoader

* Test for OnSwipeTouchListener

* Test for rest

* Reverted some test changes

* Added more tests for ImageAdapter

* Added more tests for ImageAdapter and swipe gesture

Co-authored-by: translatewiki.net <l10n-bot@translatewiki.net>
2022-09-16 18:14:16 +09:00
Madhur Gupta
3cdfdcffe1
Merge 4.0-release into master (#5028)
* Fix string for custom selector

* Fix bug #4950 back arrow still present on top-level activity (#4952)

* Fix bug #4949 by correctly setting previous db version number (#4956)

* Fix bug #4949 by correctly setting previous db version number

* Fix failing tests

* Fix bug #4959 by correctly setting previous db version number and updating the current db version (#4960)

* Fix bug #4957 (#4961)

* Update library to new version that handles older Java VMs

Fixes #4972 I believe.

* Versioning for v4.0.0

* Changelog for v4.0.0

* Fix bug #4984 Added queries for package name for Android API 30+ (#4987)

* Update mapbox sdk version (#4989)

* Versioning for v4.0.1

* Changelog for v4.0.1

* Remove network type information from NetworkUtils (#4996)

* Remove network type information from NetworkUtils

* Ignore dependent tests

* Fix #4992 invert the equals condition to be null safe (#4995)

* Fix java.lang.NullPointerException for username in ContributionBoundaryCallback (#5003)

* Fix failing tests for PR #5003 (#5004)

* Fix java.lang.NullPointerException for username in ContributionBoundaryCallback

* Fix failing tests

* Update Room DB Version (#5011)

* Fix #5001 (#5010)

* Fix DB update issue (#5016)

* [WIP] Fix both timezone problem and saved date problem (#5019)

* Fix both timezone problem and saved date problem

* Fixaccidental test code and add comments

* Add issue link to the comments

* Fix format issue and null checks

* Versioning for v4.0.2

* Changelog for v4.0.2

* Add "Report Violation" menu option (#5025)

* Add "Report Violation" menu option

* Update email template

* Update email address

* Fixed typo

Co-authored-by: Josephine Lim <josephinelim86@gmail.com>

* Versioning for v4.0.3

* Changelog for v4.0.3

Co-authored-by: Josephine Lim <josephinelim86@gmail.com>
Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>
Co-authored-by: neslihanturan <tur.neslihan@gmail.com>
2022-08-08 15:51:07 +10:00
96fbcb92e5
fix #4940 (#4986) 2022-05-30 16:14:40 +09:00
c5b527f450
fix #4971 (#4974) 2022-05-29 12:01:03 +09:00
HCH
ffbfdabb3a
fix commons-app#4978 (#4979) 2022-05-29 11:51:13 +09:00
AlexMahlon
d8724f4541
Fixes #4934. Enforces Wikimedia character blocklisting on media titles. (#4955) 2022-05-15 19:33:08 +09:00
d647c0674e
disable dialog display (#4954) 2022-05-13 17:50:35 +09:00