Commit graph

80 commits

Author SHA1 Message Date
maskara
cb77cb8323 Remove unused imports 2018-01-14 02:14:36 +05:30
maskara
7c54e95321 More cleanup based on comments 2018-01-14 02:09:32 +05:30
maskara
e1afa6081e Refactor usage of dagger application with fixed dagger application 2018-01-13 16:16:47 +05:30
maskara
3036a3372b Fix issue where map opens with incorrect coordinates 2017-12-20 02:02:10 +05:30
Dmitry Brant
da82466a17 Take out legacy event logging from app.
These are especially old bits of code, where it seems like WMF folks had set up Eventlogging schemas for some rudimentary analytics of the Commons app. These schemas are no longer queried or monitored, and can be safely removed. When the Commons app has a stronger need for more meaningful analytics, we can revisit reintroducing new and better schemas.
2017-12-05 23:01:55 -05:00
Paul Hawke
07577d73a1 Refactoring based on code review feedback. 2017-11-25 14:23:50 -06:00
Paul Hawke
02b5b9b680 Merge branch 'master' into dependency-injection 2017-11-24 22:30:08 -06:00
maskara
8dd8e09f2a Fixes NPE in Util function 2017-11-16 17:32:45 +05:30
Paul Hawke
c2b21eb575 Merge branch 'master' into dependency-injection 2017-09-29 22:39:25 -05:00
Paul Hawke
9aa021695b @Injected shared preferences where needed 2017-09-27 21:30:41 -05:00
Paul Hawke
7dd3dced35 Fixed merge conflicts 2017-09-26 22:33:59 -05:00
Paul Hawke
e33febf506 Merge branch 'master' into dependency-injection 2017-09-23 14:24:34 -05:00
Paul Hawke
a208c9f273 Further reduced coupling between classes and the need to @Inject the account utils class, fixed imports. 2017-09-10 10:37:58 -05:00
Paul Hawke
9c0cbe7ad5 Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account. 2017-09-09 14:08:40 -05:00
Paul Hawke
15107e622b Codacy suggestions for improvement. 2017-09-03 22:20:52 -05:00
Paul Hawke
d59a526f7f Lint error: use of restricted API 2017-09-03 17:00:16 -05:00
Paul Hawke
647cc166ef @Inject the MediaWikiApi where needed to reduce coupling between classes. 2017-08-26 08:56:15 -05:00
Paul Hawke
ed1ae98d8e Finished removing coupling between classes around the getInstance() method. 2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9 First baby steps into the world of dependency injection using Dagger. 2017-08-26 08:56:14 -05:00
Mikel
bef42de613 Remove unused imports 2017-08-08 13:08:56 +01:00
Mikel
7754c7c7c4 Fix vectors for drawableStart in API 17 2017-08-07 20:44:35 +01:00
Mikel
04ff70fa5b Codacy :) 2017-08-02 22:06:37 +01:00
Mikel
d314964018 Merge from master and add icons to clickable fields 2017-08-02 21:57:13 +01:00
Paul Hawke
4796557fb7 Made a pass through the code to introduce lambdas / method references in the places the Android Studio suggested. 2017-07-22 18:04:40 -05:00
Josephine Lim
19a3fa3adc Merge pull request #777 from akaita/media_detail
Fix issues in Media Detail screen
2017-07-20 01:20:10 +10:00
Mikel
2ce7a464ca Remove Clickable behaviour of License and Coordinates 2017-07-18 20:20:44 +01:00
Yusuke Matsubara
3b728ca568 Coding style fixes 2017-07-16 15:13:40 +09:00
Mikel
7edfe34a3e Merge branch 'master' into media_detail 2017-07-15 18:59:36 +02:00
Mikel
9d23907728 Fix Issue with repeating categories in MediaDetail 2017-07-15 18:16:45 +02:00
Mikel
7667180bc5 Make uploaded image's coordinates clickable 2017-07-15 17:53:37 +02:00
Paul Hawke
8e47f82de6 Merge remote-tracking branch 'upstream/master' 2017-07-15 06:16:31 -05:00
Mikel
1044fe13ae Make license in MediaDetail clickable 2017-07-15 09:21:35 +02:00
Yusuke Matsubara
d241d36d66 Add PageTitle class to canonicalize page names 2017-07-13 18:29:30 +09:00
Paul Hawke
5396fc6ed0 Optimized imports before starting 2017-07-04 14:23:13 -05:00
Yusuke Matsubara
9c69539276 Share file with camera using cache and FileProvider
* Use cache instead of external storage to share file with camera
* Execute ExistingFileAsync after permission is granted
2017-06-10 16:47:37 +09:00
Dmitry Brant
96f9526244 Fix display of media detail after screen rotation. 2017-05-20 11:49:15 +02:00
Dmitry Brant
38e7cad345 Final touch-ups to improved image loading. 2017-05-19 17:19:10 +02:00
Dmitry Brant
9469bf29e4 Remove dependency on old image-loading library, and remote a lot of code. 2017-05-19 16:24:04 +02:00
Dmitry Brant
a3f3ee7fdb Merge remote-tracking branch 'upstream/master' 2017-05-19 15:14:29 +02:00
Dmitry Brant
bb49fb9801 Clean up image loading code, and switch to using Fresco. 2017-05-19 15:08:29 +02:00
Yusuke Matsubara
19eddb7d26 Merge pull request #619 from f4ww4z/replace-clear
Replace 'removeAll(c)' with 'clear()'
2017-05-17 20:28:37 +09:00
Yusuke Matsubara
f039ec37bc Merge pull request #596 from domdomegg/codestyle
Lint issues
2017-05-17 20:15:10 +09:00
Fawwaz Yusran
547f2a062c Replace 'removeAll()' with 'clear()' 2017-05-17 13:49:04 +07:00
addshore
bdfbdc7579 Cleanup CommonsApplication Singelton 2017-05-16 15:19:15 +02:00
Adam Jones
876b299ecc Remove redudant local variables 2017-05-15 16:45:46 +01:00
Dinu Kumarasiri
a2a2589df3 Fix codecy failures 2017-05-15 11:32:48 +02:00
Dinu Kumarasiri
83727e43e6 Add upload date to the image description 2017-05-15 11:27:21 +02:00
Tobias Schönberg
c6a2f2c7ea Get coordinate template when parsing image page
Currently the image detail view does not display the
coordinates.
This commit adds the coordinate template to the
parser and displays the results rounded to 4 digits.
2017-05-13 16:09:01 +02:00
addshore
85182e3fb7 Stop unnecesary unboxing of values 2017-05-13 12:53:00 +02:00
veyndan
d33935c70f Use Timber for logging 2017-04-17 16:41:56 +01:00