Commit graph

4113 commits

Author SHA1 Message Date
misaochan
f4cef8da1b Add TODOs 2018-05-09 02:29:52 +10:00
misaochan
cf583c5a77 Add TODOs and Javadocs 2018-05-08 20:21:10 +10:00
misaochan
b1f777c674 Add TODOs 2018-05-08 19:54:13 +10:00
misaochan
7f58b21fa0 Add Javadocs to ShareActivity.java 2018-05-08 19:52:49 +10:00
misaochan
f8cb469b48 Create new UploadUtils class 2018-05-08 19:33:21 +10:00
misaochan
49a808fbf3 Merge remote-tracking branch 'refs/remotes/commons-app/master' 2018-05-08 17:38:14 +10:00
Ashish Kumar
d960029775 Feature/switch to butterknife (#1494)
* Implemented butterknife in MediaDetailFragment [issue #1491]

* Implemented butterknife in MediaDetailPagerFragment [[issue #1491]]

* post merge upstream master wip [[issue #1491]]
2018-05-08 09:51:13 +03:00
Kaartic Sivaraam
cbca264dbc CONTRIBUTING: fix formatting of the gist of the guidelines (#1453)
* CONTRIBUTING: fix formatting of the gist of the guidelines

First level headings for a gist seems to be overkill.

So, replace first level headings with an ordered-list which
sounds more meaningful.

* CONTRIBUTING: specify clearly that 'blame' is a feature of "Git"

The contributing file specifies about the ability to know who wrote
something without the need of @author javadoc tags but incorrectly
attributes the feature to GitHub.

Correctly attribute the feature to where it belongs, Git, and specify
the name of the feature to help users easily take advantage of it.
2018-05-08 09:34:09 +03:00
neslihanturan
2a98bd21ce Add nearby tutorial (#1467)
* Add dependency for MaterialShowcase

* Add actionview class to get a reference to material showcase

* Create a NearbyMaterialShowcaseSequence class

* Apply sequence steps

* Add first three steps of nearby showcase

* Add sequence id constants to make sure they will be displayed only once

* Add last step of sequence to explain plus fab

* Create an object to prevent customize all sequences every time

* Fix typo

* Code cleanup

* Add strings to strings.xml

* Code cleanup

* Revert irrelevant change

* Revert irrelevant change

* Remove showcaseview for recenter button

* Use single showcaseView instead of sequence

* Add single showcase view insted of sequence to be able to edit text style

* Make sure it will be displayed only once

* Cleanup

* Update strings

* Change dismiss text style
2018-05-07 22:05:20 +10:00
Tanvi Dadu
4f6b791c93 Open map of place where picture was taken (#1360)
* Intent to map added

*  Merge conflicts resolved

*  Added the functionality to hide FAB incase of null coordinate

*  Merge Conflict resolved

*  Improve pr quality

* Improve Quality

*  Added nested FAB animations

* Nested FAB implemented

*  Improve Quality

*  Added up arrow

*  Javadocs Added
2018-05-07 12:57:59 +03:00
Ashish
285961ec16 Resolved merge conflicts [#1494] 2018-05-07 15:12:53 +05:30
Man Parvesh Singh Randhawa
bd86dde444 resolves #1464 : MediaDataExtractor is making inefficient (redundant) server calls (#1496) 2018-05-07 12:32:11 +03:00
Josephine Lim
e36ebfeffe Update pull_request_template.md (#1476)
* Update pull_request_template.md

* Remove Javadocs mention

* Added required/optional notes
2018-05-07 12:27:14 +03:00
Vivek Maskara
9845a6265d Integrate API for displaying featured images (#1456)
* Integrate API for displaying featured images

* Add pagination and refactor code so that it can be reused for category images

* Add license info to the images

* Fix author view

* Remove unused values

* Fix minor issues with featured images

* Fix null license url issue

* Remove some log lines

* Fix back navigation issue

* fix tests

* fix test inits

* Gracefully handling various error situations

* Added java docs
2018-05-07 11:09:23 +03:00
translatewiki.net
96eae8c0a6 Localisation updates from https://translatewiki.net. 2018-05-07 07:54:16 +02:00
Josephine Lim
228aa21290 Update contributing.md (#1477) 2018-05-06 23:35:55 +05:30
Ashish
3fcbc378c9 Merge branch 'feature/switch_to_butterknife' of https://github.com/ashishkumar468/apps-android-commons into feature/switch_to_butterknife 2018-05-05 15:49:26 +05:30
Ashish
f9989ba1a3 post merge upstream master wip [[issue #1491]] 2018-05-05 14:03:59 +05:30
Ashish
f7ad2cbf8f Implemented butterknife in MediaDetailPagerFragment [[issue #1491]] 2018-05-04 19:05:35 +05:30
Ashish
d3057979d1 Implemented butterknife in MediaDetailFragment [issue #1491] 2018-05-04 16:04:14 +05:30
Ujjwal Agrawal
693c37f2ec Updated share feature (#1474) 2018-05-04 12:56:13 +03:00
translatewiki.net
bcb90db16c Localisation updates from https://translatewiki.net. 2018-05-03 09:21:58 +02:00
Ujjwal Agrawal
d3597b80a6 Added hideKeyboard in ViewUtil (#1488) 2018-05-03 02:47:56 +05:30
Josephine Lim
c959321ab0
Update issue_template.md
It feels like the template for reporting bugs is a bit redundant - we have summary, steps to reproduce, observed behaviour AND expected behaviour, which all are very similar. I think that by paring it down to the essentials, people will be less likely to skip steps.
2018-05-02 20:17:32 +10:00
Anubhav
dcd767351b Deprecation removed 2018-05-01 17:03:59 +05:30
misaochan
25f0fa31a4 Merge remote-tracking branch 'refs/remotes/commons-app/master' 2018-05-01 01:23:29 +10:00
neslihanturan
35f05be8df
fix memory leaks (they happened due to hiding keyboard) and lint null pointer warnings in the same code (#1471) 2018-04-30 14:42:19 +03:00
Balakrishnan S
6d2c41b91e Help button (#1415)
* Help button added to tutorial

* debug typo removed

* Help changed to more info

* More option moved to bottom

* Alignment changes made
2018-04-30 14:31:27 +03:00
Abhishek Poonia
0223c5ab76 Error messages in LoginActivity persist after orientation change. (#1407) 2018-04-30 14:27:35 +03:00
Aarnav Jindal
5aba7459bd Fix issue #1332 : Contribution Image auto/manual refresh if fetching fails 2018-04-30 14:22:50 +03:00
neslihanturan
3c2cc26d3b
Fix conflicts from #1366 fixing lint issues (#1470)
* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added %d

* lint issue #171 - Changed version

* lint issue #171 - added singleLine="true"

* lint issue #171 - changed commit to apply

* lint issue #171 - added Locale.getDefault()

* lint issue #171 - added Locale.getDefault()

* Codacy issues #778 - nested if loop

* Codacy issues #778 - nested if loop

* Revert "lint issue #171 - added %d" since we dont edit translated string files

This reverts commit e4917cddcf.
2018-04-30 14:05:47 +03:00
Mansi Agarwal
f80311d9f6 fixed crash while uploadiing certain images (#1388) 2018-04-30 13:49:03 +03:00
Ujjwal Agrawal
b017d1c99a Changed webview to Custom Tabs in Settings Page (#1328)
* Changed Webview to Custoom tabs in Settings Page

* Get COntext changed to getActivity
2018-04-30 12:24:37 +03:00
translatewiki.net
5ebaa7418e Localisation updates from https://translatewiki.net. 2018-04-30 08:19:57 +02:00
translatewiki.net
8a06aa5c14 Localisation updates from https://translatewiki.net. 2018-04-26 07:51:15 +02:00
Tanvi Dadu
9c91d7a799 Zoom (#1300)
*  Basic Zoom feature added along with button to control it

*  Pinch Zoom added

*  Merge Conflicts Resolved

*  Icons Changed

*  Compressed the high resolution images

* Fixed null pointer exception

* Fixed null pointer exception

*  Fixed exception

*  Fixed error

*  Fixed Resource availability issue
2018-04-26 03:18:58 +05:30
Vivek Maskara
fed9b1dc00
Merge pull request #1461 from misaochan/remove-author
Remove author Javadocs for FeaturedImagesListFragment.java
2018-04-25 02:28:33 +05:30
Vivek Maskara
07bdb42d84
Merge pull request #1460 from misaochan/fix-travis
Fix Travis
2018-04-25 02:28:16 +05:30
misaochan
fab3d32a8c Remove author Javadocs for FeaturedImagesListFragment.java
As mentioned at #1451 . Travis will fail prior to merge of #1460
2018-04-24 01:31:24 +10:00
misaochan
d252275b7c Fix error during merge conflict resolution 2018-04-23 21:56:48 +10:00
misaochan
4c78ebf58b Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-04-23 21:51:23 +10:00
misaochan
014da5fd00 Merge branch 'commons-app/master' 2018-04-23 20:20:49 +10:00
misaochan
d6a4188cb1 Merge remote-tracking branch 'refs/remotes/origin/2.7.x-release'
# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/nearby/NearbyActivity.java
2018-04-23 20:14:21 +10:00
misaochan
649da00c7f Merge remote-tracking branch 'refs/remotes/commons-app/master' 2018-04-23 17:39:14 +10:00
translatewiki.net
970704334b Localisation updates from https://translatewiki.net. 2018-04-23 08:51:06 +02:00
Josephine Lim
533297dce7
Versioning and changelog for v2.7.1 (#1457)
* Versioning

* Update changelog.md
2018-04-20 15:28:42 +10:00
Vivek Maskara
ce7754af45
Merge pull request #1455 from commons-app/featuredImages
Featured images
2018-04-20 00:33:17 +05:30
Vivek Maskara
b108dff460
Merge branch 'master' into featuredImages 2018-04-19 23:44:33 +05:30
kamilya35231
108ca26967 Fix for #1437 :Button that opens Google Maps shows always only the coordinates of the first chosen mark (#1446) 2018-04-19 23:50:23 +10:00
Vivek Maskara
8b118b309c Fix loading issue after upgrade from older version (#1454) 2018-04-19 12:52:58 +03:00