Commit graph

4982 commits

Author SHA1 Message Date
Josephine Lim
d97d40fbb9 Versioning for v2.13 2020-05-20 02:56:59 +10:00
Ashish Kumar
bff923135e
Fix NullPointer when clicking on image in MediaDetailFragment (#3730)… (#3739) 2020-05-12 13:37:17 +03:00
Vitaly V. Pinchuk
63018fcbd5 Add #3723 and #3721 to 2.13 release, fix conflicts
Conflicts were caused by merging #3723 before #3721 , so I just rolled both into one commit.
2020-05-06 01:04:09 +10:00
Ashish Kumar
461249fc30
Fixes #3639 (Fix Save State implementation of CheckBoxTriState ) (#3686) 2020-04-26 12:05:08 +03:00
Kshitij Bhardwaj
d7c2480174 Fixes #3436 and #2881: Media Detail design Overhaul (#3505)
* ic_map_dark_24dp: map icon for white background

* ic_info_outline_dark_24dp: info icon for dark background

* MediaDetailFragment: update the spacer as per image aspect ratio

* fragment_media_detail: design overhaul

* fragment_media_detail: remove redundant background color statements

* make requested changes

* add dark mode support

* minor ui tweak

* white map icon in dark mode

* make rquested changes

* make requested changes to layout

* fix misalignment of category list

* subtle amendments

* convert comments to javadocs

* minor amendments

* minor changes

* add styles for media detail

* Media detail fragment refactored

* make suggested changes

* minor name fix

* fix the delete button border
2020-04-22 01:23:14 +10:00
Ashish Kumar
05a9aa8575
Bugfix/security exception (#3627)
* Fixes #3626
* Check is file is actually created before writing to file, file picker android

* Handle Security exception
2020-04-16 23:59:30 -07:00
Kaartic Sivaraam
c961099013
Revert "Fixes: #3179 Make category search non case-sensitive (#3326)" (#3636)
Simply lower casing the name of the category sent to the server
doesn't result in the server doing a case insensitive category
search. In fact, it reduces the category search space as only
categories that has a lower case character is searched even
if the search text contains upper case characters.

The test case did not catch this issue as the first character
of the title is case insensitive[1].

So, revert the changes done in commit afdeaae075.

See further disucssion in the issue thread of #3179 starting
from [2].

[1]: https://www.mediawiki.org/wiki/Manual:Page_title
[2]: https://github.com/commons-app/apps-android-commons/issues/3179#issuecomment-605462140
2020-04-10 10:38:51 +01:00
Seán Mac Gillicuddy
cf73e28623 #3624 DateTimeFormat wrong - match pattern returned from servers (#3625) 2020-04-09 02:52:09 +10:00
Kaartic Sivaraam
93d6c52eb0
Update wiki page links (#3608)
We've moved the documentation to a separate repo.

So, change the old links to point to the corresponding
places in the documentation repo.
2020-04-07 04:57:31 +10:00
Prince Amankwah
bc8ce94d76 Fixed issue #3195 ordering contribution list (#3589)
* issue-#3195: order contribution list refactored

* issue-#3195: ordered contribution list
2020-04-07 03:46:35 +10:00
neslihanturan
b6df5f2a66
Fixes #3466 No crash information in crash email (Gmail) (#3605)
* Send ACRA logs as file instead

* no need to set it true, default is true
2020-04-07 03:17:26 +10:00
Prince Amankwah
f0a37d3369
issue-#3606: cancel in translate goes back to about screen (#3610) 2020-03-31 01:56:59 -07:00
Ashish Kumar
4f5f0da4c6
Fixes #3611 (#3613)
* Properly generate Parcealables for Media & Contribution
2020-03-31 01:47:26 -07:00
Ashish Kumar
6416314dda
Fixes #3575 (#3602)
* Donot show random colors as placeholders for contributions items
* Theme contributionsItem background as mainBackground from attributes
2020-03-30 12:42:47 +03:00
Kshitij Bhardwaj
3d1ffbb4bc
Fixes #3479: Implement Progress Bar for Zoom Activity (#3481)
* ZoomableActivity: add hierarchy to view for displaying progress bar

* CircularProgressBar: circular progress bar for ZoomableDraweeView

* ZoomableActivity: add indeterministic loading spinner

* activity_zoomable: add inderterministic Progressbar

* remove circular progressbar and make changes to controller listener
2020-03-29 22:55:47 +03:00
Prince Amankwah
8a5944dd87
issue-#3567: logos in about activity visible (#3592) 2020-03-29 22:29:51 +03:00
318anushka
5c4eea3cc1
swipe away failed notification (#3598) 2020-03-29 22:17:30 +03:00
Kaartic Sivaraam
38635d0f43
PULL_REQUEST_TEMPLATE: clarify that issue number needs to be replaced (#3599)
Some contributors seem to be missing the fact that they have to mention
the issue number right after `Fixes ` to ensure the corresponding issue
gets closed[1] when the PR gets merged.

Clarify this by using a better phrase that clearly states that they
have to replace the placeholder text with the issue number.

[1]: https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
2020-03-29 21:42:17 +03:00
translatewiki.net
b085091c2b Localisation updates from https://translatewiki.net. 2020-03-26 16:03:48 +01:00
neslihanturan
e7efd7e162
Fix auto zoom issue #3391 Zoom level gets reset at every second. (#3564)
* Add method to check if curr location marker is vsible or not

* Recenter map if users see their current location marker

* Add new methods to Contract
2020-03-27 00:53:11 +10:00
hudlerr
350e95b56a
Fixes #3494 (#3519)
* better names for the upload warning dialog buttons #3494

* Dialog button pt2

* dialog buttons pt3

* round 4..

Co-authored-by: Hdot <a.hudaa@hotmail.com>
2020-03-25 13:38:12 +00:00
Seán Mac Gillicuddy
7ed911808d
#3579 p18Value causes NPE in WikidataEditService createClaimWithLogging - add null check (#3580) 2020-03-25 00:59:44 +10:00
318anushka
8cb4e28a97
Wiki itemname displaying in toast (#3569)
* Wiki itemname displaying in toast

* Wikidata label displaying in toast

* Wikidata label displaying in toast

* wikiItemName added to parcelable methods

* Wikidata label displayed in toast

* Wikidata label displayed in toast
2020-03-24 12:54:37 +00:00
Vivek Maskara
f7efa0e20a
Fix title/desc not getting filled for nearby picture (#3577) 2020-03-24 07:56:44 +00:00
Kaartic Sivaraam
1899d92cdf
PULL_REQUEST_TEMPLATE: request only issue number (#3545)
For some time now, GitHub is showing cards when we hover over an issue
number which gives us a quick summary of the issue. The issue title is
shown in the card among other things.

Given that and the fact that we already require the issue number to be
specified in the pull request description, it's now moot to
ask the contributors to include the issue title in the pull request
description. So, let's remove this unnecessary burden from them.
2020-03-23 12:33:52 -07:00
translatewiki.net
a31499b11f Localisation updates from https://translatewiki.net. 2020-03-23 14:57:26 +01:00
Anmol Gupta
839a61bba4
Change BiMap to HashMap (#3572)
* Change BiMap to HashMap

* Change containsKey to containsValue and delete BiMap.java
2020-03-23 13:21:28 +00:00
Kaartic Sivaraam
630f0a1dff
Fix hardcoded string in similar image dialog (#3563)
Fixes #3557
2020-03-22 11:23:00 -07:00
Anmol Gupta
a63a3580de
Change "Archived" notifications to "Read" notifications (#3554)
* Change archived to read

* Change string names
2020-03-20 14:20:20 +00:00
Seán Mac Gillicuddy
fb51fc618a
#3408 Refactoring the FileProcessor and GPSExtractor classes (#3543)
* #3408 Refactoring the FileProcessor and GPSExtractor classes - refactor FileProcessor

* #3408 Refactoring the FileProcessor and GPSExtractor classes - refactor and rename GpsExtractor

* #3408 Refactoring the FileProcessor and GPSExtractor classes - convert ImageCoordinates to kotlin

* #3408 Refactoring the FileProcessor and GPSExtractor classes - convert FileProcessor to kotlin

* #3408 Refactoring the FileProcessor and GPSExtractor classes - minor reformatting

* #3408 Refactoring the FileProcessor and GPSExtractor classes - fix compilation and naming issues

* #3408 Refactoring the FileProcessor and GPSExtractor classes - remove empty test

* #3408 Refactoring the FileProcessor and GPSExtractor classes - set coordinates for upload item if user chooses it
2020-03-20 17:18:14 +03:00
Madhur Gupta
efc6fa6211
Fixes #3473 Changed Names and Order or Theme Options (#3556) 2020-03-20 13:30:28 +00:00
Seán Mac Gillicuddy
c972f74fad
#3532 Issue with gitignore - synchronise section with default plugin state (#3535) 2020-03-20 20:34:41 +10:00
Fawziyah Alebiosu
d3bc0721c6
Issue #3428: Swapped text in dialog buttons (#3496)
* Issue #3428: Swapped text in dialog buttons because, according to Android Convention, they were opposite each other

* Fixed Issue #3428 so it actually works correctly now: Swapped text in dialog buttons because, according to Android Convention, they were opposite each other

* Made sure that all of the places where the two types of showAlertDialog accurately match up with the new position of positive and negative text on the dialog box
Also removed occurences of empty lambda expressions and used null instead

* modified deletThisPicture to be accurate lambda call

* reverted mistake where ellipses replaced the three dots
2020-03-20 07:26:34 +00:00
translatewiki.net
d028cf189c Localisation updates from https://translatewiki.net. 2020-03-19 15:02:56 +01:00
Anmol Gupta
a0309d955a
Modify PR template (#3548) 2020-03-19 11:52:22 +00:00
Aryan Tyagi
4e51492de6
Removed the focus change listener of the username edittext (#3538) 2020-03-19 08:54:23 +00:00
Madhur Gupta
0ad269d3d6
Fixes 3536 (#3537) 2020-03-19 08:39:59 +00:00
Ashish Kumar
efdb00b5ee
Fixes #3359 Duplicate Photos in Contributions Page (#3515)
* Fixes #3359
* Cache thumb url & imageUrl in local db
* Use Fresco's ImageRequest to show images in ContributionViewHolder[this was the issue, we should have always used this to show the image]
* Deleted DisplayableContribution (not needed anymore)
* Exposed abstract function in ContributionDao to updateContribution

* * Make position private in ContributionViewHolder
* Remove MediaDataExtractor from ContributionsFragment

* * Show placeholder image for Contributions while the image loads
* setHasStableId's ContributionsAdapter

* make Random variable private in ContributionViewHolder

* replace local variable-if-with ternary operator in ContributionViewHolder

* Fix indentation/formatting of ternary operator in ContributionViewHolder

* I might revert this commit[I have reasons]

* Create in-memory drawables in CVH's onBind, caches are bad, add mental overhead

* Revert "I might revert this commit[I have reasons]"

This reverts commit 627ac91517.

* minor formatting changes, reverted 627ac91517

* uh-oh missed semicolon, java

* minor formatting changes
2020-03-18 13:47:51 +03:00
Aryan Tyagi
021105ac4d
Add a dialog to prompt user if location is off in Nearby when L… (#3438) 2020-03-18 15:50:00 +05:30
Madhur Gupta
15bccdf650
Fixes #3465 Use AndroidX Pref (#3521)
* [WIP] Fixes #3465 Use AndroidX Pref

* Deleted Unused Files

* Added singleLineTitle

* Updated Gradle Properties

* Migrated to Androidx

* Inline Variable change

* optimise imports

* Fixed Crash on empty input
2020-03-17 13:10:26 +00:00
Vitaly V. Pinchuk
e55b5495a1
Fixes #3464, App posts deletion request notifications ({{subst:idw}}) on the wrong user's talk page (#3495)
* Fixed #3464: App posts deletion request notifications ({{subst:idw}}) on the wrong user's talk page

* Fixed DeleteHelperTest.kt

* Fixed DeleteHelper tests and null-pointer exception

* Modified DeleteHelper makeDeletion() test

* Reverted unintentionally modified Project.xml

* Raising exception when nominating for deletion with empty creator name

* Fixed code style

* Fixed code style
2020-03-17 14:39:28 +03:00
Seán Mac Gillicuddy
cd2d530175
#3524 Convert SpinnerLanguagesAdapter to kotlin - converted to kotlin (#3528)
* #3524 Convert SpinnerLanguagesAdapter to kotlin - converted to kotlin

* #3524 Convert SpinnerLanguagesAdapter to kotlin - add KDoc - rework logic - format
2020-03-17 21:06:56 +10:00
neslihanturan
e5d5a7af92
Fix p18 issue For an item with P18 item, do not add another one (#3527)
* Add p18value variable to contrib

* set place.pic to candidate contribution

* Add p18 value to contrib

* Passes p18 value to wikidata upload service

* Checks if pic parameter of the wikidata item is empty or not. If not, it does not overrides the existing image, it is just a regular commons upload.

* Make public var private

* Make current tests pass

* Add test case for p18 value is not empty

* Fix wrong log message

* Add nonnul annotation and fix method javadoc
2020-03-17 10:35:21 +00:00
318anushka
bdb61dfda6
Fixes #2238 scalebar added in map (#3511)
* scalebar added in map

* changes reverted in .idea/Project.xml

* magic numbers replaced with constants for scalebar

* Default setting for scaling unit

* Default setting for scalebar refresh interval

* Reformatted code for adding scalebar

* dimen values for scalebar params
2020-03-17 08:41:31 +00:00
translatewiki.net
af131a9792 Localisation updates from https://translatewiki.net. 2020-03-16 15:40:49 +01:00
taakanksha
9cb81fce8c
author not shown bug (#3525) 2020-03-16 13:46:36 +00:00
gouri-panda
1fd748f8e7
solved crashing problem in nomination button (#3522)
solved crashing problem in nomination button

solved crashing problem in nomination button
2020-03-16 11:14:06 +00:00
Anmol Gupta
34a016d49d
Change item background according to the theme (#3480)
* Change item  background according to the theme

* Change background colour of item on being selected

* Change background colors using XML selectors
2020-03-16 10:13:20 +00:00
Seán Mac Gillicuddy
81c7281d3a
#3471 Remove android.enableUnitTestBinaryResources - remove line (#3478) 2020-03-16 19:38:58 +10:00
Kshitij Bhardwaj
668b5896a2
Chek if getContext() is instanceOf CategoryImagesCallback and only then request more images 2020-03-14 15:00:33 +05:30