Commit graph

1123 commits

Author SHA1 Message Date
addshore
5fe95813df Simplify boolean expressions 2017-05-13 13:01:45 +02:00
addshore
f019aa2865 Don't create local vars when returning straight away 2017-05-13 13:01:05 +02:00
addshore
85182e3fb7 Stop unnecesary unboxing of values 2017-05-13 12:53:00 +02:00
addshore
5f6f67d3e2 Use switch statements instead of long if elseifs 2017-05-13 12:52:22 +02:00
addshore
6b75810f37 Collapse try blocks 2017-05-13 12:51:43 +02:00
Neslihan
0901e67853 Optimise unnecesarry method call 2017-05-13 13:41:53 +03:00
Josephine Lim
a99ae9e8bb Merge pull request #560 from commons-app/prehack2faError
Detect when 2FA is needed and error nicely
2017-05-13 12:28:51 +02:00
addshore
e8bbbe78d8 Detect when 2FA is needed and error nicely
Fixes #507
2017-05-13 12:03:40 +02:00
Vivek Maskara
676583b6ec Merge pull request #558 from neslihanturan/nearbyMap
Nearby map
2017-05-13 09:41:57 +02:00
Neslihan
c906d6d3d4 Fix Codacy issues 2017-05-12 19:12:39 +03:00
Neslihan
ed32ebbb62 Fix Codacy issues 2017-05-12 19:05:20 +03:00
Neslihan
f9fd354d00 Fix Codacy issues 2017-05-12 18:55:29 +03:00
Neslihan
08501b9348 Organize imports 2017-05-12 18:45:33 +03:00
Neslihan
470ad29380 Fix double click to map icon and refresh icon click 2017-05-12 18:42:02 +03:00
Neslihan
f6ac8fd1a5 Display nearby places on the map 2017-05-12 17:55:21 +03:00
Dinu Kumarasiri
516a5839a3 Merge pull request #557 from misaochan/upload_limit
Add logs for checking uploads limit
2017-05-12 16:40:38 +02:00
Josephine Lim
111c09bac5 Add logs to ContributionsSyncAdapter 2017-05-12 22:33:54 +08:00
Neslihan
c2e018ae9e Nearby places displayed on the map 2017-05-12 17:13:06 +03:00
Josephine Lim
5274984682 Merge pull request #550 from commons-app/prehackLogin
Use clientlogin API module
2017-05-12 21:32:56 +08:00
Udit
a5dc7f79c1 Fix - zero quantity in messages doesn't work in English #343 (#546) 2017-05-12 22:31:13 +09:00
addshore
d1a395689a Merge pull request #554 from whym/license-exception
Show failed value on license-related RuntimeException
2017-05-12 15:23:53 +02:00
neslihanturan
d5f50e8626 Merge pull request #553 from maskaravivek/mapView
Added support for MapView in Nearby
2017-05-12 16:02:59 +03:00
addshore
d38dde0ec4 Use clientlogin API module
This is the first step to allowing 2 factor authentication #328.
This uses the new API module clientlogin instead of the login module.

We still report the same set of errors in a 'nice' way with real
error messages, how ever there are lots more that can probably be
handled, for example #507.
2017-05-12 14:36:58 +02:00
Yusuke Matsubara
040d99638c Show failed value on license-related RuntimeException 2017-05-12 21:31:10 +09:00
maskara
01948c4316 Codacy fixes 2017-05-12 14:30:54 +02:00
maskara
6118b57295 Added support for MapView in Nearby 2017-05-12 13:50:25 +02:00
Vivek Maskara
5ef4777130 Merge pull request #549 from neslihanturan/mapİconToNearby
Add icon to map
2017-05-12 13:43:56 +02:00
Neslihan
784b51e29d Add icon to map 2017-05-12 13:53:47 +03:00
Josephine Lim
75bc9f1a3d Merge pull request #544 from srv-twry/master
Added 'Up navigation' for settings activity
2017-05-12 17:40:32 +08:00
Josephine Lim
8216eb76ee Merge pull request #533 from whym/tests
Rename and refactor tests
2017-05-12 17:29:54 +08:00
translatewiki.net
2e7aaddafb Localisation updates from https://translatewiki.net. 2017-05-11 08:29:05 +02:00
srv-twry
5639be077e Plural declarations in the strings resource file now according to guidelines 2017-05-11 04:01:06 +05:30
Adam Jones
d9afd0e4bf Improve code style 2017-05-10 23:16:35 +01:00
Adam Jones
e5d7caf5f2 Update SettingsActivityTest to correctly pass test on LicenseSpinner 2017-05-10 23:15:15 +01:00
Adam Jones
0c5e0869b5 Check in SingleUploadFragment that spinner position is valid before applying 2017-05-10 22:51:33 +01:00
Adam Jones
87fe6cf585 Create untranslatable strings for pref constants 2017-05-10 22:51:19 +01:00
srv-twry
654471c098 Added 'Up navigation' for settings activity 2017-05-10 00:38:58 +05:30
Adam Jones
2b91abed22 Hardcode arrays.xml values 2017-05-09 19:59:42 +01:00
Adam Jones
b08a0a3964 Remove unused code in settingsFragment 2017-05-08 00:30:56 +01:00
translatewiki.net
fe470d64a9 Localisation updates from https://translatewiki.net. 2017-05-04 07:39:53 +02:00
translatewiki.net
779c1380c2 Localisation updates from https://translatewiki.net. 2017-05-02 07:49:56 +02:00
translatewiki.net
6d942df387 Localisation updates from https://translatewiki.net. 2017-04-27 08:08:51 +02:00
Yusuke Matsubara
f9e5b88c6d Rename and refactor tests 2017-04-25 09:30:47 +09:00
translatewiki.net
138b3541fe Localisation updates from https://translatewiki.net. 2017-04-24 19:44:18 +02:00
Josephine Lim
3c43578871 Merge pull request #528 from whym/espresso
Remove redundant Espresso/Travis settings
2017-04-23 12:59:15 +10:00
Yusuke Matsubara
559381d7f7 Fix initial emptiness of Nearby list + refactoring 2017-04-21 21:15:51 +09:00
Yusuke Matsubara
46b54e7312 Remove redundant Espresso/Travis settings 2017-04-20 21:34:04 +09:00
Josephine Lim
ba113ffc4a Merge pull request #525 from whym/espresso
Test license selection in Settings
2017-04-20 15:36:30 +10:00
translatewiki.net
a497bf527a Localisation updates from https://translatewiki.net. 2017-04-20 07:26:02 +02:00
Josephine Lim
523a4f1199 Merge pull request #524 from whym/style
Move config file of PMD
2017-04-19 21:55:04 +10:00