Commit graph

2372 commits

Author SHA1 Message Date
Josephine Lim
ca75f616d2
Merge v3.0.1 into master (#4446)
* Versioning and changelog for v3.0.0 (#4152)

* Versioning for v3.0.0

* Update changelog.md

* Handled migration 8-9-10 in BookmarksLocationDao (#4154)

* #Fixes #4141
- Handled migrations for BookmarkLocationsDao from 8-9-10

* #Fixes #4141
- Handled migrations for BookmarkLocationsDao from 8-9-10

* Fixes #4179 (#4180)

* Handled null pointer exception in MainActivity->ContributionsFragment#backButtonClicked()
* Updated >ContributionsFragment#backButtonClicked() to handle back press properly

* Fixes #4179 (#4181)

* Handled possible null check on MediaDetails in BookmarkListRootFragment#backPressed()

* Cherrypick for hotfix3.1 (#4205)

* Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.

Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.

* fixed bug: App crashes on viewing review in Review Fragment #4132 (#4146)

* fixed bug:app crashes on viewing review in Review Fragment #4135

* Fixed the issue with back button in contribution tab. (#4177)

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>

* Fixed the issue with back navigation button on toolbar in explore tab. (#4175)

* Fix (#4148) Issues on theme change

* fixed themeChange crashes

* fixed comments

* Overlooked the title bar

Co-authored-by: Pratham Pahariya <54663429+Pratham2305@users.noreply.github.com>
Co-authored-by: Shabir Ahmad <56585337+shabar-shab@users.noreply.github.com>
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
Co-authored-by: Aditya-Srivastav <54016427+4D17Y4@users.noreply.github.com>

* Fixes #4173 (#4396)

* Fix #4147  Pre-fill desc in Nearby uploads with Wikidata item's label + description (#4390)

* Update query to fetch descriptions

* Make description added to NearbyResultItem

* Make string operations to display description and label in a combined way

* Fix reviews, remove long description from list and swap label and description texts

* Fix repeated information issue

* Fix double information issue

* fix style issues

* Remove douplicated information

* Changes made (#4354)

* Remove nonexistent method

* Fix #4283 IllegalStateException (#4440)

* Fix #4283 IllegalStateException

* Fix flickering issue

* Versioning for v3.0.1

* Update changelog.md

Co-authored-by: Ashish <ashishkumar468@gmail.com>
Co-authored-by: neslihanturan <tur.neslihan@gmail.com>
Co-authored-by: Pratham Pahariya <54663429+Pratham2305@users.noreply.github.com>
Co-authored-by: Shabir Ahmad <56585337+shabar-shab@users.noreply.github.com>
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
Co-authored-by: Aditya-Srivastav <54016427+4D17Y4@users.noreply.github.com>
Co-authored-by: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com>
Co-authored-by: Vinayak Aggarwal <56196007+vinayak0505@users.noreply.github.com>
2021-06-09 20:19:24 +10:00
obsidian-zero
feb75cbb9f
Fixes #4357 After switching to different account, contributions screen shows pictures of previous account (#4421)
* Update UploadMediaDetailFragment.java

* Update LoginActivity.java

Clear CompositeDisposable after logging in successfully. It may help solve the problem of saving the contribution to the previous account

* Revert "Update UploadMediaDetailFragment.java"

This reverts commit b1b4257f20.

Co-authored-by: Obsidian_zero <1198474846@qq.com>
2021-06-07 18:52:19 +03:00
Brigham Byerly
165c375bbd
UploadMediaDetail: replace discreet error toast with more-noticeable dialog (#4433) 2021-06-04 12:34:46 +03:00
Pratham Pahariya
ca18763e4f
Fixes #2815 - Nominating for deletion is cancelled on leaving the media details (#4295)
* fix issue with nominating for deletion

* Fix UI issue

* minor improvements

* fix App crash

* Added Javadoc and other minor improvements

* Updated string name

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-06-04 11:15:39 +09:00
Prince kushwaha
4fa18e5e27
In depictions selection screen, suggest recently selected items (#4361)
* implement in depictions selection screen to suggest recently selected items

*use RoomDataBase
* Add Javadoc

* fix an bug

* minar change and remove extra line of code

* minar changes

* improve implemention strategy

* fix unittest

* Add javadoc

* added javadoc
2021-05-31 19:19:55 +09:00
Ayan Sarkar
1408fe5e53
Made locale non dependent on phone OS settings, but choosable on app settings (#4366)
* setLocale added

* localization added

* test complete

* resolved conflicts

* issues resolved

* minor issues fixed

* Made methods concise

* Issues fixed
2021-05-15 23:30:03 +09:00
Ayan Sarkar
a78fea09d7
Added an option to Remove a new language description while uploading (#4406)
* implementation done modification required in card & more

* Remove button reversed

* Code beautification done

* Code beautification done

* minor issues fixed

* java docs added
2021-05-15 09:14:29 +09:00
Pratham Pahariya
c7f7b39151
Fixes #3380 - "Nearby Place found" despite already Nearby upload (#4408)
* fix issue with "nearby place found" pop up on nearby upload

* added javadoc

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-05-13 23:00:55 +09:00
Pratham Pahariya
2b62d8487b
Fixes #4286 - Contributions didn't appear after logging in again (#4337)
* fix the issue with contributions not appearing after logging in again

* fix old contribution appearing on top

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-05-10 19:28:32 +03:00
Prince kushwaha
0c8b92c7aa
Show media details fragment when on clicking image of Peer Review (#4374)
* * show MediaDetailFragment in ReviewActivity on image click
* Add javadoc
* Reformated code of  ReviewActivity xml

* fix typos

* add unit test

* made minor changes
2021-05-10 19:07:28 +03:00
Vinayak Aggarwal
117a7805ad
Fixes #4300 Limited connection mode banner occupies too much space (#4375)
* done

* fixed

* minor changes made

changed tv, Tv to text_view, TextView, improved comment for toggleDescriptionListener
2021-05-08 18:49:50 +09:00
Pratham Pahariya
845a901604
Fixes #4385 - App crash On categoryDetail activity when click on image after orientation change (#4397)
* fix issue 4385

* fix orientation change issue

* added javadoc

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-05-08 18:45:32 +09:00
Piyush Goel
cf7583abd4
Login error message is displayed in native phone locale language and not in just English. Fixes #4290 (#4389)
* Login error message is displayed in native phone locale language.

* Login error message is displayed in native phone locale language.
2021-05-03 09:37:14 +09:00
Aditya-Srivastav
f8a8f92070
Fixes #4329 "Back button in edit categories triggers back of media details." (#4346)
* Back button on fragment

* Handled back events

* minor changes

* removed extra lines
2021-04-19 17:19:27 +03:00
Ayan Sarkar
3369d96c49
READ_EXTERNAL_STORAGE permission is not necessary while picking file from gallery (#4356) 2021-04-19 13:31:01 +03:00
Ashish
8c7954a158
Fixes #4360 (#4363)
* Trigger API call to addDepictionsAndCaptions after succesfull upload from stash
2021-04-18 16:19:26 +09:00
Vinayak Aggarwal
bebc4afae2
Changes made (#4354) 2021-04-15 23:45:10 +09:00
Pratham Pahariya
58408cf2b0
Fixes #4297 - UI Issue: After changing the system theme from settings (#4332)
* fix UI issue after theme change

* removed unnecessary changes

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-08 20:51:07 +03:00
Prince kushwaha
153e57264d
fix:In setting Default description language option is needed to get disable when user is not login (#4342) 2021-04-08 19:37:58 +03:00
Ashish
ecbff7e3b8
Fixes #3790- Use WorkManagers to upload contributions (#4298)
* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated gradle

* Revert "Updated gradle"

This reverts commit c8979fe6dc.

* rolledback to compileSDKVersion 28, fixed tests

* Don't call the show notifications on the main thread

* Bug Fix- Duplicate contributions, handle upload stash errors
2021-04-08 15:59:07 +03:00
Ayan Sarkar
fd2a7a9c56
Fix SearchView is not visible properly in lower API devices (#4333) 2021-04-08 15:57:50 +03:00
Prince kushwaha
0d23e65e0f
fix:Setting Language list is not an language list which is supported by Commons for caption and description (#4325) 2021-04-07 23:33:47 +09:00
Prince kushwaha
12547fd34a
fix:App should respect device font-size (#4306)
* * Add adjuctFontScale function  to fix issue
* Add Javadoc

* reformed the codechange

* rearrange the codechange

* make metric and wm variable final
2021-04-06 17:47:38 +09:00
Pratham Pahariya
c269693625
Fixes #4296 - "Is this a picture of ...": Not too clear about which image it is asking me about (#4317)
* fix issue 4296

* minor improvements

* minor improvement

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-05 17:03:11 +09:00
Ayan Sarkar
40b2619ccf
Added Help link in Alert Dialogue (#4315)
* READ MORE button added

* Added link to tips

* Fixed minor issues
2021-04-03 17:55:19 +09:00
Pratham Pahariya
a479dd5bb1
#4048 - "copy to subsequent media" button (#4308)
* added copy to subsequent media button

* minor change

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-02 09:12:11 +03:00
Aditya-Srivastav
ff96f5047e
Fixes #4287 "Tapping multiple items in explore should not be allowed" (#4310)
* only one media detail at a time

* requested changes

* disabled multitap on screen

* requested changes
2021-04-01 23:24:48 +09:00
Gabriel Lee
7a04a2bf9c
Simplify peer review button text (#3376) (#4303)
* Simplify peer review button text (#3376)

The lengthy button text was not showing correctly, discussions concluded
that the button texts could be simplified to just "yes" or "no". To ensure
code read-ability, the buttons were renamed. Also made slight code style
adjustments to ReviewImageFragment.java and fragment_review_image.md.

Bug: #3376

* Remove string translate file changes from patch
2021-03-24 12:38:53 +03:00
Saumia Singhal
0857eae082
set icon frame visibility to View.GONE for all preferences (#3863) 2021-03-24 12:16:08 +03:00
Pratham Pahariya
944225c3a3
Fixes #4260 - Item with P582 (end time) shown as existing (#4292)
* fix issue with item with endtime shown as existing

* Removed destroyed and endtime, Added comments and also fixed the broken tests

* minor fix

* Added comments

* fix no such column location_exists error

* minor improvement

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-18 00:05:08 +09:00
Aditya-Srivastav
5c02b2fc0a
changed column name (#4288) 2021-03-04 16:55:21 +03:00
Aditya-Srivastav
7a5774e479
Fixes #4281 "Wrong language pre-selected in Nearby upload" (#4285)
* location added

* tests

* changes requested

* comments

* Test fixed, minor improvement
2021-03-04 15:51:28 +03:00
Fawziyah Alebiosu
91a5aa1abe
Delete categoryImagesActivity (#3878)
* deleted categoryImagesActivity test & activity

* deleted categoryImagesActivity reference in ActivityBuilderModule

* deleted categoryImages from manifest

* deleted categoryImages import from ActivityBuilderModule

* deleted categoryImagesActivity
2021-03-03 21:17:29 +03:00
Prince kushwaha
a4bdd23718
fix:Explore Search: No title bar for item, non-existent menu for item, wrongly-worded menu for category (#4274) 2021-03-03 15:39:42 +03:00
Aditya-Srivastav
9cf59f7801
fixes #4266 'Image Dimensions should be reduced if too large" (#4279)
* height restriction

* requested changes

* removed landscape drawee view

* javadoc
2021-03-01 23:37:44 +09:00
Pratham Pahariya
93cd89a34b
Fixes #4255 - Media details activity shows depictions in random languages, rather than in the user's locale (#4275)
* fixes issue with depiction names in random languages

* minor change

* using if conditions to check

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-01 20:50:09 +10:00
Aditya-Srivastav
0a857974f0
fixes #3440 "Campaign notification is not removed from Home even when disabling it in the setting" (#4231) 2021-02-27 19:27:06 +03:00
Pratham Pahariya
630c2a5dcd
#3732 - Nearby Tab Accessible Without Location Permission (#4259)
* Added ability to access nearby tab without location permissions

* added ability to remember user choice if the permission is denied.

* fixed the issue with permission dialog box in contribution tab.

* changed name for stored variables

* minor change

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-26 21:49:11 +09:00
Mrudul Tora
ba000eb26e
Fixes #4129 Resolved App crash on logging out from Contributors Tab (#4257)
* Resolved App crash on logging out from Contributors Tab

* Moved if condition in fetchContributions method
2021-02-26 17:21:16 +09:00
Pratham Pahariya
e82fdd0f4f
Fixes #2803 - Cancel nearby upload -> Next upload gets the same title/description 2021-02-23 16:42:41 +03:00
Mrudul Tora
6be9317eac
Hided Peer Review in Limited Connection Mode (#4247) 2021-02-23 16:06:00 +03:00
Mrudul Tora
0ec62170fc
Removed category editing accessibility when user not logged in (#4251) 2021-02-23 18:53:03 +09:00
Mrudul Tora
a83006fc7b
Fixed crashing on setting avatar when not logged in (#4258) 2021-02-23 18:43:32 +09:00
Aditya-Srivastav
f7d1fab566
Fixes #2252 "Tapping on map doesn't close tab in 'nearby'". (#4265)
* closing the list on tap ouside

* minor improvement

* minor changes

* javadoc

* official javadoc

* javadoc error
2021-02-23 17:17:11 +09:00
Pratham Pahariya
d81caf6a42
Fixes #4218 - In-App notifications appear on media detail fragment (#4246)
* Fixed issue with In-App Notification appearing on media detail view.

* Added a comment

* fixed style issues

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-22 19:00:28 +09:00
Aditya-Srivastav
7d8ea51c4f
Added bookmark section in not-logged-in version (#4256)
* added bookmark in not-logged-in version

* javadoc

* javadoc update

* spacing

* added unit test
2021-02-22 00:23:41 +09:00
Prince kushwaha
4f130e4dd0
fix:click on skip button in Peer Review after orientation change then app is crashed (#4176)
* #fixes-4143
In ReviewActivity overrides two function-> onResume() and onPause()

* Fixed the Bug-#4143

* reformed the codechange

* reformed the codechange

* Add javadoc

* Add javadoc
2021-02-21 10:58:07 +09:00
Mrudul Tora
9075b65ddf
Fixes #4244 - App crash in WikidataItemDetailsActivity resolved (#4248) 2021-02-20 21:35:28 +09:00
Aditya-Srivastav
68689980ee
fixed #4230 'Opening notifications in "Read" section still marks them read and removes them from the list'. (#4249)
* notifications fixed

* refractored

* javadoc
2021-02-20 10:00:22 +09:00
Pratham Pahariya
b8cdc5a537
Fixes #4229 - App Crashes while trying to nominate an item for deletion, When User is not logged in (#4237)
* Fixes the crash while nominating an item for deletion.

* removed unnecessary code

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-19 10:48:39 +09:00