* Issue #3428: Swapped text in dialog buttons because, according to Android Convention, they were opposite each other
* Fixed Issue #3428 so it actually works correctly now: Swapped text in dialog buttons because, according to Android Convention, they were opposite each other
* Made sure that all of the places where the two types of showAlertDialog accurately match up with the new position of positive and negative text on the dialog box
Also removed occurences of empty lambda expressions and used null instead
* modified deletThisPicture to be accurate lambda call
* reverted mistake where ellipses replaced the three dots
* Fixes#3359
* Cache thumb url & imageUrl in local db
* Use Fresco's ImageRequest to show images in ContributionViewHolder[this was the issue, we should have always used this to show the image]
* Deleted DisplayableContribution (not needed anymore)
* Exposed abstract function in ContributionDao to updateContribution
* * Make position private in ContributionViewHolder
* Remove MediaDataExtractor from ContributionsFragment
* * Show placeholder image for Contributions while the image loads
* setHasStableId's ContributionsAdapter
* make Random variable private in ContributionViewHolder
* replace local variable-if-with ternary operator in ContributionViewHolder
* Fix indentation/formatting of ternary operator in ContributionViewHolder
* I might revert this commit[I have reasons]
* Create in-memory drawables in CVH's onBind, caches are bad, add mental overhead
* Revert "I might revert this commit[I have reasons]"
This reverts commit 627ac91517.
* minor formatting changes, reverted 627ac91517
* uh-oh missed semicolon, java
* minor formatting changes
* Add p18value variable to contrib
* set place.pic to candidate contribution
* Add p18 value to contrib
* Passes p18 value to wikidata upload service
* Checks if pic parameter of the wikidata item is empty or not. If not, it does not overrides the existing image, it is just a regular commons upload.
* Make public var private
* Make current tests pass
* Add test case for p18 value is not empty
* Fix wrong log message
* Add nonnul annotation and fix method javadoc
* scalebar added in map
* changes reverted in .idea/Project.xml
* magic numbers replaced with constants for scalebar
* Default setting for scaling unit
* Default setting for scalebar refresh interval
* Reformatted code for adding scalebar
* dimen values for scalebar params
* Revert stopgaps related to beta server cert issue
The upstream issue with Commons beta server has been
fixed now[1]. So, there's no point in stopgapping
the issue anymore. So, revert the related changes.
This reverts fa87eb5661
and df426f7c42 which
correspond to PRs #3350 and #3349 respectively.
[1]: https://phabricator.wikimedia.org/T243881#5861983
* Test-fix: fix the failing CI test
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - add apropriate schedulers and convert justs to fromCallable
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - remove test for removed functionality
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - replace kotlin with java
* Part of #3127
* Added Room Dependency
* Shifted ContributionsDao to use RoomDB
* Save and Fetch contributions via RoomDAO
* Bugfixes, fixed test cases, injected schedulers for ContributionsPresenter
* removed stetho
* Fixed ReviewHelperTest cases
* Fixed test cases in DeleteHelperTest
* Fetch all contributions [TODO add pagination to use this, maybe later in a seperate PR]
* Update Schema false in AppDatabase
* removed parameter from fetchControbutions
* Added logs for fetch contributions
* Fixed test case ContributionsPresenter
* Added an autogenerate primary key, submit save contributions on executor
* fixed getItemAtPosition
* MainActivity Config changes +=orientation
* BugFixes
* Make AppDataBase Singleton
* Set _id as autogenerate primary key [replacing the previously used filename, seems like they are not unique]
* Replace Execxutor Utils with Subscribers on Singles in UploadService
* BugFix, Upload Progress
* Remove un-nescessary null check on contributions in ContributionsListAdapter
* removed ContributionsListFragment [not-implemeted]
* Review suggested changes
* removed un-nescessary null checks
* provide ContributionsDao
* Minor bug fixes
* wip
* delete existing contributions table (from the existing db) on upgrade
* remove un-nescessary null checks in test classes
* shifted media to be a local variable in ReviewHelperTest
* removed captured folder
* Dispose composite disposables in UploadService
* replaced size check with isEmpty ContributionsPresenter
* transform saveContributions to a Completable
* Addressed comments in review
* Typo in Contributions
* ReasonBuilderTest (create media object instead of mocking)
* Use global Gson object instead of creating a new one in Converters
* Provide Gson to Converters from the CommonsApplicationComponent
* use static method instead of field instead of static field to provide GSON in Converters
* Modified gitignore to exclude captures/*
* MediaDetailFragment: add zoom feature
* fragment_media_detail: add SimpleDrawee for Scroll picture
* ZoomableActivity: activity which facilitates zoom in
* activity_zoomable: xml for zoom activity
* zoomControllers: controllers for handling gesture and zooming
* MediaDetailFragment: fixing name of image variable
* MediaDetailFragment: display as per the aspect ratio of image
* add zoom activity to AndroidManifest
* fix travis ci faliure
* fix resizing of image
* #3476 Use individual test commands on CI instead of check - use individual commands and narrow scope
* #3476 Use individual test commands on CI instead of check - fix indentation
* #3469 Update Gradle Play Publisher to resolve issues with travis build - update GPP/Gradle and use jacoco-android fork with gradle 6.0 support
* #3469 Update Gradle Play Publisher to resolve issues with travis build - remove extraneous space
* Added Support for System Wide Dark Theme
* changed methods to private
* Moved Strings to strings.xml
* Used Dagger to reduce code repetition
* Changes made as per review suggestions
* Minor Changes
* Fixes as per suggestions
* Minor Fixes as per suggestion
* made the variables static
* removed irrelevant code
It's common for users to expect that re-opening the app would
allow them to "continue where they left off". This also applies
for the case where they leave the app after opening an
external link. It's natural for them to expect that they would
see the webpage they left open when they re-open the app. This
doesn't happen for our app as we open custom tabs in a separate
activity. As a consequence, this makes the experience
un-intuitive.
Fix this by opening custom tabs in the same activity.
Fixes: #2944
Co-authored-by: Adam Jones <jones_adam@rocketmail.com>
