Commit graph

4497 commits

Author SHA1 Message Date
Dmitry Brant
c21cc83eb5 Update to API 28, and fix CI issues. (#2595)
* Update gradle version.

Also update jacoco plugin to work with latest gradle.

* Update target sdk to 28.

* Update other dependencies to latest versions.

* Remove totally unused(?) local jar file.

* Remove dependency on nineoldandroids.

The functions it provides are no longer necessary.
This also removes a homemade "evaluate" function, which is readily
available in the Support library.

* Remove dependency on Traceur.

This library has not been updated in two years (may no longer be maintained?), and no longer works with
the latest RxJava.

* Enable test coverage only when performing CI.

Running test coverage on every single build while developing in the IDE is quite a waste of time.

* Suppress gradle Notes and Warnings from reflection-using packages.

The build output was getting extremely long, and was actually causing
the build to fail because of the sheer size of the log.

* Suppress gradle Note messages during tests and CI.

Stop CI messages from exploding to 10k+ lines.

* Temporarily remove instrumented test(s).

The project's instrumented tests consist of a single test which sets a
SharedPreference, then verified that the SharedPreference was set.

I humbly submit that this is not worth the trouble of having the CI
server download the system image, spin up an emulator, load the APK, and
run it just for this purpose.

Once the instrumented tests are ready for prime time, we can reinstate
instrumented tests in CI.
2019-03-15 08:30:08 +05:30
translatewiki.net
8dbeb6eba0 Localisation updates from https://translatewiki.net. 2019-03-14 13:01:12 +01:00
Silky Priya
503887673b Label wraps in Achievements (#2577)
* Support long text

* make text right aligned in rtl layout
2019-03-13 12:19:59 +05:30
Zhao Gang
62c14ecb66 Make DeleteTask notification quieter on some devices(Fixed #2528) (#2538)
As commit ab4fca5e does, this commit fixed the repeated notification
alarms in DeleteTask.class.

Since progress indication in notification can be cleared by calling
.setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class).
This commit also refactored notification related code in UploadService.class.
Make progress and failed notification uses the same notificationBuilder.
2019-03-12 14:19:09 +03:00
Zhao Gang
52724b8be0 Add setting Picture_Has_Correct_Location prefs(Fixed #2530) (#2536)
Update Picture_Has_Correct_Location prefs in method handleImage. This
fixed an issue that this prefs is not set and related wikidata
can't be updated.
2019-03-12 17:02:51 +09:00
Silky Priya
9d03274e2f Change place bookmarks buttons color (#2570)
* change bookmarks row button color

* different button color for dark and light mode

* Resolve Merge Conflict
2019-03-12 00:34:09 +05:30
Vanshika Arora
6389b35b49 replaced icafe with metadata extractor (#2546)
* replaced icafe with metadata extractor

* replaced icafe with metadata extractor

* removed icafe from gradle

* removed icafe from gradle

* Revert: travis commented code

* Use original content URI

* merged pr

* commit after merge

* modified unit tests
2019-03-12 00:20:47 +05:30
Vanshika Arora
2e23658b77 resolved rtl issue in category (#2567)
* resolved rtl issue in category

* combined nested if

* modified code
2019-03-11 21:39:29 +05:30
Silky Priya
0a3d8c09a7 Effective UI in nightmode (#2574)
* change bookmarks row button color

* achievement_background

* Change UI for nightmode

* revert first commit, change color of buttons in bottom_sheet in night mode
2019-03-11 21:38:44 +05:30
Vanshika Arora
d1a7b2cbfe resolved progressbar overlap issue (#2575) 2019-03-11 21:37:49 +05:30
translatewiki.net
fb703ec177 Localisation updates from https://translatewiki.net. 2019-03-11 11:15:25 +01:00
Ronan Brigdale
480c05b2f3 Fix Lint Issues #171: Fix numerous errors/warnings (#2537) 2019-03-10 23:55:35 +05:30
Oluwadara Abijo
d9fa31242f Wrap and enlarge title edit text (#2572) 2019-03-10 23:48:36 +05:30
Vivek Maskara
fd82c8aed9 Fix travis config 2019-03-10 17:43:56 +05:30
Vivek Maskara
ad1f92aa7d With travis config fixed 2019-03-10 17:29:07 +05:30
Vivek Maskara
653a068200 With release notes directory 2019-03-10 16:56:10 +05:30
Vivek Maskara
f9fb465309
Include release notes with alpha releases (#2571) 2019-03-10 16:10:49 +05:30
Oluwadara Abijo
6de0731a52 strings: add spacing after "Uploaded by:" in French (#2568) 2019-03-10 11:44:54 +05:30
Vanshika Arora
3295c6d972 resolved issue with german in no_notification (#2569) 2019-03-10 11:43:04 +05:30
Vanshika Arora
0c717ecad1 removed inactive icons from the bottom panel in nearby (#2549)
* removing inactive icons

* removing inactive icons

* requested changes
2019-03-09 10:44:12 +05:30
Vanshika Arora
8733b7f315 fixed campaign layout for right to left languages (#2550)
* fixed campaign layout for right to left languages

* alignment
2019-03-09 10:43:24 +05:30
deniger
a4238c03df #2332 add param "uselang" in notifications API calls. (#2555)
The value is the user language. If null or empty the value "user" is used
2019-03-09 10:43:02 +05:30
Silky Priya
b673527467 achievements in right-to-left layout (#2557) 2019-03-09 10:42:46 +05:30
Silky Priya
32752c2d1e Fab in landscape (#2559)
* fix fab in landscape orientation

* fixes fax in landscape orientation
2019-03-09 10:42:26 +05:30
translatewiki.net
80225360f8 Localisation updates from https://translatewiki.net. 2019-03-07 16:07:39 +01:00
Moksh Mahajan
7480d00a8c Placed google as first priotity repo (#2543) 2019-03-06 18:38:36 +05:30
srinivas1729
0c2ae1df18 Fix #2139: Now showing "Upload your media" text properly (#2539)
* "Upload your media..." text was being shown while contributions were
  still being loaded. Fixed things to show after load is finished and no
  contributions are present. Also updated text string since UI now uses
  FAB button for uploads (no camera/gallery) icons any more.
* Removed waitingMessage in ContributionsListFragment and from layout
  since its never VISIBLE, only GONE.
2019-03-06 00:36:08 +05:30
Christian Fotteler
def0d3da43 Fixes Lego Messages in strings.xml for "uploaded_by_myself" and changes the message generation in "ReasonBuilder.java". Adds translations for "uploaded_by_myself"-String in English, German, French, Spanish and Dutch. (#2532) 2019-03-05 23:21:41 +05:30
Ronan Brigdale
de9a72d465 Fix Lint Issues #171: Remove unused imports (#2533)
* Fix Lint Issues #171: Remove unused imports

Removed unused Java imports

* Fix Lint Issues #171: Perfromance issue, close cursor

Cursor was not closed when no longer needed
2019-03-02 19:30:50 +05:30
Ashish Kumar
1b86726364 Bugfix #2476 (#2527)
updated database version and added associated tests
2019-03-01 06:14:36 +13:00
Zhao Gang
ab4fca5ea9 Make uploading file notification quieter on some devices(Fixed #2528) (#2529)
Add setOnlyAlertOnce flag to NotificationCompat.Builder. This fixed
the issue that notification makes an alarm(beep) every time uploading
progress updated on some devices.

Also let UploadService.class reuse NotificationCompat.Builder as much
as possible(instead of creating a NotificationCompat.Builder every
time in method uploadContribution). And some small refactors.
2019-03-01 06:12:47 +13:00
Ashish Kumar
64eae8be82 Bug fix issue #2476 (#2526)
* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery
2019-02-28 05:55:16 +13:00
Shridhar Goel
6365815e0d Toggle state of bottom card on click (#2391) 2019-02-27 02:03:59 +05:30
Madhur Gupta
ef6fd9f292 Fix Bug #2477 (#2488) 2019-02-27 01:58:15 +05:30
Madhur Gupta
5dffea4242 Fix Bug #2489 (#2491)
* Fix Bug #2489

* Removed Unused import Log statement
2019-02-27 01:57:43 +05:30
Vanshika Arora
105e5d7894 Made nearby notification also visible to right-to-left languages (#2365)
* Fixed Issue #2334

* resolved gradle changes

* changed gragle.wrapper
2019-02-27 01:55:27 +05:30
Blesson Thomas
b244e403c2 Fix achievements activity share option (#2416) (#2478)
* Use fileProvider instead of Uri.fromFile()
* As Uri.fromFile() will not work on Android 7.0+, with a targetSdkVersion of 24 or higher, throws FileUriExposedException
2019-02-27 01:53:56 +05:30
Madhur Gupta
5a9cce0f79 Add Device Support Information to Feedback Intent #2494 (#2499)
* Add Device Support Information to Feedback Intent #2494

* Update Device Support Information for Feedback Intent #2494

* Update Device Support Information and used common method for Feedback Intent #2494

* Optimise code for Device Support Information for Feedback Intent #2494
2019-02-27 01:49:59 +05:30
Vanshika Arora
ad4c444c92 Fixed issue #2369 (#2516) 2019-02-27 01:42:15 +05:30
Vivek Maskara
5bcb2a41fd Fix duplicate param information (#2515) 2019-02-26 05:24:37 +13:00
Vivek Maskara
80557a02df
Fix string resource value (#2513)
Fixes #2512
2019-02-25 15:16:35 +05:30
translatewiki.net
831970112d Localisation updates from https://translatewiki.net. 2019-02-25 10:39:24 +01:00
Vanshika Arora
3a822d3c30 Added IPTC reader (#2383)
* graddle changes

* readfbmd class

* jar files

* added icafe

* gradle changes

* ReadFBMD

* recent commit

* commit changes

* commit changes

* fixed code quality issues

* optimised imports

* changes for  reviews

* not instantiating class

* removed irrelevant code

* added documentation

* modified test cases

* commit changes

* modified variable

* modified variable

* javadoc

* test changes

* removed .log file

* Show warning dialog for FBMD
2019-02-24 23:16:22 +05:30
Zhao Gang
00b95ea9cf Remove unused string values(Fixed #2448) (#2484)
These string values are not used in layouts and java files. So just
remove them.
2019-02-22 20:02:55 +05:30
Ronak Lakhotia
01a7526477 Fix code quality issues (#2359)
* Minor changes

* Fix more errors

* Revert change

* Minor error fix

* Remove unused import

* Merge branch 'master' of github.com:commons-app/apps-android-commons into lint-errors

# Conflicts:
#	app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java

* Minor changes

* Undo changes

* Undo performclick
2019-02-22 14:51:58 +05:30
Zhao Gang
9882d24651 Clean up placeholders in media detail fragment fields(Fixed #2471) (#2500)
Remove placeholders and let these descriptions only shown in Android
Studio layout preview. Use plain text in tools:text attributes so
relative string values can also be removed and ease the translation work.
2019-02-22 11:13:31 +05:30
Josephine Lim
02be443269 Merge branch '2.10-release' 2019-02-21 21:07:57 +10:00
Josephine Lim
a48e000e15 Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2019-02-21 21:03:42 +10:00
Josephine Lim
51cf902573 Merge branch '2.10-release' 2019-02-21 21:03:33 +10:00
Josephine Lim
e9b696c553
Versioning and changelog for v2.10.1 (#2501)
* Update changelog.md

* Update build.gradle

* Versioning for v2.10.1

* Update changelog.md
2019-02-22 00:01:45 +13:00