Commit graph

2397 commits

Author SHA1 Message Date
benryder1988
a94a28f743
Removing setText calls which seem prevent text selection (#4520) 2021-08-06 11:43:09 +03:00
neslihanturan
a584c8f239
Add nullcheck (#4530) 2021-08-02 19:25:07 +10:00
neslihanturan
ee81877ebb
This error seemed to occur on compositeDisposable.clear() so null checked there (#4525) 2021-07-26 15:17:34 +10:00
benryder1988
2a9ae73750
Fixes #4455 - Warning when pressing "back" in upload wizard (#4519)
* Overrides the back button during upload with dialog

* Removing unneeded import
2021-07-23 20:40:41 +09:00
Ayan Sarkar
3b7aa0376d
Added option for sharing achievements and a back button in ProfileActivity (#4489)
* UI done

* Share added

* Minor modification

* tests added

* tests added

* tests added

* modified

* modifications

* modification

* Entered if

* Entered if

* 97% coverage

* Separate

* Minor modifications

* Minor modifications
2021-07-18 05:40:32 +05:30
neslihanturan
ec89a3377a
Add an else case where crash logs are null means there is no crash (#4506) 2021-07-15 01:05:04 +10:00
Madhur Gupta
8793d45f30
Remove duplicate code which was added during merge (#4504) 2021-07-14 16:19:43 +10:00
Madhur Gupta
1e0d7fb76b Fix #4482 (#4484) 2021-06-30 19:44:10 +10:00
Ayan Sarkar
51d06c1ef4
Tutorial removed from log out state (#4479)
* tutorial removed from log out state

* Issue removed
2021-06-29 18:12:30 +09:00
Ayan Sarkar
e9a2c32527
Added option to show and modify location while uploading (#4475)
* initial commit

* Everything done

* minor modification

* minor modification

* Issues fixed

* minor modifications

* issue fixed

* Issues fixed
2021-06-29 18:02:20 +09:00
Ayan Sarkar
8db381885b
Removed next button in quiz (#4382)
* issues resolved

* modification done

* warning fixed

* issues resolved

* Button added

* don't know function added

* Button added

* modification done

* modification done
2021-06-27 18:34:33 +09:00
Ashar
399d798159
Main activity title is sometimes "Contributions", sometimes "Commons" (#4472)
Fixes #4438  Replace == with equals() in onRestoreInstanceState
2021-06-23 19:15:39 +03:00
Madhur Gupta
7a74549b59
Fix #3792 Missing Column Issue (#4468)
* Fix Missing Column Issue

* Fix tests
2021-06-21 14:01:00 +10:00
Jamie Brown
ca9f6f5e47
Fixes #4437 - Changed indentation on files with 2 spaces to 4 spaces (#4462)
* Edited Project.xml to make indent size 4

* Changed files with 2 space indentation to use 4 space indentation

* Edited Project.xml to make indent size 4

* changed files with 2 space indent to 4 space indent

* fix :Back Pressed Event not work in Explore tab when user not login (#4404)

* fix :Back Pressed Event not work in Explore tab

* minor changes

* fix :Upload count or number of contribution does not get updated when media  is successful uploaded (#4399)

* * fix:Number of Contributions not updated
 * Add javadocs

* minor changes

* made minor changes

* String was nonsense and untranslatible, fixed (#4466)

* Ability to show captions and descriptions in all entered languages (#4355)

* implement Ability to show captions and descriptions in all entered languages
*Add Javadoc

* handle Back event of fragment(mediaDetailFragment)

* fix minor bugs

* add internationalization

* revert previous changes

* fix visibility bug

* resolve conflict

Co-authored-by: Prince kushwaha <65972015+Prince-kushwaha@users.noreply.github.com>
Co-authored-by: neslihanturan <tur.neslihan@gmail.com>
2021-06-21 12:33:11 +09:00
Prince kushwaha
b202f553f0
Ability to show captions and descriptions in all entered languages (#4355)
* implement Ability to show captions and descriptions in all entered languages
*Add Javadoc

* handle Back event of fragment(mediaDetailFragment)

* fix minor bugs

* add internationalization

* revert previous changes

* fix visibility bug

* resolve conflict
2021-06-18 22:30:14 +09:00
Prince kushwaha
13528bcabd
fix :Upload count or number of contribution does not get updated when media is successful uploaded (#4399)
* * fix:Number of Contributions not updated
 * Add javadocs

* minor changes

* made minor changes
2021-06-18 20:01:37 +09:00
Prince kushwaha
2a2d2879a9
fix :Back Pressed Event not work in Explore tab when user not login (#4404)
* fix :Back Pressed Event not work in Explore tab

* minor changes
2021-06-18 18:42:41 +09:00
neslihanturan
6df35e21a9
Fix doom version issue (#4463)
* Update db version

* DBOpenHelper version update
2021-06-17 23:36:36 +10:00
Pratham Pahariya
22f61195b2
fix edit categories ui (#4414)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-06-17 21:49:09 +09:00
Pratham Pahariya
3494fd05a2
fix-issue-4424 (#4445)
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-06-17 21:40:32 +09:00
Jamie Brown
a3cbe3659c
Typo fixes (#4461)
* Fixed typo on class documentation of TextUtils

* corrected comma placement in documentation

* Fixed typos in comments
2021-06-17 11:53:17 +09:00
Brigham Byerly
2be828c50e
Fixes #3694 Pre-select places as depictions (#4452)
* WikidataEditService: stop automatically adding WikidataPlace as a depiction

When the user initiates the upload process from Nearby and also manually adds the place as a depiction, the depiction is added twice. Since this behavior is invisible to the user, it is being removed in preparation for auto-selecting the place as a depiction on the DepictsFragment screen.

* DepictsFragment: auto-select place as a depiction

Pass the Place reference from UploadActivity to DepictsFragment and select the corresponding DepictedItem. Using the place id, retrieve the corresponding Entity to create and select a DepictedItem.

* UploadRepository: use Place from UploadItem to obtain a DepictedItem

Instead of passing a Place object from UploadActivity to DepictsFragment and then passing the Place object up the chain to obtain and select a DepictedItem, retrieve the Place object directly within UploadRepository

* DepictsFragment: select Place depiction when fragment becomes visible

* UploadDepictsAdapter: make adapter aware of selection state

Update selection state when recycled list items are automatically selected, preventing automatically selected items from appearing as unselected until they are forced to re-bind (i.e. after scrolling)

* DepictsFragment: pre-select place depictions for all UploadItems

If several images are selected and set to different places, pre-select all place depictions to reinforce the intended upload workflow philosophy (i.e. all images in a set are intended to be from/of the same place). See discussion in commons-app/apps-android-commons#3694

* DepictsFragment: scroll to the top every time list is updated
2021-06-17 10:09:41 +09:00
Ashish
10ed6678b3
Fixes 4344 - Duplicate Uploads (#4442)
* Fixes 4344
- Update the retention policy of the Work Manager to ExistingWorkPolicy.APPEND_OR_REPLACE- which would append the new work to the end of existing one. This helps remove the while loop in UploadWorker which was meant to handle the cases where a new worker would be created for retries. The while loop seemed to have race conditions uploading duplicate entries.

* Update states to IN_PROGRESS before uploads are processed
2021-06-14 14:57:15 +03:00
neslihanturan
70851fa155
Some build issues occured merging release v3.0 are fixed. One paranthesis issue is solved, a method about UploadService is removed, since we don't use it anymore. (#4451) 2021-06-14 16:25:37 +10:00
Ayan Sarkar
20f74a90c4
Added a feature for editing coordinates (#4418)
* not

* Place Picker added

* Pick location and API call linked

* minor warnings resolved

* Code conventions followed

* issue fixed

* Wikitext edited properly

* minor modification

* Location Picker added

* Bottom sheet removed

* Location picker fully implemented

* credit added

* credit added

* issues fixed

* issues fixed

* minor issue fixed
2021-06-13 12:36:47 +09:00
Josephine Lim
ca75f616d2
Merge v3.0.1 into master (#4446)
* Versioning and changelog for v3.0.0 (#4152)

* Versioning for v3.0.0

* Update changelog.md

* Handled migration 8-9-10 in BookmarksLocationDao (#4154)

* #Fixes #4141
- Handled migrations for BookmarkLocationsDao from 8-9-10

* #Fixes #4141
- Handled migrations for BookmarkLocationsDao from 8-9-10

* Fixes #4179 (#4180)

* Handled null pointer exception in MainActivity->ContributionsFragment#backButtonClicked()
* Updated >ContributionsFragment#backButtonClicked() to handle back press properly

* Fixes #4179 (#4181)

* Handled possible null check on MediaDetails in BookmarkListRootFragment#backPressed()

* Cherrypick for hotfix3.1 (#4205)

* Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.

Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.

* fixed bug: App crashes on viewing review in Review Fragment #4132 (#4146)

* fixed bug:app crashes on viewing review in Review Fragment #4135

* Fixed the issue with back button in contribution tab. (#4177)

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>

* Fixed the issue with back navigation button on toolbar in explore tab. (#4175)

* Fix (#4148) Issues on theme change

* fixed themeChange crashes

* fixed comments

* Overlooked the title bar

Co-authored-by: Pratham Pahariya <54663429+Pratham2305@users.noreply.github.com>
Co-authored-by: Shabir Ahmad <56585337+shabar-shab@users.noreply.github.com>
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
Co-authored-by: Aditya-Srivastav <54016427+4D17Y4@users.noreply.github.com>

* Fixes #4173 (#4396)

* Fix #4147  Pre-fill desc in Nearby uploads with Wikidata item's label + description (#4390)

* Update query to fetch descriptions

* Make description added to NearbyResultItem

* Make string operations to display description and label in a combined way

* Fix reviews, remove long description from list and swap label and description texts

* Fix repeated information issue

* Fix double information issue

* fix style issues

* Remove douplicated information

* Changes made (#4354)

* Remove nonexistent method

* Fix #4283 IllegalStateException (#4440)

* Fix #4283 IllegalStateException

* Fix flickering issue

* Versioning for v3.0.1

* Update changelog.md

Co-authored-by: Ashish <ashishkumar468@gmail.com>
Co-authored-by: neslihanturan <tur.neslihan@gmail.com>
Co-authored-by: Pratham Pahariya <54663429+Pratham2305@users.noreply.github.com>
Co-authored-by: Shabir Ahmad <56585337+shabar-shab@users.noreply.github.com>
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
Co-authored-by: Aditya-Srivastav <54016427+4D17Y4@users.noreply.github.com>
Co-authored-by: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com>
Co-authored-by: Vinayak Aggarwal <56196007+vinayak0505@users.noreply.github.com>
2021-06-09 20:19:24 +10:00
obsidian-zero
feb75cbb9f
Fixes #4357 After switching to different account, contributions screen shows pictures of previous account (#4421)
* Update UploadMediaDetailFragment.java

* Update LoginActivity.java

Clear CompositeDisposable after logging in successfully. It may help solve the problem of saving the contribution to the previous account

* Revert "Update UploadMediaDetailFragment.java"

This reverts commit b1b4257f20.

Co-authored-by: Obsidian_zero <1198474846@qq.com>
2021-06-07 18:52:19 +03:00
Brigham Byerly
165c375bbd
UploadMediaDetail: replace discreet error toast with more-noticeable dialog (#4433) 2021-06-04 12:34:46 +03:00
Pratham Pahariya
ca18763e4f
Fixes #2815 - Nominating for deletion is cancelled on leaving the media details (#4295)
* fix issue with nominating for deletion

* Fix UI issue

* minor improvements

* fix App crash

* Added Javadoc and other minor improvements

* Updated string name

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-06-04 11:15:39 +09:00
Prince kushwaha
4fa18e5e27
In depictions selection screen, suggest recently selected items (#4361)
* implement in depictions selection screen to suggest recently selected items

*use RoomDataBase
* Add Javadoc

* fix an bug

* minar change and remove extra line of code

* minar changes

* improve implemention strategy

* fix unittest

* Add javadoc

* added javadoc
2021-05-31 19:19:55 +09:00
Ayan Sarkar
1408fe5e53
Made locale non dependent on phone OS settings, but choosable on app settings (#4366)
* setLocale added

* localization added

* test complete

* resolved conflicts

* issues resolved

* minor issues fixed

* Made methods concise

* Issues fixed
2021-05-15 23:30:03 +09:00
Ayan Sarkar
a78fea09d7
Added an option to Remove a new language description while uploading (#4406)
* implementation done modification required in card & more

* Remove button reversed

* Code beautification done

* Code beautification done

* minor issues fixed

* java docs added
2021-05-15 09:14:29 +09:00
Pratham Pahariya
c7f7b39151
Fixes #3380 - "Nearby Place found" despite already Nearby upload (#4408)
* fix issue with "nearby place found" pop up on nearby upload

* added javadoc

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-05-13 23:00:55 +09:00
Pratham Pahariya
2b62d8487b
Fixes #4286 - Contributions didn't appear after logging in again (#4337)
* fix the issue with contributions not appearing after logging in again

* fix old contribution appearing on top

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-05-10 19:28:32 +03:00
Prince kushwaha
0c8b92c7aa
Show media details fragment when on clicking image of Peer Review (#4374)
* * show MediaDetailFragment in ReviewActivity on image click
* Add javadoc
* Reformated code of  ReviewActivity xml

* fix typos

* add unit test

* made minor changes
2021-05-10 19:07:28 +03:00
Vinayak Aggarwal
117a7805ad
Fixes #4300 Limited connection mode banner occupies too much space (#4375)
* done

* fixed

* minor changes made

changed tv, Tv to text_view, TextView, improved comment for toggleDescriptionListener
2021-05-08 18:49:50 +09:00
Pratham Pahariya
845a901604
Fixes #4385 - App crash On categoryDetail activity when click on image after orientation change (#4397)
* fix issue 4385

* fix orientation change issue

* added javadoc

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-05-08 18:45:32 +09:00
Piyush Goel
cf7583abd4
Login error message is displayed in native phone locale language and not in just English. Fixes #4290 (#4389)
* Login error message is displayed in native phone locale language.

* Login error message is displayed in native phone locale language.
2021-05-03 09:37:14 +09:00
Aditya-Srivastav
f8a8f92070
Fixes #4329 "Back button in edit categories triggers back of media details." (#4346)
* Back button on fragment

* Handled back events

* minor changes

* removed extra lines
2021-04-19 17:19:27 +03:00
Ayan Sarkar
3369d96c49
READ_EXTERNAL_STORAGE permission is not necessary while picking file from gallery (#4356) 2021-04-19 13:31:01 +03:00
Ashish
8c7954a158
Fixes #4360 (#4363)
* Trigger API call to addDepictionsAndCaptions after succesfull upload from stash
2021-04-18 16:19:26 +09:00
Vinayak Aggarwal
bebc4afae2
Changes made (#4354) 2021-04-15 23:45:10 +09:00
Pratham Pahariya
58408cf2b0
Fixes #4297 - UI Issue: After changing the system theme from settings (#4332)
* fix UI issue after theme change

* removed unnecessary changes

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-08 20:51:07 +03:00
Prince kushwaha
153e57264d
fix:In setting Default description language option is needed to get disable when user is not login (#4342) 2021-04-08 19:37:58 +03:00
Ashish
ecbff7e3b8
Fixes #3790- Use WorkManagers to upload contributions (#4298)
* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Fixes #3790
Use WorkManagers to process upload contributions
** Removed UploadService and Added UploadWorker to process contributions Upload
** Made nescessary changes to remove the usages of the Service from the classes
** UI Fxies- Minor changes in the retry and cancel uplaod icons to give them a clickable area of 48 dp

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated JavaDocs in UploadWorker, Fixed Test cases

* Updated gradle

* Revert "Updated gradle"

This reverts commit c8979fe6dc.

* rolledback to compileSDKVersion 28, fixed tests

* Don't call the show notifications on the main thread

* Bug Fix- Duplicate contributions, handle upload stash errors
2021-04-08 15:59:07 +03:00
Ayan Sarkar
fd2a7a9c56
Fix SearchView is not visible properly in lower API devices (#4333) 2021-04-08 15:57:50 +03:00
Prince kushwaha
0d23e65e0f
fix:Setting Language list is not an language list which is supported by Commons for caption and description (#4325) 2021-04-07 23:33:47 +09:00
Prince kushwaha
12547fd34a
fix:App should respect device font-size (#4306)
* * Add adjuctFontScale function  to fix issue
* Add Javadoc

* reformed the codechange

* rearrange the codechange

* make metric and wm variable final
2021-04-06 17:47:38 +09:00
Pratham Pahariya
c269693625
Fixes #4296 - "Is this a picture of ...": Not too clear about which image it is asking me about (#4317)
* fix issue 4296

* minor improvements

* minor improvement

Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-04-05 17:03:11 +09:00
Ayan Sarkar
40b2619ccf
Added Help link in Alert Dialogue (#4315)
* READ MORE button added

* Added link to tips

* Fixed minor issues
2021-04-03 17:55:19 +09:00