Commit graph

4927 commits

Author SHA1 Message Date
Seán Mac Gillicuddy
80ea11f7d8
#3445 Add codestyle to git - import google java code style, use predefined styles for kotlin/xml (#3486) 2020-03-11 22:41:29 +10:00
taakanksha
61a3f45512
openStreetMap attribution enabled (#3485) 2020-03-11 09:51:38 +00:00
Vivek Maskara
bd668182b5
[WIP] Implemented Espresso tests for upload with multilingual descriptions (#2830)
* With more upload tests

* Fix tests

* Fix tests
2020-03-10 12:01:22 -07:00
Ashish Kumar
99c6f5f105
Shift contributions to use Room DB (#3324)
* Part of #3127
* Added Room Dependency
* Shifted ContributionsDao to use RoomDB

* Save and Fetch contributions via RoomDAO

* Bugfixes, fixed test cases, injected schedulers for ContributionsPresenter

* removed stetho

* Fixed ReviewHelperTest cases

* Fixed test cases in DeleteHelperTest

* Fetch all contributions [TODO add pagination to use this, maybe later in a seperate PR]

* Update Schema false in AppDatabase

* removed parameter from fetchControbutions

* Added logs for fetch contributions

* Fixed test case ContributionsPresenter

* Added an autogenerate primary key, submit save contributions on executor

* fixed getItemAtPosition

* MainActivity Config changes +=orientation

* BugFixes
* Make AppDataBase Singleton
* Set _id as autogenerate primary key [replacing the previously used filename, seems like they are not unique]
* Replace Execxutor Utils with Subscribers on Singles in UploadService
* BugFix, Upload Progress

* Remove un-nescessary null check on contributions in ContributionsListAdapter

* removed ContributionsListFragment [not-implemeted]

* Review suggested changes
* removed un-nescessary null checks
* provide ContributionsDao
* Minor bug fixes

* wip

* delete existing contributions table (from the existing db) on upgrade

* remove un-nescessary null checks in test classes

* shifted media to be a local variable in ReviewHelperTest

* removed captured folder

* Dispose composite disposables in UploadService

* replaced size check with isEmpty ContributionsPresenter

* transform saveContributions to a Completable

* Addressed comments in review
* Typo in Contributions
* ReasonBuilderTest (create media object instead of mocking)
* Use global Gson object instead of creating a new one in Converters

* Provide Gson to Converters from the CommonsApplicationComponent

* use static method instead of field instead of static field to provide GSON in Converters

* Modified gitignore to exclude captures/*
2020-03-10 00:13:20 +03:00
Kshitij Bhardwaj
642ed51c8c
Fixes #3414: For v2.13, Handle zoom in media details view (#3422)
* MediaDetailFragment: add zoom feature

* fragment_media_detail: add SimpleDrawee for Scroll picture

* ZoomableActivity: activity which facilitates zoom in

* activity_zoomable: xml for zoom activity

* zoomControllers: controllers for handling gesture and zooming

* MediaDetailFragment: fixing name of image variable

* MediaDetailFragment: display as per the aspect ratio of image

* add zoom activity to AndroidManifest

* fix travis ci faliure

* fix resizing of image
2020-03-09 21:07:48 +03:00
translatewiki.net
5fd88ef1a8 Localisation updates from https://translatewiki.net. 2020-03-09 16:34:48 +01:00
Seán Mac Gillicuddy
64179d0073
#3476 Use individual test commands on CI instead of check (#3477)
* #3476 Use individual test commands on CI instead of check - use individual commands and narrow scope

* #3476 Use individual test commands on CI instead of check - fix indentation
2020-03-09 12:16:28 +00:00
Kshitij Bhardwaj
7450b44ab7
Fixes #3295: Ultimate achievement: Too many contributions (#3378) 2020-03-08 17:09:38 +00:00
Anmol Gupta
16f1ba8640
About page: Update logos (#3472) 2020-03-08 13:31:12 +00:00
Vivek Maskara
11e878eb89 Comment out application id from default config 2020-03-06 20:56:53 -07:00
Seán Mac Gillicuddy
49ef5619a6
#3469 Update Gradle Play Publisher to resolve issues with travis build (#3470)
* #3469 Update Gradle Play Publisher to resolve issues with travis build - update GPP/Gradle and use jacoco-android fork with gradle 6.0 support

* #3469 Update Gradle Play Publisher to resolve issues with travis build - remove extraneous space
2020-03-06 23:07:53 +10:00
translatewiki.net
fa1d8bc20b Localisation updates from https://translatewiki.net. 2020-03-05 17:27:56 +01:00
Seán Mac Gillicuddy
1584ffe0e2
Added Support for System Wide Dark Theme (#3460)
* Added Support for System Wide Dark Theme

* changed methods to private

* Moved Strings to strings.xml

* Used Dagger to reduce code repetition

* Changes made as per review suggestions

* Minor Changes

* Fixes as per suggestions

* Minor Fixes as per suggestion

* made the variables static

* removed irrelevant code
2020-03-05 14:33:57 +00:00
Vivek Maskara
65ec071493
Fix existing Espresso tests (#3450)
* Fix existing Espresso tests

* Convert class to kotlin
2020-03-02 15:17:24 -07:00
translatewiki.net
36cafd7c39 Localisation updates from https://translatewiki.net. 2020-03-02 14:43:37 +01:00
Adam Jones
6a5afefbf5
Update mapbox, gradle and android plugin versions (#3443) 2020-03-02 13:17:36 +00:00
Kaartic Sivaraam
48b6745349
Open external links in same activity (#3395)
It's common for users to expect that re-opening the app would
allow them to "continue where they left off". This also applies
for the case where they leave the app after opening an
external link. It's natural for them to expect that they would
see the webpage they left open when they re-open the app. This
doesn't happen for our app as we open custom tabs in a separate
activity. As a consequence, this makes the experience
un-intuitive.

Fix this by opening custom tabs in the same activity.

Fixes: #2944

Co-authored-by: Adam Jones <jones_adam@rocketmail.com>
2020-03-02 19:59:26 +10:00
Madhur Gupta
e68751f0b9
Moved some Java files to kotlin (#3439)
* Converted NetworkConnectionType.java to Kotlin

* Converted Urls.java to Kotlin and Updated AboutActivity

* Improved code quality
2020-03-01 16:13:08 -07:00
Aristos Pasalidis
78057b6a8a
Fix #3091: Remove odd code in CategoryImagesListFragment (#3133) 2020-03-01 15:30:58 +00:00
Veyndan Stuart
7da5d130b7
Replace functions in FileUtilsTest with ones from kotlin-stdlib (#2943) 2020-03-01 13:32:29 +00:00
translatewiki.net
e3034918e7 Localisation updates from https://translatewiki.net. 2020-02-27 17:11:09 +01:00
Madhur Gupta
584fa2c778
Fixes #814 Added App Shortcuts (#3381)
* Fixes #814 Added App Shortcuts

* removed Review app shortcut

* Added Adaptive icons
2020-02-25 15:05:00 -07:00
Aryan Tyagi
fffff62f5c
Fixed a type in NearbyParentFragment.java where significantly was written instead of slightly while adding a log using Timber (#3432) 2020-02-25 13:56:50 +02:00
translatewiki.net
47155d1f55 Localisation updates from https://translatewiki.net. 2020-02-24 15:38:45 +01:00
Madhur Gupta
3d0048a771
Added progress dialog for setting wallpaper (#3427)
* Added progress dialog for setting wallpaper

* Updated dialog strings
2020-02-23 16:51:15 -07:00
Yash Khare
39cb190571
Fix #3416 Add snackbar on clicking add/remove from bookmarks (#3419) 2020-02-21 20:01:28 +10:00
translatewiki.net
d423dbb0be Localisation updates from https://translatewiki.net. 2020-02-20 15:57:46 +01:00
Kshitij Bhardwaj
96f4a5c08f
Fixes #3355 : Do not display pins at all when "Needs Photo" is selected (#3407)
* ic_custom_greyed_out_marker: removing grey marker

* NearbyParentFragment: changing function name and description

* change method name to hideAllMarkers
2020-02-19 20:43:19 +02:00
translatewiki.net
af97e40c13 Localisation updates from https://translatewiki.net. 2020-02-17 14:53:42 +01:00
gouri-panda
fd706cf3fd
fix typo #3417 (#3418) 2020-02-17 17:30:08 +09:00
Aastha Bist
4038519012
code-quality: remove CDATA and <u> tags from string.xml (#3310)
Remove CDATA and <u> tags from string resources. Instead use setUnderlinedText() method added in Utils to create underlined string resources.
2020-02-17 00:34:46 -07:00
Yash Khare
75d489128c
Fixes #3403 Add padding between privacy policy button and bottom of the screen (#3404)
Fixes #3403 Add padding between privacy policy button and bottom of the screen
2020-02-15 01:12:02 +10:00
translatewiki.net
bc602371ec Localisation updates from https://translatewiki.net. 2020-02-13 12:31:30 +01:00
Yash Khare
69e7161c61
Fixes #3197 Replace hardcoded dimensions with dimen resource values (#3402) 2020-02-11 21:26:33 -07:00
Animesh Kumar
9b3f3e9d3c
Fixed minor Login Bug (#3373) 2020-02-11 11:35:57 -07:00
Kaartic Sivaraam
6683ea40ec
Don't show the quiz pop-up twice (#3398)
* Avoid showing the quiz pop-up twice to the user

Due to the current flow of code it's possible that in
some cases the quiz pop-up is shown to the user twice.
This is unnecessary and unintentional.

So, change the logic in such a way that the quiz pop-up
would be never be shown twice to the user.

Fixes: #3281

* Quiz: remove unused parameters from methods

Some methods don't seem to be using the parameters that
they receive. So, just remove the unused parameters.
2020-02-11 11:28:07 -07:00
Yash Khare
b65e4a1841
Fix #3191 Make the username along with the rewards icon clickable in the Navigation Drawer (#3401) 2020-02-11 19:27:54 +02:00
translatewiki.net
eb400515ca Localisation updates from https://translatewiki.net. 2020-02-10 14:50:03 +01:00
Kaartic Sivaraam
e387e9a8d3
Hide Review for logged out users (#3390)
It makes sense to not show the review activity for logged
out users for the same reasons that we don't allow users
to upload images.

We're even considering to limit the review activity to users
with a particular level of achievement[1]. So, it's valid to
not show review activity for logged out users who don't
have achievements levels at all.

[1]: https://github.com/commons-app/apps-android-commons/issues/2852
2020-02-10 04:41:33 +10:00
Madhur Gupta
0049c8ba44 Fixes #3392 Fixed Nearby List Item Icon's Background (#3393) 2020-02-08 17:55:09 +02:00
Mudit Jain
81bb46f067
changing background color of conditions in nearby as uniform (according to chip state) (#3365)
Signed-off-by: Mudit Jain <ciphereck@gmail.com>
2020-02-07 15:39:47 +02:00
Madhur Gupta
3c93d801a1
Fixes #3382 Fixed Notification Message Icon Background (#3383) 2020-02-07 15:32:47 +02:00
translatewiki.net
b13d88837e Localisation updates from https://translatewiki.net. 2020-02-06 14:53:47 +01:00
Ashish Kumar
fdbe53d1e5
Fixes #3371 (#3372)
* Is UserBrowsing should first check if last known location is non-null before checkig if last location and current locations are close
2020-02-05 01:00:57 +10:00
Ashish Kumar
05e98307be
Fixes #3303 (#3322)
* Fixes #3303
* Refactor Nearby to alig lifecycle methods

* Pass updated place list to listfragment

* Added default zoom rate to mapbox

* Removed NearbyListFragmet and added the ui login to handle the same in NearbyParentFragment

* More code refactor
* Make BottomSheetList hideable
* onFragmentHide, hide the bottom sheets

* BigFix, Fragmet visibility, register/un-register camera move based on fragments lifecycke

* More code refactor
* Let the ExecutorUtil have non-ui thread
* Add Location Marker on non-ui thread (the non-ui stuffs)

* BugFixes
* Removed configchanges "orientation" from MainActivity in Manifest (That was messing with the fragment lifecycle)
* Some null checks
* Initialise lastknown location in onMapReady

* UI Fixes
* Adjusted UI to support dark and no-dark themes both (in nearby)
* Do not update map on Location Slightly changed

* Fix failing test case, let TestCommonsApplication extend Application instead of CommonsApplication

* start map view when nearby is visible

* start the map when NearbyFragmet is visible

* More bugfixes
* Added DUMMY view for NearbyPresenter's onDetach State
* Added a wrapper frame layout parent for MapView to preven it from drawing above other views

* More bugfixes (Fixes #3287)
* Gray out the un-selected markers from the nearby filter list

* BugFix, search this area should search the nearby places for the current camera position

* More BugFixes
* Handle null primitives with proxy
* Current location marker flow via permission flow

* onCameraMove should have null-check on NearbyController.latestSearchLocation instead of currentLocation

* Search for places around last focus location

* Handle location updates
* If the user is browsing the map, donot update the map with current location
2020-02-04 11:05:29 +02:00
Kshitij Bhardwaj
a6d2523588
Adds a Test for Method A categories search (#3366)
* CategoriesModelTest: add methodA test for categories search

* CategoriesModelTest: use lateinit wherever possible

* CategoriesModelTest: make method name meaningful
2020-02-03 08:33:40 -07:00
translatewiki.net
8e88b2de8a Localisation updates from https://translatewiki.net. 2020-02-03 15:39:00 +01:00
animeshk08
bfb6dfdeaf
Fix: Issue #3367 Bug: SoftKeyboard showing even after switching from nearby tab to contribution tab (#3368)
Hide keyboard when switched back from NearbyFragment to ContributionsListFragment
2020-02-03 01:54:00 +05:30
translatewiki.net
61bfe84594 Localisation updates from https://translatewiki.net. 2020-01-30 15:48:34 +01:00
Josephine Lim
0068820ac2 Merge branch '2.12-release' 2020-01-30 02:31:59 +10:00