Commit graph

2345 commits

Author SHA1 Message Date
Madhur Gupta
e68751f0b9
Moved some Java files to kotlin (#3439)
* Converted NetworkConnectionType.java to Kotlin

* Converted Urls.java to Kotlin and Updated AboutActivity

* Improved code quality
2020-03-01 16:13:08 -07:00
Aristos Pasalidis
78057b6a8a
Fix #3091: Remove odd code in CategoryImagesListFragment (#3133) 2020-03-01 15:30:58 +00:00
Aryan Tyagi
fffff62f5c
Fixed a type in NearbyParentFragment.java where significantly was written instead of slightly while adding a log using Timber (#3432) 2020-02-25 13:56:50 +02:00
Madhur Gupta
3d0048a771
Added progress dialog for setting wallpaper (#3427)
* Added progress dialog for setting wallpaper

* Updated dialog strings
2020-02-23 16:51:15 -07:00
Yash Khare
39cb190571
Fix #3416 Add snackbar on clicking add/remove from bookmarks (#3419) 2020-02-21 20:01:28 +10:00
Kshitij Bhardwaj
96f4a5c08f
Fixes #3355 : Do not display pins at all when "Needs Photo" is selected (#3407)
* ic_custom_greyed_out_marker: removing grey marker

* NearbyParentFragment: changing function name and description

* change method name to hideAllMarkers
2020-02-19 20:43:19 +02:00
Aastha Bist
4038519012
code-quality: remove CDATA and <u> tags from string.xml (#3310)
Remove CDATA and <u> tags from string resources. Instead use setUnderlinedText() method added in Utils to create underlined string resources.
2020-02-17 00:34:46 -07:00
Kaartic Sivaraam
6683ea40ec
Don't show the quiz pop-up twice (#3398)
* Avoid showing the quiz pop-up twice to the user

Due to the current flow of code it's possible that in
some cases the quiz pop-up is shown to the user twice.
This is unnecessary and unintentional.

So, change the logic in such a way that the quiz pop-up
would be never be shown twice to the user.

Fixes: #3281

* Quiz: remove unused parameters from methods

Some methods don't seem to be using the parameters that
they receive. So, just remove the unused parameters.
2020-02-11 11:28:07 -07:00
Yash Khare
b65e4a1841
Fix #3191 Make the username along with the rewards icon clickable in the Navigation Drawer (#3401) 2020-02-11 19:27:54 +02:00
Kaartic Sivaraam
e387e9a8d3
Hide Review for logged out users (#3390)
It makes sense to not show the review activity for logged
out users for the same reasons that we don't allow users
to upload images.

We're even considering to limit the review activity to users
with a particular level of achievement[1]. So, it's valid to
not show review activity for logged out users who don't
have achievements levels at all.

[1]: https://github.com/commons-app/apps-android-commons/issues/2852
2020-02-10 04:41:33 +10:00
Ashish Kumar
fdbe53d1e5
Fixes #3371 (#3372)
* Is UserBrowsing should first check if last known location is non-null before checkig if last location and current locations are close
2020-02-05 01:00:57 +10:00
Ashish Kumar
05e98307be
Fixes #3303 (#3322)
* Fixes #3303
* Refactor Nearby to alig lifecycle methods

* Pass updated place list to listfragment

* Added default zoom rate to mapbox

* Removed NearbyListFragmet and added the ui login to handle the same in NearbyParentFragment

* More code refactor
* Make BottomSheetList hideable
* onFragmentHide, hide the bottom sheets

* BigFix, Fragmet visibility, register/un-register camera move based on fragments lifecycke

* More code refactor
* Let the ExecutorUtil have non-ui thread
* Add Location Marker on non-ui thread (the non-ui stuffs)

* BugFixes
* Removed configchanges "orientation" from MainActivity in Manifest (That was messing with the fragment lifecycle)
* Some null checks
* Initialise lastknown location in onMapReady

* UI Fixes
* Adjusted UI to support dark and no-dark themes both (in nearby)
* Do not update map on Location Slightly changed

* Fix failing test case, let TestCommonsApplication extend Application instead of CommonsApplication

* start map view when nearby is visible

* start the map when NearbyFragmet is visible

* More bugfixes
* Added DUMMY view for NearbyPresenter's onDetach State
* Added a wrapper frame layout parent for MapView to preven it from drawing above other views

* More bugfixes (Fixes #3287)
* Gray out the un-selected markers from the nearby filter list

* BugFix, search this area should search the nearby places for the current camera position

* More BugFixes
* Handle null primitives with proxy
* Current location marker flow via permission flow

* onCameraMove should have null-check on NearbyController.latestSearchLocation instead of currentLocation

* Search for places around last focus location

* Handle location updates
* If the user is browsing the map, donot update the map with current location
2020-02-04 11:05:29 +02:00
animeshk08
bfb6dfdeaf
Fix: Issue #3367 Bug: SoftKeyboard showing even after switching from nearby tab to contribution tab (#3368)
Hide keyboard when switched back from NearbyFragment to ContributionsListFragment
2020-02-03 01:54:00 +05:30
Josephine Lim
0068820ac2 Merge branch '2.12-release' 2020-01-30 02:31:59 +10:00
Vivek Maskara
2290545bc9
Suggest and auto fill title and description based on image location (#3323)
* Suggest and auto fill title and description based on image location

* with java docs
2020-01-29 13:24:37 +03:00
Kshitij Bhardwaj
afdeaae075
Fixes: #3179 Make category search non case-sensitive (#3326)
* CategoryClient: fix category search case-sensitivity by converting to lower case as MW api is inherently case-sensitive, the results obtained will be same

* CategoryItem: reverting javadoc changes

* CategoriesModel: make category search case-insensitive

* CategoryItem: fix whitespaces

* Add tests for case-insensitivity

* CategoryClientTest: add more test cases

* CategoryClientTest: fix travis ci test

* CategoriesModelTest: changes mage to CategoriesModel and tested
2020-01-28 20:38:07 -07:00
Kshitij Bhardwaj
0affe71745 Fixes: #3278: Add java docs to methods which have it missing (#3351)
* achievements/: add Javadocs

* actions/: add Javadocs

* WikiAccountAuthenticator: add Javadocs

* ReasonBuilder: add Javadocs

* di: Add javadocs to DI files

* bookmarks: add Javadocs to bookmarks files

* di: Added more Javadocs

* file: add Javadocs for file picker

* actions: add proper decription to the classes
2020-01-28 11:45:15 -07:00
Somanshu
d235e5a85b Fixes #3327: Trim whitespaces from title on upload (#3348)
Trim WhiteSpaces from Image-Title while upload
2020-01-28 10:15:09 +05:30
Ashish Kumar
721d2feb45 Fixes #3336 Hotfix: Coordinates of picture are not uploaded (#3339)
* Fixes #3336
 * Donot redact locatio by default

* Correction inn default tag save

* Use same key across application for managedExifTags

* Updated key name to avoid class cast in existing build
2020-01-27 15:48:11 +03:00
Ashish Kumar
fa87eb5661 Fixes #3345 (#3350)
* Fixes #3345
* Trust all hosts for beta
* Added a custom NetworkFetcger for Fresco when on beta

* removed unused assets

* make TestCommonsApplication extend Application instead of Commons Application
2020-01-26 22:13:18 -07:00
Ashish Kumar
df426f7c42 Fixes #3320 (#3349)
* Fixes #3320
* Added SSL certificate for commons beta
* Asked OKHTTP client to use SSLContext from beta certificate
* Probable Fix of #3345

* Use ConfigUtils to verify flavor
2020-01-26 12:31:14 -07:00
Josephine Lim
0fb8f97b50 Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2020-01-22 22:57:10 +10:00
Josephine Lim
095d047370 Merge branch '2.12-release' 2020-01-22 22:57:02 +10:00
Ashish Kumar
bae3fa8bbf Fixes #3335 (#3337)
Handled sqlitexception for adding existig column in app versions which already have COLUMN location_pic
2020-01-22 03:22:35 +10:00
Malcolm Smith
14ea6c0cba Change tempalte character case from EXIF to Exif (#3330) 2020-01-20 12:42:49 -07:00
Kshitij Bhardwaj
cd4fc2cdf0 CategoryItem: add javadocs to the file (#3332) 2020-01-20 12:39:31 -07:00
Josephine Lim
ef9e2986b2 Versioning and changelog for v2.12.1 2020-01-20 00:21:24 +10:00
Ashish Kumar
824d6ac05e Bugfix/null revision in review (#3309)
* Fixes #3305
 * Handle null firstRevision

* initialise explanation
2019-12-24 14:02:56 +05:30
Vivek Maskara
a8ee5bd201 Fix UI tests (#3297) 2019-12-17 14:24:41 +03:00
Josephine Lim
e23b80dfcd Merge branch '2.12-release' 2019-12-10 23:52:22 +10:00
neslihanturan
959b3afd4c Fixes #3231 "Nearby" always first puts me in Punta Arenas (#3271)
* Update tables from 10 to 11

* Remove unneeded changes
2019-12-10 23:47:10 +10:00
Vivek Maskara
b0be4970ef Convert few model classes to kotlin (#3270) 2019-12-07 02:36:53 +10:00
Manuel Alcaraz
f7cca31c53 Optimize imports (#3272) 2019-12-06 17:51:36 +09:00
Vivek Maskara
2f9a71911a Remove unused code from the app (#3276) 2019-12-05 18:07:21 +05:30
Ashish Kumar
bb0a21929e Added unit-tests for CacheController (#3275) 2019-12-05 16:33:55 +05:30
Vivek Maskara
f27749fa51 With more unit test cases (#3269) 2019-12-04 18:51:02 +10:00
Ashish Kumar
fa7deb3d34 Closes #3262, npe in touching edit text drawable area while uploading images (#3263) 2019-12-03 17:44:56 +10:00
Ashish Kumar
1359f706d9 Closes #3264, disable options menu for null media from provider (#3265) 2019-12-03 17:44:48 +10:00
Ashish Kumar
452f799cb3 Fixes #3260, handle null latlng when adding current location marker (#3261) 2019-12-03 17:44:31 +10:00
Ashish Kumar
7b9e792efc Unit-Tests for Campaigns (#3258) 2019-12-03 00:41:10 +10:00
Vivek Maskara
9244c0015b Fix write to parcelable for Place object (#3248) 2019-12-01 17:03:08 +10:00
Ashish Kumar
36e0f766c9 Added more unit tests to UploadMediaPresenterTest (#3251) 2019-11-30 22:11:06 +05:30
neslihanturan
1c470241e3 Fix multiple current location marker issue (#3243) 2019-11-29 21:45:25 +05:30
neslihanturan
21503fc786 Disable current location button during markers load (#3238) 2019-11-30 00:18:53 +10:00
neslihanturan
3e5360ae4d Prevent NPE (#3241) 2019-11-30 00:18:05 +10:00
Vivek Maskara
cbd5ee1850 With artist information fixed (#3232) 2019-11-30 00:17:33 +10:00
neslihanturan
b3c11842f3 Fixes #1450 Add filter to nearby (#3178)
* Add layout items for nearby filter list and filter item

(cherry picked from commit b96f8a68ce)

* Edit nearby query

(cherry picked from commit 1f3c8c8deb)

* Add filter items to nearby parent fragment xml

(cherry picked from commit d0beadd0e0)

* Add icon for green marker

(cherry picked from commit f65ca0387a)

* Add layout util file to organize layout utilities

(cherry picked from commit 5c57939245)

* Add pic parameter to nearby result item

(cherry picked from commit 86007e4bb6)

* Add pic parameter to place type

(cherry picked from commit 25c358b67f)

* Add green marker styling

(cherry picked from commit 929c92d887)

* Inıt search layouts on Nearby parent

(cherry picked from commit 2ac38a1919)

* Style green markers at nearby controller

(cherry picked from commit 3e08f39f8e)

* Edit bookmark daos to include pic to tables

(cherry picked from commit 48d69edf3b)

* TODO foc bookmark dao item but works now

(cherry picked from commit f748399720)

* Style nearby filter area

(cherry picked from commit 6267e488b0)

* fix style of filter tab

(cherry picked from commit 5f843bf366)

* Add nearby list adapter

(cherry picked from commit 56334afe03)

* Current status, list size is working, visibility working, filter mechanism is ready

(cherry picked from commit 7d75c9c589)

* Filtering works

(cherry picked from commit 8a13cf7728)

* Filter function works

(cherry picked from commit 78368a2c0c)

* Fix style issues

(cherry picked from commit 2204f70255)

* Add divider to recyclerview

(cherry picked from commit c8100b55d7)

* Hide bottom sheets accordingly

(cherry picked from commit c5deba8b0b)

* Code cleanup

(cherry picked from commit cf8f64f3cb)

* Add actions to chips

* Fetch destroyed information from servers

* Add destroyed places icon

* Make chip filter functions work

* Revert irrelevant changes

* Revert accidentally replaced strings

* Remove unneeded lines

* Remove only places expalanation from trings

* Do not filter if nearby places are not loaded

* Add triple checkbox for add none and neutral

* Make tri checkbox work

* Fix travis issue

* Add coments

* fix search this area button locaton

* Set initial place type state and recover it between each populate places
2019-11-28 18:22:32 +10:00
Josephine Lim
5c6ab3b253 Fix date template (#3226)
* Add Traceur for getting meaningful RxJava stack traces (#1832)

* Hotfix for overwrite issue in 2.8.0  (#1838)

* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.

* Check if file title includes an extension already, by checking if is there any dot in it.

* Fix logic error

* Add uncovered tests

* Remove unecessary line breaks

* Make Javadocs more explicit

* Versioning and changelog for v2.8.2 (#1842)

* Versioning for v2.8.2

* Changelog for v2.8.2

* Fix data template for other source
2019-11-27 14:30:12 +05:30
Ashish Kumar
dd76110c87 Fixes #3223 (#3224) 2019-11-26 15:14:22 +10:00
Ashish Kumar
3f0c3bb92b Closes #3217 (#3220) 2019-11-25 13:09:18 +03:00