Gabriel Lee
7a04a2bf9c
Simplify peer review button text ( #3376 ) ( #4303 )
...
* Simplify peer review button text (#3376 )
The lengthy button text was not showing correctly, discussions concluded
that the button texts could be simplified to just "yes" or "no". To ensure
code read-ability, the buttons were renamed. Also made slight code style
adjustments to ReviewImageFragment.java and fragment_review_image.md.
Bug: #3376
* Remove string translate file changes from patch
2021-03-24 12:38:53 +03:00
Saumia Singhal
0857eae082
set icon frame visibility to View.GONE for all preferences ( #3863 )
2021-03-24 12:16:08 +03:00
Pratham Pahariya
944225c3a3
Fixes #4260 - Item with P582 (end time) shown as existing ( #4292 )
...
* fix issue with item with endtime shown as existing
* Removed destroyed and endtime, Added comments and also fixed the broken tests
* minor fix
* Added comments
* fix no such column location_exists error
* minor improvement
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-18 00:05:08 +09:00
Aditya-Srivastav
5c02b2fc0a
changed column name ( #4288 )
2021-03-04 16:55:21 +03:00
Aditya-Srivastav
7a5774e479
Fixes #4281 "Wrong language pre-selected in Nearby upload" ( #4285 )
...
* location added
* tests
* changes requested
* comments
* Test fixed, minor improvement
2021-03-04 15:51:28 +03:00
Fawziyah Alebiosu
91a5aa1abe
Delete categoryImagesActivity ( #3878 )
...
* deleted categoryImagesActivity test & activity
* deleted categoryImagesActivity reference in ActivityBuilderModule
* deleted categoryImages from manifest
* deleted categoryImages import from ActivityBuilderModule
* deleted categoryImagesActivity
2021-03-03 21:17:29 +03:00
Prince kushwaha
a4bdd23718
fix:Explore Search: No title bar for item, non-existent menu for item, wrongly-worded menu for category ( #4274 )
2021-03-03 15:39:42 +03:00
Aditya-Srivastav
9cf59f7801
fixes #4266 'Image Dimensions should be reduced if too large" ( #4279 )
...
* height restriction
* requested changes
* removed landscape drawee view
* javadoc
2021-03-01 23:37:44 +09:00
Pratham Pahariya
93cd89a34b
Fixes #4255 - Media details activity shows depictions in random languages, rather than in the user's locale ( #4275 )
...
* fixes issue with depiction names in random languages
* minor change
* using if conditions to check
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-03-01 20:50:09 +10:00
Aditya-Srivastav
0a857974f0
fixes #3440 "Campaign notification is not removed from Home even when disabling it in the setting" ( #4231 )
2021-02-27 19:27:06 +03:00
Pratham Pahariya
630c2a5dcd
#3732 - Nearby Tab Accessible Without Location Permission ( #4259 )
...
* Added ability to access nearby tab without location permissions
* added ability to remember user choice if the permission is denied.
* fixed the issue with permission dialog box in contribution tab.
* changed name for stored variables
* minor change
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-26 21:49:11 +09:00
Mrudul Tora
ba000eb26e
Fixes #4129 Resolved App crash on logging out from Contributors Tab ( #4257 )
...
* Resolved App crash on logging out from Contributors Tab
* Moved if condition in fetchContributions method
2021-02-26 17:21:16 +09:00
Pratham Pahariya
e82fdd0f4f
Fixes #2803 - Cancel nearby upload -> Next upload gets the same title/description
2021-02-23 16:42:41 +03:00
Mrudul Tora
6be9317eac
Hided Peer Review in Limited Connection Mode ( #4247 )
2021-02-23 16:06:00 +03:00
Mrudul Tora
0ec62170fc
Removed category editing accessibility when user not logged in ( #4251 )
2021-02-23 18:53:03 +09:00
Mrudul Tora
a83006fc7b
Fixed crashing on setting avatar when not logged in ( #4258 )
2021-02-23 18:43:32 +09:00
Aditya-Srivastav
f7d1fab566
Fixes #2252 "Tapping on map doesn't close tab in 'nearby'". ( #4265 )
...
* closing the list on tap ouside
* minor improvement
* minor changes
* javadoc
* official javadoc
* javadoc error
2021-02-23 17:17:11 +09:00
Pratham Pahariya
d81caf6a42
Fixes #4218 - In-App notifications appear on media detail fragment ( #4246 )
...
* Fixed issue with In-App Notification appearing on media detail view.
* Added a comment
* fixed style issues
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-22 19:00:28 +09:00
Aditya-Srivastav
7d8ea51c4f
Added bookmark section in not-logged-in version ( #4256 )
...
* added bookmark in not-logged-in version
* javadoc
* javadoc update
* spacing
* added unit test
2021-02-22 00:23:41 +09:00
Prince kushwaha
4f130e4dd0
fix:click on skip button in Peer Review after orientation change then app is crashed ( #4176 )
...
* #fixes-4143
In ReviewActivity overrides two function-> onResume() and onPause()
* Fixed the Bug-#4143
* reformed the codechange
* reformed the codechange
* Add javadoc
* Add javadoc
2021-02-21 10:58:07 +09:00
Mrudul Tora
9075b65ddf
Fixes #4244 - App crash in WikidataItemDetailsActivity resolved ( #4248 )
2021-02-20 21:35:28 +09:00
Aditya-Srivastav
68689980ee
fixed #4230 'Opening notifications in "Read" section still marks them read and removes them from the list'. ( #4249 )
...
* notifications fixed
* refractored
* javadoc
2021-02-20 10:00:22 +09:00
Pratham Pahariya
b8cdc5a537
Fixes #4229 - App Crashes while trying to nominate an item for deletion, When User is not logged in ( #4237 )
...
* Fixes the crash while nominating an item for deletion.
* removed unnecessary code
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-19 10:48:39 +09:00
Aditya-Srivastav
850d9411a5
Fixes #4211 "Location not available" while fetching location updates
2021-02-17 22:02:14 +10:00
Aditya-Srivastav
7cb5ff9167
Fixed #4232 App crashes on trying to upload a media from gallery. ( #4235 )
...
* ExifFixed
* requested changes
* requested changes
* indentation
2021-02-17 18:38:11 +09:00
Prince kushwaha
6293f90950
fix app crash in CategoryDetailsActivity ( #4233 )
...
Thanks Prince kushwaha!
2021-02-17 16:37:29 +09:00
Prince kushwaha
2695bbaf4b
fix- #2770 -Incomplete Nearby List shown in Landscape mode ( #4188 )
...
* fix-Incomplete Nearby List shown in Landscape mode (#2270 )
* fix-Incomplete Nearby List shown in Landscape mode (#2770 )
* added the setLayoutParams() method
* reformed the codechange
2021-02-15 21:01:48 +03:00
Pratham Pahariya
37c39ad55f
Fixed the issue with blank screen after changing the theme. ( #4220 )
...
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-02-15 23:52:35 +09:00
Taco
38f80687b1
Remove duplicate ViewPagerAdapter ( #4222 )
2021-02-15 21:50:30 +09:00
Taco
ee50bc8188
Update AndroidX Browser and ExifInterface to latest version ( #4223 )
2021-02-15 21:35:20 +09:00
Aditya-Srivastav
1a31265770
Fixes #4215 "Swiping on the last item in explore featured tab takes you to uploaded via mobile" ( #4227 )
...
* scrolling disabled on media details
* javadoc added
* javadoc modified
2021-02-15 14:41:55 +09:00
Prince kushwaha
944bede42d
fixes - #3559 - Failed to send thanks" notification, but thank actually sent successfully
...
I create another Model Class->"MwThankPostResponse.java" to store the Result of Post Request POST(MW_API_PREFIX+"action=thank")
2021-02-08 16:50:30 +03:00
Prince kushwaha
8384ad03dc
fixes - #1984 -Upload count does not get updated right away post successful upload
...
->implements the Callback method to update total number of media uploaded
2021-02-08 15:06:16 +03:00
Adam Jones
89737b2640
#747 : Convert action package (ThanksClient and PageEditClient) to Kotlin ( #4075 )
2021-01-23 14:36:01 +05:30
Pratham Pahariya
36406bad85
Fixed the issue with back button in contribution tab. ( #4177 )
...
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-01-22 01:30:25 +10:00
Aditya-Srivastav
b58d135b4c
Fixes #4178 Bookmarks not Updated in Picture section after remove
2021-01-20 20:35:33 +03:00
Pratham Pahariya
edef23f03d
Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.
...
Fixes #4159 On Explore Tab, All Available Options on toolbar in media detail view are only targeting the first media in the list.
2021-01-20 20:18:55 +03:00
Shabir Ahmad
e70fea64fb
fixed bug: App crashes on viewing review in Review Fragment #4132 ( #4146 )
...
* fixed bug:app crashes on viewing review in Review Fragment #4135
2021-01-20 18:06:08 +03:00
KushMehta1511
f3ee74d436
Update comments in ThanksClient.java ( #4183 )
2021-01-16 17:33:18 +05:30
Pratham Pahariya
ca82addb58
Fixed the issue with back navigation button on toolbar in explore tab. ( #4175 )
2021-01-15 12:42:43 +05:30
KushMehta1511
bd90497936
Updating comments in PageEditClient.java ( #4170 )
...
Description (required)
Fixes commons-app#4161
In the comments of the class PageEditClient.java "@param pagetitle" is written in three areas in this file. It should have been "@param pageTitle" with capital T as pageTitle is being passed as an argument rather than pagetitle.
What changes did you make and why?
Changes are made in the comments of fil where the parameters for Observable method are stated. pagetitle has been changed to pageTitle as the correct argument passed. This change would increase the code readability for fellow developers.
2021-01-13 13:36:18 +05:30
Aditya-Srivastav
c4bd23f7a1
Fix ( #4148 ) Issues on theme change
...
* fixed themeChange crashes
* fixed comments
* Overlooked the title bar
2021-01-11 17:21:44 +03:00
Prince kushwaha
2d884b44ca
Repull request of fixes #4081 App is crash when Backbutton is pressed from Favourites Fragment( #4104 )
...
fixes NullPointerexception in Favorities when backButton is pressed
2021-01-11 16:03:02 +03:00
neslihanturan
b06f875812
Fixes #4079 Menu item are not visible ( #4145 )
...
* Revert custom stylings of toolbar
* Enable back button on toolbar
2021-01-02 23:06:08 +10:00
Prince kushwaha
86c571ceee
fix app Crash when tapping on the nearbyNotification ( #4139 )
...
* bugfix-#4086
-> implement CallBack interface in MainActivity centerMapToPlace() function
* update previous commit
* reformed the codechanges
2021-01-01 19:33:35 +03:00
Aditya-Srivastav
7730112807
fixed the contribution crash on scroll ( #4128 )
...
* fixed the contribution crash on scroll
* Investigation
Just to get the Log of the issue
* fixed null data causing scroll to top
* Removed unneeded log import.
2021-01-01 18:10:10 +03:00
Pratham Pahariya
e1be458821
Fixed issue with notification count. ( #4126 )
...
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2021-01-01 17:09:48 +03:00
Prince kushwaha
6286607fc5
fixes In nearby tab when back button is pressed nothing happen( #4096 ) ( #4102 )
...
* fixes #4096
* reformed the codechange
* reformed the codechange
2020-12-29 00:32:55 +09:00
Saral Verma
c461f1134c
Fixed 4115 achievement issue ( #4138 )
2020-12-28 20:16:13 +10:00
Pratham Pahariya
5bdb21cb3e
Fixed issue with "Copy previous captions & descriptions". ( #4109 )
...
* Fixed issue with "Copy previous captions & descriptions".
* Added comments and also fixed the styling issue.
Co-authored-by: Pratham2305 <Pratham2305@users.noreply.github.com>
2020-12-27 19:48:57 +09:00
