Commit graph

4274 commits

Author SHA1 Message Date
Ashish Kumar
70099a9014 Feature/permissions library (#1855)
* Added permission for Dexter, the runtime permission handling library

* [Preparing fir issue #1773] Added a utility function which would take the user to app settings screen where he could manually give us the required permission

* Added an alert dialog with positive and negative callback [Preparing fir issue #1773]

* Improvements in the way External Storage Permission is handled in MultipleShareActivity[Bug fix #1697]
1. Used dexter to handle the external storage permission
2. Behaviour changes : When user tries to share(uppload) images to commons via MultipleShareActivity, following decision tree is followed
	a. If the app has permission for external storage, normal upload operation is followed
	b. If the app does not has the permission for external storage, dexter is used to ask for the same
	c. If the user gives us the required permission, normal upload flow is proceeded
	d. If the doesnot gives us the required permission a rationale dialog is shown with the appropriate message to let him know why we need the permission
	e. If he presses okay, steps a-c are followed and if he presses cancel, we close the app.
	f. If while asking for permission, the user chooses never ask again, then next time he tries to upload an image via MSA, the rational dialog follows the app setting screen where he could manually give us the required permission and the onActivityResult of same is handled

* Added a Constants class to handle request and result codes from one place and other related constants common to the all app elements

* replaced hardcoded strings ok and cancel in DialogUtil to string resources

* init permission rationale dialog in activities onCreate

* Code formatting, updated access modifiers wherever required, added javadocs for new methods created

* *shifted constants to app class
*Added JavaDocs in PermissionUtils

* removed class REQUEST_CODES from CommonsApplication and instead put the enclosing constants in the App class itself
2018-09-07 02:57:07 +10:00
Josephine Lim
dd6144bbdb
Update credits.md 2018-09-07 02:49:58 +10:00
Josephine Lim
78f83230ee
Update credits.md 2018-09-04 19:37:39 +10:00
translatewiki.net
2efd39bd14 Localisation updates from https://translatewiki.net. 2018-09-03 08:08:46 +02:00
Mansi Agarwal
3f52211b91 Add angle bracket (#1868)
app/src/main/res/values/strings.xml: Add the missing angle bracket.
2018-09-01 17:19:38 +10:00
Mansi Agarwal
430bf90310 Added CDATA tag (#1836)
* Fix issue#1772

Add the CDATA tag to welcome_help_button_text string. Set the text of the corresponding textview using Html.fromHtml() function.

* Fix issue#1772

Add the CDATA tag to nominated_see_more string. Set the text of the corresponding textview using Html.fromHtml() function.
2018-08-31 11:44:36 +03:00
Dmitry Brant
2884bd934a Remove dependency on Glide, Picasso, SVG, and multidex. (#1859)
* Eliminate the use of Picasso.

This gets rid of the single use of the Picasso library (which was causing
the whole library to be imported and shipped) and replaces it with Glide.
TODO: replace this and the other instance(s) of Glide usage with Fresco,
or vice versa.

* Remove dependency on Glide.

This removes the dependency on Glide, as well as the SVG rendering
library, whose only purpose was to display a single SVG image in the
Notification activity. Unfortunately Android doesn't support SVG natively,
but Echo notifications have icons that are SVG formatted. Rather than
import a bunch of heavy libraries to support this single case of SVG
rendering, we can simply create a few local drawables that correspond to
the different types of notifications, and use them instead.

* Remove multidex!

Multidex is a killer of performance and should be avoided at all costs.

* Remove further unused bits.

* Remove final vestige of multidex.
2018-08-30 14:40:17 +03:00
albendz
a059a3c2ef Add button on image details to copy wikicode to clipboard (#1849)
* Add button on image details to copy wikicode to clipboard

* Make copy wikicode button width the same as the nominate deletion button width by filling in background
2018-08-27 19:13:50 +10:00
Dmitry Brant
e945d45558 Work towards eliminating string literals from code. (#1861)
String literals are being used in many places in the code, instead of
proper string resources which are automatically localized. This PR
replaces many of the string literals with pre-packaged resources, or will
add the appropriate string if necessary.
2018-08-27 19:10:50 +10:00
translatewiki.net
b84e22c292 Localisation updates from https://translatewiki.net. 2018-08-27 07:39:43 +02:00
Ashish Kumar
355c4f5b0a Feature/nearby io fix (#1847)
* Bug fix issue #1839, changes
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor
* added null checks for the same varaible [Lets be safe side]
* replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier

* Bug fix issue #1846
1. Added null check in places in loadAttractionsFromLocation() in NearbyController
2. Catched exception in getFromWikidataQuery() which getFromWikidataQuery( )[Could be because of anything, primarily io].

* code formatting, adjusted whitespaces

* return places which is initialised to empty list instead of null for places

* replace catching Exception with the excact exception, ie. InterruptedIOException in NearbyPlaces
2018-08-24 22:36:23 +05:30
translatewiki.net
4baabab960 Localisation updates from https://translatewiki.net. 2018-08-23 08:13:52 +02:00
Ashish Kumar
e4584217d2 Bug fix issue #1839, changes (#1845)
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor
* added null checks for the same varaible [Lets be safe side]
* replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier
2018-08-22 10:13:36 +05:30
Vivek Maskara
4ea7229876 Null checks for activity to prevent unwanted crashes (#1730)
* Null checks for activity to prevent unwanted crashes

* With logs before return statements
2018-08-20 14:56:03 +03:00
Vivek Maskara
e13e2c2f40 Fix issue where beta prod flavour could not be installed at the same time (#1841) 2018-08-20 13:59:14 +03:00
translatewiki.net
73d5eb54f8 Localisation updates from https://translatewiki.net. 2018-08-20 08:06:30 +02:00
Yusuke Matsubara
6842420aeb Use NotificationChannel and prevent crash in API 26 (#1835) 2018-08-19 13:19:00 +03:00
translatewiki.net
7a43c59c80 Localisation updates from https://translatewiki.net. 2018-08-17 14:55:10 +02:00
Ashish Kumar
3cee4bbe3b Feature/bug fix#1793 (#1802)
* bug fix, locales not showing up in the spinner in ShareActivity [issue #1793]

* removed extra padding from the languages edit text in the spinner

* reduced weight percentage of spinner to 30% and increased that of the descriptions in row_item_descriptions to 70%
2018-08-17 03:51:55 +10:00
misaochan
61888f7456 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-14 17:59:48 +10:00
Josephine Lim
b17957dbb1
Versioning and changelog for v2.8.1 (#1827)
* Versioning for v2.8.1

* Update changelog.md

* Fix changelog.md typo
2018-08-14 17:58:32 +10:00
Vivek Maskara
7dee0a45b1 Fix category edits (#1823) 2018-08-14 02:47:23 +10:00
translatewiki.net
2fdcddd977 Localisation updates from https://translatewiki.net. 2018-08-13 08:08:25 +02:00
Amir Aharoni
a694ff1887 Fixes in grammar and punctuation in English translatable messages 2018-08-11 21:13:41 +09:00
Siddharth Vaish
81053a13b5 Username in nav drawer centrally aligned #1806 (#1817) 2018-08-10 00:45:57 +05:30
Siddharth Vaish
654ef80ff7 Renamed Set wallpaper to Set as wallpaper #1813 (#1818) 2018-08-10 00:45:31 +05:30
translatewiki.net
56675c91a4 Localisation updates from https://translatewiki.net. 2018-08-09 09:20:21 +02:00
Nicolas Raoul
78cab49544 Merge branch 'master' of github.com:commons-app/apps-android-commons 2018-08-08 16:48:57 +09:00
misaochan
98ed7beb33 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-08 17:38:01 +10:00
Josephine Lim
634814e9d0
Versioning and changelog for v2.8.0 (#1812)
* Increment version number to 87

Because 86 used for alpha release

* Update changelog.md
2018-08-08 17:36:56 +10:00
Ujjwal Agrawal
bf50e749ec Fixes #1801 (Media details view for Browse is lacking author field) in 2.8-release branch (#1810)
* In media search results, rotating screen triggers crash fixed #1753

* Updated API to get Author name too

* Crash fixed due to notifyDataSetChange

* search API duplicate images fixed
2018-08-08 17:15:06 +10:00
Nicolas Raoul
fa13c1b4f8 Merge branch 'fix_skip_login_nearby_bug' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-08 16:07:22 +09:00
Nicolas Raoul
e00f69a23d Merged from 2.8-release 2018-08-08 15:07:51 +09:00
Ujjwal Agrawal
87b6568abe search API duplicate images fixed 2018-08-08 04:12:06 +05:30
Ujjwal Agrawal
ecebe4c584 Crash fixed due to notifyDataSetChange 2018-08-08 03:37:48 +05:30
Ujjwal Agrawal
c93bcda6f6 Updated API to get Author name too 2018-08-08 01:02:41 +05:30
Ujjwal Agrawal
825a529003 Changed default value of skip login to false 2018-08-07 23:12:28 +05:30
Tanvi Dadu
a5d4e8f739 changed Icon (#1759) 2018-08-07 19:30:22 +10:00
Vivek Maskara
b5e90bea76 Wikidata edit fix (#1800)
Wikidata edit fix
2018-08-07 19:03:59 +10:00
Nicolas Raoul
f12f1d50a3 Merge branch 'skip_login' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-07 13:12:00 +09:00
misaochan
23014e07c8 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-06 18:36:35 +10:00
translatewiki.net
6f86299a90 Localisation updates from https://translatewiki.net. 2018-08-06 07:15:25 +02:00
Vivek Maskara
143ad00149
Fix failed uploads (#1790)
* Cusom Mediawiki api layer

* Fix tests
2018-08-05 01:26:00 +05:30
Ashish Kumar
b73535f621 added null check before initialising LatLng after receiving location … (#1791)
* added null check before initialising LatLng after receiving location permission

* flipped null==lastKL with lastKL==null
2018-08-04 21:33:57 +05:30
Josephine Lim
e32f8d3d36 Fix title/desc prefill bug (#1794)
* Move isDirectUpload putExtra above Wikidata edits try catch block

* Check value of boolean isDirectUpload in intent

* Change to getBooleanExtra to prevent NPE

* Fix whitespaces, logging, and lint issues
2018-08-04 21:33:31 +05:30
Josephine Lim
ff9f43ef8b Only do http logging if a debug build is run (#1795) 2018-08-04 21:13:10 +05:30
misaochan
f46da6639c Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-08-04 19:29:55 +10:00
misaochan
18fbd47535 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-04 19:29:50 +10:00
Ashish Kumar
12a83da3a2 Feature/localised image descriptions (#1634)
* wip

* Changes for adding descriptions in multipe languages[issue #1501]

* Added callback for the adapter

* Codacy suggested changes

* Sort the languages in the spinner in alphabetical order

* scroll view nested scrolling enabled false

* Nested scrolling enabled false [Allow rv to expand]

* rebased to master, resolved conflicts

* replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]

*     replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]
2018-08-03 18:09:37 +05:30
Mansi449
e4c518ccce removed repeated implementation statements 2018-08-03 11:48:01 +09:00