Manuel Lorenzo
304bf51f5f
Fixing some lint issues for #171
2018-02-07 11:32:24 +01:00
maskara
9c23a8c34b
Make login work across sessions
2018-02-06 01:52:53 +05:30
maskara
1ea0a1ebeb
Make 2FA login work with commons
2018-02-06 01:52:53 +05:30
misaochan
87fc6903b8
Added error logging
2018-01-31 23:25:06 +10:00
misaochan
b42340b03a
Return early if contributionsClient == null
2018-01-31 23:18:28 +10:00
misaochan
c80d106636
Add TODO for sole remaining flagged NPE
2018-01-22 16:55:32 +10:00
misaochan
00eb55692e
Make error logs more polite
2018-01-22 16:54:22 +10:00
misaochan
417013dcd8
Prevent NPE from string literal comparison
2018-01-22 16:51:02 +10:00
misaochan
895d64dce9
Prevent NPE from string literal comparison
2018-01-22 16:50:47 +10:00
misaochan
2d677d9dad
Add null check to line that causes crash
2018-01-22 16:48:33 +10:00
misaochan
6ea7367bf3
Add check for moveToFirst()
2018-01-22 16:47:42 +10:00
maskara
7c54e95321
More cleanup based on comments
2018-01-14 02:09:32 +05:30
maskara
eb3e448452
Refactoring based on comments
2018-01-13 23:59:45 +05:30
maskara
e1afa6081e
Refactor usage of dagger application with fixed dagger application
2018-01-13 16:16:47 +05:30
Paul Hawke
4bd72462e5
More cleanup now that clean Dao classes are available from Dagger.
2018-01-05 19:53:51 -06:00
Paul Hawke
874627e3f5
Injected the ModifierSequenceDao where needed.
2018-01-05 13:01:20 -06:00
Paul Hawke
9927879680
Injected the ContributionDao where needed.
2018-01-05 08:34:48 -06:00
Paul Hawke
08673c91c6
Extracted and tested the database interactions from ModifierSequence
2018-01-04 13:27:55 -06:00
Paul Hawke
7c80991049
Extracted and tested the database interactions from Contribution.
2017-12-21 13:56:36 -06:00
Paul Hawke
02b5b9b680
Merge branch 'master' into dependency-injection
2017-11-24 22:30:08 -06:00
Paul Hawke
f134d23ecb
Merge branch 'master' into dependency-injection
2017-10-21 17:20:56 -05:00
Sergey Kozelko
43af519a16
Fix Codacy issues
2017-10-18 21:57:57 +03:00
poojithakr
fc9cd0a3b7
Fixing codacy issues. Reduced reported count from 550 to 518.
2017-10-04 00:28:11 -07:00
Paul Hawke
e33febf506
Merge branch 'master' into dependency-injection
2017-09-23 14:24:34 -05:00
Paul Hawke
9c0cbe7ad5
Further reduce code calling back to the CommonsApplication by pulling out a SessionManager to manage our current account.
2017-09-09 14:08:40 -05:00
Paul Hawke
8cbf56fa7b
Java 5 / Java 8 language suggestions plus general cleanup.
2017-09-03 17:27:20 -05:00
Paul Hawke
d0a85dbd82
Moved single-use code out of Utils over to where it's actually used.
2017-08-26 08:57:16 -05:00
Paul Hawke
cfe17cafa6
Moved other singletons over to being managed by Dagger
2017-08-26 08:57:15 -05:00
Paul Hawke
647cc166ef
@Inject the MediaWikiApi where needed to reduce coupling between classes.
2017-08-26 08:56:15 -05:00
Paul Hawke
8fe2816ca9
First baby steps into the world of dependency injection using Dagger.
2017-08-26 08:56:14 -05:00
Mikel
79a22c1aca
Add missing annotations
2017-07-26 16:24:24 +01:00
Paul Hawke
c3649d3efd
Merge remote-tracking branch 'upstream/master'
2017-07-11 08:06:55 -05:00
Dmytro Vodnik
869790900b
fix for #733,732 issue
...
The problem is that onCreate of content resolver are calling before even Apllication onCreate, so that fields may be null which caused crashes
2017-07-10 17:31:32 +03:00
Paul Hawke
d64c1b51cc
Refactoring to not expose the ApiResult and Apache HTTP implementation
2017-07-04 16:34:30 -05:00
Paul Hawke
599e7bb453
Consolidated media wiki api calls in a single place
2017-07-04 14:24:08 -05:00
Deskana
4b7011a725
Remove redundant call to String.format() in CategoryModifier
...
This patch removes a call to String.format that can be replaced with a
literal string which is much clearer.
2017-05-26 11:08:02 +01:00
addshore
c712b561d4
Get rid of other singletons
2017-05-16 15:19:43 +02:00
addshore
bdfbdc7579
Cleanup CommonsApplication Singelton
2017-05-16 15:19:15 +02:00
Neslihan
aec4300a2e
Logout thing
2017-05-16 16:01:29 +03:00
addshore
d38dde0ec4
Use clientlogin API module
...
This is the first step to allowing 2 factor authentication #328 .
This uses the new API module clientlogin instead of the login module.
We still report the same set of errors in a 'nice' way with real
error messages, how ever there are lots more that can probably be
handled, for example #507 .
2017-05-12 14:36:58 +02:00
veyndan
d33935c70f
Use Timber for logging
2017-04-17 16:41:56 +01:00
Adam Jones
ea43e1a796
Fix Codacy Issues + remove unused patch
2017-03-23 17:51:13 +00:00
maskara
6cecaf9e8c
Fixes #426 : Crash fix caused by NPE
2017-03-12 14:18:41 +05:30
veyndan
d866ab3e07
Replace explicit type with diamond operator
2017-03-01 15:44:32 +00:00
Josephine Lim
9ef32612c1
Merge pull request #315 from anirudh24seven/optimize-imports
...
Reorganize imports across the project
2016-10-31 14:32:43 +13:00
Anirudh S
1a11e0afc0
Reorganize imports across the project
...
Remove unwanted imports and sort import statements by running Android
Studio's 'Optimize Imports' feature in all source files.
2016-10-30 23:14:07 +05:30
Anirudh S
94e8c991ee
Modified extra whitespace lines in source code
...
Code is much easier to read if there isn't too much of a gap between
lines. Primarily converted multi-line gaps into single line gaps.
2016-10-30 23:01:44 +05:30
misaochan
87df022431
Added notes for debugging
2016-07-07 18:04:56 +12:00
Yusuke Matsubara
b4231bbfdc
Merge "commons" into the project root directory
2016-07-02 16:48:57 +09:00