Commit graph

2548 commits

Author SHA1 Message Date
Mansi Agarwal
430bf90310 Added CDATA tag (#1836)
* Fix issue#1772

Add the CDATA tag to welcome_help_button_text string. Set the text of the corresponding textview using Html.fromHtml() function.

* Fix issue#1772

Add the CDATA tag to nominated_see_more string. Set the text of the corresponding textview using Html.fromHtml() function.
2018-08-31 11:44:36 +03:00
Dmitry Brant
2884bd934a Remove dependency on Glide, Picasso, SVG, and multidex. (#1859)
* Eliminate the use of Picasso.

This gets rid of the single use of the Picasso library (which was causing
the whole library to be imported and shipped) and replaces it with Glide.
TODO: replace this and the other instance(s) of Glide usage with Fresco,
or vice versa.

* Remove dependency on Glide.

This removes the dependency on Glide, as well as the SVG rendering
library, whose only purpose was to display a single SVG image in the
Notification activity. Unfortunately Android doesn't support SVG natively,
but Echo notifications have icons that are SVG formatted. Rather than
import a bunch of heavy libraries to support this single case of SVG
rendering, we can simply create a few local drawables that correspond to
the different types of notifications, and use them instead.

* Remove multidex!

Multidex is a killer of performance and should be avoided at all costs.

* Remove further unused bits.

* Remove final vestige of multidex.
2018-08-30 14:40:17 +03:00
albendz
a059a3c2ef Add button on image details to copy wikicode to clipboard (#1849)
* Add button on image details to copy wikicode to clipboard

* Make copy wikicode button width the same as the nominate deletion button width by filling in background
2018-08-27 19:13:50 +10:00
Dmitry Brant
e945d45558 Work towards eliminating string literals from code. (#1861)
String literals are being used in many places in the code, instead of
proper string resources which are automatically localized. This PR
replaces many of the string literals with pre-packaged resources, or will
add the appropriate string if necessary.
2018-08-27 19:10:50 +10:00
translatewiki.net
b84e22c292 Localisation updates from https://translatewiki.net. 2018-08-27 07:39:43 +02:00
Ashish Kumar
355c4f5b0a Feature/nearby io fix (#1847)
* Bug fix issue #1839, changes
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor
* added null checks for the same varaible [Lets be safe side]
* replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier

* Bug fix issue #1846
1. Added null check in places in loadAttractionsFromLocation() in NearbyController
2. Catched exception in getFromWikidataQuery() which getFromWikidataQuery( )[Could be because of anything, primarily io].

* code formatting, adjusted whitespaces

* return places which is initialised to empty list instead of null for places

* replace catching Exception with the excact exception, ie. InterruptedIOException in NearbyPlaces
2018-08-24 22:36:23 +05:30
translatewiki.net
4baabab960 Localisation updates from https://translatewiki.net. 2018-08-23 08:13:52 +02:00
Ashish Kumar
e4584217d2 Bug fix issue #1839, changes (#1845)
* Extracted out PageTitle object's member varaible, displayText in a variable in findTemplate() in MediaDataExtractor
* added null checks for the same varaible [Lets be safe side]
* replaced equals with contains, ie. displayText.contains(title), so that uploads from multiple sources which have different formats still show up coordinates which was not being shown earlier
2018-08-22 10:13:36 +05:30
Vivek Maskara
4ea7229876 Null checks for activity to prevent unwanted crashes (#1730)
* Null checks for activity to prevent unwanted crashes

* With logs before return statements
2018-08-20 14:56:03 +03:00
Vivek Maskara
e13e2c2f40 Fix issue where beta prod flavour could not be installed at the same time (#1841) 2018-08-20 13:59:14 +03:00
translatewiki.net
73d5eb54f8 Localisation updates from https://translatewiki.net. 2018-08-20 08:06:30 +02:00
Yusuke Matsubara
6842420aeb Use NotificationChannel and prevent crash in API 26 (#1835) 2018-08-19 13:19:00 +03:00
translatewiki.net
7a43c59c80 Localisation updates from https://translatewiki.net. 2018-08-17 14:55:10 +02:00
Ashish Kumar
3cee4bbe3b Feature/bug fix#1793 (#1802)
* bug fix, locales not showing up in the spinner in ShareActivity [issue #1793]

* removed extra padding from the languages edit text in the spinner

* reduced weight percentage of spinner to 30% and increased that of the descriptions in row_item_descriptions to 70%
2018-08-17 03:51:55 +10:00
misaochan
61888f7456 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-14 17:59:48 +10:00
Josephine Lim
b17957dbb1
Versioning and changelog for v2.8.1 (#1827)
* Versioning for v2.8.1

* Update changelog.md

* Fix changelog.md typo
2018-08-14 17:58:32 +10:00
Vivek Maskara
7dee0a45b1 Fix category edits (#1823) 2018-08-14 02:47:23 +10:00
translatewiki.net
2fdcddd977 Localisation updates from https://translatewiki.net. 2018-08-13 08:08:25 +02:00
Amir Aharoni
a694ff1887 Fixes in grammar and punctuation in English translatable messages 2018-08-11 21:13:41 +09:00
Siddharth Vaish
81053a13b5 Username in nav drawer centrally aligned #1806 (#1817) 2018-08-10 00:45:57 +05:30
Siddharth Vaish
654ef80ff7 Renamed Set wallpaper to Set as wallpaper #1813 (#1818) 2018-08-10 00:45:31 +05:30
translatewiki.net
56675c91a4 Localisation updates from https://translatewiki.net. 2018-08-09 09:20:21 +02:00
Nicolas Raoul
78cab49544 Merge branch 'master' of github.com:commons-app/apps-android-commons 2018-08-08 16:48:57 +09:00
misaochan
98ed7beb33 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-08 17:38:01 +10:00
Josephine Lim
634814e9d0
Versioning and changelog for v2.8.0 (#1812)
* Increment version number to 87

Because 86 used for alpha release

* Update changelog.md
2018-08-08 17:36:56 +10:00
Ujjwal Agrawal
bf50e749ec Fixes #1801 (Media details view for Browse is lacking author field) in 2.8-release branch (#1810)
* In media search results, rotating screen triggers crash fixed #1753

* Updated API to get Author name too

* Crash fixed due to notifyDataSetChange

* search API duplicate images fixed
2018-08-08 17:15:06 +10:00
Nicolas Raoul
fa13c1b4f8 Merge branch 'fix_skip_login_nearby_bug' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-08 16:07:22 +09:00
Nicolas Raoul
e00f69a23d Merged from 2.8-release 2018-08-08 15:07:51 +09:00
Ujjwal Agrawal
87b6568abe search API duplicate images fixed 2018-08-08 04:12:06 +05:30
Ujjwal Agrawal
ecebe4c584 Crash fixed due to notifyDataSetChange 2018-08-08 03:37:48 +05:30
Ujjwal Agrawal
c93bcda6f6 Updated API to get Author name too 2018-08-08 01:02:41 +05:30
Ujjwal Agrawal
825a529003 Changed default value of skip login to false 2018-08-07 23:12:28 +05:30
Tanvi Dadu
a5d4e8f739 changed Icon (#1759) 2018-08-07 19:30:22 +10:00
Vivek Maskara
b5e90bea76 Wikidata edit fix (#1800)
Wikidata edit fix
2018-08-07 19:03:59 +10:00
Nicolas Raoul
f12f1d50a3 Merge branch 'skip_login' of github.com:ujjwalagrawal17/apps-android-commons 2018-08-07 13:12:00 +09:00
misaochan
23014e07c8 Merge remote-tracking branch 'refs/remotes/origin/2.8-release' 2018-08-06 18:36:35 +10:00
translatewiki.net
6f86299a90 Localisation updates from https://translatewiki.net. 2018-08-06 07:15:25 +02:00
Vivek Maskara
143ad00149
Fix failed uploads (#1790)
* Cusom Mediawiki api layer

* Fix tests
2018-08-05 01:26:00 +05:30
Ashish Kumar
b73535f621 added null check before initialising LatLng after receiving location … (#1791)
* added null check before initialising LatLng after receiving location permission

* flipped null==lastKL with lastKL==null
2018-08-04 21:33:57 +05:30
Josephine Lim
e32f8d3d36 Fix title/desc prefill bug (#1794)
* Move isDirectUpload putExtra above Wikidata edits try catch block

* Check value of boolean isDirectUpload in intent

* Change to getBooleanExtra to prevent NPE

* Fix whitespaces, logging, and lint issues
2018-08-04 21:33:31 +05:30
Josephine Lim
ff9f43ef8b Only do http logging if a debug build is run (#1795) 2018-08-04 21:13:10 +05:30
misaochan
f46da6639c Merge branch 'master' of https://github.com/commons-app/apps-android-commons 2018-08-04 19:29:55 +10:00
Ashish Kumar
12a83da3a2 Feature/localised image descriptions (#1634)
* wip

* Changes for adding descriptions in multipe languages[issue #1501]

* Added callback for the adapter

* Codacy suggested changes

* Sort the languages in the spinner in alphabetical order

* scroll view nested scrolling enabled false

* Nested scrolling enabled false [Allow rv to expand]

* rebased to master, resolved conflicts

* replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]

*     replaced setCompoundDrawables with setCompoundDrawablesWithIntrinsicBounds [the former dint used to work on all devices]
2018-08-03 18:09:37 +05:30
Mansi449
e4c518ccce removed repeated implementation statements 2018-08-03 11:48:01 +09:00
VaishSiddharth
d7792d5861 In media search results, rotating screen triggers crash fixed #1753 2018-08-03 11:46:07 +09:00
Mansi449
781cfac7b1 changed 'login' to 'log in' 2018-08-03 11:41:27 +09:00
Ujjwal Agrawal
bf58fcab59 Fixed upload from gallery 2018-08-02 15:02:23 +05:30
Siddharth Vaish
911873379b Alignment of language selection dialog in About>Translate #1713 (#1776) 2018-08-02 19:14:56 +10:00
translatewiki.net
b0e962c85c Localisation updates from https://translatewiki.net. 2018-08-02 10:12:47 +02:00
neslihanturan
d29aa2e2e5 Fix urgent crashes A and E (#1749)
* Create utility class for contribution process

* implement method to save five from given URİ

* Add file utilities for directory checks

* Add ContributionUtils for saving file during upload

* Change method call acordingly with handleImagePicked() method

* Call method to save file temproarily when a photo to upload is chosen from contributions list.

* Call method to save file temproarily when a photo to upload is chosen from nearby list and map

* Arrange method call

* Write a method to save file temporarily during upload process. It will save the file to a internal path and it will be deleted by another method after upload process is done.

* Add a method to save a file to a given path from a content provider Uri

* On openAssetFileDescriptor method, use URi from temporarily saved file, instead of Contributions.getLocalUri which was Uri from content provider

* Edit uploadContribution method so that it will use FileInputStream from temporarily saved file, insdeat of the Uri from content provider.

* Make it work

* Code cleanup

* Add directory cleaner method

* Call temp directory cleaner method at the end of uplpoad process

* Use FileInputStream insted

* Add directory cleaner method

* Add file removal method

* Use external directory instead

* Make destination file name flexible

* Make it work with share action coming from another activity

* Make it work for Multiple hare Activity

* Code cleanup

* Solve camera issue

* Fix camera crash

* Cleanup

* Revert change of commenting out posibly useles code, because I am not sure if it is useless or not. Requires discussion

* Use timestamp in temoorary file names, so that we wont never create same file and access old file reference. It was a weird problem though

* Code cleanup

* Add nullable annotation to handleImagePicked method uri parameter

* Add Nullable anotation to method

* Code cleanup

* Bugfix: use uri.getPath() instead uri.toString

* Remove unecesarry file saving operation, which was added accidentally

* Fix travis fail

* Remove temp file if upload gets failed and file is still there

* Code cleanup:Remove unused parameters from removeTempFile method

* Empty temp directory on app create, in case some of files are still there

* Add null check to array to prevent NPE on first run

* Fix multiple uploads bug

* Remove file if upload is succeed

* Add external storage utility methods

* Check external file permission before saving files temporarily

* finish activity if permission is not granted

* Add log lines

* Remove files even if user decides to go back without sharing

* Add easy null check

* Change storage permission settings in singe upload fragment too

* Finish app if permission is not granted

* Code optimisation

* Remove temp file if upload process never is finalised on activity stop

* Bugfix maybe contribution is never created

* Fix travis build
2018-08-02 06:24:08 +10:00