Commit graph

4367 commits

Author SHA1 Message Date
Supriya
2b45194379 Fix #2250: Make version number copyable in About screen (#2273)
* Make version number copyable

* Resolve Travis build fail

* Revert "Make version number copyable"

This reverts commit c3f435423a.

* Revert "Resolve Travis build fail"

This reverts commit 20e70b21fb.

* Add gen folder to gitignore
2019-01-06 01:28:45 +05:30
sp2710
dabcd43a5b Removed default license settings, and implemented selecting last selected license as default licence(#2170) (#2218)
* Removed default license settings, and implemented selecting last selected license as default licence(#2170)
* Replace settings license tests with recent upload limit test
2019-01-04 15:26:39 +00:00
Adam Jones
f5c8e7ad93 Fix #2214: Use Utils.isDarkTheme for consistency (#2268) 2019-01-04 18:25:31 +10:00
Vivek Maskara
e773a82206 Handle null URI while uploading picture (#2262)
* Handle null URI while uploading picture

* Modify cache method to never return null path

* Fix tests
2019-01-04 18:21:55 +10:00
vanshikaarora
e69c03cf83 fixed issue #2154 for achievements activity (#2087)
* fixed issue #2065 for achievements activity

* updates for issue #2154

* removed unwanted comments and undo gradle changes

* added strings to strings.xml

* changes made after reviews

* review changes

* build issues resolved

* Undo changes in gradle properties
2019-01-03 21:25:13 +05:30
translatewiki.net
10e57bd8d0 Localisation updates from https://translatewiki.net. 2019-01-03 16:38:22 +01:00
Sai Krishna
7b2f7191f5 Fix for issue #1157 Added try-catch block in getBuildVersion function in gitutils.gradle … (#1158)
* Added try-catch block in getBuildVersion function in gitutils.gradle file.

* Formatting fix

* Add comment
2019-01-03 20:18:42 +05:30
neslihanturan
bedc53b0ca Fixes #2062 Nearby: My position does not move (#2235)
* Add method to check if current location marker is in visible region or not

* Ignore postion track updates if current location marker is not in the visible region

* Fix unnecessary progess bar issue
2019-01-04 00:28:11 +10:00
Vivek Maskara
a4a037a577 Use large heap size for commons app (#2261) 2019-01-04 00:16:16 +10:00
Kaartic Sivaraam
ed51d8b871 Rephrase misleading statement shown when skipping login (#2249)
* Rephrase misleading statement shown when skipping login

The previous statement was misleading as it could also
mean that the user could never upload pictures if he
skips login. This not the case because after skipping
the login he could login again if he wants to upload
pictures.

Clarify it by using a statement which states that he
would have to login in future in case he wants to
upload pictures.

* Rephrase with a better statement

The old statement doesn't read so well.
Rephrase it with a  better statement.
2019-01-04 00:07:45 +10:00
Vivek Maskara
be98a56ba0 Improve text for receiving shared images (#2266) 2019-01-04 00:05:00 +10:00
Vivek Maskara
465e232c67 Open gallery on gallery button click (#2267) 2019-01-03 12:18:36 +05:30
Vivek Maskara
a48a09a785 Use dexter for requesting storage permissions (#2258)
* Use dexter for requesting storage permissions

* minor changes

* Fix minor issue
2019-01-02 18:11:19 +02:00
Vivek Maskara
2ea6bd7f65 With more information while sending logs (#2222)
* With more information while sending logs

* With java docs and unit tests

* Changes based on code review
2019-01-03 01:12:08 +10:00
Adam Jones
5317063689 Fix night mode issues with search and categories (#2213) 2019-01-01 16:25:46 +05:30
DylanRobson
55113b3018 Fix issue #2164 Links open with handleWebUrl. (#2220)
* AboutActivity links now open with the in-app tabbed browser.
* UploadActivity license and policy links now open with the in-app tabbed browser.
2019-01-01 16:21:33 +05:30
Zhao Gang
af291a5fcc Fix #2163: Hide subtitle message when uploading a single image (#2169)
* Hide subtitle message when uploading a single image (#2163)

* updateSubtitleVisibility: Javadoc and replace if with ternary operator

* updateSubtitleVisibility: change findViewById to BindView

* Remove null checks for views

Null check is not required while binding views with butterknife.
2019-01-01 16:08:12 +05:30
Adam Jones
5c8a0cdd93 Add WhiteSearchBarTheme to styles.xml (#2211) 2019-01-01 15:55:34 +05:30
translatewiki.net
774436ce7b Localisation updates from https://translatewiki.net. 2018-12-31 17:52:23 +01:00
translatewiki.net
da36d2cda3 Localisation updates from https://translatewiki.net. 2018-12-27 10:46:23 +01:00
Kaartic Sivaraam
ecc05c1ca4 Bring back the label for multiple upload intent (#2221)
In the upload revamp, commit f607c1c1 (Multiple uploads with over haul (#1968), 19 Nov 2018),
kept back the label for the single upload intent but removed the label for the multiple upload
intent.

Correct it and bring back the label for the multiple upload intent thus giving a more useful
label for the intent, again.
2018-12-25 13:31:17 +05:30
Shridhar Goel
b447612cc5 Fix #2200: Prevent app from closing while navigating to Home (#2204)
* Fix #2200 Prevent app from closing while navigating to Home
* Add workaround for reorder activity Android bug in some API levels
2018-12-22 13:27:47 +00:00
Adam Jones
493fa6b721 Fix okay buttons in alert dialogs (#2206) 2018-12-21 17:30:36 +02:00
Adam Jones
96d540372a Improve search UI (#2189)
* Improve search UI

* Undo irrelevant parts of commit
2018-12-21 17:24:48 +02:00
Adam Jones
ef517042e3 Update mapbox sdk (#2176) 2018-12-21 16:41:02 +02:00
Adam Jones
fb3136ab19 Spelling mistake fixes (#2151)
* Spelling mistake fixes

* Spelling mistake fix
2018-12-21 15:20:52 +02:00
Adam Jones
d31574f6cd Fix #2197: Links on about page in night mode are correct color (#2199) 2018-12-21 14:26:30 +02:00
Adam Jones
d7e73c37e6 Refactor and add tests to LengthUtils (#2201) 2018-12-21 14:23:53 +02:00
Adam Jones
f04503bb3e Lint issues (#2114)
* Dangling Javadoc comments

* Replace for loop with foreach

* Explicit type can be replaced with <>

* Anonymous type can be replaced with lambda

* Lambda can be replaced with method reference

* Remove redundant methods

* Use capital L for long literals

* Remove unnecessary StringBuilder
2018-12-21 13:09:04 +02:00
Hariharan
8e967a3698 UploadController: Added support for using author names. Fixes #1707. (#1856)
* UploadController: Added support for using author names. Fixes #1707.

* Minor PR tidy-up

* Reword preference item

* Null check to pass startUpload test
2018-12-21 12:52:59 +02:00
Reid
809c0c32d7 Add missing Javadocs to License, Media, and Utils classes (#1965)
* Add missing Javadocs to License, Media, and Utils classes
2018-12-20 21:12:18 +00:00
Ojonathan
f521e8886d Fix night mode accent color (#2098) 2018-12-20 18:20:21 +00:00
briancollins-92
fcd5432f74 Fix 2072: default license selector in Settings (#2084)
* SharedPreferences Dep Injection added, updateLicense() updated

method updateLicense() was previously looking to the UploadModel for the
current default license, this has now been changed so that it gets it from
a SharedPreferences object

* UploadModel.license aligned to SharedPreferences

variable UploadModel.license within the constuctor is now assigned to the string of the
"default_license" value within SharedPreferences

Admittedly this may not be completly necissary as UploadModel.license is modified via
UploadPresenter.updateLicense on creation.
2018-12-20 18:10:06 +00:00
briancollins-92
aec377f547 Fix #2191: Avoid getting stuck if there are any issues with media upload (#2193) 2018-12-20 17:30:14 +00:00
sp2710
a3b33736b3 Updated deleteAll() method to delete all searches instead of 10(#2181) (#2185)
* Updated deleteAll() method to remove all searches insetead of 10 (#2181)

* Updated deleteAll() method to delete all searches instead of 10 (#2181)

* some minor chages
2018-12-20 16:38:29 +00:00
Josephine Lim
aec1e51339 Javadocs and minor refactoring for Nearby package (#2188)
* Add Traceur for getting meaningful RxJava stack traces (#1832)

* Hotfix for overwrite issue in 2.8.0  (#1838)

* This solution is an hotfix for overrite issue came back on 2.8.0 version. What I did is checking the extension, and if it is null, adding .jpg suffix. Because commons files always have suffixes, and we should compare file names after adding suffixes. Othervise overrides are possible.

* Check if file title includes an extension already, by checking if is there any dot in it.

* Fix logic error

* Add uncovered tests

* Remove unecessary line breaks

* Make Javadocs more explicit

* Versioning and changelog for v2.8.2 (#1842)

* Versioning for v2.8.2

* Changelog for v2.8.2

* Delete unused MaterialShowcase class

* Add Javadocs and fix lint errors for DirectUpload.java

* Fix whitespace and add docs

* Replace fragment.getActivity() with the parentActivity var

* Rename unnecessarily-overloaded method getFromWikidataQuery(), add Javadocs

* Javadocs and whitespaces for NearbyPlaces.java

* Use local vars where possible instead of class fields. Non-constants should not be in all caps

* Missed one unnecessary class field

* Remove unnecessary whitespaces that don't improve readability

* Add class summary

* Optimize imports

* Fix access modifiers in Place.java

* Clearer Javadocs

* Add Javadocs to Place.java

* Remove residual conflict

* Fix lint issues in Sitelinks

* Javadocs for Sitelinks.java

* DirectUpload: Replace nested conditionals with guard clauses
2018-12-20 15:19:27 +02:00
Vivek Maskara
4b58f16557 Fix null context error in network utils (#2184) 2018-12-20 12:55:21 +00:00
Ashish Kumar
b9274c0335 Fix memory leak in CategoryDetailsActivity (#1792) 2018-12-20 14:18:30 +02:00
Josephine Lim
33995764ff
Merge pull request #2085 from neslihanturan/fixOrientationIssueOnSearchNearby
Fix orientation issue on nearby after "search this area" is implemented
2018-12-20 20:59:49 +10:00
Nicolas Raoul
24a76b1446 Moved Play Store descriptions to the marketing project 2018-12-20 18:46:39 +09:00
neslihanturan
784ee8b506 Fix #1828: Add missing Javadocs and tidy up code in nearby package (#2133)
* Add Javadocs
* Remove unused variables, methods, fragments, imports, classes
2018-12-19 18:49:08 +00:00
neslihanturan
5a584545a0 Fixes #2014 After re-logging, notifications bell icon is empty (#2173)
* Fix white background on notification bell icon issue

* Fix icon size to 36
2018-12-19 18:18:38 +00:00
Vivek Maskara
f3b450e020 Merge 2.9 release with master (#2174)
* Fix memory leak due to wikidata edit listener (#2048)

* Fix bookmark crash fix (#2047)

* Fix bookmark crash fix

* Fix check for bookmark creator

* Bug fix #2042 (#2056)

* Bug fix #2042
* Added a snack with retry when api in AA fails
* Increased connection timeouts in okhttpclient builder

* added missing string resource

* Bugfix/duplicate categories (#2080)

* Increased timeout to 60 seconds

* Bug fix #1550
* filter duplicate categories

* Fix crash because of inactive fragment UI (#2046)

* Fix crash because of inactive fragment UI

* Add java docs

* Add information icon action Fiixes #2055 2.9.0: the 'i' icon in nearby doesn't do anything (#2057)

* Localisation updates from https://translatewiki.net.

* Remove unused mediawiki api dependency (#1991)

* Categories with pipe suffix (#1873)

* Bug fix issue #1826
Changes made :
-Certain category names used to show suffixed with strings prefixed with pipe '|'. Removed everything after the pipe. As per the discussion on the thread, its safe to remove everything after the pipe, including the pipe

* review suggested changes
*Code formatting
*Extracted out the index of pipe in a variable
*Added issue link in comments

* Remove libraries section from README (#1988)

* Remove libraries section from README

* Add wiki link to "libraries used" to README

* Localisation updates from https://translatewiki.net.

* Localisation updates from https://translatewiki.net.

* Use alert dialog instead of popup window, for nearby information

* Revert irrelevant changes, sorry
2018-12-19 18:59:49 +02:00
Josephine Lim
21edcb7cbe
Retry failed uploads - #1556 Allow users to easily re-upload failed uploads... (#2112)
* Add cancel and retry buttons on layout contribution

* Make sure your retry logic works

* Add cancel method too

* Add javadocs and remove debug logs

* Remove two unused methods

* Remove old and unused retry buttons as we do for their functions

* Check internet connection before button function, since function requires internet connection

* Remove unused variable

* Display possible solution for badtoken error

* Fix string
2018-12-20 02:56:00 +10:00
Adam Jones
d960c14174
Fix #2172 by fixing whitespace in bash test 2018-12-19 16:24:28 +00:00
Ashish Kumar
4425c36713 Bug fix in campaigns (#2119)
* Bug fix in campaigns

* remove hardcoded reference to camapign at index 0
2018-12-19 22:06:51 +10:00
Adam Jones
46db38b8e9 Fix #2153: Fix explore category lists (#2155) 2018-12-19 01:37:24 +05:30
Adam Jones
0f69deab84 Fix #2147: Remove strings from notification and place layouts (#2150) 2018-12-19 01:33:48 +05:30
Adam Jones
e6593c55e9 Travis should only sign and build APK on master branch (#2162) 2018-12-19 00:08:54 +05:30
Zhao Gang
db38174eb4 Fix #2156: Add plural support for share_license_summary string (#2161) 2018-12-18 17:29:11 +00:00