* #3529 Captions/depictions are not saved to Commons - make copy of list of depictionEntityIds - uncomment editBaseDepictsProperty - refactor upload related classes
* #3529 Captions/depictions are not saved to Commons - fix wrong ArrayList usage
* #3529 Captions/depictions are not saved to Commons - fix test
For some time now, GitHub is showing cards when we hover over an issue
number which gives us a quick summary of the issue. The issue title is
shown in the card among other things.
Given that and the fact that we already require the issue number to be
specified in the pull request description, it's now moot to
ask the contributors to include the issue title in the pull request
description. So, let's remove this unnecessary burden from them.
* #3408 Refactoring the FileProcessor and GPSExtractor classes - refactor FileProcessor
* #3408 Refactoring the FileProcessor and GPSExtractor classes - refactor and rename GpsExtractor
* #3408 Refactoring the FileProcessor and GPSExtractor classes - convert ImageCoordinates to kotlin
* #3408 Refactoring the FileProcessor and GPSExtractor classes - convert FileProcessor to kotlin
* #3408 Refactoring the FileProcessor and GPSExtractor classes - minor reformatting
* #3408 Refactoring the FileProcessor and GPSExtractor classes - fix compilation and naming issues
* #3408 Refactoring the FileProcessor and GPSExtractor classes - remove empty test
* #3408 Refactoring the FileProcessor and GPSExtractor classes - set coordinates for upload item if user chooses it
* Issue #3428: Swapped text in dialog buttons because, according to Android Convention, they were opposite each other
* Fixed Issue #3428 so it actually works correctly now: Swapped text in dialog buttons because, according to Android Convention, they were opposite each other
* Made sure that all of the places where the two types of showAlertDialog accurately match up with the new position of positive and negative text on the dialog box
Also removed occurences of empty lambda expressions and used null instead
* modified deletThisPicture to be accurate lambda call
* reverted mistake where ellipses replaced the three dots
* #3482 Use Room in Structured Data branch - remove unused code
* #3482 Use Room in Structured Data branch - fix unit test compilation
* #3490 Depiction Search in upload shows No Results before it gets results - stop showing error on subscription
* #3490 Depiction Search in upload shows No Results before it gets results - update test cases
* make labels nullable too
* #3482 Use Room in Structured Data branch - remove unused code
* #3482 Use Room in Structured Data branch - fix unit test compilation
* #3482 Use Room in Structured Data branch - add kdoc
* Fixes#3359
* Cache thumb url & imageUrl in local db
* Use Fresco's ImageRequest to show images in ContributionViewHolder[this was the issue, we should have always used this to show the image]
* Deleted DisplayableContribution (not needed anymore)
* Exposed abstract function in ContributionDao to updateContribution
* * Make position private in ContributionViewHolder
* Remove MediaDataExtractor from ContributionsFragment
* * Show placeholder image for Contributions while the image loads
* setHasStableId's ContributionsAdapter
* make Random variable private in ContributionViewHolder
* replace local variable-if-with ternary operator in ContributionViewHolder
* Fix indentation/formatting of ternary operator in ContributionViewHolder
* I might revert this commit[I have reasons]
* Create in-memory drawables in CVH's onBind, caches are bad, add mental overhead
* Revert "I might revert this commit[I have reasons]"
This reverts commit 627ac91517.
* minor formatting changes, reverted 627ac91517
* uh-oh missed semicolon, java
* minor formatting changes
* Add p18value variable to contrib
* set place.pic to candidate contribution
* Add p18 value to contrib
* Passes p18 value to wikidata upload service
* Checks if pic parameter of the wikidata item is empty or not. If not, it does not overrides the existing image, it is just a regular commons upload.
* Make public var private
* Make current tests pass
* Add test case for p18 value is not empty
* Fix wrong log message
* Add nonnul annotation and fix method javadoc
* scalebar added in map
* changes reverted in .idea/Project.xml
* magic numbers replaced with constants for scalebar
* Default setting for scaling unit
* Default setting for scalebar refresh interval
* Reformatted code for adding scalebar
* dimen values for scalebar params
* Revert stopgaps related to beta server cert issue
The upstream issue with Commons beta server has been
fixed now[1]. So, there's no point in stopgapping
the issue anymore. So, revert the related changes.
This reverts fa87eb5661
and df426f7c42 which
correspond to PRs #3350 and #3349 respectively.
[1]: https://phabricator.wikimedia.org/T243881#5861983
* Test-fix: fix the failing CI test
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - add apropriate schedulers and convert justs to fromCallable
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - remove test for removed functionality
* #3493 App freezes for 15 seconds when you press Next in UploadMediaDetailsFragment - replace kotlin with java
