Commit graph

4540 commits

Author SHA1 Message Date
Adam Jones
1040c2d5b1 #2643: Remove unused resource files (#2641)
* Remove unused resource files

* Remove unused layout files
2019-03-18 22:47:29 +05:30
Yusuke Matsubara
ee7af37d00 Stash upload (#2505)
* Introduce Single<UploadResult>

* Two stage upload process

- split upload process and use stash
- resolve filename conflict after upload not before
- use NotificationManagerCompat; add notification tag; assign temporaty stash file name
2019-03-18 21:07:29 +05:30
translatewiki.net
341f9614a7 Localisation updates from https://translatewiki.net. 2019-03-18 08:45:15 +01:00
Adam Jones
0b6a1addfb Add WelcomeActivityTest (#2636)
* Add WelcomeActivityTest

* Convert WelcomeActivityTest to Kotlin
2019-03-18 11:21:22 +05:30
Shubham Pinjwani
38dc0c3fc8 Fix #2634: Prevent incorrect dialog from appearing if non-GPS location is enabled (#2635)
* Prevent dialog from appearing if location is enabled
* Update Javadoc
2019-03-17 20:41:46 +00:00
Shubham Pinjwani
31c688860d Fix #1850: Show media talk page in media details (#2560) 2019-03-17 17:11:34 +00:00
Adam Jones
3b7b6f91a2
Fix #2203: Require number of uploads not to have decimal (#2615) 2019-03-17 16:54:55 +00:00
Shridhar Goel
0b25730a18 Fix #2194: Updated Nearby ⓘ icon to include 'Search this area' feature (#2198) 2019-03-17 16:23:11 +00:00
Madhur Gupta
21f2e088fa Fix #2592: Overlapping text bug on tablet login screen (#2600) 2019-03-17 16:14:58 +00:00
Shridhar Goel
40568eccf8 Fix #2394: Prevent crash while navigating between Explore and Achievements (#2395) 2019-03-17 15:29:24 +00:00
Divyanshu Shukla
16df68a073 Fix #2246: Remove NPE in Nearby (#2247) 2019-03-17 15:20:17 +00:00
Adam Jones
d24bf20c80 Add NavigationBaseActivityTest (#2633) 2019-03-17 18:09:16 +05:30
Adam Jones
f983a99f45 Fix compiler warnings from Apache AvalonLogger (#2631) 2019-03-17 16:35:03 +05:30
Vanshika Arora
1a8a99997d modified activity_upload_bottom_card (#2630) 2019-03-17 16:12:53 +05:30
Brenda Jerop
8e8558ae6d Fix #2017: Explore shows featured images and mobile uploads (#2551) 2019-03-17 10:32:24 +00:00
Vanshika Arora
38dceddbf5 resolved issue #2542 with position of map icon (#2601)
* resolved issue #2542

* removed commented code
2019-03-17 15:42:57 +05:30
Adam Jones
d719a4a9d4 Add tests for PageTitle (#2624) 2019-03-17 11:22:37 +05:30
Adam Jones
cfade144d9 Refactor string sorting utils to remove dependency (#2623)
Also adds Javadocs, and simplifies calculateSimilarity
2019-03-17 11:21:45 +05:30
Adam Jones
701764d974 Fix tests in SettingsActivity (#2625)
* Fix SettingsActivityTest

* Add test in SettingsActivity to set recent upload limit to 0

* Add tests to recent upload limit setting

* Simplify activity test rule
2019-03-17 11:21:10 +05:30
Adam Jones
561f9ea23c Add more tests to StringSortingUtils (#2622)
* Add more tests to StringSortingUtils

* Add test with empty strings to improve coverage
2019-03-16 23:21:23 +05:30
Shubham Pinjwani
deb0a9874c Fix #2620: Prevent app from crash while visiting achievements in flight mode (#2621) 2019-03-16 17:06:54 +00:00
Vanshika Arora
9d55c1e8d7 Fix #2245: Correct back button behaviour from nearby fragment (#2301) 2019-03-16 16:27:25 +00:00
Vitaly V. Pinchuk
a26b62f51b Fix #1334: Refactor variable names of nearby_query.rq (#2583)
* all variables were refactored to camelCase
2019-03-16 21:09:39 +05:30
Shridhar Goel
a8fac9d160 Fix #2231: Explore recent searches list updates quickly (#2232) 2019-03-16 15:27:28 +00:00
Vivek Maskara
7cb87f3cab Consolidate shared prefs to a single store (#2613)
* Consolidate shared prefs to a single store
* Fix achievements activity
* Fix store usage
2019-03-16 13:56:56 +00:00
Adam Jones
51f58b7118 Add MapBox localization (#2614) 2019-03-16 19:07:21 +05:30
Vivek Maskara
1d225c545e Remove dead code from dialog util (#2612) 2019-03-16 12:55:44 +00:00
Adam Jones
0bbfd54465 Fix #2610: Use dark map theme in night mode (#2611) 2019-03-16 18:03:15 +05:30
Vivek Maskara
6cbce9d283 Fix #1131: Update min sdk version and remove redundant checks (#2608) 2019-03-16 12:21:51 +00:00
Vanshika Arora
900bd4ff2f Fix #2563: Uploading from wikidata with "?" description (#2586) 2019-03-16 12:10:29 +00:00
Vivek Maskara
57e685cf6c Fix #2593: Migrate to androidX (#2594)
* Update dependencies and migrate to androidX
* Make gradle properties tidy
2019-03-16 11:22:37 +00:00
Adam Jones
5b1b0037c3 Fix #2197: Fix color of links on about page in night mode (#2604) 2019-03-16 12:02:42 +05:30
Adam Jones
11c013b195 Fix #2605: Wording of no notification message (#2606) 2019-03-16 12:01:53 +05:30
Zhao Gang
bb40c24de8 Fix #2520: Fix dangling snackbar in NearbyFragment (#2521)
NetworkBroadcastReceiver is unregistered in onPause() and not reregistered in onResume(). This causes the snackbar doesn't disappear after network becomes available. Fixed this and improved the null checking logic in snackbar related code.
2019-03-15 23:47:21 +00:00
Madhur Gupta
5c4278bbff Fix #2324: Number of contributions updates on upload (#2587)
* Fixed bug - Number of Contributions not updating unless app is restarted, #2324
* Inverted if statement for better readability
2019-03-15 23:15:11 +00:00
Madhur Gupta
68014f69eb Fix #2524: Move 'Images via Nearby Places' to top of secondary achievements list (#2579)
* Moved Images via Nearby Places to top, fixes #2524
* Resolved Merge conflicts
2019-03-15 23:02:52 +00:00
Szymon20000
14ea653c1b Fix #2276: Prevent index out of bounds exception when search query result size is 0 (#2277) 2019-03-15 22:48:15 +00:00
Shubham Pinjwani
cbf625d3f9 Add #2241: Add long-press to delete specific search (#2275) 2019-03-15 22:06:05 +00:00
Tim Borisenko
b46ea0aba8 Fix #2186: Standardize tab theming across app, and fix related night mode issues (#2227) 2019-03-15 19:48:18 +00:00
Brenda Jerop
2dc2e32d87 Fix #2552: Close FAB in contributions when an mini-fab is clicked (#2556) 2019-03-15 17:27:39 +00:00
Vivek Maskara
44c18ac238 Fix crash on API 28 (#2597)
Fixes #2596
2019-03-15 09:36:00 +05:30
Ashish Kumar
1b5a56c7e6 Bugfix/issue 2580 (#2584)
* Corrected string placedholders in certain string files

* Corrected string placedholders in certain string files[Bug fix #2580]
2019-03-15 09:16:15 +05:30
Yusuke Matsubara
b5051f9a4f Use Timber.e(Throwable t, String message, Object... args) (#2582) 2019-03-15 08:34:25 +05:30
Dmitry Brant
c21cc83eb5 Update to API 28, and fix CI issues. (#2595)
* Update gradle version.

Also update jacoco plugin to work with latest gradle.

* Update target sdk to 28.

* Update other dependencies to latest versions.

* Remove totally unused(?) local jar file.

* Remove dependency on nineoldandroids.

The functions it provides are no longer necessary.
This also removes a homemade "evaluate" function, which is readily
available in the Support library.

* Remove dependency on Traceur.

This library has not been updated in two years (may no longer be maintained?), and no longer works with
the latest RxJava.

* Enable test coverage only when performing CI.

Running test coverage on every single build while developing in the IDE is quite a waste of time.

* Suppress gradle Notes and Warnings from reflection-using packages.

The build output was getting extremely long, and was actually causing
the build to fail because of the sheer size of the log.

* Suppress gradle Note messages during tests and CI.

Stop CI messages from exploding to 10k+ lines.

* Temporarily remove instrumented test(s).

The project's instrumented tests consist of a single test which sets a
SharedPreference, then verified that the SharedPreference was set.

I humbly submit that this is not worth the trouble of having the CI
server download the system image, spin up an emulator, load the APK, and
run it just for this purpose.

Once the instrumented tests are ready for prime time, we can reinstate
instrumented tests in CI.
2019-03-15 08:30:08 +05:30
translatewiki.net
8dbeb6eba0 Localisation updates from https://translatewiki.net. 2019-03-14 13:01:12 +01:00
Silky Priya
503887673b Label wraps in Achievements (#2577)
* Support long text

* make text right aligned in rtl layout
2019-03-13 12:19:59 +05:30
Zhao Gang
62c14ecb66 Make DeleteTask notification quieter on some devices(Fixed #2528) (#2538)
As commit ab4fca5e does, this commit fixed the repeated notification
alarms in DeleteTask.class.

Since progress indication in notification can be cleared by calling
.setProgress(0,0,false) on notificationBuilder(As shown in DeleteTask.class).
This commit also refactored notification related code in UploadService.class.
Make progress and failed notification uses the same notificationBuilder.
2019-03-12 14:19:09 +03:00
Zhao Gang
52724b8be0 Add setting Picture_Has_Correct_Location prefs(Fixed #2530) (#2536)
Update Picture_Has_Correct_Location prefs in method handleImage. This
fixed an issue that this prefs is not set and related wikidata
can't be updated.
2019-03-12 17:02:51 +09:00
Silky Priya
9d03274e2f Change place bookmarks buttons color (#2570)
* change bookmarks row button color

* different button color for dark and light mode

* Resolve Merge Conflict
2019-03-12 00:34:09 +05:30
Vanshika Arora
6389b35b49 replaced icafe with metadata extractor (#2546)
* replaced icafe with metadata extractor

* replaced icafe with metadata extractor

* removed icafe from gradle

* removed icafe from gradle

* Revert: travis commented code

* Use original content URI

* merged pr

* commit after merge

* modified unit tests
2019-03-12 00:20:47 +05:30