Sean Mac Gillicuddy
02714649e8
#3760 remove test that got re-added by merge
2020-05-28 12:52:17 +01:00
Sean Mac Gillicuddy
1a1a8389d5
Merge remote-tracking branch 'origin/master' into macgills/3760-categories-pagination
...
# Conflicts:
# app/src/main/java/fr/free/nrw/commons/explore/SearchActivity.java
# app/src/main/java/fr/free/nrw/commons/explore/SearchModule.java
# app/src/main/java/fr/free/nrw/commons/explore/categories/SearchCategoryFragment.java
# app/src/main/java/fr/free/nrw/commons/explore/depictions/DepictionAdapter.kt
# app/src/main/java/fr/free/nrw/commons/explore/depictions/SearchDepictionsFragment.kt
# app/src/main/java/fr/free/nrw/commons/explore/depictions/SearchDepictionsFragmentContract.kt
# app/src/main/java/fr/free/nrw/commons/explore/depictions/SearchDepictionsFragmentPresenter.kt
# app/src/main/java/fr/free/nrw/commons/nearby/PlaceAdapterDelegate.kt
# app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
2020-05-28 12:39:59 +01:00
Seán Mac Gillicuddy
c216fdf0d4
#3756 Convert SearchDepictionsFragment to use Pagination ( #3758 )
2020-05-28 14:10:04 +03:00
Sotirios Siamandouras
0ebd59a223
Fixes #3712 Changed button attributes ( #3718 )
...
* Fixes #3712 Changed Widget.AppCompat.Button.Borderless to Widget.AppCompat.Button
* Update upload_depicts_fragment.xml
* Update upload_depicts_fragment.xml
Removed unnecessary line
2020-05-28 09:00:09 +01:00
V Bhavna Haritsa
cda4a8fa76
updated the readme with new links ( #3773 )
2020-05-27 15:30:23 +05:30
Seán Mac Gillicuddy
b063d6bdfd
#3468 Switch from RvRenderer to AdapterDelegates ( #3750 )
...
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer
* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer
* #3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer
* #3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer
* #3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer
* #3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer
* #3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer
* #3468 fix constant import
* #3468 Switch from RvRenderer to AdapterDelegates - resolve id conflict
2020-05-27 19:44:21 +10:00
Vaibhav
82d662c8ef
Add destroyed column to BookmarkLocation table (##3729) ( #3774 )
...
* Add destroyed column to BookmarkLocation table (##3729)
* switch with fall through for migrations
2020-05-27 10:10:00 +01:00
translatewiki.net
7a49ca12a4
Localisation updates from https://translatewiki.net .
2020-05-26 17:04:25 +02:00
Sean Mac Gillicuddy
6368e500a8
#3760 Convert SearchCategoriesFragment to use Pagination - extract functionality of pagination to base classes - add category pagination
2020-05-25 13:01:27 +01:00
Seán Mac Gillicuddy
df76aef070
#3763 IllegalArgumentException at fetchImagesForDepictedItem - pass entityId in ( #3764 )
2020-05-22 01:50:49 +10:00
Seán Mac Gillicuddy
618ace707b
#3752 Media details do not show depiction - make request return all languages available and choose preferred or first ( #3761 )
2020-05-21 21:51:20 +09:00
neslihanturan
3f31c3eded
Add bookmarks to Nearby map ( #3728 )
...
* Remove bookmark button from row button set and put to upper level list item
* Fix npe caused by lookinf for parent fragment, we don't have one anymore
* style
* Add new icons for bookmarked places
* Change bookmarked info when bookmarked
* Add pic field to bookmark dao so that we can retrieve them later
* Put bookmarks as the first item of list
* Add bookmark as a label
* Add logic to filter nearby
* remove unneeded changes
* fix word
* Remove logs
* Remove unused part of code
* Fix tests
* Remove logs
* simplify icon picking
* remove redundant margin left
* Remove non needed map and swap
* Add main thread annotation
* Fix tests
2020-05-21 20:58:27 +10:00
Seán Mac Gillicuddy
384afa6c44
#3753 Item label/description: Fall back to non-empty language - attempt to read labels by language or the first one in the list ( #3759 )
2020-05-21 08:54:09 +09:00
Seán Mac Gillicuddy
de3377c0fe
#3120 Suggest categories based on depictions ( #3736 )
2020-05-20 17:26:16 +03:00
Sean Mac Gillicuddy
ec53377035
#3756 Convert SearchDepictionsFragment to use Pagination - reset rx scheduler - ignore failing test
2020-05-20 12:29:58 +01:00
Sean Mac Gillicuddy
0fd81d09b1
#3756 Convert SearchDepictionsFragment to use Pagination - test DataSource related classes
2020-05-20 12:00:54 +01:00
Sean Mac Gillicuddy
9af97c483e
#3756 Convert SearchDepictionsFragment to use Pagination - fix presenter unit tests now that view is not nullable - fix Category prefix imports
2020-05-20 09:20:03 +01:00
Sean Mac Gillicuddy
8d13122e0e
Merge remote-tracking branch 'origin/master' into macgills/3756-depictions-pagination
...
# Conflicts:
# app/src/main/java/fr/free/nrw/commons/category/CategoryClient.java
# app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java
# app/src/main/java/fr/free/nrw/commons/upload/categories/UploadCategoriesFragment.java
# app/src/main/res/values/strings.xml
# gradle.properties
2020-05-19 15:31:30 +01:00
Sean Mac Gillicuddy
4866fee7f2
#3756 Convert SearchDepictionsFragment to use Pagination - convert SearchDepictionsFragment
2020-05-19 14:38:55 +01:00
Cloe Riva
01839dec6e
Adding multidex to support more method references ( #3755 )
...
* adding multidex to support more method references
* add multidex version to gradle properties
2020-05-19 14:32:33 +01:00
Cloe Riva
7084fd2535
Nearby: make list resize and display message when empty ( #3746 )
...
* Nearby: make list resize and display message when empty
* refactored and renamed for clarity
* refactoring and simplifying based on comments
* refactoring and simplifying based on comments
* removing vertical orientation
2020-05-19 13:43:49 +01:00
translatewiki.net
fbd057b87e
Localisation updates from https://translatewiki.net .
2020-05-18 16:02:30 +02:00
Seán Mac Gillicuddy
4690925cf5
#3734 Refactor and convert CategoryPresenter to kotlin ( #3735 )
2020-05-15 16:17:26 +03:00
Sean Mac Gillicuddy
9f2dcb8c5e
Merge remote-tracking branch 'origin/master' into macgills/3468-adapter-delegates
2020-05-15 12:27:30 +01:00
Seán Mac Gillicuddy
e597a7c96f
#3745 Upload depiction suggestions not following text input - on upstream error emit empty list ( #3751 )
2020-05-14 23:32:51 +09:00
Sean Mac Gillicuddy
3b422963a4
#3468 Switch from RvRenderer to AdapterDelegates - replace PlaceRenderer
2020-05-14 07:23:37 +01:00
Sean Mac Gillicuddy
456b86454e
#3468 Switch from RvRenderer to AdapterDelegates - replace UploadDepictsRenderer
2020-05-13 12:34:24 +01:00
Sean Mac Gillicuddy
8a39fddde8
#3468 Switch from RvRenderer to AdapterDelegates - replace NotificationRenderer
2020-05-13 12:13:31 +01:00
Sean Mac Gillicuddy
1c50591887
#3468 Switch from RvRenderer to AdapterDelegates - replace SearchCategoriesRenderer
2020-05-13 11:37:17 +01:00
Sean Mac Gillicuddy
f083eb653e
#3468 Switch from RvRenderer to AdapterDelegates - replace SearchImagesRenderer
2020-05-13 11:12:12 +01:00
Sean Mac Gillicuddy
58af240c9d
#3468 Switch from RvRenderer to AdapterDelegates - update BaseAdapter to be easier to use
2020-05-13 10:45:37 +01:00
Sean Mac Gillicuddy
c7d25e12cc
#3468 Switch from RvRenderer to AdapterDelegates - replace UploadCategoryDepictionsRenderer
2020-05-12 15:11:33 +01:00
Seán Mac Gillicuddy
affcd8a6d7
#3733 On first view of DepictionUpload suggestions don't show - remove zip which was only taking 1 value from the processor ( #3737 )
2020-05-12 16:38:45 +03:00
Sean Mac Gillicuddy
88c307d265
#3468 Switch from RvRenderer to AdapterDelegates - replace SearchDepictionsRenderer
2020-05-12 12:51:17 +01:00
Seán Mac Gillicuddy
057d11a0e0
#3077 Hide disambiguation items from depiction search - when fetching depictions get the entity instead of the search result ( #3741 )
2020-05-12 13:44:17 +03:00
translatewiki.net
34f02499e4
Localisation updates from https://translatewiki.net .
2020-05-11 17:35:27 +02:00
Seán Mac Gillicuddy
4443810823
#3699 Multiple upload: Only one file's caption is used for all files, others ignored - share model data with the UI - inline and remove Remote/LocalDataSource ( #3707 )
2020-05-08 20:21:17 +10:00
Vaibhav
11ff5fb055
Fix NullPointer when clicking on image in MediaDetailFragment ( #3730 ) ( #3738 )
...
Uri.parse would throw NullPointerException if the image in MediaDetailFragment was clicked before the image URL is available
2020-05-08 09:37:00 +05:30
translatewiki.net
dc6a3e507b
Localisation updates from https://translatewiki.net .
2020-05-07 17:07:32 +02:00
Seán Mac Gillicuddy
77f75a4627
#3716 Depiction search does not return any results - clear so CompositeDisposable can be reused ( #3731 )
2020-05-06 20:07:40 +10:00
Seán Mac Gillicuddy
953f09d683
#3448 CategoryImagesListFragment.handleError never succeeds ( #3710 )
...
* #3448 CategoryImagesListFragment.handleError never succeeds - remove timeouts, rely on default timeout params
* #3448 CategoryImagesListFragment.handleError never succeeds - fix compilation
2020-05-05 12:00:42 -07:00
Vitaly V. Pinchuk
6d687c3efb
Fixes #3720 : None of the filters work on Nearby list ( #3723 )
2020-05-04 17:15:08 +03:00
translatewiki.net
70f28b1dcf
Localisation updates from https://translatewiki.net .
2020-05-04 15:49:51 +02:00
Vitaly V. Pinchuk
ff9f4f20e7
Fixes #3704 : Green pins seen on initial "Nearby" map, despite "Needs Photos" selected ( #3721 )
2020-05-04 16:43:08 +03:00
translatewiki.net
ccdf2646b9
Localisation updates from https://translatewiki.net .
2020-04-30 16:47:25 +02:00
translatewiki.net
83790a6f1f
Localisation updates from https://translatewiki.net .
2020-04-27 16:43:48 +02:00
Madhur Gupta
0e0d404d89
Updated Navigation Base Activity Unit Tests ( #2725 )
...
* Updated Navigation Base Activity Unit Tests
* Standardise function call
* Standardise function call
Co-authored-by: Adam Jones <jones_adam@rocketmail.com>
2020-04-26 19:08:48 -07:00
Raj Bapat
95372f33b5
There were 2 issues combined into one: ( #3643 )
...
1. The languages were shown with the characters of the given language (i.e. Mandarin was displayed with Chinese characters).
2. The languages were not sorted
How I fixed them:
1. I changed the list that was called from AppLanguageLookUpTable from localized to cannonical.
2. I imported List and Collections and I sorted said list in lexicographical order.
2020-04-26 00:23:00 -07:00
Vitaly V. Pinchuk
1fea1bbf49
Get rid of HandlerService #3555 ( #3671 )
...
* [WIP] Removed HandlerService
* [WIP] Added PublishProcessor for managing queue
* Resolved conflicts after merge
2020-04-25 23:17:57 -07:00
Seán Mac Gillicuddy
ce089d3f73
#3457 Permissions in Manifest only granted to system apps - remove system app only permissions ( #3708 )
2020-04-25 13:23:11 -07:00
