* Closes#3027
* Concat category search with search with image title list and default categories
* Fixed unit test CategoriesPresenterTest.searchForCategoriesTest
* bug fix [search for categories even when the edit text is empty (perform title based search)]
* Category items should show the selected item on top
* With media client APIs migrated to retrofit (#2998)
* With media client APIs migrated to retrofit
* Add test cases and java docs
* Fix test
* Fix build
* Fix build and other minor issues
* Fix tests
* Categories related client API's migrated to retrofit (#3053)
* Commit 1
* searchCategories migrated to retrofit
* SearchCategoriesFragment migrated to new API
* Removed unused code
* Created tests
* implemented searching by prefix
fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones.
* added tests
* Migrated searchTitles to searchCategories, function behaviour seems identical
* With media client APIs migrated to retrofit (#2998)
* With media client APIs migrated to retrofit
* Add test cases and java docs
* Fix test
* Fix build
* Fix build and other minor issues
* Fix tests
* Categories related client API's migrated to retrofit (#3053)
* Commit 1
* searchCategories migrated to retrofit
* SearchCategoriesFragment migrated to new API
* Removed unused code
* Created tests
* implemented searching by prefix
fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones.
* added tests
* Migrated searchTitles to searchCategories, function behaviour seems identical
* OkHttpJsonApi#getMediaList migrated to retrofit (#3054)
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages
* Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages
* Removed unused code and tests
* Fixed small bug
* Added tests
* Removed unused CategoryImageController
* getSubCategoryList and getParentCategoryList migrated to retrofit (#3055)
* Migrated getSubCategoryList to retrofit
* Migrated getParentCategoryList to retrofit
* Removed obsolete functions
* Added tests
* Fixed small bugs
* Migrated OkHttpJsonApiClient#getMedia and getPictureOfTheDay to MediaClient
* Removed obsolete functions and added tests
* Fixed merge errors
* With media client APIs migrated to retrofit (#2998)
* With media client APIs migrated to retrofit
* Add test cases and java docs
* Fix test
* Fix build
* Fix build and other minor issues
* Fix tests
* Categories related client API's migrated to retrofit (#3053)
* Commit 1
* searchCategories migrated to retrofit
* SearchCategoriesFragment migrated to new API
* Removed unused code
* Created tests
* implemented searching by prefix
fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones.
* added tests
* Migrated searchTitles to searchCategories, function behaviour seems identical
* OkHttpJsonApi#getMediaList migrated to retrofit (#3054)
* Migrated OkHttpJsonApi#getMediaList partially to MediaClient#getCategoryImages
* Migrated rest of OkHttpJsonApi#getMediaList functionality to MediaClient#getCategoryImages
* Removed unused code and tests
* Fixed small bug
* Added tests
* Removed unused CategoryImageController
* getSubCategoryList and getParentCategoryList migrated to retrofit (#3055)
* Migrated getSubCategoryList to retrofit
* Migrated getParentCategoryList to retrofit
* Removed obsolete functions
* Added tests
* Fixed small bugs
* Consume login client from data client library (#2894)
Fix actions for review client
Use data client library for notifications
With delete helper migrated to data client
With wikidata edits
With notifications and modifications migrated to data client
With upload migrated to retrofit
Delete unused code
Reuse thank interface from the library
Fix actions for review client
Use data client library for notifications
With delete helper migrated to data client
With wikidata edits
With notifications and modifications migrated to data client
With upload migrated to retrofit
Delete unused code
Reuse thank interface from the library
Fix actions for review client
Use data client library for notifications
With delete helper migrated to data client
With wikidata edits
With notifications and modifications migrated to data client
With upload migrated to retrofit
Delete unused code
Reuse thank interface from the library
* Commit 1
* searchCategories migrated to retrofit
* SearchCategoriesFragment migrated to new API
* Removed unused code
* Created tests
* implemented searching by prefix
fixed SearchCategoryFragment behaviour where the same categories would be added to the list instead of new ones.
* added tests
* Migrated searchTitles to searchCategories, function behaviour seems identical
* Closes#3048
* response.body().string() was called more than once and because response body can be huge so OkHttp doesnot store it in memory, it reads it as a stream from network when we need it, which cannot be done without a new request.
* null check in response.body()
* Fixed possible NumberFormatException, made review suggested changes
* added getUploadCount test case
* * Refactored ContributionsListFragment to use RecyclerView
* Added ContributionsPresenter
* Extracted out the cursor to presenter
* Probable fix for #3028
* Improved the logic for cache in ContributionViewHolder
* Some more refactoring
* While displaying images in ContributionsList, check if status is not completed && local uri exists, use that uri to show image
* typo correction in LocalDataSource
* Fixed formatting in ContributionsPresenter
* retain adapter position when orientation changes
* retain child position with its id
* Made ContributionViewHolder not implement ViewHolder
* Code formatting, review suggested changes
* initialise the rv layout managers only when needed
* added test cases for ContributionPresenter
* removed not needed semi colon
* added more java docs and code formatting
* Removed hardcoded strings in DeleteHelper
* Revert "Removed hardcoded strings in DeleteHelper"
This reverts commit 4bc55fc3af.
* Removed all hardcoded strings in DeleteHelper.
* fixed test problems
* Correction strings in DeleteHelper
* decision problem with color of info icon #2940
* Correction DeleteHelper and string.xml
* minor fix
* fixed problems in DeleteHelper.java and strings.xml
* and another little fix
* Revert "and another little fix"
This reverts commit fe4ea5255f.
* Revert "decision problem with color of info icon #2940"
This reverts commit 5895cc8785.
* FIX#2918 Add option for default language for file descriptions
* navigation menu error fixed and improvement of code quality
* error language description default fixed
* adapter language selected fixed
* local language selected per default in description language
* Use a better string and variable name as required in review 1
* Add comments
* Add previously missing setValue methods so that list item will be chosen along with the summary
* Add missing Javadocs
* Fix capitalization
* Lint and formatting issues
* Rename methods so it's clearer they are to do with languages
* Use default kv store instead of shared preferences variable
* Make sure saved language code from settings activity is handled on init
* Feature/refractor uploads [WIP] (#2887)
* Fix duplicate param information (#2515)
* Bug fix issue #2476 (#2526)
* Added wikidataEntityID in all db versions, handled db.execSql via method runQuery
* Versioning and changelog for v2.10.2 (#2531)
* Update changelog.md
* Versioning for v2.10.2
* Update changelog.md
* Bugfix/issue 2580 (#2584)
* Corrected string placedholders in certain string files
* Corrected string placedholders in certain string files[Bug fix#2580]
* Bug Fix#2585 (#2647)
* Bug Fix#2585
* Added null checks on view in SearchImageFragment when updating views from external sources
* Disposed the disposables in SearchActivity and SearchImageFragment when no longer in active lifecycle
* use FragmentUtils to verify fragment active state
* Bug Fix issue #2648 (#2678)
* Bug Fix issue #2648
* Handled external storage permission before file download
* * Removed redudant check for permission in MediaDetailPagerFragment (Dexter already does that)
* Removed duplicate code in PermissionUtil$checkPermissionsAndPerformAction, used the existing function with conditional extra parameters
* string name typo correction
* BugFix issue #2652 (#2706)
* Addded null check on bookmark before operating on it
* BugFix issue #2711 (#2712)
* Added null checks in OkHttpJsonApiClient$searchImages MwQueryResponse
* BugFix #2718 (#2719)
* Handled null auth cookies
* Fix#2791: NPE when nominating for deletion and leaving screen (#2792)
* Bug Fix issue #2789 (#2790)
* Handled Illegal State Exception for non existent appropriate view parents in ViewUtils$showShortSnackbar
* BugFix #2720 (#2831)
BugFix deprecated licenes #2720
* ui fixes, wip, upload
* *Issue #2886, BugFix #2832[wip]
* updated UploadActivity code
* modified ui
* Updated UploadPresenterTest
* * updated interfaces names to follow names suffixed with Contract
* added test cases
* card view elevation
* view pager disabled swipe
* bug fix, duplicate image
* used existing non-swipable view pager
* Avoid image view resize with keyboard, added adjustPan and stateVisible as softinputMode for UploadActivity
* retain UploadBaseFragment instances on orientation changes
* * Added test cases for UploadMediaPresenter
* Injected io and main thread schedulers
* categories presenter test cased wip
* Added CategoriesPresenter test
* * Added the logic to show open map (with to be uploaded image's coordinates while uploading image)
* codacy suggested changes * added java docs
* Added travis_wait fot android-wait-for-emulator
* ranamed interface onResponseCallback to Callback
* * Added api to delete picture in UploadModel
* cleanUp in UploadModel. once upload has been initiated
* Removed unused methods from UploadModel and the corresponding test class
* * Added tests for UploadPresenter
* Travis suggested changes
* Addded copy previous title and description
* * Made the upload add descriptions visible when keyboard visible
* add description request focus only when user manually requests it
* Added JavaDocs, review suggested changes
* Fix dagger injection
* use DialogUtil to show info in descriptions
* use activity context for DialogUtil
* Minor changes
* Bug fix, reduced the add description edit text clickable bound (#2973)
* Bugfix/uploads (#3000)
* merged with master
* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active
* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel
* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java
* Added class level JavaDoc UploadRemoteDataSource
* Added class level JavaDoc for UploadRepository
* Added JavaDocs for ThumbnailsAdapter
* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter
* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search
* Attached image scale listener to upload media image
* Bug fix, reduced the add description edit text clickable bound
* Fix memory leak (#3001)
* Bugfix/uploads (#3002)
* merged with master
* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active
* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel
* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java
* Added class level JavaDoc UploadRemoteDataSource
* Added class level JavaDoc for UploadRepository
* Added JavaDocs for ThumbnailsAdapter
* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter
* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search
* Attached image scale listener to upload media image
* Bug fix, reduced the add description edit text clickable bound
* Added tooltip in Title in UploadMediaFragment
* BugFix recent categories
* Updated test methods
* Bugfix/uploads (#3011)
* merged with master
* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active
* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel
* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java
* Added class level JavaDoc UploadRemoteDataSource
* Added class level JavaDoc for UploadRepository
* Added JavaDocs for ThumbnailsAdapter
* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter
* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search
* Attached image scale listener to upload media image
* Bug fix, reduced the add description edit text clickable bound
* Added tooltip in Title in UploadMediaFragment
* BugFix recent categories
* Updated test methods
* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView
* bugfix/uploads (#3012)
* merged with master
* BugFix IllegalStateException
* setRetainState(true), not required with FragmentStatePagerAdapter
* Increase the ViewPager's Offscreen Limit, we want all the fragments to be active
* BugFix, clear selected categoris for previous upload session
* Clear Selected Categories
* Addded JavaDocs for CategoriesModel
* Code Formatting in app/src/main/java/fr/free/nrw/commons/upload/UploadModel.java
* Added class level JavaDoc UploadRemoteDataSource
* Added class level JavaDoc for UploadRepository
* Added JavaDocs for ThumbnailsAdapter
* Added JavaDocs for MediaLicensePresenter, CategoriesPresenter
* Removed null check on category query
* Show default catgeories based on image title and gps location when category text empty
* Allow search for empty category search
* Attached image scale listener to upload media image
* Bug fix, reduced the add description edit text clickable bound
* Added tooltip in Title in UploadMediaFragment
* BugFix recent categories
* Updated test methods
* Avoid memory leak, free the adpater in MediaLicenseFragment.onDestroyView
* BugFix Illegal State Exception in ViewpPagerAdapter
* Remove irrelevant comment
* merge conflict with strings (#3016)
