mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Closes #3061 (#3062)

Browse source 
* Added null check for contribution with position in ContributionsListFragment
This commit is contained in:
Ashish Kumar 2019-07-10 14:40:34 +05:30 • committed by Josephine Lim
parent f605c5c13a
commit 828b5a3cd1
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -199,7 +199,10 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment {
}else if(layoutManager instanceof GridLayoutManager){
lastVisibleItemPosition=((GridLayoutManager)layoutManager).findLastCompletelyVisibleItemPosition();
}
outState.putString(VISIBLE_ITEM_ID,findIdOfItemWithPosition(lastVisibleItemPosition));
String idOfItemWithPosition = findIdOfItemWithPosition(lastVisibleItemPosition);
if (null != idOfItemWithPosition) {
outState.putString(VISIBLE_ITEM_ID, idOfItemWithPosition);
}
}
@Override
@ -216,8 +219,13 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment {
* @param position
* @return
*/
@Nullable
private String findIdOfItemWithPosition(int position) {
return callback.getContributionForPosition(position).getContentUri().getLastPathSegment();
Contribution contributionForPosition = callback.getContributionForPosition(position);
if (null != contributionForPosition) {
return contributionForPosition.getContentUri().getLastPathSegment();
}
return null;
}
}