mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 06:43:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor: using string resources for the text instead of hard coded values

Browse source
This commit is contained in:
yuvraj-coder1 2025-01-07 02:34:59 +05:30
parent fef0d03b11
commit f8d4452e14
3 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt
View file

@ -60,9 +60,16 @@ class FailedUploadsAdapter(
itemView.context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager itemView.context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager
itemView.setOnLongClickListener { itemView.setOnLongClickListener {
val clip = ClipData.newPlainText("Caption", item?.media?.displayTitle) val clip = ClipData.newPlainText(
itemView.context.getString(R.string.caption),
item?.media?.displayTitle
)
clipboardManager.setPrimaryClip(clip) clipboardManager.setPrimaryClip(clip)
Snackbar.make(itemView, "Caption copied to clipboard", Snackbar.LENGTH_SHORT).show() Snackbar.make(
itemView,
itemView.context.getString(R.string.caption_copied_to_clipboard),
Snackbar.LENGTH_SHORT
).show()
true true
} }

11
app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt
View file

@ -107,9 +107,16 @@ class PendingUploadsAdapter(
itemView.context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager itemView.context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager
itemView.setOnLongClickListener { itemView.setOnLongClickListener {
val clip = ClipData.newPlainText("Caption", titleTextView.text) val clip = ClipData.newPlainText(
itemView.context.getString(R.string.caption),
titleTextView.text
)
clipboardManager.setPrimaryClip(clip) clipboardManager.setPrimaryClip(clip)
Snackbar.make(itemView, "Caption copied to clipboard", Snackbar.LENGTH_SHORT).show() Snackbar.make(
itemView,
itemView.context.getString(R.string.caption_copied_to_clipboard),
Snackbar.LENGTH_SHORT
).show()
true true
} }

2
app/src/main/res/values/strings.xml
View file

@ -860,5 +860,7 @@ Upload your first media by tapping on the add button.</string>
<string name="usages_on_other_wikis_heading">Other wikis</string> <string name="usages_on_other_wikis_heading">Other wikis</string>
<string name="bullet_point">•</string> <string name="bullet_point">•</string>
<string name="file_usages_container_heading">File usages</string> <string name="file_usages_container_heading">File usages</string>
<string name="caption">Caption</string>
<string name="caption_copied_to_clipboard">Caption copied to clipboard</string>
</resources> </resources>