From f8d4452e144597f7831fca97f0b4345eefcef38d Mon Sep 17 00:00:00 2001
From: yuvraj-coder1 <yuvrajshorewalavis@gmail.com>
Date: Tue, 7 Jan 2025 02:34:59 +0530
Subject: [PATCH] refactor: using string resources for the text instead of hard
 coded values

---
 .../free/nrw/commons/upload/FailedUploadsAdapter.kt   | 11 +++++++++--
 .../free/nrw/commons/upload/PendingUploadsAdapter.kt  | 11 +++++++++--
 app/src/main/res/values/strings.xml                   |  2 ++
 3 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt b/app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt
index aaf0e05c4..5b3eb5140 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt
+++ b/app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsAdapter.kt
@@ -60,9 +60,16 @@ class FailedUploadsAdapter(
             itemView.context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager
 
         itemView.setOnLongClickListener {
-            val clip = ClipData.newPlainText("Caption", item?.media?.displayTitle)
+            val clip = ClipData.newPlainText(
+                itemView.context.getString(R.string.caption),
+                item?.media?.displayTitle
+            )
             clipboardManager.setPrimaryClip(clip)
-            Snackbar.make(itemView, "Caption copied to clipboard", Snackbar.LENGTH_SHORT).show()
+            Snackbar.make(
+                itemView,
+                itemView.context.getString(R.string.caption_copied_to_clipboard),
+                Snackbar.LENGTH_SHORT
+            ).show()
             true
         }
 
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt b/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt
index c0f91037c..7f0b8aba1 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt
+++ b/app/src/main/java/fr/free/nrw/commons/upload/PendingUploadsAdapter.kt
@@ -107,9 +107,16 @@ class PendingUploadsAdapter(
                 itemView.context.getSystemService(CLIPBOARD_SERVICE) as ClipboardManager
 
             itemView.setOnLongClickListener {
-                val clip = ClipData.newPlainText("Caption", titleTextView.text)
+                val clip = ClipData.newPlainText(
+                    itemView.context.getString(R.string.caption),
+                    titleTextView.text
+                )
                 clipboardManager.setPrimaryClip(clip)
-                Snackbar.make(itemView, "Caption copied to clipboard", Snackbar.LENGTH_SHORT).show()
+                Snackbar.make(
+                    itemView,
+                    itemView.context.getString(R.string.caption_copied_to_clipboard),
+                    Snackbar.LENGTH_SHORT
+                ).show()
                 true
             }
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 843ab6545..7f5cbf814 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -860,5 +860,7 @@ Upload your first media by tapping on the add button.</string>
   <string name="usages_on_other_wikis_heading">Other wikis</string>
   <string name="bullet_point">•</string>
   <string name="file_usages_container_heading">File usages</string>
+  <string name="caption">Caption</string>
+  <string name="caption_copied_to_clipboard">Caption copied to clipboard</string>
 
 </resources>