mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #4589 :- The empty screen while no images found in custom picture selector [bug] (#4884)

Browse source 
* bug fix

* bug fix 2
This commit is contained in:
RISHAV GUPTA 2022-03-11 19:42:39 +05:30 • committed by GitHub
parent 4ea20fafde
commit ed572aab6f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/FolderFragment.kt
View file

@ -115,7 +115,9 @@ class FolderFragment : CommonsDaggerSupportFragment() {
val images = result.images val images = result.images
if(images.isNullOrEmpty()) if(images.isNullOrEmpty())
{ {
empty_text.visibility = View.VISIBLE empty_text?.let {
it.visibility = View.VISIBLE
}
} }
folders = ImageHelper.folderListFromImages(result.images) folders = ImageHelper.folderListFromImages(result.images)
folderAdapter.init(folders) folderAdapter.init(folders)

5
app/src/main/java/fr/free/nrw/commons/customselector/ui/selector/ImageFragment.kt
View file

@ -142,7 +142,6 @@ class ImageFragment: CommonsDaggerSupportFragment() {
if(result.status is CallbackStatus.SUCCESS){ if(result.status is CallbackStatus.SUCCESS){
val images = result.images val images = result.images
if(images.isNotEmpty()) { if(images.isNotEmpty()) {
empty_text.visibility = View.GONE
filteredImages = ImageHelper.filterImages(images, bucketId) filteredImages = ImageHelper.filterImages(images, bucketId)
imageAdapter.init(filteredImages) imageAdapter.init(filteredImages)
selectorRV?.let { selectorRV?.let {
@ -154,7 +153,9 @@ class ImageFragment: CommonsDaggerSupportFragment() {
} }
} }
else{ else{
empty_text.visibility = View.VISIBLE empty_text?.let {
it.visibility = View.VISIBLE
}
selectorRV?.let{ selectorRV?.let{
it.visibility = View.GONE it.visibility = View.GONE
} }