mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 14:53:59 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

LocationPickerActivity.java: replace references to EXIF in documentation

Browse source 
Before this commit, there were several mentions of EXIF location data in the javadocs. It is not clear if
this is correct, since many images have location data that is chosen by the user rather than derived from EXIF.

After this commit, the more generic term "location metadata" is used in place of EXIF location data.
Hopefully this change will help avoid confusion in the future.
This commit is contained in:
Jason Whitmore 2024-09-13 16:21:57 -07:00
parent 1d2398b30b
commit c32b5d5d14
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java
View file

@ -318,11 +318,11 @@ public class LocationPickerActivity extends BaseActivity implements
private void setupMapView() {
requestLocationPermissions();
//If EXIF data is available, move map to EXIF location.
//If location metadata is available, move map to that location.
if(activity.equals("UploadActivity") || activity.equals("MediaActivity")){
moveMapToMediaLocation();
} else {
//EXIF data is not available. Move map to device GPS location.
//If location metadata is not available, move map to device GPS location.
moveMapToGPSLocation();
}
@ -379,18 +379,18 @@ public class LocationPickerActivity extends BaseActivity implements
}
/**
* Show the location in map app. Map will center on EXIF location, if available.
* If there is no EXIF data, the map will center on the commons app map center.
* Show the location in map app. Map will center on the location metadata, if available.
* If there is no location metadata, the map will center on the commons app map center.
*/
private void showInMapApp() {
fr.free.nrw.commons.location.LatLng position = null;
if(activity.equals("UploadActivity") && cameraPosition != null){
//EXIF location data is available
//location metadata is available
position = new fr.free.nrw.commons.location.LatLng(cameraPosition.getLatitude(),
cameraPosition.getLongitude(), 0.0f);
} else if(mapView != null){
//EXIF location data is not available
//location metadata is not available
position = new fr.free.nrw.commons.location.LatLng(mapView.getMapCenter().getLatitude(),
mapView.getMapCenter().getLongitude(), 0.0f);
}
@ -401,7 +401,7 @@ public class LocationPickerActivity extends BaseActivity implements
}
/**
* Moves the center of the map to the media's location (likely EXIF data), if that data
* Moves the center of the map to the media's location, if that data
* is available.
*/
private void moveMapToMediaLocation() {