From c32b5d5d1437cf56c8f32a0516bf4c10520faa19 Mon Sep 17 00:00:00 2001 From: Jason Whitmore Date: Fri, 13 Sep 2024 16:21:57 -0700 Subject: [PATCH] LocationPickerActivity.java: replace references to EXIF in documentation Before this commit, there were several mentions of EXIF location data in the javadocs. It is not clear if this is correct, since many images have location data that is chosen by the user rather than derived from EXIF. After this commit, the more generic term "location metadata" is used in place of EXIF location data. Hopefully this change will help avoid confusion in the future. --- .../LocationPicker/LocationPickerActivity.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java b/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java index 22659e77c..8c54fd292 100644 --- a/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/LocationPicker/LocationPickerActivity.java @@ -318,11 +318,11 @@ public class LocationPickerActivity extends BaseActivity implements private void setupMapView() { requestLocationPermissions(); - //If EXIF data is available, move map to EXIF location. + //If location metadata is available, move map to that location. if(activity.equals("UploadActivity") || activity.equals("MediaActivity")){ moveMapToMediaLocation(); } else { - //EXIF data is not available. Move map to device GPS location. + //If location metadata is not available, move map to device GPS location. moveMapToGPSLocation(); } @@ -379,18 +379,18 @@ public class LocationPickerActivity extends BaseActivity implements } /** - * Show the location in map app. Map will center on EXIF location, if available. - * If there is no EXIF data, the map will center on the commons app map center. + * Show the location in map app. Map will center on the location metadata, if available. + * If there is no location metadata, the map will center on the commons app map center. */ private void showInMapApp() { fr.free.nrw.commons.location.LatLng position = null; if(activity.equals("UploadActivity") && cameraPosition != null){ - //EXIF location data is available + //location metadata is available position = new fr.free.nrw.commons.location.LatLng(cameraPosition.getLatitude(), cameraPosition.getLongitude(), 0.0f); } else if(mapView != null){ - //EXIF location data is not available + //location metadata is not available position = new fr.free.nrw.commons.location.LatLng(mapView.getMapCenter().getLatitude(), mapView.getMapCenter().getLongitude(), 0.0f); } @@ -401,7 +401,7 @@ public class LocationPickerActivity extends BaseActivity implements } /** - * Moves the center of the map to the media's location (likely EXIF data), if that data + * Moves the center of the map to the media's location, if that data * is available. */ private void moveMapToMediaLocation() {