mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Resolved issue of dark icons not visible in bottom NavBar and Achievements Fragment (#5410)

Browse source
This commit is contained in:
Shashwat Kedia 2024-01-15 13:32:23 +05:30 • committed by GitHub
parent 1f738eb7c4
commit b3a4e8731e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/res/color/color_state_nav_tab_dark.xml
View file

@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<item android:state_checked="true" android:color="@color/white" />
<item android:color="@color/black" />
<item android:color="@color/primaryLightColor" />
</selector>

14
app/src/main/res/layout/fragment_achievements.xml
View file

@ -123,7 +123,7 @@
android:layout_toRightOf="@+id/images_upload_text_param"
android:layout_toEndOf="@+id/images_upload_text_param"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor"
android:tint="@color/primaryLightColor"
android:layout_marginLeft="@dimen/activity_margin_horizontal"
android:layout_marginStart="@dimen/activity_margin_horizontal"/>
@ -210,7 +210,7 @@
android:layout_toRightOf="@+id/images_reverted_text"
android:layout_toEndOf="@+id/images_reverted_text"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor"
android:tint="@color/primaryLightColor"
android:layout_marginLeft="@dimen/activity_margin_horizontal"
android:layout_marginStart="@dimen/activity_margin_horizontal"/>
@ -285,7 +285,7 @@
android:layout_toRightOf="@+id/images_used_by_wiki_text"
android:layout_toEndOf="@+id/images_used_by_wiki_text"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor"
android:tint="@color/primaryLightColor"
android:layout_marginLeft="@dimen/activity_margin_horizontal"
android:layout_marginStart="@dimen/activity_margin_horizontal"/>
@ -414,7 +414,7 @@
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintRight_toRightOf="parent"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor" />
android:tint="@color/primaryLightColor" />
</androidx.constraintlayout.widget.ConstraintLayout>
@ -493,7 +493,7 @@
app:layout_constraintRight_toRightOf="parent"
android:layout_gravity="top"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor" />
android:tint="@color/primaryLightColor" />
</androidx.constraintlayout.widget.ConstraintLayout>
@ -571,7 +571,7 @@
app:layout_constraintRight_toRightOf="parent"
android:layout_gravity="top"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor" />
android:tint="@color/primaryLightColor" />
</androidx.constraintlayout.widget.ConstraintLayout>
@ -650,7 +650,7 @@
app:layout_constraintRight_toRightOf="parent"
android:layout_gravity="top"
app:srcCompat="@drawable/ic_info_outline_24dp"
android:tint="@color/primaryDarkColor" />
android:tint="@color/primaryLightColor" />
</androidx.constraintlayout.widget.ConstraintLayout>

1
app/src/main/res/layout/fragment_contributions_list.xml
View file

@ -117,6 +117,7 @@
app:backgroundTint="@color/status_bar_blue"
app:elevation="@dimen/tiny_margin"
app:srcCompat="@drawable/ic_add_white_24dp"
android:tint="?attr/floatingActionButtonStyle"
app:useCompatPadding="true" />
</LinearLayout>

2
app/src/main/res/values/styles.xml
View file

@ -20,6 +20,7 @@
<item name="reviewHeading">@color/white</item>
<item name="aboutIconsColor">@color/white</item>
<item name="caption_description_text_color">@color/white</item>
<item name="floatingActionButtonStyle">@color/black</item>
<item name="semitransparentText">@color/commons_app_blue_dark</item>
<item name="subBackground">@color/sub_background_dark</item>
@ -80,6 +81,7 @@
<item name="reviewHeading">@color/black</item>
<item name="aboutIconsColor">@color/black</item>
<item name="caption_description_text_color">@color/black</item>
<item name="floatingActionButtonStyle">@color/white</item>
<item name="semitransparentText">@color/commons_app_blue_light</item>
<item name="subBackground">@color/sub_background_light</item>