From b3a4e8731e0e95db79917b287cacf8f7affc6c38 Mon Sep 17 00:00:00 2001
From: Shashwat Kedia <142137555+ShashwatKedia@users.noreply.github.com>
Date: Mon, 15 Jan 2024 13:32:23 +0530
Subject: [PATCH] Resolved issue of dark icons not visible in bottom NavBar and
 Achievements Fragment (#5410)

---
 .../main/res/color/color_state_nav_tab_dark.xml    |  2 +-
 app/src/main/res/layout/fragment_achievements.xml  | 14 +++++++-------
 .../res/layout/fragment_contributions_list.xml     |  1 +
 app/src/main/res/values/styles.xml                 |  2 ++
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/app/src/main/res/color/color_state_nav_tab_dark.xml b/app/src/main/res/color/color_state_nav_tab_dark.xml
index 740c70a43..c0606458f 100644
--- a/app/src/main/res/color/color_state_nav_tab_dark.xml
+++ b/app/src/main/res/color/color_state_nav_tab_dark.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
   <item android:state_checked="true" android:color="@color/white" />
-  <item android:color="@color/black" />
+  <item android:color="@color/primaryLightColor" />
 </selector>
\ No newline at end of file
diff --git a/app/src/main/res/layout/fragment_achievements.xml b/app/src/main/res/layout/fragment_achievements.xml
index 5fe125257..dd4b07c48 100644
--- a/app/src/main/res/layout/fragment_achievements.xml
+++ b/app/src/main/res/layout/fragment_achievements.xml
@@ -123,7 +123,7 @@
                 android:layout_toRightOf="@+id/images_upload_text_param"
                 android:layout_toEndOf="@+id/images_upload_text_param"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor"
+                android:tint="@color/primaryLightColor"
                 android:layout_marginLeft="@dimen/activity_margin_horizontal"
                 android:layout_marginStart="@dimen/activity_margin_horizontal"/>
 
@@ -210,7 +210,7 @@
                 android:layout_toRightOf="@+id/images_reverted_text"
                 android:layout_toEndOf="@+id/images_reverted_text"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor"
+                android:tint="@color/primaryLightColor"
                 android:layout_marginLeft="@dimen/activity_margin_horizontal"
                 android:layout_marginStart="@dimen/activity_margin_horizontal"/>
 
@@ -285,7 +285,7 @@
                 android:layout_toRightOf="@+id/images_used_by_wiki_text"
                 android:layout_toEndOf="@+id/images_used_by_wiki_text"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor"
+                android:tint="@color/primaryLightColor"
                 android:layout_marginLeft="@dimen/activity_margin_horizontal"
                 android:layout_marginStart="@dimen/activity_margin_horizontal"/>
 
@@ -414,7 +414,7 @@
                 app:layout_constraintTop_toTopOf="parent"
                 app:layout_constraintRight_toRightOf="parent"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor" />
+                android:tint="@color/primaryLightColor" />
 
             </androidx.constraintlayout.widget.ConstraintLayout>
 
@@ -493,7 +493,7 @@
                 app:layout_constraintRight_toRightOf="parent"
                 android:layout_gravity="top"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor" />
+                android:tint="@color/primaryLightColor" />
 
             </androidx.constraintlayout.widget.ConstraintLayout>
 
@@ -571,7 +571,7 @@
                 app:layout_constraintRight_toRightOf="parent"
                 android:layout_gravity="top"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor" />
+                android:tint="@color/primaryLightColor" />
 
             </androidx.constraintlayout.widget.ConstraintLayout>
 
@@ -650,7 +650,7 @@
                 app:layout_constraintRight_toRightOf="parent"
                 android:layout_gravity="top"
                 app:srcCompat="@drawable/ic_info_outline_24dp"
-                android:tint="@color/primaryDarkColor" />
+                android:tint="@color/primaryLightColor" />
 
             </androidx.constraintlayout.widget.ConstraintLayout>
 
diff --git a/app/src/main/res/layout/fragment_contributions_list.xml b/app/src/main/res/layout/fragment_contributions_list.xml
index b490c35ff..2b43140f6 100644
--- a/app/src/main/res/layout/fragment_contributions_list.xml
+++ b/app/src/main/res/layout/fragment_contributions_list.xml
@@ -117,6 +117,7 @@
           app:backgroundTint="@color/status_bar_blue"
           app:elevation="@dimen/tiny_margin"
           app:srcCompat="@drawable/ic_add_white_24dp"
+          android:tint="?attr/floatingActionButtonStyle"
           app:useCompatPadding="true" />
 
     </LinearLayout>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 2de248129..27836774d 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -20,6 +20,7 @@
         <item name="reviewHeading">@color/white</item>
         <item name="aboutIconsColor">@color/white</item>
         <item name="caption_description_text_color">@color/white</item>
+        <item name="floatingActionButtonStyle">@color/black</item>
 
         <item name="semitransparentText">@color/commons_app_blue_dark</item>
         <item name="subBackground">@color/sub_background_dark</item>
@@ -80,6 +81,7 @@
         <item name="reviewHeading">@color/black</item>
         <item name="aboutIconsColor">@color/black</item>
         <item name="caption_description_text_color">@color/black</item>
+        <item name="floatingActionButtonStyle">@color/white</item>
 
         <item name="semitransparentText">@color/commons_app_blue_light</item>
         <item name="subBackground">@color/sub_background_light</item>