mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Toggle photo picker switch behaviour and tweak phrases (#5250)

Browse source 
* photo picker: toggle behaviour of switch and adjust phrasing for better UX

The enable state used to trigger the GET_CONTENT intent. Alter the flow
such that the GET_CONTENT intent is triggered when switch is disabled.
Adjust default value and other parts of code naming to reflect this.

The existing phrasing had a lot of tech jargon in it which could
result in the non-technical users being confused. Tweak the phrasing
to avoid such phrases.

The documentation in the website could also use some follow up
improvements.

* Adjust strings to clearly convey that location loss is a "risk"
This commit is contained in:
Kaartic Sivaraam 2023-07-25 14:18:53 +05:30 • committed by GitHub
parent 8a9aa962bc
commit a1b6973614
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 25 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/res/xml/preferences.xml
View file

@ -72,10 +72,10 @@
android:title="@string/display_campaigns" />
<SwitchPreference
android:defaultValue="false"
android:key="getContentPhotoPickerPref"
android:summary="@string/get_content_photo_picker_explanation"
android:title="@string/get_content_photo_picker_title"/>
android:defaultValue="true"
android:key="openDocumentPhotoPickerPref"
android:summary="@string/open_document_photo_picker_explanation"
android:title="@string/open_document_photo_picker_title"/>
</PreferenceCategory>
<PreferenceCategory