mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix failing tests for PR #5003 (#5004)

Browse source 
* Fix java.lang.NullPointerException for username in ContributionBoundaryCallback

* Fix failing tests
This commit is contained in:
Madhur Gupta 2022-07-06 12:50:29 +05:30 • committed by GitHub
parent 5fe1ad84a0
commit 8eb6681354
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt
View file

@ -18,6 +18,7 @@ import org.mockito.ArgumentMatchers.anyString
import org.mockito.Mock
import org.mockito.Mockito.mock
import org.mockito.MockitoAnnotations
import java.lang.reflect.Method
/**
* The unit test class for ContributionBoundaryCallbackTest
@ -95,7 +96,11 @@ class ContributionBoundaryCallbackTest {
whenever(mediaClient.getMediaListForUser(anyString())).thenReturn(
Single.just(listOf(media()))
)
contributionBoundaryCallback.fetchContributions()
val method: Method = ContributionBoundaryCallback::class.java.getDeclaredMethod(
"fetchContributions"
)
method.isAccessible = true
method.invoke(contributionBoundaryCallback)
verify(repository).save(anyList());
verify(mediaClient).getMediaListForUser(anyString());
}
@ -104,7 +109,11 @@ class ContributionBoundaryCallbackTest {
fun testFetchContributionsFailed() {
whenever(sessionManager.userName).thenReturn("Test")
whenever(mediaClient.getMediaListForUser(anyString())).thenReturn(Single.error(Exception("Error")))
contributionBoundaryCallback.fetchContributions()
val method: Method = ContributionBoundaryCallback::class.java.getDeclaredMethod(
"fetchContributions"
)
method.isAccessible = true
method.invoke(contributionBoundaryCallback)
verifyZeroInteractions(repository);
verify(mediaClient).getMediaListForUser(anyString());
}