From 8eb66813546100e9ec06d4ace866dba78938d11f Mon Sep 17 00:00:00 2001 From: Madhur Gupta <30932899+madhurgupta10@users.noreply.github.com> Date: Wed, 6 Jul 2022 12:50:29 +0530 Subject: [PATCH] Fix failing tests for PR #5003 (#5004) * Fix java.lang.NullPointerException for username in ContributionBoundaryCallback * Fix failing tests --- .../ContributionBoundaryCallbackTest.kt | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt index f58342467..399b39aff 100644 --- a/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt +++ b/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionBoundaryCallbackTest.kt @@ -18,6 +18,7 @@ import org.mockito.ArgumentMatchers.anyString import org.mockito.Mock import org.mockito.Mockito.mock import org.mockito.MockitoAnnotations +import java.lang.reflect.Method /** * The unit test class for ContributionBoundaryCallbackTest @@ -95,7 +96,11 @@ class ContributionBoundaryCallbackTest { whenever(mediaClient.getMediaListForUser(anyString())).thenReturn( Single.just(listOf(media())) ) - contributionBoundaryCallback.fetchContributions() + val method: Method = ContributionBoundaryCallback::class.java.getDeclaredMethod( + "fetchContributions" + ) + method.isAccessible = true + method.invoke(contributionBoundaryCallback) verify(repository).save(anyList()); verify(mediaClient).getMediaListForUser(anyString()); } @@ -104,7 +109,11 @@ class ContributionBoundaryCallbackTest { fun testFetchContributionsFailed() { whenever(sessionManager.userName).thenReturn("Test") whenever(mediaClient.getMediaListForUser(anyString())).thenReturn(Single.error(Exception("Error"))) - contributionBoundaryCallback.fetchContributions() + val method: Method = ContributionBoundaryCallback::class.java.getDeclaredMethod( + "fetchContributions" + ) + method.isAccessible = true + method.invoke(contributionBoundaryCallback) verifyZeroInteractions(repository); verify(mediaClient).getMediaListForUser(anyString()); }