mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 04:43:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Don't store Activity instance in adapter.

Browse source
This commit is contained in:
Dmitry Brant 2017-05-26 15:15:21 -04:00
parent 40c1ea375a
commit 8255bac32e
2 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
View file

@ -227,7 +227,7 @@ public class ContributionsActivity
@Override @Override
public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) { public void onLoadFinished(Loader<Cursor> cursorLoader, Cursor cursor) {
if(contributionsList.getAdapter() == null) { if(contributionsList.getAdapter() == null) {
contributionsList.setAdapter(new ContributionsListAdapter(this, cursor, 0)); contributionsList.setAdapter(new ContributionsListAdapter(getApplicationContext(), cursor, 0));
} else { } else {
((CursorAdapter)contributionsList.getAdapter()).swapCursor(cursor); ((CursorAdapter)contributionsList.getAdapter()).swapCursor(cursor);
} }

10
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListAdapter.java
View file

@ -1,25 +1,23 @@
package fr.free.nrw.commons.contributions; package fr.free.nrw.commons.contributions;
import android.app.Activity;
import android.content.Context; import android.content.Context;
import android.database.Cursor; import android.database.Cursor;
import android.support.v4.widget.CursorAdapter; import android.support.v4.widget.CursorAdapter;
import android.view.LayoutInflater;
import android.view.View; import android.view.View;
import android.view.ViewGroup; import android.view.ViewGroup;
import fr.free.nrw.commons.R; import fr.free.nrw.commons.R;
class ContributionsListAdapter extends CursorAdapter { class ContributionsListAdapter extends CursorAdapter {
private Activity activity;
public ContributionsListAdapter(Activity activity, Cursor c, int flags) { public ContributionsListAdapter(Context context, Cursor c, int flags) {
super(activity, c, flags); super(context, c, flags);
this.activity = activity;
} }
@Override @Override
public View newView(Context context, Cursor cursor, ViewGroup viewGroup) { public View newView(Context context, Cursor cursor, ViewGroup viewGroup) {
View parent = activity.getLayoutInflater().inflate(R.layout.layout_contribution, viewGroup, false); View parent = LayoutInflater.from(context).inflate(R.layout.layout_contribution, viewGroup, false);
parent.setTag(new ContributionViewHolder(parent)); parent.setTag(new ContributionViewHolder(parent));
return parent; return parent;
} }